Also renames simple-methods-v2.xsd in simple-methods.xsd and replaces simple-methods-v2.xsd references by simple-methods.xsd references everywhere it's needed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1737087 13f79535-47bb-0310-9956-ffa450edef68
Problem
=======
Go to http://localhost:8080/ecommerce/
Change the language dropdown from English to another language will revert back to English. I am using SVN revision 1735923
jleroux: This was due to OFBIZ-6879 ("Remove forceHttpSession feature"). Now as soon as you start with HTTPS instead of HTTP it works. I mean other links don't get back on HTTP, see OFBIZ-6966 for details... More to come with OFBIZ-6849, hopefully soon...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1737046 13f79535-47bb-0310-9956-ffa450edef68
Fixes "Comment out RMI related code because of the Java deserialization issue" - https://issues.apache.org/jira/browse/OFBIZ-6942
We decided to comment out as less as possible because once, in the start and both properties; the rmi part is off and the related test services are off there is no RMI related danger left (test services are not a danger but would fail during tests run).
It's then easier for users who need RMI in their projects to have only to uncomment those and not digg everywhere.
[CVE-2016-2170] The infamous Java serialization vulnerability
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1736083 13f79535-47bb-0310-9956-ffa450edef68
Add width and height attributes retrieval in renderLink method in MacroMenuRenderer. Thanks Pierre for the report.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1735738 13f79535-47bb-0310-9956-ffa450edef68
When you call expire on a entity :
* if a date field is present on service attribute, OFBiz try to expire it with the given value or with now date
* else try to expire thruDate field
* else try to expire *ThruDate or thru*Date field
With the new action I refactoring the code to separate each action on dedicate function.
the unit test associate to expire action was updated.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1735737 13f79535-47bb-0310-9956-ffa450edef68
I decided to comment out as less as possible because once the RMI loaders, the RMI dispatcher and the related test services are off there is no RMI related danger left (test services are not a danger but would fail during tests run). It's then easier for users who need RMI in their projects to have only to uncomment those and not digg everywhere. Because the naming (JNDI) server relies on the rmi loader it will also be commented out.
[CVE-2016-2170] The infamous Java serialization vulnerability
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1735569 13f79535-47bb-0310-9956-ffa450edef68
If GroovyEngine.serviceInvoker catches an exception in a Groovy script, it would mask the exception in some cases. An exception's detailMessage can be null. If it is null, the exception won't be properly returned and logged, and that will make spotting problems very difficult. This was the case for me while trying to track down a problem with a java.util.ConcurrentModificationException error in a Groovy script. I suspect that this choice to mask exceptions and only return the message has cause bugs to not be spotted.
Disabling this for now in favor of returning a proper exception. GroovyEngine.serviceInvoker() should throw GenericServiceException if error, rather than returning ServiceUtil.returnError(e.getMessage())
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1734269 13f79535-47bb-0310-9956-ffa450edef68
Obvious error that cause deserialization errors on receiving side under some conditions because data extracted from response shorter than it really was sent.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1734246 13f79535-47bb-0310-9956-ffa450edef68
Replacing Axis2 1.6.3 by 1.7.1 version is easy as long as you don't try to replace the commons-httpclient-3.1 lib. The only noticeable change is this warning shown in log
|http-bio-8443-exec-1 |AxisConfigBuilder |W| Unable to instantiate deployer org.apache.axis2.deployment.ServiceDeployer; see debug logs for more details|
It has no effects on the SOAP test services, both works.
But the main goal of this issue is a security update because commons-httpclient-3.1 lib is deprecated, no longer maintained and vulnerable and must be replaced.
This commit also concerns OFBIZ-6755 but to not mix things OFBIZ-6755 will be completed later. So to not block this issue, the commons-httpclient-3.1 lib is moved from framework/service/lib to specialpurpose/passport/lib/ where it's still required.
Normally, as explained at https://axis.apache.org/axis2/java/core/release-notes/1.7.0.html, Axis2 1.7.1 requires "HttpClient 4.2.x and should work with 4.3.x and 4.4.x, but is incompatible with 4.5.x". I did not replace commons-httpclient-3.1 by HttpClient 4.2.1, which is bundled with Axis2 1.7.1, because we have already HttpClient/Core 4.4.1 in base/lib and it works well as is (HttpClient/Core 4.4.1 is in the classpath).
To use HttpClient/Core 4.4.1 you need to change the axis2.xml files as specified in the 1.7.0 release note. But where to place this file in OFBiz is not obvious!
I decided the best way was to use Axis2 ConfigurationContextFactory.createConfigurationContextFromFileSystem() method to let know Axis2 we want the new httpclient instead of the default one (I really don't understand why the Axis2 team still prefers commons-httpclient-3.1 as default). I had to pass both locations to avoid hardcoding the repository location in the axis2.xml file.
I have also decided the best place for the "Axis2 repository" (as they call it) was in framework/service/axis2. So following Axis2 convention http://wso2.com/library/tutorials/axis2-repository/ I put the axis2.xml file in framework/service/axis2/conf.
Note: the Axis2 repository could be used to put [Apache Rampart|https://axis.apache.org/axis2/java/rampart/] as a module to secure web services...
After this change, there are a number of warnings thrown by Axis2 but they are actually interesting as they provide guidance for future use of modules and such (notably Apache Rampart)
|ttp-bio-8443-exec-10 |Utils |W| [JAXWS] - unable to load org.apache.axis2.jaxws.dispatchers.GenericProviderDispatcher
|ttp-bio-8443-exec-10 |Utils |W| [JAXWS] - unable to load org.apache.axis2.jaxws.dispatchers.MustUnderstandValidationDispatcher
|ttp-bio-8443-exec-10 |Utils |W| [JAXWS] - unable to load org.apache.axis2.jaxws.dispatchers.MustUnderstandChecker
|ttp-bio-8443-exec-10 |Utils |W| [JAXWS] - unable to load org.apache.axis2.jaxws.dispatchers.GenericProviderDispatcher
|ttp-bio-8443-exec-10 |Utils |W| [JAXWS] - unable to load org.apache.axis2.jaxws.dispatchers.MustUnderstandValidationDispatcher
|ttp-bio-8443-exec-10 |AxisConfigBuilder |W| Unable to instantiate deployer org.apache.axis2.deployment.ServiceDeployer; see debug logs for more details
|ttp-bio-8443-exec-10 |AxisConfigBuilder |W| Unable to instantiate deployer org.apache.axis2.jaxws.framework.JAXWSDeployer; see debug logs for more details
While at it I replaced StAXOMBuilder (deprecated) by OMXMLBuilderFactory
I will backport the changes in the supported releases branches but R12.04 which use a too old version of HttpClient/Core. Others all use versions older than 4.2.1. I'm aware I will have to handle several conflicts by hand, some are easy others "harder". We have the passport component only in R15.12, it will be easy to neglect in older releases. I expect more work with the LICENSE file and even more with the .classpath file. Since R15.12 we use tabs in it (Adrian rightly told us to use Eclipse internal tools to edit this file, though I noted it does not respect the alphabetical order) but older releases still use spaces (and this is often a pain now, but a bright future ahead ;))
Crossing fingers with this commit, I have other changes pending in this instance (notably for OFBIZ-6849) and it got quite complicated...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1733956 13f79535-47bb-0310-9956-ffa450edef68
It's a security update. It also concerns OFBIZ-6755 but to not mix things it will be done later. So to not block this issue, the commons-httpclient-3.1 lib is moved from framework/service/lib to specialpurpose/passport/lib/ where it's still required (no code change in this commit, only libs update)
It's a test because I began this work on Windows and there the NTML Auth is expected https://axis.apache.org/axis2/java/core/docs/http-transport.html#preemptive_auth. So, on my machine, I get this error with testSOAPSimpleService and testSOAPService:
TestRunContainer |W| [JUNIT (error)] - testSOAPSimpleService : org.ofbiz.service.GenericServiceException: Service [testSoapSimple] Failed (org/apache/commons/httpclient/NTCredentials)
Caused by: java.lang.NoClassDefFoundError: org/apache/commons/httpclient/NTCredentials
at org.apache.axis2.transport.http.CommonsHTTPTransportSender.createHTTPSender(CommonsHTTPTransportSender.java:414) ~[axis2-transport-http-1.7.0.jar:1.7.0]
Since I don't want to introduce more complexity at this stage I hope the basic Auth will be used in BuildBot and the tests will all pass. Else I will revert and do more work...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1732631 13f79535-47bb-0310-9956-ffa450edef68
Log:
==========================================================
- Make use of ResourceLoader.readXmlRootElement, which is
non-caching; this fixes a deprecation warning.
- Use ResourceLoader.readXmlRootElement, which is a
non-caching version. This fixes a deprecation warning.
- Provide method variants (readXml{Document,RootElement}) that contain the body of the deprecated methods (getXml{Document,RootElement}).
==========================================================
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1731399 13f79535-47bb-0310-9956-ffa450edef68
Log:
===========================================================
Fix deprecated use of
SimpleMethod.getAll{Entity,Service}NamesUsed(), instead
using ArtifactInfoContext.
============================================================
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1731387 13f79535-47bb-0310-9956-ffa450edef68
Log:
============================================================
UtilDateTime implements deprecated methods, so add the
@Deprecated tag to stop javac from producing a warning.
============================================================
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1731385 13f79535-47bb-0310-9956-ffa450edef68
Log:
============================================================
new Configuration() is deprecated; instead, the desired
freemarker version should be passed in. To make it easier to control
the version centrally, add a helper method on FreeMarkerWorker that
wraps the instantiation of the Configuration object.
============================================================
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1731380 13f79535-47bb-0310-9956-ffa450edef68
- Mark some SecurityFactory method as deprecated
- Mark FoFormRender as deprecated
- Fixed deprecation warning for PassportUtil class.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1731377 13f79535-47bb-0310-9956-ffa450edef68
This implies to update also Xerces from 2.9.1 to 2.11.0 and also xml-apis from 2.9.1 to 1.4.01 (2.9.1 was a wrong version number. It was actually part of the Xerces 2.9.1 package but I was unable to find the real version number then at https://xerces.apache.org/xerces2-j/releases.html)
Also updates Xalan from 27(?) to 2.7.2 in cmssite/template/docbook/extensions. I rendered https://localhost:8443/cmssite/cms/APACHE_OFBIZ_HTML w/o issues
Note: According to the DOM Level 3 specification and DOM Level 2 errata the createElementNS and createAttributeNS methods convert empty string namespaceURI to null.
jleroux: though the tests pass I'm not sure all is covered...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1730882 13f79535-47bb-0310-9956-ffa450edef68
There are few cases where we show the sessionId in logs (using UtilHttp.getSessionId() in or HttpSessionEvent.getSession().getId()) in other places)
Despite we secured the log access at r1489461, I feel better using a properties to opt in, false by default.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1729348 13f79535-47bb-0310-9956-ffa450edef68
jleroux: this was git patch, I'm now used to change them to apply, but I will explain how to generate svn patch from it
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1729078 13f79535-47bb-0310-9956-ffa450edef68
Static["org.ofbiz.base.util.UtilProperties"].getPropertyValue is used in several .ftl files.
Replaces with EnittyUtilProperties variant where appropriate.
jleroux: In this is the 2nd commit from the 3rd patch (the 2nd had issues) I fixed 2 "typos" I spotted while reviewing in
ecommerce/customer/editcontactmech.ftl
ecommerce/customer/newcustomer.ftl
where "UtilProperties" was not replaced
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1729002 13f79535-47bb-0310-9956-ffa450edef68
Static["org.ofbiz.base.util.UtilProperties"].getPropertyValue is used in several .ftl files.
Replaces with EnittyUtilProperties variant where appropriate.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728959 13f79535-47bb-0310-9956-ffa450edef68