Commit Graph
10472 Commits
Author SHA1 Message Date
Jacques Le Roux bd0b57613c A patch from Wai for "EntityUtilProperties" https://issues.apache.org/jira/browse/OFBIZ-7112
OFBiz reads properties from either a properties file or the entity:SystemProperty. The way it worked previously is that OFBiz reads from the entity:SystemProperty first and if there is no value associated with the target propertyname, it would then locate the value from the relevant properties file.
In other words, if there is a database entry for a property, the database entry should override the associated properties file.
The issue is that if a database entry exist but the value is empty, it would look for a value from the properties file.  It should not do so.  If a database entry exists for the propertyname of interest, the value should be taken from the database even if it holds an empty value.

"isExistInDb" is first defined in Map<String, String> getSystemPropertyValue(String, String, Delegator).  This method is call by many other methods.  "isExistInDb" is used to indicate whether the method is returning an empty value for the property that 'exists' in the database rather than as a result of an absent database entry for the property.

The other methods...
  boolean propertyValueEqualsIgnoreCase(String, String, String, Delegator)
  String getPropertyValue(String, String, String, Delegator)
  String getPropertyValue(String, String, Delegator) 
  String getMessage(String, String, Locale, Delegator)
uses the above method and needs to decide whether to use the empty value returned (ie. empty value from an existing property entry in database) or decide if it needs to read from the property file (ie. property entry does not exist in database)

jleroux: this also add systemPropertyValue data in CommonSystemPropertyData.xml

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1748560 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 11:23:54 +00:00
Jacques Le Roux 99de8f8705 A patch from Gareth Carter for "DB connections remain open and unused on startup" https://issues.apache.org/jira/browse/OFBIZ-7344
When ofbiz starts and checks the database, it will leave open connections and they will not get reused.

If you run Check/Update database from webtools, you can see a new connection is created for your selected group

As far as I can tell, the problem lies in DatabaseUtil.getDatabaseMetaData. If the parameter connection is null, a new connection object is created but not closed (like any resource should be!)

jleroux: I was unable to "see a new connection is created for your selected group" when running "Check/Update database from webtools". But I tested with Postgres while and after discussing with Gareth about this.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1748543 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 10:35:18 +00:00
Jacques Le Roux da29d8e842 This closes "Add the -server JVM argument to Ant targets like start and tools/start*.bat files" https://issues.apache.org/jira/browse/OFBIZ-7321
I kept things as simple as possible. I only changed the following Ant targets
  start
  start-secure
  start-batch
  start-batch-secure
  run-test

I also changed the startofbiz.bat file. The other start*.bat are for the POS and it's not expected to run on a server.

I put a mention when using "java -jar ofbiz.jar -u" (start)
I will add a mention in "Technical+Production+Setup+Guide" wiki page about using "java -jar ofbiz.jar"

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1748173 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 10:34:39 +00:00
Pranay Pandey 042864ac13 [OFBIZ-7268] Improved the styling for the anchor links inside the 'button-bar' to fix styling for CommonButtonBarMenu. Reverted the changes committed under OFBIZ-7006, since these UI improvements fix that issue as well by extending CommonButtonBarMenu.
Thanks Swapnil M Mane for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1748145 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 09:13:14 +00:00
Jacques Le Roux 27b736e3ed No functional changes. While reviewing Wai's patch for OFBIZ-7112 I noticed that he (re)used this pattern introduced earlier:
(resource == null || resource.length() <= 0)
From Java spec. a String, Collection, Map or CharSequence can't have a negative length, so the pattern above can be reduced to 
  (resource == null || resource.length() == 0)
which can be replaced using 
  UtilValidate.isEmpty()
I checked, there are several other occurrences of this pattern (some very old, I guess most were routinely copied from an initial occurrence). I decided to replace all of them, here they are.

I did that already long ago for the 
  (resource == null || resource.length() == 0)
pattern. It remains 4 of them. Three are justified (because of the dependency on base component or because using isEmpty() on Object is disputable for performance reasons). I took care of the remaining one right aways (in SplashScreen.java)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747976 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 10:43:58 +00:00
Deepak Dixit 02c723c669 (OFBIZ-7213) Applied patch from jira issue
===================================
Override allow-html attribute do not work in service implementing any interface
===================================

Thanks Nameet Jain for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747959 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 07:17:06 +00:00
Deepak Dixit d9a8278ae6 (OFBIZ-7245) Renamed groovy file in upper camel case as per best practices
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747850 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 06:12:27 +00:00
Jacques Le Roux 1ee87e749b This has slipped in inadvertently in a previous commit, removes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747792 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 19:52:15 +00:00
Jacques Le Roux 0029608c28 This has slipped in inadvertently in a previous commit, removes!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747783 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 19:25:25 +00:00
Deepak Dixit 4a276ecf91 (OFBIZ-7231) Relocate .groovy files in the framework/common component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747776 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 18:58:37 +00:00
Deepak Dixit e929d179d8 (OFBIZ-7228) Relocate .groovy files in the party component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747770 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 18:39:22 +00:00
Deepak Dixit 543dd8e488 (OFBIZ-7221) Relocate .groovy files in the framework/webtools component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747755 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 17:16:22 +00:00
Jacques Le Roux ec66e361e1 A big but straightforward commit for "Move minilang scripts from component://componentname/script/org/ofbiz to component://componentname/minilang" - https://issues.apache.org/jira/browse/OFBIZ-7267
I removed duplicate paths were componentname was uselessly repeated after component://componentname/script/org/ofbiz (projectmngr was the only one using there project instead)

I had few typos, easily fixed thanks to the tests. There could be still typos but they are unexpected and anyway no-brainer to fix 

I'm still wondering about specialpurpose/example/minilang/README.txt.
I changed its content to 
  "The minilang directory is for static resources that are interpreted at run time rather than being compiled. This goes on the classpath, but does not get built or put into a JAR file."
not sure it makes any sense, I don't see how this relates to the classpath. 


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747712 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 14:04:30 +00:00
Ashish Vijaywargiya 89e4e9c642 Applied patch from jira issue - OFBIZ-7203 - Empty Requirement Id and Product Id fields when generating pdf for Approved Product Requirements. Thanks Ravi for the contribution. Thanks for your extensive research and providing the details in the task, your notes are very helpful.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747516 13f79535-47bb-0310-9956-ffa450edef68
2016-06-09 09:14:13 +00:00
Pranay Pandey f0134b07cc [OFBIZ-7214] No functional changes, adding missing license header.
Thanks Pierre Smits for reporting.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747344 13f79535-47bb-0310-9956-ffa450edef68
2016-06-08 04:09:23 +00:00
Taher A. Alkhateeb 50127f4a9c Major commit for refactoring the start component - Ref OFBIZ-6783
A thank you is due to Jacques Le Roux, whom substantially improved
the refactoring of the start component with his QA work, and also
credit is due to Jacopo Capellato and Gil Portenseigne for their help

This commit is the last commit on OFBIZ-6783 and applies the following:

- convert the startup loaders from ArrayList to List. Given that
  only two loaders existed in the system since the beginning of 
  OFBiz means that it is really unnecessary to use the 
  loaders.trimToSize() method. It's simply too much specificity for
  no apparent performance value. this leads to changing many method
  signatures from ArrayList to list across different classes
- More simplification of Config.java by simplifying timezone setting
  logic
- remove the throws StartupException from main. This was confusing
  confused me a lot and lead to a regression from my refactoring
  in OFBIZ-7167 because some exceptions bubble up all the way to
  main but then the system does not terminate because other 
  threads are running. It took me and Jacques a long while to 
  dig it out and figure the root cause.
- Introduce a function called fullyTerminateSystem(StartupException e).
  This function replaces the exception bubble issue that is
  described above. Consequently, the methods init, status and
  shutdown no longer throw an exception but instead terminate
  the system (which is the right thing to do).
- finetune adaptStartupCommandsToLoaderArgs(...) and other 
  places in StartupControlPanel
- separate the Classpath creation from NativeLibClassLoader 
  creation. This makes it cleaner and easier to refactor
  in the future
- break the StartupControlPanel.start(...) method into
  smaller more readable methods. It is easier now to understand
  the startup sequence for ofbiz in english words (the method names).
  It also allows for cleaner refactoring in the future.
- add JavaDoc to a lot of methods all over the start component
- rename AdminPortThread to AdminServer and create a new class called
  AdminClient. Now everything relating to controlling OFBiz directly
  happens through StartupControlPanel such as start, stop or init 
  for the server, and everything which happens indirectly through
  the network (by an admin client) is done through the AdminClient
  which talks to AdminServer
- more refactoring of AdminServer to simplify the code and break it
  down into multiple methods and refactor some messy old code

Assuming this commit is stable, and after waiting for a sufficient time
I will close the JIRA and move on with the refactoring exercise.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747288 13f79535-47bb-0310-9956-ffa450edef68
2016-06-07 18:12:46 +00:00
Pranay Pandey 247df14284 [OFBIZ-7209] No functional change. Corrected formatting.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747207 13f79535-47bb-0310-9956-ffa450edef68
2016-06-07 12:44:52 +00:00
Pranay Pandey be6ece2105 [OFBIZ-7209] Fixed Order Ship Group PDF.
This issue was due to the declaration of map with list syntax. It was introduced when we moved from Javolution collections to java collections.
One more issue found after fixing map syntax, that is missing block elements error. Added checks to handle that error as well.

Thanks Amardeep Singh Jhajj for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747202 13f79535-47bb-0310-9956-ffa450edef68
2016-06-07 12:14:29 +00:00
Taher A. Alkhateeb d91d0dc283 Fix regression caused by refactoring start comp - ref OFBIZ-7167
Thanks to an excellent investigation by Jacques Le Roux we realized
that if not all tests are successful (on java -jar ofbiz -jar --tests)
then the system hangs and does not print HTML reports.

After investigating this issue, I realized that the old logic before
refactoring used to call System.exit(99) which executes all the shutdown
hooks and releases the system resources. In the new code, however, the
resources are not released as the exception simply bubbles up to the main
method and thrown out, while the other threads are still running. So
the resources are not released and build.xml cannot continue processing
the HTML results with <junitreport ...>

The fix is simple, but the investigation was hard. Big thank you to Jacques.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746737 13f79535-47bb-0310-9956-ffa450edef68
2016-06-03 16:31:34 +00:00
Deepak Dixit 09ca38b7f6 (OFBIZ-7164) Fix typo in freemarker else tag.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746691 13f79535-47bb-0310-9956-ffa450edef68
2016-06-03 08:59:56 +00:00
Christian Geisert 351a15a292 OFBIZ-7163 Fix Definition Location filter at Service Reference
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746601 13f79535-47bb-0310-9956-ffa450edef68
2016-06-02 16:20:11 +00:00
Jacques Le Roux 0e7696a881 Adds a missing xls reference in platform-specific, stumbled upon it by chance
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746420 13f79535-47bb-0310-9956-ffa450edef68
2016-06-01 10:51:20 +00:00
Jacques Le Roux 3aadf4e8da A slightly modified patch from James Yong for "Autocompletion for Compound Widget" https://issues.apache.org/jira/browse/OFBIZ-7061
1. The following xsd are duplicated to use namespaces
  site-conf.xsd     ->  site-conf-ns.xsd
  widget-form.xsd   ->  widget-form-ns.xsd
  widget-screen.xsd ->  widget-screen-ns.xsd
  widget-menu.xsd   ->  widget-menu-ns.xsd
  simple-methods.xsd->  simple-methods-ns.xsd
For example, in site-conf-ns.xsd, we have the following document level attribute
  <xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified" xmlns="http://ofbiz.apache.org/Site-Conf" targetNamespace="http://ofbiz.apache.org/Site-Conf">
instead of 
  <xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified">

2. The above schema are used into compound-widgets.xsd so that compound widgets use only one consolidated schema. 

3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For example
<compound-widgets xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xmlns:sc="http://ofbiz.apache.org/Site-Conf"
        xmlns:sm="http://ofbiz.apache.org/Simple-Method"
        xmlns:wf="http://ofbiz.apache.org/Widget-Form"
        xmlns:wt="http://ofbiz.apache.org/Widget-Tree"
        xmlns:wm="http://ofbiz.apache.org/Widget-Menu"
        xmlns:ws="http://ofbiz.apache.org/Widget-Screen"
        xsi:noNamespaceSchemaLocation="../../../../framework/widget/dtd/compound-widgets.xsd">
    
    <sc:site-conf>
        <sc:request-map uri="CompoundWidgets1">
            <sc:security https="true" auth="true"/>
            <sc:event type="simple" invoke="CompoundWidgetsFunc" path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
            <sc:response name="success" type="view" value="CompoundWidgets1"/>
        </sc:request-map>
        <sc:request-map uri="CompoundWidgets2"><sc:security https="true" auth="true"/><sc:response name="success" type="view" value="CompoundWidgets2"/></sc:request-map>

        <sc:view-map name="CompoundWidgets1" type="screen" page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
        <sc:view-map name="CompoundWidgets2" type="screen" page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
    </sc:site-conf>
...... the rest

4. Change java code to support reading xml with namespace (i.e. xml for compound widgets)

jleroux: I simply replaced tabs by spaces in Java files and removed this commented out line 
  <compound-widgets xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd">
in ExampleCompoundWidgets.xml

We decided to duplicate the simple-methods.xsd rather than updating all concerned files. Else we would have to update the attributes at document level for rest of the controllers, menus, forms, simple methods and screens. For example, in controller.xml, we would have to change 
  xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
to 
  xmlns="http://ofbiz.apache.org/sc” xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
But especially we would have to use the same syntax with namespaces prefixes than in ExampleCompoundWidgets.xml (see example above). This can be discussed because with auto-completion it's not a big deal, but could be overwhelming for existing custom projects...

James mentionned that "the schema location at compound-widgets.xsd is relative to the project...". I don't see any problems with that. We can keep as is as long as we maintain the relation (ie if the main XSDs are moved). Moreover with the previous addition of compound-widgets.xsd in widget-catalog.xml it seems all things work correctly (eg w/o the new *-ns.xsd yet committed, the auto-completion works well in ExampleCompoundWidgets.xml




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746302 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 16:48:09 +00:00
Deepak Dixit 64d804e2e1 (OFBIZ-7141) Updated apache fop to 2.1 and also updated xmlgraphics-commons to 2.1.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746270 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 12:49:12 +00:00
Jacques Le Roux 06245c53ae A fix for "Use only HTTPS in OFBiz" - https://issues.apache.org/jira/browse/OFBIZ-6849
The tests did not pass because of xmlrpc. Simply adding it in http.request-map.list in url.properties and like for SOAPService request setting <security https="false"/> does it.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746254 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 08:39:07 +00:00
Taher A. Alkhateeb e8b73f703f related to r1746236 on OFBIZ-6783 to delete extra files forgotten
The patch that I provided only emptied the files when they should be
deleted. This removes them completely


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746239 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 06:56:21 +00:00
Taher A. Alkhateeb ca819dda9d Remove cobertura and sonar completely. Ref OFBIZ-6783
After getting consensus from the community in the email thread below
we agreed to remove these two items because they make the startup
logic more complex and also because many things are broken and 
unmaintained for years.

It is a good idea to reintroduce cobertura in the future on a cleaner
implementation, hopefully completely away from the start component and
perhaps as a container implementation.

The email thread:
http://ofbiz.markmail.org/message/b4jovfhurczunbam?q=remove+cobertura

The related JIRA:
https://issues.apache.org/jira/browse/OFBIZ-6783


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746236 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 06:43:11 +00:00
Arun Patidar fbe2dfb9d2 [OFBIZ-7140] Added Fetch Log Functionality parallel to View Log in webtools. Thanks Rishi Solanki for new feature and patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746227 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 05:26:43 +00:00
Jacques Le Roux 7531712225 A fix for "Use only HTTPS in OFBiz" - https://issues.apache.org/jira/browse/OFBIZ-6849
I just realised that the main change (the one in ConfigXMLReader.java, exposed in a comment in OFBIZ-6849) was not committed in r1745525. I guess it was because of tests I did for OFBIZ-4090, I certainly removed these changes then and forgot to put them back.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746159 13f79535-47bb-0310-9956-ffa450edef68
2016-05-30 17:40:10 +00:00
Pranay Pandey 681ebea533 [OFBIZ-7130] Applied patch from the ticket to fix error on console when navigating to update party email address view.
This error occurs due to the code used for dependent drop down for country and state. At party email address update page, no dependent drop down used, so js code triggering the request with empty countryGeoId and generating console error. Added check in code that if drop down field is not present on page then no need to observe it for the change. 

Thanks Amardeep Singh Jhajj for reporting the issue and providing patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746130 13f79535-47bb-0310-9956-ffa450edef68
2016-05-30 13:34:35 +00:00
Nicolas Malin ab92393570 Add xls screen renderer to convert a screen definition like an html flow directly ready by a spreadsheet application
In addition, add an export example button on FindExample screen and add complete macro ftl renderer unit test. Issue OFBIZ-6931 proposed by Leila Mekika. Thanks to her, jacques and pierre for theirs remarks.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746045 13f79535-47bb-0310-9956-ffa450edef68
2016-05-29 18:38:26 +00:00
Jacques Le Roux c048e9c85a Ugrades PDFBox to 1.8.12 (or 2.0.1?) due to vulnerability - https://issues.apache.org/jira/browse/OFBIZ-7136
See CVE-2016-2175: Apache PDFBox XML External Entity vulnerability

I did not try to update to version 2.0.1. 
I only tested by using https://localhost:8443/example/control/ExampleReportPdfOptions?exampleId=EX01 but I got nothing, so I tried with R15.12 before backporting with the same issue so I guess it's unrelated with this update moreover with both branches I get an error in log for the barcode PDF I will open a Jira

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1745751 13f79535-47bb-0310-9956-ffa450edef68
2016-05-27 13:12:55 +00:00
Jacques Le Roux 7df0fcda3a Fixes "Use only HTTPS in OFBiz" - https://issues.apache.org/jira/browse/OFBIZ-6849
Quoting Deepak on dev ML

Hi Jacques,

I think in fop.xconf file we have to keep http url, as FOP does not support
https baseUrl for external graphics due to certificate issue (not remember
exact reason).

{code}
 <!-- Base URL for resolving relative URLs -->
-  <base>http://localhost:8080</base>
+  <base>https://localhost:8443</base>
{code}

If we set the https as <base> than images will not be rendered. Please
refer
http://demo-trunk-ofbiz.apache.org/ordermgr/control/order.pdf?orderId=DEMO10091

and we get following error on console:
{code}

     [java] 2016-05-27 13:51:48,308 |http-nio-8443-exec-3 |FOUserAgent
              |E| Image not found. URI: /images/ofbiz_logo.gif. (No context
info available)

{code}
If we set the http url than its working fine.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1745732 13f79535-47bb-0310-9956-ffa450edef68
2016-05-27 09:52:51 +00:00
Taher A. Alkhateeb 741ac838cc move validation logic to its correct place in StartupCommandUtil OFBIZ-6783
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1745584 13f79535-47bb-0310-9956-ffa450edef68
2016-05-26 09:33:46 +00:00
Deepak Dixit f1fd6b0b44 (OFBIZ-6810) Fixed typo on tempExprMaint.ftl file name. Thanks Vaibhav Jain for reporting the issue.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1745559 13f79535-47bb-0310-9956-ffa450edef68
2016-05-26 05:33:25 +00:00
Jacques Le Roux e7cdb8a30d Implements "Use only HTTPS in OFBiz" - https://issues.apache.org/jira/browse/OFBIZ-6849
All tests passes and the normal use of OFBiz seems to work

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1745525 13f79535-47bb-0310-9956-ffa450edef68
2016-05-25 18:02:23 +00:00
Deepak Dixit 5bb84a92ca (OFBIZ-6810) Removed some unused screen and ftl, found during ftl cleanup. I took extra care while removing these code this should not break anything.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1745500 13f79535-47bb-0310-9956-ffa450edef68
2016-05-25 15:05:50 +00:00
Jacques Le Roux bbc93ba99a Forgot to remove empty folders at r1745451
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1745458 13f79535-47bb-0310-9956-ffa450edef68
2016-05-25 08:57:18 +00:00
Jacques Le Roux 32188a9d0f Since I introduced the use of PatternFactory.createOrGetPerl5CompiledPattern() in Minilang Regexp class at r1542960 the IfRegexpTest class and test are no longer needed.
Tested with "java -jar ofbiz.jar --test component=minilang --test suitename=MinilangTests"

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1745451 13f79535-47bb-0310-9956-ffa450edef68
2016-05-25 08:36:57 +00:00
Taher A. Alkhateeb ed564da850 major commit to start component - for OFBIZ-6783
This is another major refactoring exercise of the start
component in ofbiz. There are too many details in this commit
that may be summarized as follows:

- refactor Start.java to make it about 140 lines long and focused
  only on high level function calls. Also minimized the number of
  class fields (state) to only two (ServerState and Config)
- Separate the AdminPortThread into a new class with some refactoring
  done to ensure interoperability with other classes
- delete CommonsDaemonStart as jsvc is not yet fully implemented in ofbiz
  and it stands in the way of a proper refactoring of ofbiz
- refactor everything so that all dependencies between classes are explicit
  through function calls (no hidden state or declarations)
- Move all the server processing logic (status, shutdown, start ...) to a 
  new class called StartupControlPanel. All methods in this class are static 
  with side effects only limited to the arguments passed to them.
- Add a few missing apache copyright headers
- Refactoring some method, variable and enum names to make them clearer
- Refactor Config.java and make it much cleaner and simpler by breaking 
  things down into private methods. Also changed the portoffset to be
  a normal int instead of a boxed int (Integer)
- redefine most classes to be package protected (not public) to offer
  more isolation from the rest of the framework
- redefine most classes to be final


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1745351 13f79535-47bb-0310-9956-ffa450edef68
2016-05-24 12:26:28 +00:00
Ashish Vijaywargiya 8d5599c88d Applied patch from jira issue - Quote report doesn't show terms of the quote - https://issues.apache.org/jira/browse/OFBIZ-5861
Thanks Pierre for creating the issue and Thanks Ravi for providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1744910 13f79535-47bb-0310-9956-ffa450edef68
2016-05-21 11:38:36 +00:00
Pranay Pandey 066b6a470f [OFBIZ-7099] Fixed: Service entity auto not having duplicate record check when we pass single primary key.
Thanks  Amardeep Singh Jhajj for reporting the issue and providing patch.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1744892 13f79535-47bb-0310-9956-ffa450edef68
2016-05-21 10:30:36 +00:00
Deepak Dixit 83696e3203 (OFBIZ-7021) Renamed framework common component ftl file name from lower camel case to upper camel case pattern.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1744783 13f79535-47bb-0310-9956-ffa450edef68
2016-05-20 18:52:54 +00:00
Deepak Dixit 79a4302d2c (OFBIZ-7021) Renamed framework widget component ftl file name from lower camel case to upper camel case pattern.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1744782 13f79535-47bb-0310-9956-ffa450edef68
2016-05-20 18:21:02 +00:00
Taher A. Alkhateeb a27bad3e90 clarify documentation for java -jar ofbiz.jar --testlist OFBIZ-6783
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1744547 13f79535-47bb-0310-9956-ffa450edef68
2016-05-19 09:46:01 +00:00
Taher A. Alkhateeb e2dd77fe6d improve the --test command documentation and widen commons-cli screen OFBIZ-6783
as suggested by Jacques, the commons-cli screen is widened to be
80 characters instead of the default 74 characters. Also the test
command for java -jar ofbiz.jar is improved in terms of documentation
so that it does not break off into a newline which was confusing


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1744537 13f79535-47bb-0310-9956-ffa450edef68
2016-05-19 08:54:03 +00:00
Taher A. Alkhateeb af91a37dd3 provide further clarification for usage of java -jar ofbiz.jar OFBIZ-6783
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1744528 13f79535-47bb-0310-9956-ffa450edef68
2016-05-19 08:05:27 +00:00
Taher A. Alkhateeb 9ba1e73c3b provide pretty printing for error messages for startup OFBIZ-6783
Box the error messages with "=======" strings to highlight
the error the to user when calling java -jar ofbiz.jar --somewrongcommand


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1744525 13f79535-47bb-0310-9956-ffa450edef68
2016-05-19 07:54:16 +00:00
Jacques Le Roux 4808935bbc Reverts formatting changes in Start component (was Improves the visibility of the Start error messages - OFBIZ-6783)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1744524 13f79535-47bb-0310-9956-ffa450edef68
2016-05-19 07:38:51 +00:00
Jacques Le Roux a651b20151 No functional change, completes previous commit ("Improves the visibility of the Start error messages - OFBIZ-6783")
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1744516 13f79535-47bb-0310-9956-ffa450edef68
2016-05-19 05:31:52 +00:00