Commit Graph
10472 Commits
Author SHA1 Message Date
Arun Patidar 1316f3e26f Applied patch from jira issue - OFBIZ-7732 - Enforce noninstantiability to ModelUtil class. Thanks Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751298 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 14:47:30 +00:00
Arun Patidar c25b45ab1a Applied patch from jira issue - OFBIZ-7715 - Enforce noninstantiability to SqlJdbcUtil class. Thanks Rishi solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751296 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 14:36:44 +00:00
Arun Patidar dd984fc92a Applied patch from jira issue - OFBIZ-7690 - Enforce noninstantiability to PreferenceWorker class. Thanks Rishi solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751292 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 14:23:22 +00:00
Ashish Vijaywargiya f802907da9 Applied patch from jira issue - OFBIZ-7634 - Remove HtmlFormRenderer Class after removing its dependency.
Thanks Ravi for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751270 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 12:59:37 +00:00
Ashish Vijaywargiya f40a6b6cb4 Applied patch from jira issue - OFBIZ-7635 - Remove HtmlScreenRenderer Class after removing its dependency.
Thanks Ravi for the contribution. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751267 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 12:53:21 +00:00
Ashish Vijaywargiya 9470a3bd0e Applied patch from jira issue - OFBIZ-7513 - alt-target tag is not working as expected in Form Widget.
Thanks Pritam for the contribution. Thanks Montalbano and Jacques for participating in discussion.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751124 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 06:46:14 +00:00
Jacques Le Roux 949d21159c A patch from James Yong for "Invalid content was found starting with element 'xls'" https://issues.apache.org/jira/browse/OFBIZ-7699 reported by Nameet Jain
If found this in console logs:

XmlFileLoader: File file:/home/ofbizDemo/trunk/framework/common/widget/CommonScreens.xml process error. Line: 491. Error message: cvc-complex-type.2.4.d: Invalid content was found starting with element 'xls'. No child element is expected at this point.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751055 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 12:47:38 +00:00
Arun Patidar e7f41ad116 Applied patch from jira issue - OFBIZ-7551 - Enforce noninstantiability to SSLUtil class. Thanks Rishi solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751040 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 08:50:31 +00:00
Arun Patidar f3ce2f02ec Applied patch from jira issue - OFBIZ-7562 - Enforce noninstantiability to UtilDateTime class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751028 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 06:16:52 +00:00
Arun Patidar 542db954a5 Applied patch from jira issue - OFBIZ-7588 - Enforce noninstantiability to UtilGenerics class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751027 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 06:06:43 +00:00
Arun Patidar bd0472e263 Applied patch from jira issue - OFBIZ-7589 - Enforce noninstantiability to UtilHttp class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751026 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 05:56:47 +00:00
Arun Patidar 63308fd046 Applied patch from jira issue - OFBIZ-7601 - Enforce noninstantiability to UtilURL class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751025 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 05:46:56 +00:00
Arun Patidar 3fb5c91e11 Applied patch from jira issue - OFBIZ-7591 - Enforce noninstantiability to UtilJavaParse class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750969 13f79535-47bb-0310-9956-ffa450edef68
2016-07-01 15:53:19 +00:00
Arun Patidar 76df6b013f Applied patch from jira issue - OFBIZ-7587 - Enforce noninstantiability to UtilFormatOut class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750968 13f79535-47bb-0310-9956-ffa450edef68
2016-07-01 15:47:16 +00:00
Nicolas Malin 46296d0688 Add new functionnality on auto-complete lookup field do offer the possibility for developper to add condition dates for the search on the lookup screen.
To automatically filter on fromDate thruDate attribute with value now, init a condition map like 
     <set field="conditionDates.default" value="Y"/>

To use specific attribute date with value now
      <set field="conditionDates.fromDateName" value="startDate"/>
      <set field="conditionDates.thruDateName" value="endDate"/>

To use an other value than now
      <set field="conditionDates.filterByDateValue" from-field="invoice.invoiceDate"/>
or
      <set field="conditionDates.filterByDateValue" value="2016-01-01 00:00:00" type="Timestamp"/>

You can also set only low border date 
      <set field="conditionDates.fromDateName" value="fromDate"/>
Or you can also set only high border date 
      <set field="conditionDates.thruDateName" value="endDate"/>

Thanks to Kongrath Suankaewmanee for the proposition follow on issue OFBIZ-7266

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750856 13f79535-47bb-0310-9956-ffa450edef68
2016-06-30 19:38:13 +00:00
Arun Patidar 593f996d60 Applied patch from jira issue - OFBIZ-7540 - Enforce noninstantiability to FileUtil class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750663 13f79535-47bb-0310-9956-ffa450edef68
2016-06-29 15:20:09 +00:00
Arun Patidar 7f6a53c91f Applied patch from jira issue - OFBIZ-7479 - Enforce noninstantiability to BshUtil class. Thanks Rishi Solanki and Rahul Singh for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750662 13f79535-47bb-0310-9956-ffa450edef68
2016-06-29 15:16:20 +00:00
Arun Patidar 8357565e56 Applied patch from jira issue - OFBIZ-7474 - Enforce noninstantiability to ServiceMcaUtil class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750661 13f79535-47bb-0310-9956-ffa450edef68
2016-06-29 15:11:54 +00:00
Arun Patidar 103115895f Applied patch from jira issue - OFBIZ-7466 - Enforce noninstantiability to ProtectViewWorker Class. Thanks Pratik Kulshreshth for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750648 13f79535-47bb-0310-9956-ffa450edef68
2016-06-29 14:07:41 +00:00
Jacques Le Roux 6e54fba04e A last slightly modified patch from James Yong for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
I have uploaded a patch for the simple methods schema.
In general, the top level attributes are converted to simpleType, and attributeGroups to complexType.

Changed the following attribute name
1. ‘field’ to ‘fieldType’
2. ‘level’ to ‘levelType'

Denormalize the following attributeGroups
1. attlist.compare
2. attlist.compare-field

Left attributeGroup ‘typeDefaultString’ unchanged, cos it doesn’t matter. Not in use, it seem.

jleroux: we also fixed an issue with 
<xs:element name="field" type="fieldType"/> 
to 
<xs:element ref="field"/>
In the patch 

And I found a small issue (not minilang related) in ExampleCompoundWidgets.xml
-            <sm:log message="CompoundWidgetsFunc runs" sm:level="info"/>
+            <sm:log message="CompoundWidgetsFunc runs" level="info"/>


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750647 13f79535-47bb-0310-9956-ffa450edef68
2016-06-29 14:06:29 +00:00
Jacques Le Roux 12e9c7f36c No functional change, just removing trailing blanks
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750585 13f79535-47bb-0310-9956-ffa450edef68
2016-06-28 21:11:06 +00:00
Jacques Le Roux 4172b230a7 A patch from Amardeep Singh Jhajj for "Add websocket support in OFBiz" https://issues.apache.org/jira/browse/OFBIZ-7073
It also contains a slightly modified patch from Amardeep Singh Jhajj for "WebSocket Example - Push Notifications" - https://issues.apache.org/jira/browse/OFBIZ-7467 - It's adding working example (in example application) of WebSocket support

I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar in catalina lib and created one webapp for websocket and also added server endpoint class.
It didn't work. After that, I tried the same thing with plain j2ee application with embedded tomcat. It worked there.
I researched on above issue in OFBiz and got the reason. Websockets implementation need jar scanning enabled and it is currently disabled in OFBiz. Below is the code snippet of disabling jar scan from CatalinaContainer.java:

    JarScanner jarScanner = context.getJarScanner();
    if (jarScanner instanceof StandardJarScanner) {
        StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
        standardJarScanner.setScanClassPath(false);
    }

Jar scanning enabling increase OFBiz server startup time upto couples of minutes (in my case, it took approx 8 minutes), so we don't want this much of startup time for OFBiz.
I got the following document where I found the reason why websocket is not working if scanning disabled.

    https://wiki.apache.org/tomcat/HowTo/FasterStartUp

Here tips are given to decrease the startup time. This tips also include disabling of jar scanning. 
We can say disabling jar scanning is right approach because if we enable it then scanner will scan all the jars loaded in OFBiz startup that we don't want.
But, If we want websockets working then we have to enable jar scanning.
For enabling jar scanning, we need below code:

    standardJarScanner.setScanClassPath(true); // Will increase server startup time.

Solution: We can add filter on jar scanning. It will allow only some kind of jars only. For example: jars having websockets endpoints. I am attaching patch for the same here.
I added filter like if jar name string contains "discoverable" word then only it will be considered for jar scan. We can change jar name of our jars using build.xml to make it discoverable for jar scanning.
For example: I have added my websocket endpoint class in "specialpurpose/ecommerce/src" and changed the "name" property in build.xml of ecommerce component from "ofbiz-ecommerce"
to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:

    <property name="name" value="ofbiz-ecommerce-discoverable"/>

This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" in "ecommerce/build/lib/".
Now created jar will be scanned in jar scanner as its name contains "discoverable" word in it.
This change will not increase server start up time more than couple of seconds (in my case, it just two seconds). So scanning time totally depends on the list of jars scanned.
Conclusion: We can use websocket support with the help of jar filters.

The very basic working example of sending push notifications to all connected clients using WebSocket added by Amardeep Singh Jhajj works as follow:
1. Adds support to show push notifications over every screen of an example application using WebSocket when any example created or updated.
2. As it's an example, so for now push notifications will only for example creation and update using SECA's.
3. Push notification will be shown on screen for 5 seconds only, we can close it before 5 seconds using close button if needed.
The UI of notification pop-up can be changed. I kept it simple (No fancy work) to just demonstrate the WebSocket usage.
To see it in action, Please follow the steps given in OFBIZ-7073 and apply patch given here.


jleroux: I committed the 2 patches at the same time because the changes in .classpath and the LICENSE files were in the example patch for OFBIZ-7467. 

I also slightly modified the example patch in order to provide an example where no sync issues are possible by using a Collections.synchronizedSet for the javax.websocket.Session Set. I also used synchronized loops as it's requested for synchronizedSet where it's used. I know it rather symbolic in the example component but it will remember developers about the possible sync issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750557 13f79535-47bb-0310-9956-ffa450edef68
2016-06-28 18:50:04 +00:00
Deepak Dixit cb2a770d25 (OFBIZ-7350) Applied slightly modified patch jira issue.
===========================================
Manage filters in lookup auto completion
===========================================

Thanks  Charles STELTZLEN for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750555 13f79535-47bb-0310-9956-ffa450edef68
2016-06-28 18:46:50 +00:00
Arun Patidar 77dbb2851c Applied patch from jira issue - OFBIZ-7459 - Enforce noninstantiability to ApacheFopWorker Class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750534 13f79535-47bb-0310-9956-ffa450edef68
2016-06-28 15:10:51 +00:00
Arun Patidar 22321501c4 Applied patch from jira issue - OFBIZ-7453 - Enforce noninstantiability to WebDavUtil Class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750532 13f79535-47bb-0310-9956-ffa450edef68
2016-06-28 15:01:10 +00:00
Arun Patidar 48a8eefce6 Applied patch from jira issue - OFBIZ-7446 - Enforce noninstantiability to WebSiteWorker Class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750527 13f79535-47bb-0310-9956-ffa450edef68
2016-06-28 14:44:16 +00:00
Arun Patidar 4df4175818 Applied patch from jira issue - OFBIZ-7433 - Enforce noninstantiability to UtilCacheEvents Class. Thanks Rahul Singh for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750525 13f79535-47bb-0310-9956-ffa450edef68
2016-06-28 14:36:05 +00:00
Arun Patidar 760d8e11a5 Applied patch from jira issue - OFBIZ-7428 - Enforce noninstantiability to WidgetContentWorker Class. Thanks Rishi Solanki and Pratik Kulshreshth for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750521 13f79535-47bb-0310-9956-ffa450edef68
2016-06-28 14:27:18 +00:00
Arun Patidar 00f9537e01 Applied patch from jira issue - OFBIZ-7422 - Enforce noninstantiability to WidgetDataResourceWorker Class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750515 13f79535-47bb-0310-9956-ffa450edef68
2016-06-28 14:06:41 +00:00
Arun Patidar c5cb0d4f49 Applied patch from jira issue - OFBIZ-7420 - Enforce noninstantiability to WidgetPortalPageWorker Class. Thanks Rishi Solanki and Rahul Singh Kushwah for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750513 13f79535-47bb-0310-9956-ffa450edef68
2016-06-28 14:02:14 +00:00
Nicolas Malin 05c05be429 OFBIZ-7632 and OFBIZ-7633 Remove deprecated TextFormRenderer class that has been replace by MacroFormRenderer. Thanks Ravi Lodhi for this issue.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750401 13f79535-47bb-0310-9956-ffa450edef68
2016-06-27 18:38:14 +00:00
Nicolas Malin 1fd2632252 OFBIZ-7631 Remove deprecated XmlFormRenderer class that has been replace by MacroFormRenderer. Thanks Ravi Lodhi for this issue
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750400 13f79535-47bb-0310-9956-ffa450edef68
2016-06-27 18:33:29 +00:00
Arun Patidar f36e6a76f8 Applied patch from jira issue - OFBIZ-7412 - Enforce noninstantiability to UtilHelpText Class. Thanks Amit Gadaley for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750353 13f79535-47bb-0310-9956-ffa450edef68
2016-06-27 14:46:24 +00:00
Pranay Pandey 517138623b [OFBIZ-7575] Fixed styling issue on Logs in LogView, as none was being applied.
As per updated code now-
INFO will be shown in Green color
WARNING will be in bold Blue color
ERROR will be in Red color along with border
DEBUG will be in Grey color
Thanks Swapnil M Mane for reporting the issue and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750336 13f79535-47bb-0310-9956-ffa450edef68
2016-06-27 13:53:24 +00:00
Ashish Vijaywargiya 33d8e7a9a1 Applied patch from jira issue OFBIZ-7574 - Remove HtmlFormWrapper Class after removing all its dependencies.
Thanks Ravi for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750309 13f79535-47bb-0310-9956-ffa450edef68
2016-06-27 08:20:28 +00:00
Jacques Le Roux a025b28013 Fixes an issue related done with "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 reported by Swapnil M Mane
<<xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">> was missing, this happened in r1749488. It was the only case like that (checked in Eclipse using validate, there are tons of other mnior issues BTW)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750050 13f79535-47bb-0310-9956-ffa450edef68
2016-06-24 08:51:05 +00:00
Jacques Le Roux 642f42886e A temporary workaround for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
Reverts the simple method to use the original schema without namespace. "Duplicates" simple-methods.xsd in simple-methods-ns.xsd as we did, to get the simple-method namespace for compound-widgets.

For myself: when we will do the 3rd more elegant option (no schema duplication), have been changed also:
minilang-catalog.xml
compound-widgets.xsd


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749938 13f79535-47bb-0310-9956-ffa450edef68
2016-06-23 16:40:22 +00:00
Arun Patidar a91b9edae9 Applied patch from ticket - OFBIZ-7339 - Replace EntityUtilProperties getPropertyValue method with correct method calls. Thanks Rahul Singh Kushwah and Rishi Solanki for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749882 13f79535-47bb-0310-9956-ffa450edef68
2016-06-23 13:10:51 +00:00
Ashish Vijaywargiya 9e63d2dde8 Applied patch from jira issue - OFBIZ-7330 - Error with Agreement Item Supplier product Pdf.
Thanks Ravi for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749850 13f79535-47bb-0310-9956-ffa450edef68
2016-06-23 06:59:22 +00:00
Jacques Le Roux a0acf8fa3d No functional change, just formatting
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749664 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 12:47:38 +00:00
Jacques Le Roux c8ba932772 Fixes a "typo" in last commit for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
We used targetNamespace (should only be used in schema) instead of xsi:schemaLocation



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749634 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 05:58:26 +00:00
Jacques Le Roux 89212904bd Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749489 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:37:47 +00:00
Jacques Le Roux 4931db1ed9 Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 by replacing xsd files references in xml files by -ns.xsd files and removing the concerned xsd files
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749488 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:14:16 +00:00
Jacques Le Roux b43b62bef2 Updates Shiro to 1.2.5 (CVE-2016-4437) - https://issues.apache.org/jira/browse/OFBIZ-7373
Apache Shiro before 1.2.5, when a cipher key has not been configured for the "remember me" feature, allows remote attackers to execute arbitrary code or bypass intended access restrictions via an unspecified request parameter.

Details at https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2016-4437

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749220 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:30:06 +00:00
Pranay Pandey ce35b0d583 [OFBIZ-7274] Updated the widget.lookup.width property so that the pagination header in lookups is rendered properly.
Thanks Vaibhav Jain for reporting the issue and Aditya Patwa for providing the patch.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1748929 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 07:34:32 +00:00
Jacques Le Roux 11b4e86332 A patch from Gareth Carter for "connection pooling not working" https://issues.apache.org/jira/browse/OFBIZ-7346
Connection pooling does not seem to work. Connections are created fine but as the close() method is called (outside of transaction) or the transaction is committed the connections are closed to the db server and not returned to the pool.

I believe the issue is with org.apache.commons.dbcp2.PoolableConnectionFactory passivateObject method. This will call rollback() when rollbackOnReturn is set to true even if the transaction is committed. This is because any connection wrappers extending org.apache.commons.dbcp2.DelegatingConnection cache autoCommit status. At some point, this cached autoCommit is different from the underlying connection autoCommit. The rollback() method will throw an exception and the connection is destroyed rather than put back to the pool

Environment this has been tested on:
ofbiz: rev 1725574 and latest trunk (as of 2016-06-14)
db: postgresql 9.1
jdbc driver: postgresql-9.3-1101.jdbc4
os: linux and windows

jleroux: this issue doest not exist with Derby, it's a matter of driver (DBMS actually) see Derby vs Postgres

    https://db.apache.org/derby/docs/10.9/devguide/cdevconcepts29416.html
    https://www.postgresql.org/docs/9.1/static/ecpg-sql-set-autocommit.html

Another solution would be to force Postgres to autocommit but I'd not do that, better not change this DBMS dependent behaviour.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1748837 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 11:51:13 +00:00
Jacques Le Roux b476fc3dfc As always forgot to commit this French label change while committing stuff for OFBIZ-7363. Anyway better to have it apart.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1748703 13f79535-47bb-0310-9956-ffa450edef68
2016-06-16 12:34:30 +00:00
Jacques Le Roux 6eaa2239a6 Fixes "The Connection Pool Status feature in webtools is broken" - https://issues.apache.org/jira/browse/OFBIZ-7363
Completes the work I did in r1748689. Actually I worked on different editors and mixed things so not all was committed previously, here they are

Removes now useless commented out line about DebugManagedDataSource (// Useful to debug the usage of connections in the pool). I put more information in the class head while fixing the type warnings

Fixes other type warnings I missed previously

Eventually removes the old comment
        // Hmm... then how do we close the JDBC connections?
Because "we" don't close JDBC connections, DBPC takes care of that (or at least should, I did not check).


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1748693 13f79535-47bb-0310-9956-ffa450edef68
2016-06-16 12:13:02 +00:00
Jacques Le Roux e0c49bb75f Fixes "The Connection Pool Status feature in webtools is broken" - https://issues.apache.org/jira/browse/OFBIZ-7363
The Connection Pool Status feature was introduced by OFBIZ-4864 hence 1st in R13.07 where it still work well (see demo), as the connection pooling. But has been broken since, with the pooling.
Fortunately, it's easy to fix and has no implications has long has you don't enable verbose logging (the DebugManagedDataSource only extends ManagedDataSource for verbose logging and to generate the info needed for the Connection Pool Status feature).

I fixed it by using directly the DebugManagedDataSource. It's not an issue as long as you don't set the logging level to verbose which is anyway not something you would do in production. In case you do so and don't want to be disturbed in the log (focusing on something else), it's still easy to comment out the line from DebugManagedDataSource. I also fixed some type warnings while at it.

I also removed this old comment
        // Hmm... then how do we close the JDBC connections?
Because "we" don't close JDBC connections, DBPC takes care of that (or at least should, I did not check).

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1748689 13f79535-47bb-0310-9956-ffa450edef68
2016-06-16 11:46:03 +00:00
Jacques Le Roux 3d61573b57 A patch from Arvind Singh Tomar for "Inventory report throws an error" https://issues.apache.org/jira/browse/OFBIZ-6947 reported by Pierre Smits
When executing the print pdf function in https://demo-trunk-ofbiz.apache.org/facility/control/ViewFacilityInventoryByProduct
the following error is thrown:
Unable to transform FO file: org.apache.fop.apps.FOPException: org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is missing child elements. Required content model: marker* (%block;)+ (See position 80:115) javax.xml.transform.TransformerException: org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is missing child elements. Required content model: marker* (%block;)+ (See position 80:115)

The issue was due to missing child element which is failing on validation. Earlier we were using fop-1.1.jar and now it is updated to fop-2.0.jar which by default validates the markup. It is same as OFBIZ-7090
I have added the missing child elements in the macro which were causing the validation to fail and providing the updated patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1748628 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 20:11:57 +00:00