Commit Graph
27737 Commits
Author SHA1 Message Date
Jacques Le Roux c2c609d8e4 Improved: Dependency verification (OFBIZ-12186)
I just read an ASF members thread about this article:
https://medium.com/@alex.birsan/dependency-confusion-4a5d60fec610

One member mentioned that the Groovy project is using the Gradle's dependency
verification feature[1] in the Apache Groovy build.

I suggest we do the same, even after the move from JCenter to MavenCentral where
things should be safer.

[1] https://docs.gradle.org/current/userguide/dependency_verification.html

This commit includes:
The  verification-metadata.xml and verification-keyring.gpg used by the
verification task
*.gpg as binary in .gitattrubtes for verification-keyring.gpg

The documentation about the verification in sy-dependency-verification.adoc
with a link and some unrelated changes in security.adoc about security for
OFBiz in production
An empty line removed in build.gradle
2021-02-27 13:53:33 +01:00
Sebastian Berg bcb76eb607 Improved: Convert ImageManagementServices.xml minilang to groovy (OFBIZ-11604) 2021-02-26 18:53:22 +01:00
Sebastian Berg 1047003b92 Fixed: Remove CommunicationContent not working as expected (OFBIZ-12172) 2021-02-26 18:49:58 +01:00
James Yong 162506d372 Fixed: Display last-visited-time popup after login (OFBIZ-12148)
Empty popup occurs when showjGrowl is run later than the javascript from unsafe message. Delay running of showjGrowl function from 10 to 100 milliseconds.

Thanks Jacques for reporting.
2021-02-24 16:54:39 +07:00
Jacques Le Roux 07054fdaf5 Fixed: Error while running MRP (OFBIZ-12187)
I tried running MRP for Sales Forecast option and it returned the following error.

Error running the initMrpEvents service: Service [initMrpEvents] target threw
an unexpected exception (java.sql.Timestamp cannot be cast to java.sql.Date)

Thanks: Nameet Jain
2021-02-23 12:59:46 +01:00
Jacques Le Roux 67e4f61a66 Fixed: fixes wrong wiki URL 2021-02-22 11:45:43 +01:00
Jacques Le Roux 78dd625bbe Improved: Display last-visited-time popup after login (OFBIZ-12148)
Makes afterlogin.lastvisit.show to false by default and document that in the
security documentation, ie in
https://cwiki.apache.org/confluence/display/OFBIZ/How+to+secure+your+deployment

Else when working in dev mode you always have to remove or wait the message to
remove itself

Fixes wrong wiki links in sy-password-and-JWT.adoc
2021-02-22 11:15:28 +01:00
Jacques Le Roux 4944ef8017 Fixed: Error while uploading file in Ecommerce Profile's File Manager (OFBIZ-10746)
On uploading File in Ecommerce Profile's File Manager,

"The following required parameter is missing:
[IN] [uploadPartyContentFile.partyContentTypeId]" error is displaying.

Steps to regenerate the issue:
    Open Ecommerce on Ofbiz.
    Login with any user.
    Go to Profile.
    Navigate down to File Manager.
    Select Purpose.
    Seletct Mime Type
    Click upload.

Thanks: Aishwary Shrivastava for report, Priya Sharma fir the fix
2021-02-21 19:20:00 +01:00
Jacques Le Roux 54ab93ff2a Improved: Field 'govAgencyPartyId' shows all parties, not just Government Agencies (OFBIZ-10863)
The field govAgencyPartyId in the AddFixedAssetRegistration form shows all
parties through the lookup target-form-name="LookupPartyName function.

This should be limited to those parties that qualify with the constraint.

Thanks: Pierre Smits for report Priya Sharma for the fix
2021-02-21 14:22:00 +01:00
Jacques Le Roux d5c336ed3a Fixed: Error on quick ship complete order (OFBIZ-12185)
When we try to quick ship entire order from the Order Manager, the following
error is thrown (in some cases, specifically when we have added a telecom number
for the customer

This was broken by OFBIZ-11462

Thanks: Priya Sharma
2021-02-21 14:14:38 +01:00
SebastianEcomify 8a96462538 Improved: Convert CostService.xml minilang to groovy
(OFBIZ-11595)

Thanks: Sebastian Berg for implementation
2021-02-21 11:38:21 +00:00
Jacques Le Roux e988dd4efd Improved: increases some French labels length
They fits with new enlarged second menu in Rainbow Stone
2021-02-21 12:31:13 +01:00
Jacques Le Roux 36380d198d Improved: Enlarge the "more-app" menu in Rainbow Stome theme (OFBIZ-12181)
Enlarges #more-app in rainbowstone-main-theme.less from 40 to 200px
2021-02-21 12:17:24 +01:00
Jacques Le Roux 7fb64ba5b5 Fixed: Wrong heading on creating quote under order component (OFBIZ-11221)
Steps to re-generate :

1. Login with the username and password.
2. Go to order component order.
3. Click on Quotes
4. Click on new quotes

Error: Edit quote is shown on the place of New quote.
Actual: New quote should be shown on the place of edit quote on UI.

Thanks: jai kumar raghuwanshi for report, Pradyum Dharwa  for 1st patch,
Ratnesh Upadhyay for better suggestion and Ankit Joshi for the patch
2021-02-20 13:28:06 +01:00
Jacques Le Roux b1c611bebd Fixed: Bypass Java GString to String conversion in ObjectType::simpleTypeOrObjectConvert (OFBIZ-12182)
Follows https://markmail.org/message/azn7e4g2rbpo7tvj
2021-02-19 09:28:53 +01:00
Jacques Le Roux 4be71d74c2 Improved: Update Freemarker to 2.3.31 (OFBIZ-12180)
Adds the Jira ref
2021-02-18 13:43:09 +01:00
Jacques Le Roux 44922f0fba Improved: Update Freemarker to 2.3.31 2021-02-18 13:35:53 +01:00
Jacques Le Roux e259170b77 Improved: Improvement on Find BOM screen (OFBIZ-12179)
While exploring the manufacturing code I observed on the find screen BOM type is
set hardcoded. We can improve it by using the entity-option tag to allow all
ProductAssocType with parentTypeId equals "PRODUCT_COMPONENT".

Thanks: Nameet Jain
2021-02-18 11:57:35 +01:00
Nicolas Malin 5229d572df Implemented: Element link can update partial area
(OFBIZ-11810)

   Currently when you want to display an information easily on sub-screen
dynamically (example as related element) is currently not possible without
write specific js code.
   To simplify it, we introduce a new link type: update-area, to indicate
to the theme that we want to refresh  a local area with the call result.

   Example :
       <link target="ListCategoryProductMembers" link-type="update-area" target-window="detail">
           <parameter param-name="productCategoryId"/>
       </link>

For this example we indicate that the display result of target 'ListCategoryProductMembers' is going
on the area identify by 'detail'. Pleasure to the theme to manage it.
2021-02-17 18:11:19 +01:00
Deepak Dixit 574bf8fa31 Fixed: Corrected property name as defined in general.properties
(OFBIZ-10008)
2021-02-17 12:43:06 +05:30
Wiebke Pätzold 785be8abe4 Fixed: Financial account transaction (OFBIZ-10308)
Fixes the direction of some accounting transactions.

Thanks Ingo Wolfmayr for the patch
2021-02-15 19:47:21 +01:00
Sebastian Berg 18b83b91c2 Fixed: Unable to add product (of ASSET_USAGE type) in order OFBIZ-10791
Thanks Priya for providing the patch
2021-02-15 17:56:35 +01:00
Michael Brohl dbecce6396 Improved: Corrects max number of checkstyle errors allowed (OFBIZ-12169) 2021-02-15 17:48:09 +01:00
Michael Brohl 69c62f5f00 Merge changes for PR #267 due to conflicting changes in trunk (OFBIZ-12169) 2021-02-15 17:15:18 +01:00
Jacques Le Roux 3517a54a48 Fixed: webapp position does not really work (OFBIZ-12176)
Remove webtools from secondary menu to get it in right (12) position
2021-02-15 13:57:17 +01:00
Jacques Le Roux 0ebb819247 Fixed: webapp position does not really work (OFBIZ-12176)
Fixes the tests:
Checks that when the same position is provided by the `WebappInfo` instance
only one is retrieved

Checks that when the same title with no position is provided by the `WebappInfo`
instance 2 instances are retrieved. though they use the same title only position
allows "collision"
2021-02-15 10:21:59 +01:00
Jacques Le Roux a2dac5482c Improved: Default ordering of webapps titles in main menu (OFBIZ-12166)
[...] having more important apps in 1st places would be better [...]
the feature should be easily changed by custom projects [...]
documentation for that would be enough.

This 1st step sorts the applications and webtools. I believe webtools should not
be secondary but that needs to be discussed with other options.
2021-02-14 21:11:58 +01:00
Jacques Le Roux 568ac8927b Fixed: webapp position does not really work (OFBIZ-12176)
The current implementation of webapp position uses String as key.
You can't really order on String, you need numbers.

This is needed by OFBIZ-12166
2021-02-14 19:27:33 +01:00
Jacques Le Roux da134243f7 Fixed: issue put in with r1160964 (9 years, 5 months ago)
Fixes a syntax issue spotted while testing FreeMarker 2.3.31
2021-02-13 18:12:00 +01:00
Jacques Le Roux 432c7bde98 Fixed: Use from-field pattern instead of value=${***} pattern in 'set' element (OFBIZ-9607)
Fixes a syntax issue spotted while testing FreeMarker 2.3.31
2021-02-13 18:12:00 +01:00
Michael Brohl 662a3f9d1c Improved: Remove Compdoc functionality from content manager
(OFBIZ-10476)
2021-02-13 17:33:05 +01:00
Michael Brohl 8ea75c9e2e Fixed: Adds log4j dependencies to avoid classpath conflict while loading
log4j ReflectionUtil (OFBIZ-12171)
2021-02-13 17:08:53 +01:00
Michael Brohl 2b118ce643 Improved: Switch from jCenter to mavenCentral to handle the jCenter
shutdown (OFBIZ-12171)

See comments in build.gradle for details.
2021-02-13 17:08:53 +01:00
Jacques Le Roux d60bf1574b Fixed: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047)
After some small study, it seem there is a problem because login request not
require authentication

I have tried to add a test to check if current request is login and only if it's
not to remove PREVIOUS_REQUEST Session Attribute, it seem better with this
modification.

Thanks: Olivier for the patch and Michael for suggesting to parameterize using
a property. I simply used EntityUtilProperties.getPropertyValue instead of
UtilProperties.getPropertyValue
2021-02-13 12:29:02 +01:00
Michael Brohl 29bf0a040a Merge branch 'trunk' into OFBIZ-12169_Handle_remaining_checkstyle_errors 2021-02-13 11:26:01 +01:00
Jacques Le Roux 89b2dbaec9 Improved: Handle remaining checkstyle errors (OFBIZ-12169)
As I mentioned I copied and adapted the code from
document-upload-protection sanitizer. Focused on the issue at hand I did not
take care much about the style.

Finally (pun intended ;)) I prefer to use a try-with-ressource for fos.

Thanks: Wiebke for proposing another solution at
https://github.com/apache/ofbiz-framework/pull/267/commits/51e82c66989b093392a06cb800fc84a7e413fe45
2021-02-13 10:42:32 +01:00
Jacques Le Roux 0044d288a6 Improved: Rename some connoted words like blacklist and whitelist (OFBIZ-12168)
Updates DATAMODEL_CHANGES.adoc
2021-02-12 12:41:52 +01:00
Jacques Le Roux 49a1438806 Improved: Rename some connoted words like blacklist and whitelist (OFBIZ-12168)
The fk-name for OrderDenylist entity needs to be different from the one of
OldOrderBlacklist

Thanks to Deepak Dixit for spotting it
2021-02-12 12:34:09 +01:00
Deepak Dixit 3273793842 Fixed: Incorrect mapping for Lookup Purchase Order (#272)
(OFBIZ-12143)

This issue was due to common form is being used for LookupPurchaseOrderHeaderAndShipInfo and LookupOrderHeaderAndShipInfo screen. Passed the paginateTargetUrl from screen to make sure pagination works properly
Thanks Rajesh Kumar for reporting the issue
2021-02-12 16:05:27 +05:30
Deepak Dixit 782bddb729 Fixed File Resource not found console warning related to already removed data files 2021-02-12 12:55:31 +05:30
Suraj Khurana cbec4d7b7c Fixed: ViewQuoteProfit shows fields in wrong order.
(OFBIZ-11680)
Thanks Pierre for reporting and Lalit Dashora for providing the patch.
2021-02-12 10:59:11 +05:30
Benjamin Jugl ce5397dbc6 Fixed: Prevents NPE in Party/My Communications (OFBIZ-12164) 2021-02-11 21:36:04 +01:00
Michael Brohl d251164e06 Improved: simplified ModelInduceFromDb.groovy code to be a one-liner. 2021-02-11 20:54:18 +01:00
Wiebke Pätzold fab0783722 Improved: Used uppercase 'L' as suggested by checkstyle (OFBIZ-12169) 2021-02-10 12:44:44 +01:00
Wiebke Pätzold 39458d2897 Improved: Removed Conditional logic as shown by checkstyle (OFBIZ-12169) 2021-02-10 11:47:53 +01:00
Wiebke Pätzold 82a15c70e3 Improved: Removed inner assignments (OFBIZ-12169) 2021-02-10 11:38:04 +01:00
Wiebke Pätzold 780e00866f Improved: Changed line break so line doesnt't start with ( (OFBIZ-12169) 2021-02-10 11:35:03 +01:00
Wiebke Pätzold 3cd7cf1cea Improved: Changed modifier order (OFBIZ-12169) 2021-02-10 11:31:12 +01:00
Wiebke Pätzold 783a987e5a Improved: Multiblock indentations as shown by checkstyle (OFBIZ-12169) 2021-02-10 11:23:53 +01:00
Jacques Le Roux a608fa4b56 Improved: puts dates in migration services to be able to remove them later 2021-02-10 11:02:59 +01:00