Commit Graph
27737 Commits
Author SHA1 Message Date
Wiebke Pätzold 51e82c6698 Improved: Removes nested blocks and closed OutputStream in finally
statment (OFBIZ-12169)
2021-02-10 10:18:07 +01:00
Wiebke Pätzold 74f224f88c Improved: Removed trailing spaces (OFBIZ-12169) 2021-02-09 14:16:08 +01:00
Wiebke Pätzold 384572401d Improved: Fixed indentation level (OFBIZ-12169) 2021-02-09 14:12:15 +01:00
Wiebke Pätzold 636c5e393e Improved: max line length is 150 characters (OFBIZ-12169) 2021-02-09 14:10:36 +01:00
Wiebke Pätzold 2e6399c20c Improved: Simplified expression (OFBIZ-12169) 2021-02-09 14:09:55 +01:00
Wiebke Pätzold 8f323d493d Improved: Each variable declaration in an own statement (OFBIZ-12169) 2021-02-09 13:33:15 +01:00
Wiebke Pätzold 03960053a8 Improved: Replaced '.*' import form (OFBIZ-12169) 2021-02-09 11:30:18 +01:00
Wiebke Pätzold 5d52bcf2e1 Improved: Replaced tab character (OFBIZ-12169) 2021-02-09 10:32:26 +01:00
Wiebke Pätzold c1c0813da2 Improved: Removes illegal character as shown by checkstyle (OFBIZ-12169) 2021-02-09 10:19:49 +01:00
Jacques Le Roux e7b3169d03 Improved: Rename some connoted words like blacklist and whitelist (OFBIZ-12168)
Renames respectively blacklist and whitelist to denylist and allowlist in
several places.

There are still a lot of master word which can be replaced by main, but not in
contexts where slave is also used. I'll discuss that on dev ML again...

Provides the migrateOldOrderBlacklistAndOldOrderBlacklistType service to migrate
records from OrderBlacklist and OrderBlacklistType entities to new OrderDenylist
and OrderDenylistType entities
2021-02-09 09:55:39 +01:00
Wiebke Pätzold b65be41fc7 Improved: if else construct must use parentheses (OFBIZ-12169) 2021-02-09 09:11:48 +01:00
Wiebke Pätzold 95d37d2189 Removes and adds whitespaces as suggested by checkstyle (OFBIZ-12169) 2021-02-09 08:46:20 +01:00
Michael Brohl badc59034b Improved: Updates the max checkstyle error count according to the latest
changes (OFBIZ-12169)
2021-02-08 17:27:07 +01:00
Michael Brohl d61e0e7558 Improved: added an example memory setting notice for the case of heap
memory problems during build.
2021-02-08 17:19:58 +01:00
Michael Brohl bae3628501 Declare classes final as suggested by checkstyle (OFBIZ-12169)
Helper and Worker classes which are likely to be extended by custom
projects where left as is.
2021-02-08 17:09:56 +01:00
Wiebke Pätzold 2fe5e15a83 Improved: Adds newline at the end of file (OFBIZ-12169) 2021-02-08 16:31:13 +01:00
James Yong ad0211ab2d Improved: Display last-visited-time popup after login (OFBIZ-12148) (#266)
Improved: Display last-visited-time popup after login (OFBIZ-12148)

To allow users to know of any unauthorised access to their accounts.

Thanks: Michael for review
2021-02-08 00:04:29 +08:00
Michael Brohl 0dc7e562c9 Improved: Remove unused imports (OFBIZ-12169) 2021-02-05 18:14:51 +01:00
Jacques Le Roux a234f8e201 Improved: fixes a Java doc issue reported by checkstyle
Also removes unused ModelEntity::toXmlElement and ModelEntity::toGroupXmlElement

tasks.checkstyleMain.maxErrors from 278 to 277
2021-02-05 11:26:34 +01:00
Jacques Le Roux af9ed4e68e Fixed: Adds a blacklist (to be renamed soon to denylist) in Java serialisation (OFBIZ-12167)
Adds an example based on RMI which is known to be a problem
2021-02-05 11:02:28 +01:00
Sebastian Berg 11634ae08c Improved: Converted OrderDeliveryServices.xml minilang to groovy
(OFBIZ-11461)
2021-02-04 17:46:55 +01:00
Benjamin Jugl 5a0b0a0c0d Fixed: Checkstyle Issues in WebToolsDbEvents and UtilXml (OFBIZ-6510) 2021-02-04 12:29:28 +01:00
Michael Brohl 91594dd259 Implemented: Upgrade Tomcat from 9.0.41 to 9.0.43 (OFBIZ-12165) 2021-02-03 17:22:17 +01:00
Benjamin Jugl 8fac07ad0a Improved: Replaces ModelInduceFromDb with widgets (OFBIZ-6510) 2021-02-03 12:39:15 +01:00
Ingo Könemann ffcd8f34fc Fixed: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication
pages (OFBIZ-12047)

Added removal of the _PREVIOUS_REQUEST_ attribute when requesting
non-authenticated sites and moved targetRequestUri handling to a
accommodate this change
2021-02-03 11:47:15 +01:00
Benjamin Jugl 7bca526c10 Fixed: StringOutOfBounds Exception while checking available Languages
(OFBIZ-10707)
2021-02-03 11:24:10 +01:00
Benjamin Jugl f5788b2a81 Improved: Converts DataServices.xml to Groovy. (OFBIZ-11469) 2021-02-01 17:08:46 +01:00
Sebastian Berg a33ac5cff3 Improved: Convert EmailServices.xml mini lang to groovy (OFBIZ-11868) 2021-02-01 16:51:00 +01:00
Jacques Le Roux 8e9cbde7c5 Documented: issue on Windows when OFBiz home dir has space/s in it 2021-01-31 10:30:13 +01:00
Jacques Le Roux 2718ee011c Improved: fixes a typo 2021-01-30 11:01:37 +01:00
Wiebke Pätzold b57f4d0845 Improved: Spelling error in the German translation of Slovakia
(OFBIZ-12161)
2021-01-28 18:08:15 +01:00
James Yong 0863084062 Improved: Apply CSS Grid to Find Orders (OFBIZ-12116)
Improve CSS for centering grid item
2021-01-26 20:56:23 +08:00
Benjamin Jugl 17864a11e9 Fixed: Possible NPE in DatabaseUtil.getColumnInfo(...) (OFBIZ-11385) 2021-01-25 18:11:54 +01:00
Sebastian Berg 10f1f5a546 Improved: Update German UiLabel in relation with entity QuantityBreak (OFBIZ-12146)
changed german translations from using "Sprung" to "Staffelung"
2021-01-25 18:08:07 +01:00
Jacques Le Roux 49dbd2afcb Improved: Create 'New Request' button should be removed from create new request screen in Order the component. (OFBIZ-12121)
Thanks: Shubham Choudhary
2021-01-24 18:14:30 +01:00
Daniel Watford edd7960e4b Fixed: Use data url scheme for logo in CompanyHeader
(OFBIZ-7327)

Use a data URL rather than a regular URL for company logos when a
logo has been specified as a Party Content item. This works around the
problem of Apache FOP failing to retrieve content from HTTPS URLs.

Thanks: Deepak Dixit for the review and suggestions
2021-01-24 16:26:34 +00:00
Daniel Watford da2ab82b11 Added a SourceSet for groovyScript files specifying the classpath that should be used for compilation.
(OFBIZ-12149)

This helps IDEs navigate to the scripts' dependencies, making it easier
to spot issues during development.

However we don't want gradle to attempt to compile groovyScripts,
therefore the compileGroovyScriptsGroovy task is disabled.
2021-01-24 15:44:11 +00:00
James Yong d7d424fafd Fixed: Issue in rendering Comparitive balance sheet pdf (OFBIZ-12151), and Exporting the PDF for Cash Flow Statement displays the macro code for the date fields (OFBIZ-12155)
Bug introduced when fixing OFBIZ-12097

Thanks: Lalit for reporting OFBIZ-12151; Ankit, OFBIZ-12155. Jacques for linking the issues.
2021-01-24 10:27:42 +08:00
Jacques Le Roux c54dced51c Improved: Improve description encoding in 2 classes: MacroFormRenderer and renderableFtlFormElementsBuilder (OFBIZ-12159)
Concern MacroFormRenderer::makeHyperlinkByType and renderableFtlFormElementsBuilder::encode
I'm not sure it's useful but it's harmless
2021-01-23 18:18:16 +01:00
Jacques Le Roux cb9c366327 Fixed: Ampersand in Party not displayed correctly (OFBIZ-12140)
In the reported case, ModelFormField::getDescription double HTML encodes the
description when both the entity and the description contain an ampersand.

A solution is to test if the description is already HTML encoded before encoding
it again. If HTML encoded then only String encodes it.

BTW I'm not sure it's useful but it's harmless, the same solution can be applied
to OFBIZ-12026 and similarly in renderableFtlFormElementsBuilder::encode. I'll
do as improvements...

Thanks: Andrew Waters for report and help in analysis
2021-01-23 17:56:15 +01:00
James Yong 6a08920606 Improved: Allow Unsafe Event Message (OFBIZ-12147)
Only delay jgrowl message when there is _UNSAFE_EVENT_MESSAGE_

Thanks Michael for feedback.
2021-01-21 22:53:57 +08:00
James Yong b679d36b49 Improved: Updated tasks.checkstyleMain.maxErrors to 278 2021-01-21 21:21:54 +08:00
James Yong 1bfd3c5fb0 Improved: Allow Unsafe Event Message (OFBIZ-12147)
Allow application to define event messages that contain javascripts, via request attribute "_UNSAFE_EVENT_MESSAGE_"

Thanks Jacques for review
2021-01-21 20:46:06 +08:00
Jacques Le Roux bee1b11831 Fixed: Terms are not shown correctly on the Invoice overview (OFBIZ-12139)
When we have multiple Payment (Net Days) terms on the invoice say
20% in 15Days (FIN_PAY_NETDAYS_1)
80% in 30Days (FIN_PAY_NETDAYS_2)

The terms section shows incorrect term data as shown in the screenshot.

Thanks: Nameet Jain for report and fix, Jacopo for confirmation
2021-01-18 20:19:21 +01:00
Jacques Le Roux 20e7fc5435 Fixed: Creating a new Customer create a wrong record in CommunicationEvent (OFBIZ-12142)
In https://markmail.org/message/pf3d3qyjfucicbj7 I initially answered:
In demo data 13 parties use <<infoString="ofbiztest@example.com">> as in
<ContactMech contactMechId="FRA01" contactMechTypeId="EMAIL_ADDRESS" infoString="ofbiztest@example.com"/>
This one is loaded last. Rather
<ContactMech contactMechId="Company" contactMechTypeId="EMAIL_ADDRESS" infoString="ofbiztest@example.com"/>
which is the 1st one, should be loaded last.

A better solution is to use "ofbizsupport@example.com" in EmailServices.xml

Indeed, fortunately the Company party also uses this infoString and using it in
EmailServices.xml does not affect the integration test and should not affect
other parts of the (only) demo data

Thanks: Emad Radwan for opiniated report :) and Pritam Kute for issue analysis
2021-01-18 19:41:08 +01:00
Jacques Le Roux 3f76f86014 Improved: Marked unused HTML renderers as deprecated (OFBIZ-11927)
Upcoming Branch is actually another name for trunk. It's always evolving and
never released. Better put a date when deprecating a Class or method. Else you
have no idea when it was deprecated, apart referring to git-blame.
2021-01-16 10:14:28 +01:00
Eugen Stan cc76b990cf Improved: Add extra classpath directories for ofbiz.tar/zip
(OFBIZ-12136)

Allows people to add configuration files and jars (database drivers) when
using the binary distribution.

Thanks: Eugen Stan for improvement
2021-01-15 11:54:43 +00:00
Nicolas Malin 7165768251 Implemented: Add a framework method to get main webapp menu with the webapp name
(OFBIZ-10601)

To improve theme management and provide better tools for new themes, we implement a method to obtain the main menu of a webapp.
Instead of just managing a menu, we extend the functionality by offering a method to expose a summary of the webapp, to simplify the navigation.

For this we add a new attribute on webapp definition app-shortcut-screen :

    <webapp name="mywebapp"
            ...
            app-shortcut-screen="component://mycomponent/widget/CommonScreens.xml#ShortcutApp"
            ...
    />

The idea is to define a new purpose screen *Shortcut* that contains what defines a webapp when an action or navigation has been requested. With this screen you can load a menu, a search, a complex description and use all screen powerfulness to resolve what displaying and support by theming

    <screen name="ShortcutApp">
        <section>
            <actions>
                <property-map resource="CommonUiLabels" map-name="uiLabelMap" global="true"/>
            </actions>
            <widgets>
                <decorator-screen name="ShortcutDecorator" location="component://common/widget/CommonScreens.xml">
                    <decorator-section name="body">
                        <include-menu name="MyShortcutAppBar" location="component://mycomponent/widget/CommonMenus.xml"/>
                    </decorator-section>
                </decorator-screen>
            </widgets>
        </section>
    </screen>

Each component are self-sufficient to define what shortcuts to display without framework change or knowledge about other component.
Each theme can implement and customize the display rendering at will.

To illustrate an example of implementation we set sub menu for each webapp defined on applications and exploit it on bluelight theme.

Thanks for Dennis Balkir, Jacques Leroux, Leila Mekika and Julien Nicolas for their involvement
2021-01-15 08:56:23 +01:00
Daniel Watford c4d8f904b7 Improved: Don't log warning when ObjectType converts from String to
String

(OFBIZ-10710)

Thanks: Benjamin Jugl for report and patch.
2021-01-14 17:58:05 +00:00
Daniel Watford 406f51d032 Improved: Marked unused HTML renderers as deprecated
(OFBIZ-11927)
2021-01-14 17:30:03 +00:00