Commit Graph
10472 Commits
Author SHA1 Message Date
Nicolas Malin ec00f23292 complete commit r1710727 on OFBIZ-6354 that adding new ftl macros renderFormatHeaderOpen and renderFormatHeaderClose on htmlFromMacroLibrary.ftl. This commit adding these macro on textFormMacroLibrary.ftl, xmlFormMacroLibrary.ftl and csvFormMacroLibrary.ftl. The unit test widgettests now pass without failure
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1715756 13f79535-47bb-0310-9956-ffa450edef68
2015-11-23 10:42:55 +00:00
Jacques Le Roux 2e95018e59 Better French label, there are plenty similar others but it's OK
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1715670 13f79535-47bb-0310-9956-ffa450edef68
2015-11-22 18:28:55 +00:00
Divesh Dutta 5e7ffc0692 [OFBIZ-6709] Now when you add party content, party profile page refresh, earlier it was not refreshing. Updated uiLabelJsonObjects method's (used for jsonify ui lables) signature. Added callback function in this method to get response returned from asynchronous ajax request. After this uiLabel object is available which resolves the issue
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1715505 13f79535-47bb-0310-9956-ffa450edef68
2015-11-21 12:33:52 +00:00
Ashish Vijaywargiya fe6aabb64d Applied bug fix from jira issue - OFBIZ-6741 - The state list is not populated when trying to add a shipping address from the Quick Finalize Order screen.
Thanks Aditya for reporting the issue and providing the fix for the same.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1715495 13f79535-47bb-0310-9956-ffa450edef68
2015-11-21 10:40:47 +00:00
Deepak Dixit c1ba07a466 (OFBIZ-6241) Fixed table-layout="auto" FOP warning. Used table-layout="fixed" to fix the warning.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1715493 13f79535-47bb-0310-9956-ffa450edef68
2015-11-21 10:14:05 +00:00
Deepak Dixit 7da7a18d8a Fixed EntitySaxReader compile time warning related to Freemarker configuration.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1715491 13f79535-47bb-0310-9956-ffa450edef68
2015-11-21 10:04:59 +00:00
Jacques Le Roux 7524cd299c Fixed a bug introduced w/ r1714652 (not sure on this one but better safe than sorry)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1714691 13f79535-47bb-0310-9956-ffa450edef68
2015-11-16 22:00:52 +00:00
Jacques Le Roux d16b6da338 Fixed a bug introduced w/ r1714652
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1714689 13f79535-47bb-0310-9956-ffa450edef68
2015-11-16 21:56:56 +00:00
Jacques Le Roux 1b8b15b45d Fixed a bug introduced w/ r1714652
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1714688 13f79535-47bb-0310-9956-ffa450edef68
2015-11-16 21:54:10 +00:00
Jacques Le Roux fbca214fca Fixed a bug introduced w/ r1714652
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1714686 13f79535-47bb-0310-9956-ffa450edef68
2015-11-16 21:52:16 +00:00
Jacques Le Roux 3c7cf2bd0d Fixes OFBIZ-6727 - Webtools Entity edition, the suggested date and time formats are not localised
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1714657 13f79535-47bb-0310-9956-ffa450edef68
2015-11-16 20:32:00 +00:00
Jacques Le Roux b32ea9f89f No functional change, completes r1713985: removes superfluous .properties extension from UtilProperties requests (and yes I checked UspsServicesTests ;))
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1714652 13f79535-47bb-0310-9956-ffa450edef68
2015-11-16 19:02:25 +00:00
Jacques Le Roux c66a9b8c30 Updates commons-collections lib from 3.2.1 to 3.2.2
[CVE-2016-2170] The infamous Java serialization vulnerability

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1714571 13f79535-47bb-0310-9956-ffa450edef68
2015-11-16 12:24:13 +00:00
Jacques Le Roux efd15b5a63 Fixes "Project Manager throws error if project user is not assigned to every project" OFBIZ-4206 reported by Tolulope Aganga-Williams and well commented by Mansour Al Akeel and Pierre Smits
The project manager returns an error on the main page unless every user is added to every single project. It should return a list of just the projects the user is assigned to.

:ERROR MESSAGE: 
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Error running Groovy script at location [component://projectmgr/webapp/projectmgr/WEB-INF/actions/ListCurrentProjects.groovy]: org.ofbiz.service.ServiceAuthException: You have no access to the project#: 10040 (Error running Groovy script at location [component://projectmgr/webapp/projectmgr/WEB-INF/actions/ListCurrentProjects.groovy]: org.ofbiz.service.ServiceAuthException: You have no access to the project#: 10040) 
It defeats the point.

Mansour:
Pierre,
The patch seems to restrict access to this scree to "PROJECTMGR_ADMIN".
I am not sure if this issue is to be resolved in the screen or making the service returns projects the user has access to.
I appreciate your help here.

Pierre:
Hi Mansour,
You are right. The patch indeed does that and returns a blank screen for
users other than with access 'PROJECTMGR_ADMIN. Other users can look at
projects which will show projects the user is a member of.

jleroux:
I did not test all, but because of ListCurrentProjects.groovy, it seems to me that this is a better solution
I added the CommonAsk label to help lambda users better understand the situation (by asking :p)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1714415 13f79535-47bb-0310-9956-ffa450edef68
2015-11-15 09:01:57 +00:00
Jacques Le Roux 8dfbe6834c A patch from Pierre Smits for "remove superfluous comment from entity-eca.xsd" https://issues.apache.org/jira/browse/OFBIZ-6724
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1714308 13f79535-47bb-0310-9956-ffa450edef68
2015-11-14 12:41:26 +00:00
Jacques Le Roux 6a71e0df30 A patch from Forrest Rae for "org.ofbiz.common.login.LoginServices.userLogin causes stack track when username or password is incorrect" https://issues.apache.org/jira/browse/OFBIZ-6721
org.ofbiz.common.login.LoginServices.userLogin is returning ERROR when a username or password is incorrect. It should return FAILURE instead of error. The error causes stack track to be printed to the log. The stack trace makes watching the log for actual errors difficult. This is especially hard when running and analyzing the log after a full test run, of in my case, a custom set of test cases.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1714244 13f79535-47bb-0310-9956-ffa450edef68
2015-11-13 17:38:07 +00:00
Jacques Le Roux 0eab108bbb A patch from Pierre Smits for "Remove tenant data from the demo data set" https://issues.apache.org/jira/browse/OFBIZ-5757
The demo data set (in location /framework/entity/data/TenantDemoData.xml) contains elements to load the tenants DEMO1 and DEMO2 into the implemented OFBiz setup.

This data set is intended to be loaded into the master tables when a user wants to explore multity tenancy. However, when a user also wants/needs to load demo data into the tenant DEMO1 or DEMO2 OFBiz also tries to upload the demo setup data for each tenant. This is not allowed as tenants do not have access to tables:
# Tenant
# Tenantdatasource
# etc

jleroux: (based on a Pierre's comment)
With
    ./ant create-tenant
and
    ./ant load-tenant-data-readers

We provide enough tools to explore the opportunity to demonstrate the multi-tenancy aspects of OFBiz. 
Moreover OFBIZ-6720 will be used to rewrite the multi-tenant support page in wiki. We will then see if we should not remove old ant tenant related targets now useless


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1714085 13f79535-47bb-0310-9956-ffa450edef68
2015-11-12 16:22:34 +00:00
Jacques Le Roux 8ae051720e Non functional changes
Removes useless commented out code in UtilCodec.java
Replaces a tab by spaces in ContextFilter.java
Removes useless line and replaces tabs by spaces in OFBizSolrContextFilter.java (annoying in compare)



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1713991 13f79535-47bb-0310-9956-ffa450edef68
2015-11-12 09:34:56 +00:00
Jacques Le Roux a0f6bcc5d0 No functional change, completes r1713985 ("Remove superfluous .properties extension from EntityUtilProperties requests" https://issues.apache.org/jira/browse/OFBIZ-6719) for groovy files (nothing left elsewhere)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1713989 13f79535-47bb-0310-9956-ffa450edef68
2015-11-12 09:32:13 +00:00
Jacques Le Roux 87f4513d2b A modified patch from Pierre Smits for "Remove superfluous .properties extension from EntityUtilProperties requests" https://issues.apache.org/jira/browse/OFBIZ-6719
Currently many EntityUtilProperties requests have the .properties extension in the parameters for the resource, but this is not needed as it is stripped later on.

jleroux: I found 5 others, replaced also


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1713985 13f79535-47bb-0310-9956-ffa450edef68
2015-11-12 09:22:38 +00:00
Jacques Le Roux ec34fab02e Forgot the label used in previous commit
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1713901 13f79535-47bb-0310-9956-ffa450edef68
2015-11-11 17:37:10 +00:00
Jacques Le Roux 0bd172fafc Completes r1709882 for <<Possible static XSS issue with Content>> https://issues.apache.org/jira/browse/OFBIZ-6669
As explained in OFBIZ-6669 last comments, contrary to what I did in ContentWorker class, when I before did the work on *ContentWrapper classes I did not use the sanitizer but only an encoder (either HTML or URL).
Because I wrongly supposed that only plain text was used there and certainly my lazy mind thought it was easier because of the URL encoderType to also handle.

When the encoderType is HTML, we now use the sanitizer in *ContentWrapper classes, and ContentWorker.java has also been adapted. 
For that I enhanced the UtilCodec class. The sanitizer is only used when HTML is requested, else the sanitize() method simply calls the encode() method.

I removed the content.sanitize property in content.properties and added a sanitizer.permissive.policy property in the new owasp.properties (in base config) with some explanations. This allows for more configuration.

I changed the line 85 in productsummary.ftl to use an HTML content wrapper, same in minilastviewedcategories.ftl. 
To be totally complete, we should change *lines like* in productsummary.ftl line 85 to use an HTML content wrapper.
Not easy to spot but anyway those not done will simply not totally show well, without any security impacts.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1713634 13f79535-47bb-0310-9956-ffa450edef68
2015-11-10 13:40:22 +00:00
Jacques Le Roux 2e46227f59 This has slipped in inadvertently, removes to add in next commit
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1713632 13f79535-47bb-0310-9956-ffa450edef68
2015-11-10 13:26:23 +00:00
Jacques Le Roux 5befa22833 A modified patch from Pierre Smits for "Display GeoPoint with map in WebTools" https://issues.apache.org/jira/browse/OFBIZ-6527
Currently only a list of geoPoints is shown. The user experience will improve when we not only show that, but a map as well.

jleroux: 
I refactored the js scripts in party editGeoLocation.ftl and added webtools GeoLocation.ftl into a new common GoogleGeoLocation.ftl template now included in both party editGeoLocation.ftl and webtools GeoLocation.ftl 
I also removed trailing blanks in common GeoLocation.ftl template. 
I also added a French label

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1713627 13f79535-47bb-0310-9956-ffa450edef68
2015-11-10 12:32:01 +00:00
Jacques Le Roux 81dc18d40c A rearranged patch from Gareth Carter for "Update SimpleContentViewHandler to return mime type on file extension and use inline for content-disposition" https://issues.apache.org/jira/browse/OFBIZ-6702
SimpleContentViewHandler will return mime type 'text/html' for all DataResource values without a specified mimeTypeId. Changing to DataResourceWorker.getMimeType will allow determining the mimeTypeId by file extension 
Fixing the mime type will allow the browsers to display content inline if UtilHttp is updated aswell. All unknown extensions will be set to octet-stream causing the browser to prompt for download

jleroux: after some discussions, this finally uses a content-disposition-type property in requestHandler.properties to allow more flexibility for users (see UtilHttp.setContentDisposition() method). Beware "inline" is less secure. For this reason, Gareth forced the "dangerous" text/html mime type to application/octet-stream in SimpleContentViewHandler class. This to prevent possible static XSS attacks. See the Jira issue for more details.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1712835 13f79535-47bb-0310-9956-ffa450edef68
2015-11-05 17:47:00 +00:00
Jacques Le Roux 50cedb1744 Implements "Improve the way default position and size lookup parameters are set" https://issues.apache.org/jira/browse/OFBIZ-6710
Inspired by Nicolas's recent work on modal-layer windows

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1712520 13f79535-47bb-0310-9956-ffa450edef68
2015-11-04 09:54:34 +00:00
Jacques Le Roux 53a618ce1a Fixes https://issues.apache.org/jira/browse/OFBIZ-6673 "Form layered-modal is not respecting passed (default) width"
Actually this worked perfectly well, I just used size instead of height in the hyperlink definition. Better to not set anything and use default value which are committed uncommented here

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1712411 13f79535-47bb-0310-9956-ffa450edef68
2015-11-03 21:04:03 +00:00
Jacques Le Roux aa9129deb3 These changes accidentally slipped in with r1712347, reverting
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1712366 13f79535-47bb-0310-9956-ffa450edef68
2015-11-03 18:41:04 +00:00
Jacques Le Roux 40bc757dea An updated and modified patch from Bob Morley for "ProductStore did not allow the default timezone to be set" https://issues.apache.org/jira/browse/OFBIZ-2813
The ProductStore has the defaultLocaleString and the defaultCurrencyUomId but does not have a defaultTimeZoneString.  What happens when a store is selected (from e-commerce or the POS) is that it will look to the user for a lastTimeZone and if that is not set, it would simply revert to the TimeZone.getDefault() (so the timezone based on the server).

The trouble we had was that you may have an application server that is running in a completely different timezone than what is desired for the store.

jleroux: see comments in the Jira issue for the modifications I did

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1712347 13f79535-47bb-0310-9956-ffa450edef68
2015-11-03 16:53:30 +00:00
Jacques Le Roux 7f3a9303ad This is an (almost) automatically done (ie I locally ran createJsLanguageFileMapping service) update of the JsLanguageFilesMapping for Java 8
There are some things interesting in it: look for instance for de-GR or ja-JP-JP-#u-ca-japanese
You can already seen those at http://demo-trunk-ofbiz.apache.org/catalog/control/ListLocales (yes you read well Deutsch (Griechenland) - [de-GR] weird isn'it?). Some others like ja-JP-JP-#u-ca-japanese or th_TH_TH_#u-nu-thai, also introduced with this commit were already present with at least Java 7. Not sure why we have de_GR here also http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/sun/util/LocaleDataMetaInfo.java

I checked you have ja-JP-JP-#u-ca-japanese but not de_GR when you get to https://localhost:8443/catalog/control/ListLocales running with Java 7

Don't ask how I went there: serendipity in it's higher form :D https://twitter.com/jeroenfrijters/status/464753273275428865 but hè: https://bugs.openjdk.java.net/browse/JDK-8065555


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1712091 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 17:18:27 +00:00
Jacques Le Roux 063c1201cf Fixes a typo I introduced, thanks to Nicolas at r1711918
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1711941 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 12:11:11 +00:00
Jacques Le Roux a73de1850c No functional change, removes an useless warning
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1711914 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 09:07:00 +00:00
Jacques Le Roux 109be3c183 Fixes a bug introduced with r1710513 for OFBIZ-6422 and OFBIZ-6423, true can(must) now be used here if performFindList is used
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1711903 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 08:17:26 +00:00
Jacques Le Roux e9705da1ff Fixes a French label
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1711513 13f79535-47bb-0310-9956-ffa450edef68
2015-10-30 17:20:18 +00:00
Jacques Le Roux ffa71d74ae 3 patches from Christian Carlow for "FOP rendered list form widgets do not work for fields with postition > 0" https://issues.apache.org/jira/browse/OFBIZ-6354
It doesn't work because of the way the renderFormatHeaderRowOpen is called causes the FOP renderer to create more than one <fo:table-header>.

The 1st patch adds renderFormatHeaderOpen and renderFormatHeaderClose to separately generate <fo:table-header> for FOP and <thead> for html.
The 2nd patch adds the new list form widget header methods to the deprecated HtmlFormRenderer needed by EmailServices.java to handle OFBIZ-6360 until replaced with MacroFormRender.
The 3rd patch handles the other FormRenderers FOP, Text, Xml. This issue is still a work in process.

jleroux: there is this  "FIXME: this is an hack to avoid FOP rendering errors for empty lists (fo:table-body cannot be null)" in code



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1710727 13f79535-47bb-0310-9956-ffa450edef68
2015-10-27 07:18:01 +00:00
Jacques Le Roux a1a4374359 Reverts r1710527 and r1710528 (was for OFBIZ-6354), thanks to Deepak for warning on dev ML (BuildBot still down but infra is working on it)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1710675 13f79535-47bb-0310-9956-ffa450edef68
2015-10-26 18:53:33 +00:00
Deepak Dixit 3d5b387f13 (OFBIZ-6699) Removed invalid field condition from StatusValidChange data.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1710566 13f79535-47bb-0310-9956-ffa450edef68
2015-10-26 11:09:54 +00:00
Jacques Le Roux 4536b7e1a3 A patch from Christian Carlow for "FOP rendered list form widgets do not work for fields with postition > 0" https://issues.apache.org/jira/browse/OFBIZ-6354
This patch adds the new list form widget header methods to the deprecated HtmlFormRenderer needed by EmailServices.java to handle OFBIZ-6360 until replaced with MacroFormRender.

jleroux: completes r1710527  


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1710528 13f79535-47bb-0310-9956-ffa450edef68
2015-10-26 08:18:34 +00:00
Jacques Le Roux 9efb447a80 A patch from Christian Carlow for "FOP rendered list form widgets do not work for fields with postition > 0" https://issues.apache.org/jira/browse/OFBIZ-6354
It doesn't work because of the way the renderFormatHeaderRowOpen is called causes the FOP renderer to create more than one <fo:table-header>.

This patch adds renderFormatHeaderOpen and renderFormatHeaderClose to separately generate <fo:table-header> for FOP and <thead> for html.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1710527 13f79535-47bb-0310-9956-ffa450edef68
2015-10-26 08:15:45 +00:00
Wei Zhang b675211e74 The <description> tag was not be closed in last commit
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1710507 13f79535-47bb-0310-9956-ffa450edef68
2015-10-26 04:12:58 +00:00
Jacques Le Roux 069c5d51bb Completes schema documentation for override-list-size in case of performFindList use - OFBIZ-6422
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1710424 13f79535-47bb-0310-9956-ffa450edef68
2015-10-25 11:13:24 +00:00
Jacques Le Roux 027f037200 A patch from Christian Carlow for "Paginator.getListLimits listSize gets set to viewSize for FindServices.performFindList" https://issues.apache.org/jira/browse/OFBIZ-6422
This patch adds code to Paginator to account for the entryList being instanceOf List and extracts from the context.results object the original listSize.

jleroux, important note from OFBIZ-6423 which depends on OFBIZ-6422: it is necessary to assign a value (true makes sense) to override-list-size attribute so that FormRenderer.renderItemRows sets the lowIndex correctly, because once the results of performFindList are displayed, otherwise pages > 0 are rendered as empty.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1710413 13f79535-47bb-0310-9956-ffa450edef68
2015-10-25 05:39:07 +00:00
Jacques Le Roux 0b432b6be9 A patch from Christian Carlow for "FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0" https://issues.apache.org/jira/browse/OFBIZ-6425
I was testing at catalog/control/FindProduct. I just changed ProductForms.xml#ListProducts service-name from performFind to performFindList. Then upon initially visiting the page the error is displayed.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1710348 13f79535-47bb-0310-9956-ffa450edef68
2015-10-24 14:57:13 +00:00
Jacques Le Roux 37dbfcceb0 A patch from Christian Carlow for "Form widget <auto-fields-entity default-field-type="find"/> does not render range find fields for fixed-point" https://issues.apache.org/jira/browse/OFBIZ-6443
A form widget with auto-entity-fields for OrderItem will render the quantity fields as text find fields but the prices as range find fields. The quantity find field should match the price range find capability.

This patch adds "fixed-point" to the condition that renders RangeFindField for induceFieldInfoFromEntityField, with support RangeFindField rendering for currency-precise fields also.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1710177 13f79535-47bb-0310-9956-ffa450edef68
2015-10-23 11:35:29 +00:00
Taher A. Alkhateeb e48fe0b23a another round of javolution removal in achieving OFBIZ-5169
Remove javolution reference from multiple java source files and a few
BIRT reports. I had to replace the FastList with a LinkedList in 
SolrProductSearch.getSideDeepCategories(..) because it uses the 
implementation methods getLast() and removeFirst()

REF https://issues.apache.org/jira/browse/OFBIZ-5169


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1710122 13f79535-47bb-0310-9956-ffa450edef68
2015-10-23 05:52:25 +00:00
Jacques Le Roux 901b1a4a06 Removes tooltip="${uiLabelMap.CommonRequired}" from fields, https://issues.apache.org/jira/browse/OFBIZ-6691
Instead of a quiet S/R action, this was an unexpected pain in the ass. A considerable number of forms:
    EmployeeForms.xml
    EmploymentForms.xml
    EmplPositionForms.xml
    GlobalHRSettingForms.xml
    RecruitmentForms.xml
    QuoteForms.xml
    PartyForms.xml
    StoreForms.xml
    ContactForms.xml
    FixedAssetForms.xml
    TaskForms.xml
    scrumForms.xml
    TaskForms.xml
contained a large number of fields with 
  tooltip="${uiLabelMap.CommonRequired}"
but no 
  required-field="true"


Of course display and display-entity should not be concerned, I spotted a number of them in the lot.

I also removed a bunch of harcoded * at end of labels (those followed by required-field="true"* and spotted a number of others }*"  who still need to be carefully reviewed to see if required=true is not missing there :/

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1709882 13f79535-47bb-0310-9956-ffa450edef68
2015-10-21 16:57:25 +00:00
Jacques Le Roux 7dc24b6902 A slightly modified patch from Taher Alkhateeb for <<replace widget-style="required" with required-field="true">> https://issues.apache.org/jira/browse/OFBIZ-6690
jleroux: after a cursory review, I simply did the chunk related to exampleName by hand, it needed more work. I also removed some trailing blanks.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1709872 13f79535-47bb-0310-9956-ffa450edef68
2015-10-21 16:00:02 +00:00
Jacques Le Roux 2d47601831 An improved patch from Pierre Gaudin for "JGrowl to display alerts " https://issues.apache.org/jira/browse/OFBIZ-6023
I've been working on Jgrowl integration for a project. (https://github.com/stanlemon/jGrowl)
This allowS to display system's messages in a popup at the top of the windows even if you scroll. This is also useful for ajax call because there is no need to scroll to the top of the screen to view message.
Message can stick to the screen until it is intentionally closed by the user or not.

jleroux? as already explained in the Jira: to have it working in trunk HEAD I had to make some changes

    I put the jgrowl loading in GlobalActions rather than GlobalDecorator
    in showjGrowl() js function
        I Added a test for if (contentMessages.length) because of an error in lookups
        I did some formatting in function showjGrowl()
        I used jQuery instead of $ (same for expandAllP() and expandAll() functions)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1709679 13f79535-47bb-0310-9956-ffa450edef68
2015-10-20 20:46:42 +00:00
Hans Bakker 582f8e6eb0 Selenium web driver integration using XML files: https://issues.apache.org/jira/browse/OFBIZ-6618
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1709516 13f79535-47bb-0310-9956-ffa450edef68
2015-10-20 06:34:32 +00:00
Adrian Crum d2e8ad8eea Updated documentation, no functional change.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1709339 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 00:14:48 +00:00