Commit Graph
10472 Commits
Author SHA1 Message Date
Jacques Le Roux f9928cbc55 Since
r1727987: Removes the forceManualJsessionid feature - OFBIZ-6867 
and
r1728121: Gets rid of the session-cookie-accepted feature - OFBIZ-6871
are done we can remove the now useless cookies variables, this does it


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728660 13f79535-47bb-0310-9956-ffa450edef68
2016-02-05 13:18:44 +00:00
Hans Bakker 9d39583bcf be able to set accounting company in the header, so other companent can change it too. https://issues.apache.org/jira/browse/OFBIZ-6802
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728584 13f79535-47bb-0310-9956-ffa450edef68
2016-02-05 01:45:50 +00:00
Nicolas Malin 179106169f correct typo, no functional change
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728560 13f79535-47bb-0310-9956-ffa450edef68
2016-02-04 22:07:55 +00:00
Julien Nicolas 324bc0af74 Add new theme rainbowstone JIRA6843
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728388 13f79535-47bb-0310-9956-ffa450edef68
2016-02-03 22:51:33 +00:00
Jacques Le Roux 82cecfdfcc Removes forceHttpSession feature - https://issues.apache.org/jira/browse/OFBIZ-6879
We should always use HTTPS as explained at OFBIZ-6849

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728381 13f79535-47bb-0310-9956-ffa450edef68
2016-02-03 22:07:10 +00:00
Jacques Le Roux fffc684891 Removes all sessionsIds put in URLs - https://issues.apache.org/jira/browse/OFBIZ-6872
We should always use sessionIds in cookies and newer have sessionsIds in URLs. So I will remove all sessionsIds in URLs. There are 2 cases:

* the part related to spiders in RequestHandler
* HtmlFormRenderer.appendExternalLoginKey() (there is also an appendExternalLoginKey method in MacroFormRenderer class but it's not used OOTB)

I also removed some old commented out code in RequestHandler class

There are also many cases where we show the sessionId in logs (using UtilHttp.getSessionId()) I wonder if we should not keep those commented out or change the debug info level. Also HttpSessionEvent.getSession().getId() is directly used in some places for the same purpose (log)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728375 13f79535-47bb-0310-9956-ffa450edef68
2016-02-03 21:09:28 +00:00
Gil Portenseigne 63e01c97f7 OFBIZ-6869 : Add properties in widget.properties, for easy customization of JGrowl alert. Thanks Jacques for the idea
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728351 13f79535-47bb-0310-9956-ffa450edef68
2016-02-03 19:18:35 +00:00
Jacques Le Roux e4a0586ff2 Gets rid of the session-cookie-accepted feature - https://issues.apache.org/jira/browse/OFBIZ-6871
Since OFBIZ-6867 is now done, it will no longer be used OOTB and anyway should not be needed because we should preferably always use sessionIds in cookies and newer have sessionsIds in URLs.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728121 13f79535-47bb-0310-9956-ffa450edef68
2016-02-02 14:10:08 +00:00
Gil Portenseigne f3dd6cbadc OFBIZ-6869 : Jgrowl enhancement for internationalization, center and speed up display, with some format/typo fixes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728029 13f79535-47bb-0310-9956-ffa450edef68
2016-02-02 00:38:51 +00:00
Nicolas Malin 40d44a3513 Add new template location : VT_LOGIN_TMPLT_LOC for the login
VT_CHPWD_TMPLT_LOC for the changePassword
VT_FGPWD_TMPLT_LOC for the forgetPassword
VT_GSQUE_TMPLT_LOC for the getSecurityQuestion
Related issue OFBIZ-6868. The origin requirement came from issue OFBIZ-6843 with proposition to adding new theme with dedicate template for these previous element

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728026 13f79535-47bb-0310-9956-ffa450edef68
2016-02-02 00:08:55 +00:00
Jacques Le Roux 0e7c4d0a5c Removes the forceManualJsessionid feature - https://issues.apache.org/jira/browse/OFBIZ-6867
This follows Scott's comment at https://issues.apache.org/jira/browse/OFBIZ-6111?focusedCommentId=15076677

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1727987 13f79535-47bb-0310-9956-ffa450edef68
2016-02-01 18:30:43 +00:00
Nicolas Malin 0c5de17f41 Add the possibility to set a blackout period for job manager service. During this time all async and scheduled service are put on hold.
This improvement add a entity JobManagerLock, a new screen to add/edit job manager lock and an information for end user on FindJob and ScheduleJob screen.
See more information on issue OFBIZ-6790. Thanks to Jacques for sharing on this improvement.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1727570 13f79535-47bb-0310-9956-ffa450edef68
2016-01-29 12:52:34 +00:00
Nicolas Malin 3a07efc5df correct locale (en to fr) associate to french translation
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1726486 13f79535-47bb-0310-9956-ffa450edef68
2016-01-24 12:50:01 +00:00
Nicolas Malin c4c57626d8 * add missing french translation
* correct typo error on label WebtoolsEntityCretePermissionError -> WebtoolsEntityCreatePermissionError
* correct typo error on labels WebtoolsErrror* -> WebtoolsError*

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1726485 13f79535-47bb-0310-9956-ffa450edef68
2016-01-24 12:41:38 +00:00
Nicolas Malin fbae10008c add french label missing for EntityImport* and PageTitle*
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1726457 13f79535-47bb-0310-9956-ffa450edef68
2016-01-24 00:06:17 +00:00
Jacques Le Roux 9bbd16e9fa Temporary fix for "UtilXml.LocalResolver.resolveEntity] could not find LOCAL DTD/Schema with publicId [null] and the file/resource is [web-app_3_0.xsd]" - https://issues.apache.org/jira/browse/OFBIZ-6807
As suggested by Deepak keeps only <<web-app version="3.0">> in web.xml files instead of whole xmlns and schemaLocation. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1726388 13f79535-47bb-0310-9956-ffa450edef68
2016-01-23 11:52:08 +00:00
Jacques Le Roux 340c2b6745 A slightly formatted patch from Gareth Carter for "Add getFieldList method to EntityQuery" https://issues.apache.org/jira/browse/OFBIZ-6848
Improves EntityQuery by adding method getFieldList so we don't have to chain to EntityUtils.getFieldListFromEntityList or getFieldListFromEntityListIterator

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1726184 13f79535-47bb-0310-9956-ffa450edef68
2016-01-22 11:50:49 +00:00
Ashish Vijaywargiya 6caa828896 Applied patch from jira issue - OFBIZ-6735. Tooltip Calendar field (date or date-time) should not stop when using tab key. Thanks Jacques for creating the issue and thanks Jagpreet for the patch contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1724975 13f79535-47bb-0310-9956-ffa450edef68
2016-01-16 13:47:30 +00:00
Deepak Dixit 05f52504b5 (OFBIZ-6400) Applied slightly modified patch from jira issue OFBIZ-6400
============================================================
Fix permissions at specialpurpose/myportal/widget/PortalAdmScreens.xml
============================================================

Also added some missing permission to SUPER user group.
Thanks Christian Carlow for reporting the issue and Aditi or providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1724946 13f79535-47bb-0310-9956-ffa450edef68
2016-01-16 10:03:25 +00:00
Deepak Dixit c9cf2336ae (OFBIZ-6789) Applied patch from jira issue OFBIZ-6789
============================================================
image management cannot share images
============================================================

Thanks Wai for reporting the issue and Vaibhav for the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1724943 13f79535-47bb-0310-9956-ffa450edef68
2016-01-16 09:50:02 +00:00
Nicolas Malin 6fd3a96ed6 Correct on layered-modal link :
* the uuid string to set as unique layered-modal call method name, error introduce with issue OFBIZ-6707 and raise on the issue OFBIZ-6786 by Wai.
* parameters missing when you call the link from a form because their passed in the url and not with the jquery data set, related to OFBIZ-6803

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1724796 13f79535-47bb-0310-9956-ffa450edef68
2016-01-15 13:17:39 +00:00
Nicolas Malin ee44b0f8db add french label for CommonCost
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1724701 13f79535-47bb-0310-9956-ffa450edef68
2016-01-14 21:56:49 +00:00
Nicolas Malin 916823d5a4 When ofbiz reload crashed jobs when it start, replay only one time the crashed jobs. Remove all temporal information to ensure that the new job don't create any reccurent schedule that duplicate the origin job's configuration, See OFBIZ-6784, thanks Scott to spot the good correction
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1722816 13f79535-47bb-0310-9956-ffa450edef68
2016-01-04 09:46:42 +00:00
Deepak Dixit f037b221f9 (OFBIZ-6655) Reverted r1719762, as system fails to find the session cookie for ecommerce, will debug it in more detail but for now to fix this issue reverting r1719762.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1722379 13f79535-47bb-0310-9956-ffa450edef68
2015-12-30 17:00:00 +00:00
Nicolas Malin 23fca59d0c add french translation on WebtoolsConfirmDelete label
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1722071 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 08:07:55 +00:00
Deepak Dixit 76742dc2bc (OFBIZ-2987) Applied slightly modified patch from OFBIZ-2987
============================================================ Html clean up of quick add page.
============================================================ 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1721091 13f79535-47bb-0310-9956-ffa450edef68
2015-12-21 05:16:28 +00:00
Deepak Dixit f7a89e5cdd (OFBIZ-6525) Add confirmation message before deleting entity record from web-tools application.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1721089 13f79535-47bb-0310-9956-ffa450edef68
2015-12-21 05:09:06 +00:00
Julien Nicolas 305dfee0a4 JIRA-6706 - Correct the widget-style of the itemMenu inheritance for the contained hyperlink
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1720891 13f79535-47bb-0310-9956-ffa450edef68
2015-12-19 09:07:28 +00:00
Wei Zhang 3138e599d2 OFBIZ-6775 Duplicated to display jGrowl error message when open a popup dialog
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1720728 13f79535-47bb-0310-9956-ffa450edef68
2015-12-18 08:19:03 +00:00
Jacques Le Roux 7297da68a9 5th step for "Secure HTTP headers" https://issues.apache.org/jira/browse/OFBIZ-6766
X-XSS-Protection

This header enables the Cross-site scripting (XSS) filter built into most recent web browsers.
It's usually enabled by default anyway, so the role of this header is to re-enable the filter for this particular website if it was disabled by the user.
This header is supported in IE 8+, and in Chrome (not sure which versions). The anti-XSS filter was added in Chrome 4. Its unknown if that version honored this header.
FireFox has still an open bug entry and "offers" only the noscript plugin.
https://wiki.mozilla.org/Security/Features/XSS_Filter
https://bugzilla.mozilla.org/show_bug.cgi?id=528661

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1720213 13f79535-47bb-0310-9956-ffa450edef68
2015-12-15 18:12:05 +00:00
Jacques Le Roux 95702618c5 Reapplies r1719762 because of OFBIZ-6655
This for 3 reasons:

1) Tomcat protects the cookies which it cares about (session and SSO cookies) but not all. Notably the OFBiz specific cookies, like visitorCookie. I guess also trackableCookie, billableCookie, siteIdCookie, updatedTimeStampCookie, guestShoppingListCookie, usernameCookieName and autoLoginCookie are not secured with The data in those cookies are less sensible than jsessionId but anyway it's safer to have them all secured.
2) I don't want to debug the ecommerce issue I reported in OFBIZ-6655. And if I don't use the sessionConifg_ecommerce.patch but rather reapply r1719762 then it's OK (if I also locally revert r1686574 done for OFBIz-6111, still waiting on this one...)
3) I see no reasons why someone would not want her cookies secured, as recommended by OWASP and others


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1719939 13f79535-47bb-0310-9956-ffa450edef68
2015-12-14 15:28:54 +00:00
Jacques Le Roux c06e6f7f62 2 modified patches from Rahul Bhammarker for "Add session tracking mode and make cookie secure" https://issues.apache.org/jira/browse/OFBIZ-6655
Need to enhance security at web-app level. 
As per current implementation:
- The cookie containing the session identifier is not secure
- The session identifier is transmitted in the query string of the URL

To fix these issue we have to add following session config otpions in web.xml
{code}
<session-config>
	<cookie-config>
	    <http-only>true</http-only>
	    <secure>true</secure>
	</cookie-config>
	<tracking-mode>COOKIE</tracking-mode>
</session-config>
{code}

Also we need to update the web-app servlet specification from 2.3 to 3.0
{code}
<web-app version="3.0"
        xmlns="http://java.sun.com/xml/ns/javaee"
        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
                            http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd">
{code}
https://tomcat.apache.org/whichversion.html

jleroux: these are only the framework+themes+applications patches, with 3 entries not applied


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1719872 13f79535-47bb-0310-9956-ffa450edef68
2015-12-14 10:02:24 +00:00
Nicolas Malin fdb9235b5e Remove an over charge on js function getRequestData() use by layered-modal link call when two links are present on the same page. Related to OFBIZ-6768
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1719868 13f79535-47bb-0310-9956-ffa450edef68
2015-12-14 09:19:37 +00:00
Jacques Le Roux 4885f653af Reverts r1719762 because of OFBIZ-6655
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1719764 13f79535-47bb-0310-9956-ffa450edef68
2015-12-13 05:47:33 +00:00
Jacques Le Roux 677b49015e 4th step for "Secure HTTP headers" https://issues.apache.org/jira/browse/OFBIZ-6766
The secure flag on cookies instructs the browser to only submit the cookie as part of requests over secure (HTTPS) connections. This prevents the cookie from being observed as plain text in transit over the network.
The HttpOnly flag instructs the browser that this cookie can only be accessed when sending an HTTP request. This prevents scripts running as part of a page from retrieving the value and is a defense against XSS attacks.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1719762 13f79535-47bb-0310-9956-ffa450edef68
2015-12-13 05:07:47 +00:00
Jacques Le Roux 435f07e53e 3rd step for "Secure HTTP headers" https://issues.apache.org/jira/browse/OFBIZ-6766
It's recommended to not use the X-Powered-By header. 
Tomcat doc: The xpoweredBy attribute controls whether or not the X-Powered-By HTTP header is sent with each request. If sent, the value of the header contains the Servlet and JSP specification versions, the full Tomcat version (e.g. Apache Tomcat/7.0.0), the name of the JVM vendor and the version of the JVM. This header is disabled by default. This header can provide useful information to both legitimate clients and attackers. 

OFBiz users can decide to change this parameter if they want

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1719684 13f79535-47bb-0310-9956-ffa450edef68
2015-12-12 13:21:16 +00:00
Jacques Le Roux 64da8f75f8 Of course one more time I forgot to save after fixing a typo :/
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1719683 13f79535-47bb-0310-9956-ffa450edef68
2015-12-12 13:01:55 +00:00
Jacques Le Roux fde61d402a 2nd step for "Secure HTTP headers" https://issues.apache.org/jira/browse/OFBIZ-6766
Adds X-Content-Type-Options. According to Wikipedia and Owasp, the only defined value, "nosniff", prevents Internet Explorer from MIME-sniffing a response away from the declared content-type. This also applies to Google Chrome, when downloading extensions.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1719682 13f79535-47bb-0310-9956-ffa450edef68
2015-12-12 12:58:18 +00:00
Jacques Le Roux 4c593a6d33 1st step for "Secure HTTP headers" https://issues.apache.org/jira/browse/OFBIZ-6766
Here are X-Frame-Options and Strict-Transport-Security, just a start...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1719660 13f79535-47bb-0310-9956-ffa450edef68
2015-12-12 11:37:56 +00:00
Wei Zhang ef072df4e8 OFBIZ-6762 Show JGrowl alert when using ajax submit form
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1719250 13f79535-47bb-0310-9956-ffa450edef68
2015-12-11 04:06:43 +00:00
Nicolas Malin ce97afbf6b patch from Pierre Smits : Remove tooltip CommonNotModifRecreat from display fields (OFBIZ-6696), thanks for the screen clean Pierre
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1718970 13f79535-47bb-0310-9956-ffa450edef68
2015-12-09 21:24:44 +00:00
Jacques Le Roux b3f2a59616 No functional changes: arranges imports
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1718153 13f79535-47bb-0310-9956-ffa450edef68
2015-12-06 09:06:48 +00:00
Jacques Le Roux 58cbed1366 Updates Spring Framework to 4.2.3, rename org.springframework.*-3.1.0.M2.jar to spring-*-4.2.3.jar as it's the name used by Spring. OFBIZ-6754
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1718109 13f79535-47bb-0310-9956-ffa450edef68
2015-12-05 17:39:44 +00:00
Jacques Le Roux bcf00752dd Upgrades Axis2 to 1.6.3, with its dependencies on Axiom 1.2.9 and Neethi 3.0.2 - OFBIZ-5801
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1718023 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 20:30:39 +00:00
Jacques Le Roux 13c114cee7 Updates Tomcat to 7.0.65 - OFBIZ-6752
Though disputed CVE-2013-2185 indicates a possible vulnerability with jasper.jar. Better safe than sorry: I will backport to all concerned branches (R14 and R13)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1717760 13f79535-47bb-0310-9956-ffa450edef68
2015-12-03 13:26:23 +00:00
Wei Zhang 60b776e46b OFBIZ-6736 The attribute paginate-style of form widget dose not work
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1717710 13f79535-47bb-0310-9956-ffa450edef68
2015-12-03 04:46:57 +00:00
Gil Portenseigne 9a26099c85 Fix compilation error since OFBIZ-6748 improvements in TransactionUtil.java,
Testsuite entity-test successfull

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1717333 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 21:36:30 +00:00
Jacques Le Roux 3b84a03fab Updates commons collections from 3.2.2 to 4.1 - OFBIZ-6748
Even if we are covered from the Java Object possible deserialisation exploit by the 3.2.2 version, since it's easy to update, this issue to update the trunk to the last available release.

I updated the .classpath file by hand, but kept the tabs in it, so I could move misplaced entries to their right alphabetical places.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1717247 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 13:01:47 +00:00
Jacques Le Roux 0dd553ec96 A modified patch from Harsha Chadhar for "New feature to reclaim a user account - Using Security Questions" https://issues.apache.org/jira/browse/OFBIZ-4983
jleroux: the issue description is quite lengthy so I will summarise it here, please refer to the Jira issue for details.
"When a customer creates an account on eCommerce site, s/he will also need to answer a security question. This security question then can be used by the user to reclaim her/his account in case s/he forgets her/his password. If the user correctly answers the required security question while reclaiming her/his account, her/his password will be sent through email notification. This part would work in the same way as the existing functionality of email password (forget password)."

The description was actually more ambitious (several questions, possibility for users to create own questions) but AFAIK these parts have not been implemented.

Apart updating the patch which did not merge, I got 2 majors issues (and few others I will not report here) I bypassed with workarounds.

Unlike Harsha, and as I reported earlier in the issue, I never got the username (userLoginId) back when using hidden parameters in the request body (not in requestParameters, ie UtilHttp.getParameterMap(request)), nor actually any parameters. This is maybe due to my OS (Windows7 was XP before) or my email client (Outlook Express then, now Thunderbird) or even my SMTP configuration (I used my ISP SMTP server) but most probably because I did it all on my sole machine (localhost). I tried to understand what was happening to request body parameters with http://www.telerik.com/fiddler, but finally gave up because it's even more complicated when https is in the picture. So I decided to rather use parameters in the URL (Query string). It's a bit less safe, though the password is OFBiz encrypted, and should be replaced. But it's safe enough because only the user should receive this message and even if the message is sniffed during its journey it should be hard to decrypt the password!

Harsha used the SecurityExtUiLabels.xml (created by ashish at r1618415) in securityext component but there is already a SecurityextUiLabels.xml in common component. Since I use Windows OFBiz was unable to retrieve the labels from SecurityExtUiLabels.xml since I guess it looked into a SecurityextUiLabels.xml. So I renamed a SecurityExtUiLabels.xml to EmailPassword.xml.










git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1716915 13f79535-47bb-0310-9956-ffa450edef68
2015-11-27 20:37:15 +00:00
Jacques Le Roux 0dd95cedbf A patch from Anne Jessel for "Entity ECAs not triggered correctly when using Delegator.storeAll() method" https://issues.apache.org/jira/browse/OFBIZ-3847
As reported by  Martin Kreidenweis 
The conditions don't work when updating (not creating) entities using the Delegator.storeAll() method. E.g. the following condition does not work:
<eca entity="Product" operation="create-store" event="return">
        <condition field-name="autoCreateKeywords" operator="not-equals" value="N"/>
        <action service="indexProductKeywords" mode="sync" value-attr="productInstance"/>
</eca>
The indexProductKeywords service is called anyway when the product is updated and the autoCreateKeywords was "N" and stays "N". It works correctly for newly created products. 
The problem is in the method GenericDelegator.storeAll(), where unchanged field values are not passed down to the store() method. The store method calls the ECA engine, which does not receive the unchanged values at all and thus cannot evaluate the EECA conditions correctly. 

Scott's comment:We could consider having EntityEcaCondition.eval() perform a db lookup if any of the fields it needs to evaluate are missing. If they are missing it could fully populate the entity with the missing fields so that a lookup is only required at most once per delegator operation. If no ECA conditions require any missing fields then the lookup wouldn't be performed, so the performance penalty would only be incurred when necessary.


Anne: I've created a patch modeled after Scott's suggestion. I'd appreciate someone reviewing it. It does work for me, however I am concerned that it might fail when the value of a field that is part of the EECA condition is being changed from non-null to null using GenericDelegator.storeAll, because of the way storeAll works. There may be a simple solution I've missed.

jleroux: After reviewing  and waiting for Anne's feedback, I commit because even if in some cases it would not work it's at least better than current situation

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1716319 13f79535-47bb-0310-9956-ffa450edef68
2015-11-25 08:15:42 +00:00