Commit Graph
4365 Commits
Author SHA1 Message Date
Jacques Le Roux 1f0cca7fa4 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
Renames BirtEngineServlet class to OfbizBirtEngineServlet, because it shadowed
the simple name of it superclass.
It can be exceptionally confusing, create lots of situations in which you have
to look at import statements to resolve references and creates many
opportunities to accidentally define methods that do not override methods
in their superclasses.

Also remove trailing spaces in OpenApiUtil class
2021-12-05 12:59:59 +01:00
Jacques Le Roux cf086a2b47 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
In GitHubEvents::gitHubRedirect, random object created and used only once.

This code creates a java.util.Random object, uses it to generate one random
number, and then discards the Random object. This produces mediocre quality
random numbers and is inefficient. If possible, rewrite the code so that the
Random object is created once and saved, and each time a new random number is
required invoke a method on the existing Random object to obtain it.
Also fixes 2 Javadoc errors

In SampleHtmlThread, uses SecureRandom rather than Random class

In LinkedInEvents::linkedInRedirect, uses SecureRandom rather than Random class
Also fixes 2 Javadoc errors
2021-12-05 09:55:08 +01:00
Jacques Le Roux 923b42c2da Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
Fixes possible null dereferencings in
EbayHelper::createPayment,
AbstractPricatParser::writeCommentsToFile
SolrProductSearch::getSideDeepCategories
WebPosEvents::getProductType
2021-12-05 09:55:08 +01:00
Michael Brohl 421e0e7994 Fixed: REST-API Plugin: Remove errors and warnings in generated openapi
documentation (OFBIZ-12426)

This fixes the following errors and warnings which are displayed by the
Swagger Editor (editor.swagger.io) when reading the generated openapi
documentation:

Errors fixed
* "Header parameters named "Authorization" are ignored. Use the
`securitySchemes` and `security` sections instead to define
authorization."
* "Structural error at paths./....parameters.0 should have either a
`schema` or `content` property"
the generated parameters from the service definition now have schema
entries generated
* the same applies to the WWW-Authenticate header in the responses

Warnings fixed

* "Header parameters named "Accept" are ignored. The values for the
"Accept" header are defined by `responses.<code>.content.<media-type>`."
2021-12-01 17:58:20 +01:00
Jacques Le Roux 51501fe7e3 Improved: Upgrade Solr and Lucene to 8.11 (OFBIZ-12388)
https://solr.apache.org/docs/8_11_0/changes/Changes.html
2021-11-17 19:08:18 +01:00
Jacques Le Roux 002bb61b6e Fixed: Fix some bugs Spotbugs reports (OFBIZ-12386)
Return with post increment does not work, pre increment does

Thanks: Spotbugs
2021-11-17 08:16:14 +01:00
Pierre Smits f91339b576 Improved: Dutch labels for Ecommerce UI (OFBIZ-12378) (#69)
added:
Dutch tranlations for various labels in EcommerceUiLabels.xml
2021-11-12 12:52:12 +01:00
Jacques Le Roux 97fe0058a8 Fixed: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
additional-methods.min.js was missing, forgot previously

Unrelated to plugins, but I also tried to use jquery-ui-dist from node
https://www.npmjs.com/package/jquery-ui-dist despite I knew it was less secure
https://www.cvedetails.com/vulnerability-list/vendor_id-6538/product_id-31126/Jquery-Jquery-Ui.html
But it missed at least the lookup icon in Helveticus.

I'll check later when https://www.npmjs.com/package/jquery-ui-dist will provide
a more secure version.

Also in ecommerceI found this error in js console: : "$.timepicker is undefined"
I did not find the reason. Anyway it seems not used in ecommerce.
2021-11-11 11:26:02 +01:00
Jacques Le Roux b542a38b18 Reverted: work related to PartyRole handling initiated with (OFBIZ-5980)
Currently OFBiz is broken and hard to fix. You can't even create an order !

Revert "Improved: visibility of expire button (OFBIZ-12362) (#331)"
This reverts commit e3b125ef4cb4247233097f3e00f28b10773d708c.

Revert "(OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation (#330)"
This reverts commit a8ab2be55a96a1aeccc4c07887ebbb4d25b2cc28.

Revert "Improved: seed data (OFBIZ-12355) (#328)"
This reverts commit b204b867b40787dbcc5a17a30c1d22ade1a422cc.

Revert "Reverted: Have the ability to revoke (expire) roles of a party (OFBIZ-5980)"
This reverts commit 85e066deb358404b4681c148ba0d296e481bf666.

Revert "Reverted: damn I did not revert the right push :/"
This reverts commit b867b2a89fe36bb7e02b24814b2fb2fc2683f1c4.

Revert "(OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation (#325)"
This reverts commit 8ed2252df82be226d99d97250c659a1f8e3211fe.

Revert "Reverted: Have the ability to revoke (expire) roles of a party (OFBIZ-5980)"
This reverts commit 5b5e03f71b6f94ca3c4a1a1526681634835527a5.

Revert "Improved: Have the ability to revoke (expire) roles of a party (OFBIZ-5980)"
This reverts commit 46f7ee91d3355b3e10a5b2732797591c748a27dd.

Revert "Improved: seed data (OFBIZ-12353) (#324)"
This reverts commit fade92bb57d23333dd648bbab456c23cdb517787.
2021-11-08 20:42:03 +01:00
Pierre Smits a03567363b Improved: party roles (OFBIZ-5980) (#68)
updated data set regarding party roles
2021-10-30 16:39:45 +02:00
Jacques Le Roux 7ab9d05412 Improved: Handle remaining checkstyle errors (OFBIZ-12169)
Fixes wrong methods names in EntityFunction class
Forgot the plugins while working on smthg else :/
2021-10-17 11:42:38 +02:00
Nicolas Malin 553472c052 Fixed: Replace hardcoded label 'Popular categories' (OFBIZ-12323)
Labellise the 'Popular categories' title by adding an EcommerceBestSelling label and replace traduction by 'Best Selling' to avoid confusion with catalog category type 'Most Popular (one)'.

Thanks: Charles STELTZLEN
2021-09-28 16:51:00 +02:00
Nicolas Malin 7b37304043 Fixed: ecommerce head title, no ':' if no title or titleProperty (OFBIZ-12326)
When the page title is empty, avoid the ':' in the navigator tabs title for Ecommerce

Thanks: Charles STELTZLEN
2021-09-28 16:35:14 +02:00
Nicolas Malin 20e00c82a3 Fixed: Add to cart is not working for products with selectable features (OFBIZ-11970)
Two issues were present, first was due to incorrect markup and the second was due to ajax request and response view of the additem request.
In additem request last saved view or the view of the last request is rendered on successful operation and in this case the last request/view is the one which is used to render UOM dropdown.

Thanks: Akash Jain and Ravi Lodhi
2021-09-28 14:11:52 +02:00
Nicolas Malin 209f15f2b6 Fixed: Incorrect price for selected variant shown (OFBIZ-12236)
When the webshop (ecommerce component) has been set up for retail (B2C), with the tax setting 'Show prices with VAT tax included' set to 'Y' in store 9000 the appropriat Tax Auth Geo and Tax Auth set in store 9000 the flag 'Include Tax In Price' set to 'Y' for the Tax Auth the price for a virtual product is shown including VAT.

However, for a selected variant the price shown is without VAT

Thanks: Pierre Smits to raise this issue and Priya Sharma for solved it
2021-09-27 16:28:19 +02:00
Jacques Le Roux a6364a8afa Improved: Remove Docbook parts now useless since Ascidoc is used for online help (OFBIZ-12327)
At https://markmail.org/message/inoihmcon37wq5zz I suggested:

If I'm not wrong, we no longer use Docbook anywhere. So I suggest to remove it
from:

1. cmssite component, where it was used by the online help, now assured by
    Asciidoc. BTW, for whom it could concern, I noticed that anchors jumping
    in adoc files does not work in online help
2. docbook.dtd in content component only used by the cmssite component
3. docbook.css in themes, I'm not sure that still useful there
2021-09-25 10:32:53 +02:00
Jacques Le Roux 48156518c9 Improved: Adds the HTML <input> accept Attribute in form widgets and Freemaker templates (OFBIZ-12049)
Removes unused OOTB TextImage.ftl
Explain the script in ViewProfile.ftl
"Accepts" CSV files in SamplePricat.ftl
2021-09-21 17:47:20 +02:00
Jacques Le Roux ff03ec248a Fixed: The Solr version included in OFBiz has an SSRF vulnerability (CVE-2021-27905) (OFBIZ-12316)
This post-auth security issue was reported to the security team by weinull orz
<weinull@outlook.com> As he suggested the solution is to update Solr to its last
version (8.9.0)

This solution contains a (justified) rant!

Thanks: weinull orz
2021-09-15 10:20:45 +02:00
Charles 2218d9f9a1 Replace summary label by common one 2021-09-08 09:53:10 +02:00
Jacques Le Roux 9d4c9fcaff Improved: Update build.gradle to the latest dependencies (OFBIZ-12311)
The tests fails locally but it makes no sense, trying w/ BUilbot...
2021-09-06 10:05:40 +02:00
Jacques Le Roux 30ec649c57 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Fixes last bugs
2021-08-06 18:29:43 +02:00
Jacques Le Roux 229b9b9ca1 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Another fake change in .sonarcloud.properties to test setting changes in
GitHub sonarQBE UI
2021-08-06 18:22:16 +02:00
Jacques Le Roux 874c830fbb Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Fixes few bugs
2021-08-06 18:16:41 +02:00
Jacques Le Roux eee69f91c5 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Fixes a possible http issue (not a big deal)
2021-08-06 17:47:21 +02:00
Jacques Le Roux 4f4328bf61 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Another fake change in .sonarcloud.properties to test setting changes in
GitHub sonarQBE UI
2021-08-06 17:16:45 +02:00
Jacques Le Roux 0606714363 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Another fake change in .sonarcloud.properties to test setting changes in
GitHub sonarQBE UI
2021-08-06 17:11:33 +02:00
Jacques Le Roux 69eea73ba2 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Fake change in .sonarcloud.properties to test setting changes in sonarQBE
following
https://sonarcloud.io/documentation/advanced-setup/analysis-scope/
and
https://sonarcloud.io/project/settings?category=exclusions&id=apache_ofbiz-plugins

1st step, maybe others will be needed...
2021-08-06 17:04:14 +02:00
Jacques Le Roux 190e816364 Fixed: Add http to https redirect rule for ofbiz.apache.org (OFBIZ-10590)
This prevented to run the stable demo, hence the next, weirdly the trunk had
not this problem. Anyway better safe than sorry... Maybe related to Gradle
version or rather libs loaded?

The reason why the stable (and old) demos were not running is because the
EntitySaxReaderTests did not pass
2021-07-20 07:47:25 +02:00
Jacques Le Roux 6106277bb4 Improved: Add global web.xml to simplify session timeout configuration (OFBIZ-12255)
Currently, session timeout is configured in apps separately, but session is
shared globally, so the smallest one take effects, and it will not take effect
separately for different apps.

Then it is both inconvenient and confusing to increase session timeout value,
as all values in those files need to be updated.

A global web.xml is needed, to simplify session timeout configuration.

Thanks: Xin Wang
2021-06-22 08:52:44 +02:00
Jacques Le Roux af63249c4e Improved: removes mention of Birt in plugins LICENSE file
We no longer embed files from Birt project. For years now we use Gradle to load
org.eclipse.birt.runtime:viewservlets:4.5.0 that is only "loaded at runtime"
2021-06-17 18:34:26 +02:00
Jacques Le Roux e51dccb9bb Fixed: Empty field is reflecting on Contact list section on Profile Page (OFBIZ-10386)
Steps to generate:

Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile

On the profile page, Go down to Contact list
Empty fields are displaying before Verify Subscription button

Expected: The field should have some specifications to be filled up

Thanks: Archana Asthana for report, Devanshu Vyas for suggestion, Praveen Patil
for patch and Thirumurugan for confirming
2021-05-29 15:47:21 +02:00
Jacques Le Roux 88152045de Improved: Adds swagger-ui in LICENSE file 2021-05-15 23:50:23 +02:00
Jacques Le Roux dbfa4f0ca0 Improved: Handle remaining checkstyle errors (OFBIZ-12169)
This handles the "'(' should be on the previous line?" rule of MethodParamPad

Actually not completely, because there are still some cases that can't be
handled by changing code, notably when a casting is necessary. I believe there
is an error in checkstyle code. I'll discuss that in dev ML before sending
checkstyle team a report.
2021-05-04 10:35:12 +02:00
Girish Vasmatkar 510239a5f2 Improved: Added CORS filter for the rest-api (OFBIZ-12220).
Thanks Alexander Gepting for the contribution.
2021-04-06 11:16:52 +05:30
Girish Vasmatkar 45e246bce0 Improved: Added CORS filter for the rest-api (OFBIZ-12220).
Thanks Alexander Gepting for the contribution.
2021-04-06 10:37:03 +05:30
Jacques Le Roux a3438121d8 Improved: Comment out the SOAP and HTTP engines (OFBIZ-12212)
The SOAP and HTTP engines are open doors to security issues.
At https://markmail.org/message/pgtjyh23bazq4s2w I proposed to comment them out
as we did for RMI in the past.
Of cause it must be clearly documented how to use them if needed.

Here is the email content:

    After the recent fix for the CVE-2021-26295[1] we discussed with the security
    team about the opportunity need to comment out the SOAP and HTTP engines
    like we did in the past for RMI[2], this obviously for security reason.

    [1] OFBIZ-12167 "Adds a blacklist (to be
    renamed soon to denylist) in Java serialisation (CVE-2021-26295)"
    [2] OFBIZ-6942 "Comment out RMI related
    code because of the Java deserialization issue [CVE-2016-2170] "

I just put a small comment in webtools and scrumm controllers, it should be
enough.

The tests pass
2021-03-29 13:29:58 +02:00
Michael Brohl 57d24425df Improved: Updates swagger ui version to 3.45.1, moves and updates README
(OFBIZ-12207)
2021-03-28 23:55:51 +02:00
Michael Brohl 5eb003e1a6 Improved: Updates Redoc version and makes it locally available
(OFBIZ-12207)

The reference was chanegd from cdn-hosted version to a locally saved
version to avoid integrity check mechanism and making it possible to
track the used version in the README.
2021-03-28 23:55:51 +02:00
Michael Brohl 66055a731a Improved: Fixes sonarcloud error by using the resource integrity feature
for embedding external redoc javascript file (OFBIZ-12197)
2021-03-27 10:45:17 +01:00
Michael Brohl 84d705373f Improved: Fixes html bugs spotted by sonarcloud (OFBIZ-12197) 2021-03-27 10:45:17 +01:00
Michael Brohl b5c6a17024 Improved: Corrects asciidoc levels and follows one-sentence-per-line
rule (OFBIZ-12197)
2021-03-27 10:45:17 +01:00
Michael Brohl 1a6e4f8294 Improved: Removes "ofbiz" prefix from files and folders, code cleanup
(OFBIZ-12197)
2021-03-27 10:45:17 +01:00
Michael Brohl 107b26b66c Improved: Remove ofbiz prefix from files and folders (OFBIZ-12197)
Renames ofbiz-rest-impl to rest-api.
2021-03-27 10:45:17 +01:00
Devanshu Vyas c6704e90c3 Fixed: Error message is displayed when user clicks on create link after the user quick chechout and user is not logged in (OFBIZ-12188)
Added missing UtilHttp class import statement
Thanks: Arpit Mor for reporting the issue and Sourabh Punyani for providing the fix.
2021-03-27 14:12:58 +05:30
Girish Vasmatkar c257243fc0 Fixed: Incorrect Display Name for the Swagger component corrected (OFBIZ-12197) 2021-03-17 18:26:48 +05:30
Jacques Le Roux cf1cb40479 Documented: fixes ldap documentation
It was no up to date, only in R16 the plugins was not enabled

Only trunk as so far AsciiDoc documentation
2021-03-11 10:41:26 +01:00
holivier 32508bd437 Documented: ordered component documentation in the same order than application menu (OFBIZ-12166) 2021-03-10 18:38:33 +01:00
Jacques Le Roux 3ade20a4f8 Improved: Add JAX-RS capabilities (Jersey)
The real name of ofbiz is OFBiz. This renames it in descriptions.
It also renames the webapp title from Ofbiz-rest-jersey to Rest-jersey.
We know it's in OFBiz.
2021-03-01 11:23:48 +01:00
Jacques Le Roux 35a2eca9b4 Fixed: Exception error on ecommerce portal while trying to register new user
(OFBIZ-)

Missing import statement in the groovy script on the new customer registration
page.

Thanks: Pradeep Choudhary
2021-02-27 14:08:42 +01:00
Jacques Le Roux 2b6da24f7e Fixed: Error while uploading file in Ecommerce Profile's File Manager (OFBIZ-10746)
On uploading File in Ecommerce Profile's File Manager,

"The following required parameter is missing:
[IN] [uploadPartyContentFile.partyContentTypeId]" error is displaying.

Steps to regenerate the issue:
    Open Ecommerce on Ofbiz.
    Login with any user.
    Go to Profile.
    Navigate down to File Manager.
    Select Purpose.
    Seletct Mime Type
    Click upload.

Thanks: Aishwary Shrivastava for report, Priya Sharma fir the fix
2021-02-21 19:20:05 +01:00