Commit Graph
4365 Commits
Author SHA1 Message Date
holivier b76ee41197 Documented: migrate help link to asciidoc developer manual for Plugins
dedicated for developer (OFBIZ-11587)

create file plugins-developer-manual, which will include all include
plugins for developer.

The file plugin-developer-manual is include in developer-manual
2020-07-20 12:52:14 +02:00
holivier 8f57d0c87f Documented: migrate help link to asciidoc user manual for Plugin Ebay
(OFBIZ-11587)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about
Ebay and add a short page with a link to the new help

Remove docbook help files for Ebay
2020-07-20 12:44:13 +02:00
holivier 7ecfaebc72 Documented: ofbiz-plugins / ebay, migration for Help docbook file to
asciidoc
(OFBIZ-11587)

- ebay.adoc call (with include) other files
2020-07-20 11:48:40 +02:00
Jacques Le Roux a905d459bd Improved: Rename a few map files (OFBIZ-11882)
Renames a few files to suppress warnings in the browser console.

Thanks: Alex Bodnaru
2020-07-19 16:04:18 +02:00
Jacques Le Roux 899d3061fe Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)
The ecommerce and webpos controller missed an errorpage reference.
All other controllers either use directly the common-controller or indirectly by
including controller/s that include the common-controller
2020-07-18 11:15:18 +02:00
Suraj Khurana 2144763bc0 Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in plugins component.
(OFBIZ-11887)
2020-07-18 12:26:04 +05:30
Jacques Le Roux df8b8213ff Improved: User Error.ftl everywhere it's not yet used (OFBIZ-11890)
Those are no longer needed, replaced by error.ftl
2020-07-16 17:14:42 +02:00
Jacques Le Roux a50442d121 Improved: User Error.ftl everywhere it's not yet used (OFBIZ-11890)
At https://markmail.org/message/n76cchtriexxmgm7 I asked

Why having the ftl handlers only in webtools controller? BTW it makes the XSD
documentation awkward because it speaks about the ftl handlers being in
handlers-controller.xml
Why not using error.ftl in common-controller.xml instead of error.jsp?
Same question for plugins.

And answered

I believe we could change all that and definitely get rid of error.jsp
(error.ftl is already in all supported releases branches)
2020-07-15 20:56:23 +02:00
holivier 647e10377b Documented: ofbiz-framework /framework, migration for
SingleSignOn-docbook files to asciidoc
(OFBIZ-11587)

- SingleSignOn with LDAP: move to plugin LDAP and include in
developer-manual in deployment section
2020-07-14 21:18:14 +02:00
Suraj Khurana e7ead3697f Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in plugins component.
(OFBIZ-11880)
Thanks Jacques for review.
2020-07-13 14:14:42 +05:30
Suraj Khurana b18669cddc Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for plugins component.
(OFBIZ-11874)
This fixes following checkstyle issues:
'{' is not preceded with whitespace.

'{' is not followed by whitespace.

'}' is not followed by whitespace.

'}' is not preceded with whitespace.

'typecast' is not followed by whitespace.

'try' is not followed by whitespace.

';' is preceded with whitespace.
2020-07-11 14:27:09 +05:30
Pawan Verma 845de6eb63 Fixed: Send me this every month link is not working in order items section(OFBIZ-10891)
Thanks, Ashish for the report, Vivek for lookup and Amit for the patch.
2020-07-11 10:30:54 +05:30
Suraj Khurana 6f264947c7 Improved: Corrected all checkstyle issues related to succeeding space for comma in plugins directory.
(OFBIZ-11805)
Thanks Jacques and Ritesh Kumar for review.
2020-07-09 12:02:54 +05:30
Suraj Khurana f8e17a5b00 Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in plugin component.
(OFBIZ-11805)
2020-07-07 14:59:53 +05:30
Suraj Khurana 40ddf41c1a Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-plugins into trunk 2020-07-06 15:28:28 +05:30
Suraj Khurana c24db772c9 Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors.
(OFBIZ-11805)
Thanks Jacques Le Roux and Ritesh Kumar for review.
2020-07-06 15:28:07 +05:30
Jacques Le Roux 2cbb7bd278 Improved: No need to do anything if there is no person
Possible bug found while checking 17.12.04
2020-07-04 12:14:49 +02:00
Jacques Le Roux c2925a43a4 Improved: Adds plugin for integration of 1st Data payment gateway (OFBIZ-11837)
Adds missing ASL2 license headers
2020-07-03 15:07:18 +02:00
Jacques Le Roux 8ca14ec910 Fixed: BigDecimal casting in Groovy (OFBIZ-11862)
Sometimes use wrong type castings for BigDecimal:

I have observed that for typecasting in groovy, we have used the wrong coding
pattern like

(BigDecimal) 0
It should be like
0 as BigDecimal

Note that this does not apply to decimal because in case of decimal, the default
type is always BigDecimal in Groovy.

Thanks: Pritam Kute for spotting the issue in OFBIZ-11843
2020-06-30 15:31:27 +02:00
Jacques Le Roux d5a2fe0696 Fixed: Adding new plugin for integration of First Data payment gateway with Apache OFBiz. (OFBIZ-11837)
Comments out FirstDataDemoData.xml loading because it makes fail
auto-accounting-transaction-tests-sales

Thanks: Pritam Kute for the lead on data error
2020-06-29 11:17:07 +02:00
d931dfb9c9 Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files (OFBIZ-11779) (#33)
* Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files(OFBIZ-11779)

* Improved: Removed extra bracket added accidentally. (OFBIZ-11779)

* Update bi/groovyScripts/DimensionServices.groovy

Co-authored-by: Nicolas Malin <nmalin@apache.org>

Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>
Co-authored-by: Nicolas Malin <nmalin@apache.org>
2020-06-28 01:24:52 +05:30
Pawan Verma 8f14af21c5 Improved: Replace Collection.sort() with List.sort().(OFBIZ-11830) 2020-06-28 01:22:17 +05:30
Pawan Verma 2e415638b2 Improved: Replace explicit type argument with diamond operator(OFBIZ-11828)
Since Java 1.7, when defining generic types it is unnecessary to redefine those types in the constructor when it is already done in the declared type.
2020-06-28 01:06:04 +05:30
Pawan Verma 1f97f89bae Improved: Merge identical catch blocks in single catch block(OFBIZ-11827)
In Java SE 7 and later, a single catch block can handle more than one type of exception. This feature can reduce code duplication and lessen the temptation to catch an overly broad exception.

Thanks: Jacques for the review.
2020-06-27 11:24:33 +05:30
Pawan Verma 7680c0d3ab Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-plugins into trunk 2020-06-25 18:14:11 +05:30
Jacques Le Roux 0e1510701a Fixed: Add missing license header 2020-06-25 09:23:50 +02:00
Pritam Kute df753f80b2 Adding new plugin for integration of First Data payment gateway with Apache OFBiz. (OFBIZ-11837) 2020-06-24 17:40:55 +05:30
Pawan Verma 57fd870878 Improved: Replace anonymous types with lambda expressions(OFBIZ-11833) 2020-06-24 14:11:38 +05:30
Jacques Le Roux 17c42bcddc Fixed: Error while uploading file in Ecommerce Profile's File Manager (OFBIZ-10746)
This is only fixing the UI where you did not see the file to upload you selected

There is still an issue to upload the file

Thanks: Priya Sharma for testing
2020-06-23 14:54:53 +02:00
Pawan Verma 32f3e468da Improved: Replace try-finally with try with resources(OFBIZ-11826)
Set checkstyleMain.maxErrors to 26678 (-4)

Thanks: Jacques for the review.
2020-06-22 21:37:00 +05:30
Pawan Verma 8dd7f30247 Improved: Replace for-loop with forEach loop(OFBIZ-11829)
Also modified some checkstyle issues.

Set checkstyleMain.maxErrors to 26684 (-61)

Thanks: Jacques for the review.
2020-06-22 21:19:40 +05:30
Jacques Le Roux 670c08e7a3 Improved: Use a .asf.yaml file for more information in OFBiz GitHub repos
Same for ofbiz-plugins than for ofbiz-framework, not enough place for details
2020-06-22 08:36:05 +02:00
Priya SharmaandPriya Sharma 3fe12199d3 Improved: Convert FixedAssetMaintTests.xml to groovy (OFBIZ-11444) (#29)
* [Improved] Convert FixedAssetMaintTests.xml to groovy
Done the following
- Removed the xml tests file
- Updated the test suite mappings to point to the groovy test file
- Added Groovy implementation for all the test cases in FixedAssetMaintTests.xml

(OFBIZ-11444)

* [Improved]: Removed the userlogin fetching logic as the userlogin is already available in the groovy context. (OFBIZ-11444)

Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>
2020-06-16 10:49:02 +05:30
Suraj Khurana b4bdfcdf92 Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component. (#28)
* Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component.
(OFBIZ-11804)
2020-06-13 14:42:35 +05:30
Priya SharmaandPriya Sharma dd1d408bc8 [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762) (#24)
* [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

* [Improved]: Updated all ocurances where we only needed to pass the throwable object, without a message
- We have now added one more utility method to handle these cases. (OFBIZ-11762)

Co-authored-by: Priya Sharma <priya.sharma@example.com>
2020-06-08 13:39:42 +02:00
Suraj Khurana 9c447f2486 Improved: Enforce noninstantiability to LdapLoginWorker, OFBizSolrLoginWorker class. (#23)
(OFBIZ-11747)

Made class as final, added private constructor and made static variables as private.
2020-06-07 10:55:56 +05:30
Suraj Khurana b08fa4a944 Improved: Enforce noninstantiability to FinAccountHelper Class. (#22)
(OFBIZ-11723)

Made class as final, added private constructor, also made data members as private, defined getter and changed related occurrences.
2020-06-05 13:14:11 +05:30
Aditya Sharma 12e9f087a4 Improved: Breadcrumbs should be shown on all the pages of eCommerce application
(OFBIZ-2584)
Right now in OOTB eCommerce application breadcrumbs are only shown for catalog pages. It should be available on other pages too.

Added breadcrumb for ContactUs and Anonymous ContactUs page

Thanks Pranay Pandey for reporting the issue and Aishwary Shrivastava for providing the patch
2020-06-02 19:20:59 +05:30
Jacques Le Roux a133199830 Improved: adds pull_request_template.md (OFBIZ-11722) 2020-05-31 09:18:47 +02:00
Suraj Khurana ae31c01fa7 Improved: Change resources with proper naming convention in all plugin components.
(OFBIZ-11739)
Also, made MODULE as private data member of class instead of public. Thanks Jacques for review.
2020-05-29 13:14:02 +05:30
Suraj Khurana 2c65f7d17b Improved: Improved: Added UI labels for success/error messages for scrum component.
(OFBIZ-7696)
Thanks Deepak Nigam for reporting and Sourabh Punyani for the patch.
2020-05-24 13:09:47 +05:30
Suraj Khurana ade15ec80a Improved: Improvement of Quick Add screen according to new bootstrap framework.
(OFBIZ-11386)
Thanks Nitish Mishra for reporting and providing the patch.
2020-05-23 11:03:37 +05:30
Suraj Khurana 7aa38a284b Improved: UI markup Improvement of Inline promotion screen according to latest bootstrap.
(OFBIZ-11397)
Thanks Nitish Mishra for reporting and providing the patch.
2020-05-23 10:50:32 +05:30
Suraj Khurana 9c6838ef0b Improved: Refactor simple methods names as per naming convention best practices. (#20)
(OFBIZ-11700)
2020-05-23 10:34:37 +05:30
Pawan Verma 9c369dc489 Improved: Expansion of form widget field disabled atrribute with xsd improvement (#21)
(OFBIZ-10432)

Added disabled attribute support in ModelFormField with xs: boolean type
Removed specific field level disabled attribute support for CheckField and TextField
Modified existing usage of the disabled attribute as per new implementation.
Added new DisabledFieldExampleForm under Form Widget Examples for all the fields with disabled attributes.

Thanks: Rishi for the report and Taher, Gil and Jacques for the feedback
2020-05-19 17:37:19 +05:30
James Yong e7f587d8af Improved: Apply multi-block attr to each application (OFBIZ-11706)
Fix regression
2020-05-16 19:40:27 +08:00
Suraj Khurana 9428ee9579 Improved: Updated service name and removed duplicate service. (#16)
* Improved: Updated service name and removed duplicate service.
(OFBIZ-11616)

Please check dependent PR (https://github.com/apache/ofbiz-framework/pull/88) for more details.
2020-05-16 13:47:16 +05:30
James Yong 2e937378f4 Improved: Apply multi-block attr to each application (OFBIZ-11706)
Fix regression
2020-05-16 15:12:28 +08:00
James Yong ca5e6b45f1 Improved: Apply multi-block attr to each application (OFBIZ-11706)
For remaining plugin applications.
2020-05-16 13:37:43 +08:00
James Yong a802ae0a02 Improved: Apply multi-block attr to each application (OFBIZ-11706)
For eCommerce application.
2020-05-16 12:31:24 +08:00