Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)

Renames BirtEngineServlet class to OfbizBirtEngineServlet, because it shadowed
the simple name of it superclass.
It can be exceptionally confusing, create lots of situations in which you have
to look at import statements to resolve references and creates many
opportunities to accidentally define methods that do not override methods
in their superclasses.

Also remove trailing spaces in OpenApiUtil class
This commit is contained in:
Jacques Le Roux
2021-12-05 12:59:59 +01:00
parent cf086a2b47
commit 1f0cca7fa4
2 changed files with 4 additions and 6 deletions
@@ -24,19 +24,17 @@ import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.ofbiz.base.util.GeneralException;
import org.apache.ofbiz.base.util.UtilGenerics;
import org.apache.ofbiz.birt.BirtWorker;
import org.eclipse.birt.core.exception.BirtException;
import org.eclipse.birt.report.context.BirtContext;
import org.eclipse.birt.report.context.IContext;
import org.eclipse.birt.report.service.BirtReportServiceFactory;
import org.eclipse.birt.report.service.ReportEngineService;
import org.eclipse.birt.report.utility.ParameterAccessor;
import org.apache.ofbiz.base.util.UtilGenerics;
import org.apache.ofbiz.birt.BirtWorker;
@SuppressWarnings("serial")
public class BirtEngineServlet extends org.eclipse.birt.report.servlet.BirtEngineServlet {
private static final String MODULE = BirtEngineServlet.class.getName();
public class OfbizBirtEngineServlet extends org.eclipse.birt.report.servlet.BirtEngineServlet {
@Override
protected IContext __getContext(HttpServletRequest request, HttpServletResponse response) throws BirtException {
@@ -245,7 +245,7 @@ public final class OpenApiUtil {
.schema(new Schema<>()
.$ref("#/components/schemas/" + "api.response.service.unprocessableentity"))
.example(unprocessableEntExample)));
final ApiResponse methodNotAllowed = new ApiResponse()
.description("Method Not Allowed: Service called with HTTP method other than the declared one.")
.content(new Content()