1. While creating an organization, it is possible to specify a meaningful party id through ofbiz setup.
2. But, it is NOT possible to specify the party id through GUI while creating a Party (Person or Party Group). this means, all the parties created get a sequence id for party id.
If the user inputs a party ID to any of the party creation screens (person, party group, customer, employee or prospect) then that ID will be used, otherwise it will pull a party ID from the sequence bank
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1666794 13f79535-47bb-0310-9956-ffa450edef68
We neglected this aspect so far, adding a "form-name" attribute to the lookup element fixes it. You then need also to set the correct id-name value on field element.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1665535 13f79535-47bb-0310-9956-ffa450edef68
This fix move the code that reads the JSON parameters from the body into the ContextFilter: the parameters are then stored as attributes that can be later used by events and other artifacts (service events, simple events, scripts events support this and Java events if they use UtilHttp.getCombinedMap(request) to get the map of input parameters.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1665162 13f79535-47bb-0310-9956-ffa450edef68
java.lang.UnsupportedOperationException: hashCode: org.ofbiz.entity.condition.EntityConditionBuilder$ConditionHolder
[java] java.lang.UnsupportedOperationException: hashCode: org.ofbiz.entity.condition.EntityConditionBuilder$ConditionHolder
Thanks to Deepak Dixit for the bug report and for his tests.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1665154 13f79535-47bb-0310-9956-ffa450edef68
Reported by Taher:
Any search form that calls "performFind" and has a "date-find" tag will not persist but it will give correct search results.
For example, If I go to Order -> Requests and search using any of the date fields, the result will be correct but the field will be blank upon returning results. This behavior affects only dates.
I suspect the main offender here is a bug in performFind service or one of the services it calls (prepareFind or executeFind). I believe that the "queryStringMap" does not contain the date-find fields in its returned value. I did not look heavily into the code but I think "fld" types are not persisted in-between requests.
Christian:
This issue is still relevant and needed. The <date-find> values are not persisted after submission due to MacroFormRenderer.java not evaluating value and value2 correctly. In face, value2 isn't event passed to the definition in framework/widget/templates/htmlFormMacroLibrary.ftl. This is a starting point for this functionality. I said starting point because I'm not sure if it handles default values and other field settings that may need to be applied after my patch.
jleroux: It indeed needs to be improved, at least to keep the related date operator... I don't close yet, but would be better to open a new Jira issue...
I simply formatted the patch (tabs instead of 4 spaces) and used UtilGenerics.checkMap() instead of (Map<String, Object>)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1664696 13f79535-47bb-0310-9956-ffa450edef68
I have translated fully the framework/common/config/CommonUiLabels.xml & CommonEntityLabels.xml to Arabic. Attached is the patch for both files.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1664602 13f79535-47bb-0310-9956-ffa450edef68
FOP <fo:external-graphic/> images do not appear when portoffset used:
2015-02-28 18:12:12,249 |http-bio-8445-exec-4 |ApacheFopWorker |I| FOP FontBaseURL: file:/home/anon/workspace/ofbiz/framework/webapp/config/
2015-02-28 18:12:12,254 |http-bio-8445-exec-4 |FOP |D| target-resolution set to: 72.0dpi (px2mm=0.35277778)
2015-02-28 18:12:12,593 |http-bio-8445-exec-4 |FOP |E| Error with opening URL 'http://localhost:8080/content/control/stream?contentId=10004': Connection refused
2015-02-28 18:12:12,616 |http-bio-8445-exec-4 |FOUserAgent |E| Image not found. URI: /content/control/stream?contentId=10004. (See position 40:158)
In framework/webapp/config/fop.xconf <base>http://localhost:8080</base> is hardcoded
This patch employs FopFactory.setBaseUrl() along with the portOffset from Start class.
A better solution might be to extract the port from the baseUrl of fop.xconf and then apply the offset to that but I don't have time to implement that yet.
jleroux: I followed Christian's tip to complete his patch
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1663979 13f79535-47bb-0310-9956-ffa450edef68
<@ofbizUrl secure="true">SomeRequest</@ofbizUrl>
will actually use the https protocol. Thanks to Deepak Dixit for reporting discussing the issue and fix with me.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1662919 13f79535-47bb-0310-9956-ffa450edef68
Thanks Sumit for creating the issue and providing the patch for the same. Thanks Arun for the verification.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1661292 13f79535-47bb-0310-9956-ffa450edef68
<Uom abbreviation="Pb" description="Petabyte of Data" uomId="DATA_Pb" uomTypeId="DATA_MEASURE"/>
<UomConversion uomId="DATA_Pb" uomIdTo="DATA_Tb" conversionFactor="1024"/>
were left out when PB was added.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1660412 13f79535-47bb-0310-9956-ffa450edef68
The issue reported in OFBIZ-3382 and the fix committed for it need to be reviewed and possibly reworked but in the meantime this fix will solve the problem with broken links reported recently.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1660031 13f79535-47bb-0310-9956-ffa450edef68
This should fix, at least as a temporary solution, the recent issues happening after the upgrade to the new ESAPI.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1659224 13f79535-47bb-0310-9956-ffa450edef68
I'm reverting this instead of fixing it because the original commit was a first step in an effort to eliminate ThreadLocal variables in the framework (so we can make better use of multi-threading). But since then I have come to the conclusion that it will not be possible without a framework redesign.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1657714 13f79535-47bb-0310-9956-ffa450edef68
After some efforts to take into consideration Anil's justified concerns (simply put: keep the current behaviour), the modifications are finally light, which is greater for reviews. Most important are:
* Product component
** I have moved the OfbizCatalogAltUrlTransform and OfbizCatalogUrlTransform classes to a ftl subdirectory with the new FTL macros implementation: CatalogAltUrlSeoTransform, CatalogUrlSeoFilter, CatalogAltUrlSeoTransform, CatalogUrlSeoTransform, SeoTransform, UrlRegexpTransform
** A bunch of new filters have been added CatalogUrlSeoFilter, controlServlet, SeoCatalogUrlServlet, SeoContentUrlFilter, SeoContextFilter, SeoControlServlet, UrlRegexpContextFilter
** 2 util classes: SeoConfigUtil, SeoUrlUtil
** By default ofbizCatalogAltUrl and ofbizCatalogUrl macros now use the new implementations by CatalogAltUrlSeoTransform and CatalogUrlSeoTransform. This can be changed back in freemarkerTransforms.properties
** A SeoConfig.xml file define some SEO parameters, the SeoConfig.xsd can be sued as documentation, globally please refer to OFBIZ-5312.
* Framework webapp component
** By default ofbizUrl macro now uses the new implementations by UrlRegexpTransform. This can be changed back in freemarkerTransforms.properties
* Ecommerce component
** A new ecomseo webapp clones the ecommerce webapp on the model of ecomclone. There is not much there: mostly a controller with a new JspViewHandler class (in ecommerce) and a web.xml file
With these changes we can have both worlds running side by side. So you can use eitherb http://localhost:8080/ecommerce/control/main as root or http://localhost:8080/ecomseo, but also if you want http://localhost:8080/ecommerce/. Then everything follows.
From my reviews and tests all is working as expected. I only found a trivial bug that I can also reproduce in current trunk see OFBIZ-5305 (sometimes not locally, weird).
Of course, all the tests passes.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1655803 13f79535-47bb-0310-9956-ffa450edef68
With the difficulty to test, I create a new test-suite performfindtests with five junit :
* testPerformFindConditionFieldEquals
* testPerformFindConditionFieldLike
* testPerformFindConditionDistinct
* testPerformFindFilterByDate
* testPerformFindFilterByDateWithDedicateDateField
I also improve TestNodeMember with two fields extendFromDate and extendThruDate to realize filter on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1655499 13f79535-47bb-0310-9956-ffa450edef68
At bootstrap an eca definition like the following:
<eca entity="JobSandbox" operation="store" event="validate">
<action service="ping" mode="sync"/>
</eca>
is causing a deadlock because it is triggered at startup when the reloadCrashedJobs method is executed; reloadCrashedJobs is executed holding a lock on the JobManager object; within this method a "find" operation is performed that (because of the "validate" event) triggers the action; but for this a getDispatchContext is executed and this blocks until the task (executed by a thread Executor) that reads and setups the eca rules is complete; but this task requires a lock on the same JobManager object and thus we get the deadlock
Thanks to Arun Patidar and Deepak Dixit for analyzing the issue with me.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1655046 13f79535-47bb-0310-9956-ffa450edef68
Remove code related to Portal Management functionality from WebTools after equivalent code in MyPortal has been committed.
jleroux: I just removed also the FindPortalPage entry in Webtools main.ftl
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1653481 13f79535-47bb-0310-9956-ffa450edef68