Fix the following problems:
- The search screen results take you to the link geos.
it should go directly to create / edit instead
- You cannot edit a geo because the parameter is not passed across
the tabs link and edit / create. The menus should be redefined
to pass the parameter around
- The primary key is enforced in the service definition when
it should be optional to create new geos
- finally, the geoId should not be a lookup field as
an entity cannot lookup itself
Refs https://issues.apache.org/jira/browse/OFBIZ-6229
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1682415 13f79535-47bb-0310-9956-ffa450edef68
ModelFormField.getEntry returns the string representation of the value corresponding to the field in either the context map or parameters map but when the value is returned as a list [X, Y, Z], the opening and closing brackets are encoded [X, Y, Z]
This prevents the FormRenderer (atleast MacroFormRenderer) from detecting a list object from the string and converting it back to a list
eg - currentValueList = StringUtil.toList(currentValue).
The solution detects a collection value and handles the proper encoding.
Thanks Gareth Carter for reporting the issue and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1682234 13f79535-47bb-0310-9956-ffa450edef68
Removed unnecessary double checks and corrected exception handling where the catched exception was too broad.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1682214 13f79535-47bb-0310-9956-ffa450edef68
Introduces a new maxlength attribute to the textarea element in forms, applies the maxlength (255 chars) value in several FTL files, when the DB is limiting the length.
Thanks Forrest Rae for reporting the issue and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1682132 13f79535-47bb-0310-9956-ffa450edef68
jleroux: I suspected it was only a matter of replacing "${bsh" by "${groovy" in *.xml. But I had not the guts to get into 11(!) sub tasks.
So, in Eclipse, I simply did a S/R in *.xml and compared parts of my changes with some Pierre's most "complex" patches respectively product, ebaystore, projectmgr and scrum.
They were totally similar (just revisions number changed) so here is the whole.
I will later improve these changes by removing HTML entities when possible, this is a bit more delicate because in some cases the XML schema are not complete (or/and for other still obscure to me reasons) and if you simply replace HTML entities by simple code (eg &Amp; by &) you get issues in logs when the XML parser cross them...
Note: only menus, screen and forms are changed here.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1682118 13f79535-47bb-0310-9956-ffa450edef68
Adds a read-only attribute to the text input field. Using the display type is not enough, because it's uneasy to assign values through Javascript as using the lookup description-field-name shows OOTB. And the disabled option is not good when you want to still show the submitted values on return.
Also
* improves widget-form.xsd documentation about read-only attribute for lookup
* completes the foFormMacroLibrary.ftl where placeholder tabindex were missing (if this even ever makes sense)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1680921 13f79535-47bb-0310-9956-ffa450edef68
When widget verbose is set to false and using field lookup, the description of the selected object is not displayed (not using auto completion but the popup).
To reproduce : Set widget.verbose=false in framework/widget/config/widget.properties
Clear OFBiz cache then go to : https://localhost:8443/partymgr/control/EditPartyRelationships?partyId=Company
In the partyRelationship creation form, in party Id From field, click on lookup, search, select AUTHOR_MADMAX, and so no description displayed. Using autocompletion it's fine.
jleroux: This reverts the previous patch from Gil. It did not occur to me that all the rest of the result was only commented out HTML code, so a simple trim was enough. Happy to get rid of this ugly kludge
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1680881 13f79535-47bb-0310-9956-ffa450edef68
When widget verbose is set to false and using field lookup, the description of the selected object is not displayed (not using auto completion but the popup).
To reproduce : Set widget.verbose=false in framework/widget/config/widget.properties
Clear OFBiz cache then go to : https://localhost:8443/partymgr/control/EditPartyRelationships?partyId=Company
In the partyRelationship creation form, in party Id From field, click on lookup, search, select AUTHOR_MADMAX, and so no description displayed. Using autocompletion it's fine.
This patch use a trick to no care about widgetVerbose comments. Sad to use this kind of trick, but if not, spaces might not be trimed. With that, the display is perfect. No side effect detected.
jleroux: I still regret Hans past attitude about widgetVerbose which initially forced me to this hack
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1680873 13f79535-47bb-0310-9956-ffa450edef68
Or on a form of type list or multi, it is not possible to completely ignore a field via use-when attribute. Instead it hides the title and the column header became shifted from the table content.
For example I want to hide the description column from my form when exampleName is choosen as sort-field.
This also modifies
example/widget/example/ExampleForms.xml#ListExamples
to illustrate this functionality
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1680865 13f79535-47bb-0310-9956-ffa450edef68
I had to slightly modify the patch from "en_GB" to "en-GB" entries. Thanks Gareth Carter for reporting the issue and providing the fix.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1680219 13f79535-47bb-0310-9956-ffa450edef68
Ignoring a thrown ClassCastException is a common pattern in the project (one I have used myself), but it should be avoided in the future because it makes debugging difficult, plus it creates objects unnecessarily.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1680058 13f79535-47bb-0310-9956-ffa450edef68
jleroux: This is related to OFBIZ-5409. I noted then "The util.js script is introduced for that, though normally should not be needed... "
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1679982 13f79535-47bb-0310-9956-ffa450edef68
Upgrade commons-compress jar from 1.4.1 to 1.9
Thanks Supachai Chaima-ngua and Pierre Smits for reporting the issue, and thanks Supachai Chaima-ngua for providing the fix.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1679709 13f79535-47bb-0310-9956-ffa450edef68
1. Class path loading was ignoring component settings, so class paths for disabled components were being loaded.
2. Configuration files were parsed twice.
3. Potential problem with unloading a loader that failed loading.
I was unable to test Cobertura because the necessary class (org.ofbiz.base.config.CoberturaInstrumenter) isn't being compiled for some reason.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1676746 13f79535-47bb-0310-9956-ffa450edef68
This was based on the availabily of javax.crypto.Cipher, which became
standard in java 1.4. We require 1.7. This is very old.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1676154 13f79535-47bb-0310-9956-ffa450edef68