Commit Graph
10472 Commits
Author SHA1 Message Date
Michael Brohl be4b13e954 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.service.calendar.
(OFBIZ-9691)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812057 13f79535-47bb-0310-9956-ffa450edef68
2017-10-12 22:07:59 +00:00
Michael Brohl 8a9e3b2e7d Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.service.mail.
(OFBIZ-9690)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812051 13f79535-47bb-0310-9956-ffa450edef68
2017-10-12 21:18:35 +00:00
Michael Brohl 830561bfaa Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.crypto.
(OFBIZ-9689)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812049 13f79535-47bb-0310-9956-ffa450edef68
2017-10-12 20:59:59 +00:00
Michael Brohl e3f932eb88 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.widget.renderer.fo.
(OFBIZ-9685)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811700 13f79535-47bb-0310-9956-ffa450edef68
2017-10-10 13:50:41 +00:00
Michael Brohl 0f51376f26 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.service.config.model.
(OFBIZ-9682)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811699 13f79535-47bb-0310-9956-ffa450edef68
2017-10-10 13:46:42 +00:00
Michael Brohl 347201db90 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.util.collections.
(OFBIZ-9590)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811685 13f79535-47bb-0310-9956-ffa450edef68
2017-10-10 12:28:01 +00:00
Jacques Le Roux fa58cb36d2 No functional change
Adds a comment for the default-no-eca using the reason suggested by Nicolas on
dev ML

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811571 13f79535-47bb-0310-9956-ffa450edef68
2017-10-09 13:55:21 +00:00
Taher A. Alkhateeb f3c80f7de3 Improved: removed dependency from start component on base
Debug class should not be used directly from the start component, hence replaced
it with standard System.out.println


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811566 13f79535-47bb-0310-9956-ffa450edef68
2017-10-09 12:45:20 +00:00
Michael Brohl f0771922f0 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.service.engine.
(OFBIZ-9688)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811468 13f79535-47bb-0310-9956-ffa450edef68
2017-10-08 10:39:01 +00:00
Michael Brohl 4303f902b4 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.service.group.
(OFBIZ-9684)

I modified the patch to make ServiceGroupReader#groupsCache private.

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811467 13f79535-47bb-0310-9956-ffa450edef68
2017-10-08 10:28:57 +00:00
Michael Brohl 4934374b64 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.widget.renderer.html.
(OFBIZ-9686)

I modified the class further by removing all commented out code.

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811439 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 16:06:24 +00:00
Michael Brohl ee46dbb019 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.
(OFBIZ-9681)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811438 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 15:47:59 +00:00
Michael Brohl e87607b19f Fixed: the introduction of multicatch in Converters.java which came with
r1811434 breaks MiscTests#testLoadContainedConvertersIgnoresException
which throws a RuntimeException.

Not sure if we should change the test so the fix is to reintroduce the
catch of Exception.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811437 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 15:46:38 +00:00
Michael Brohl af9cdae275 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.conversion.
(OFBIZ-9679)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811434 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:53:43 +00:00
Michael Brohl cf3081a277 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.preferences.
(OFBIZ-9640)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811433 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:51:43 +00:00
Michael Brohl 05697cee3d Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.catalina.container.
(OFBIZ-9639)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811432 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:49:16 +00:00
Michael Brohl ca51783af8 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.service.
(OFBIZ-9638)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811431 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:30:13 +00:00
Michael Brohl 57aa05a457 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.security.
(OFBIZ-9635)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811429 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:15:58 +00:00
Michael Brohl a7beb48720 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.uom.
(OFBIZ-9634)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811428 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:12:51 +00:00
Michael Brohl 2a66a06aef Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.qrcode.
(OFBIZ-9633)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811427 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:10:50 +00:00
Michael Brohl 404139505e Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.period.
(OFBIZ-9631)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811426 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:08:49 +00:00
Michael Brohl 31a2e43496 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.login.
(OFBIZ-9630)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811424 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:06:21 +00:00
Michael Brohl 36492861ee Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.image.
(OFBIZ-9629)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811423 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:00:27 +00:00
Michael Brohl 17db653e57 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.email.
(OFBIZ-9628)

Applied modified patch due to intermediate changes and removed an
obsolete import.

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811422 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 13:56:48 +00:00
Michael Brohl 2921eff056 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.authentication.
(OFBIZ-9627)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811421 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 13:49:20 +00:00
Michael Brohl 61d6a6ede0 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.util.string.test.
(OFBIZ-9589)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811418 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 12:47:36 +00:00
Michael Brohl 7279dec7c2 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.util.cache.test.
(OFBIZ-9576)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811416 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 12:28:52 +00:00
Michael Brohl 06fc59dbf5 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.util.cache.
(OFBIZ-9575)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811415 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 12:26:35 +00:00
Michael Brohl d55ec1f8bb Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.test.
(OFBIZ-9574)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811414 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 12:13:05 +00:00
Michael Brohl bfa9e5adf6 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.start.
(OFBIZ-9573)

I slighly modified the patch because of a conflicting change.

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811413 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 12:07:16 +00:00
Michael Brohl 96601e4d22 Fixed: Exception in service semaphore in wait mode and with multi
thread calls.
(OFBIZ-9534).

Thanks Pierre Gaudin for reporting and providing the patch.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811406 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 10:23:02 +00:00
Nicolas Malin 8f447bdbc2 Fixed: InitTheme.groovy can't work without request (OFBIZ-9798)
When a sendOrderConfirmation runs it calls InitTheme.groovy. But then there is no request and InitTheme fails
The script was improved to escape if the request is empty and try before to resolve the visualThemeId from the context
Tanks Jacques for the catch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811042 13f79535-47bb-0310-9956-ffa450edef68
2017-10-04 07:13:21 +00:00
Jacques Le Roux 456ad70aca Improved: Add session tracking mode and make cookie secure
(OFBIZ-6655)

Programmatically replaces the web.xml <session-config> declarations and uses 
the @WebListener annotation to start the process. This avoid to duplicates 
things everywhere in web.xml files. Since the web.xml files have precedence 
on annotations, the setting can be easily overridden when necessary.

Now that we also use HTTPS in ecommerce the ecommerce session cookie is 
also secured.

I also noted that we had 8 weird <session-timeout> declarations:
    in solr component: <session-timeout>2</session-timeout>
    in themes: <session-timeout>1</session-timeout>

Also in Rainbowstone we lacked the <cookie-config> and <tracking-mode> 
declarations. I think it's not good.

I resolve these points by simply removing the <session-config> in web.xml files 
of themes and Solr.

Thanks: Pradhan Yash Sharma  for review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811041 13f79535-47bb-0310-9956-ffa450edef68
2017-10-04 07:12:57 +00:00
Michael Brohl 2c2078768d Fixed: EmailServices.sendMailFromScreen improved to take multiple
attachments with appropriate type along with several email fixes.
(OFBIZ-9395).

This adds the missing service attributes for attachmentType and
attachmentTypeList which did not come with the initial patch. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1810260 13f79535-47bb-0310-9956-ffa450edef68
2017-10-01 10:39:18 +00:00
Jacques Le Roux 793f6c586a Reverted: Bug SQL Count Distinct command in GenericDAO.java
(OFBIZ-5701)

Reverts
trunk r1804319
R16.11 r1804320
R15.12 r1804321
R14.12 r1804322
R13.07 r1804323

This raised 2 issues:
  MSSQL as reported by Wei Zhang in OFBIZ-9676
  Dynamic View Entities as reported by Pawan Verma in OFBIZ-5701

I asked kieuanhvu to see if he can provide a new patch taking these 2 issues in
consideration


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1810054 13f79535-47bb-0310-9956-ffa450edef68
2017-09-29 06:21:16 +00:00
Jacques Le Roux 63938c6816 Improved: Add session tracking mode and make cookie secure
(OFBIZ-6655)

This completes r1809687, no need to secure when deleting. I will not backport

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809838 13f79535-47bb-0310-9956-ffa450edef68
2017-09-27 12:30:25 +00:00
Jacques Le Roux 1674e51b37 Fixed: Unable to run the MRP
(OFBIZ-9794)

This is only loosely related to this issue but I believe it could help and is 
needed anyway

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809821 13f79535-47bb-0310-9956-ffa450edef68
2017-09-27 09:43:10 +00:00
Jacques Le Roux 39e75f3a46 No functional change.
Clarifies in log when a weppabb is not mounted (overriding another)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809747 13f79535-47bb-0310-9956-ffa450edef68
2017-09-26 13:29:10 +00:00
Jacques Le Roux 6030547746 Fixed: Transaction Timeout in JavaEventHandler
(OFBIZ-9725)

When you run a service from webtools (not scheduling it) the the duration of the
 service is limited to the transaction default timeout (60 seconds)

Thanks: Jeffrey Breault for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809741 13f79535-47bb-0310-9956-ffa450edef68
2017-09-26 13:15:12 +00:00
Jacques Le Roux d56833ae7c Improved: Add session tracking mode and make cookie secure
(OFBIZ-6655)

This is somehow related with OFBIZ-6655 because it's there that Deepak reverted
r1719762 (actually r1719939). It was right to do so at r1722379 for 
RequesHandler but not for the other files. Because it now does not handle 
security for cookies which are not session cookies. It's minor but still a risk,
notably for autoLoginCookie

This reapplies r1719762 for the other files to make other than session cookies
secure. I will not backport


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809687 13f79535-47bb-0310-9956-ffa450edef68
2017-09-26 07:17:40 +00:00
Arun Patidar 45a723e6df IMPROVED: Update UtilMisc.formatRuleBasedAmount() method to take rules and ruleSet and formatting can be done, rather than system providing all ruleset support. (OFBIZ-9490)
Thanks Pradhan Yash Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809425 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 13:18:41 +00:00
Arun Patidar fca6a917d5 ADDED: new Rule Based Number Format for Indian Number System in International Components for Unicode (ICU) OFBiz usage. (OFBIZ-9489)
Thanks Pradhan Yash Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809424 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 13:14:07 +00:00
Deepak Dixit 259a585512 Fixed: Manually changed the date locale js for cs locale
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809413 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 12:39:52 +00:00
Arun Patidar 33e8efb477 IMPROVED: Updated phone validation method to validate phone for specific geo. (OFBIZ-9358)
> Thanks Renuka Srishti for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809412 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 12:35:27 +00:00
Deepak Dixit 344e97909a Fixed: JsLanguageFilesMapping.java location in createJsLanguageFileMapping service, and commiting the auto generated java file for language mapping js.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809410 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 12:11:31 +00:00
Deepak Dixit 69a3268067 Improved: Moved OfbizUtil.js and fieldlookup.js from images to common-theme and made changes accordingly. (OFBIZ-5776)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809391 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 11:01:24 +00:00
Deepak Dixit 88493836bc Improved: Moved jquery related js/plugins from images to common-theme webapp and made changes accordinlgy. (OFBIZ-5776)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809389 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 10:41:28 +00:00
Rishi Solanki 3d29d37572 Improved: Extend SecurityGroup entity and add name/groupName field. Added groupName field to entity SecurityGroup and related changes done in the data, services and UI. (OFBIZ-9620)
Thanks Suraj Khurana for your patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809386 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 10:16:17 +00:00
Jacques Le Roux a360a3ffc7 Improved: Missing foreign key constraint for fields userLoginId &
userPrefGroupTypeId in UserPreference entity
(OFBIZ-9678)

UserPreference.userLoginId is related to UserLogin.userLoginId.
UserPreference.userPrefGroupTypeId is related to 
UserPrefGroupType.userPrefGroupTypeId.

Fixes tests by using one-nofk for UserLogin relation
Uses uppercase for fk-name as remarked by Deepak


Thanks: Aditya and Deepak

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809383 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 09:59:24 +00:00
Jacques Le Roux c8e8e740e3 Improved: Missing foreign key constraint for fields userLoginId &
userPrefGroupTypeId in UserPreference entity

UserPreference.userLoginId is related to UserLogin.userLoginId.
UserPreference.userPrefGroupTypeId is related to 
UserPrefGroupType.userPrefGroupTypeId.

(OFBIZ-9678)


Thanks: Aditya

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809375 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 08:24:08 +00:00