Commit Graph
10472 Commits
Author SHA1 Message Date
Jacques Le Roux c3f3ea6847 Improved: Enable/Disable JMS
(OFBIZ-4454)

Allows to Enable/Disable JMS with a service properties

Thanks: Adrian for report Dimitri Unruh for creating the Jira

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1805158 13f79535-47bb-0310-9956-ffa450edef68
2017-08-16 09:15:00 +00:00
Jacques Le Roux d6b89bc509 Fixed: Collection added to itself
(OFBIZ-9578)

In a recent github mirror, I've found suspicious code.
Branch: master
path: framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java

...
1588         protected final List<String> messages = new LinkedList<String>();
...
1596         protected int updateData(Collection<String> messages) {
1597             if (messages != null && UtilValidate.isNotEmpty(this.messages)) {
1598                 messages.addAll(messages);
1599             }
1600             return count;
1601         }
1602     }

In Line 1598, `messages.addAll' should be `this.messages.addAll'? 
This might not be an issue but I wanted to report this just in case.

Thanks: JC (jaechang.nam@gmail.com)for report 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1805143 13f79535-47bb-0310-9956-ffa450edef68
2017-08-16 07:41:31 +00:00
Jacques Le Roux 3cc575b6de Improved: Check there are no white spaces around the name of a form field when
updating a form
(OFBIZ-9306)

Sometimes ago, I lost an hour because of a space at the end of a field's name in 
a form. In creation it does not pass (the field lacks) but when updating the 
form it passes and it's hard to find from where comes the problem.

Thanks: Michael for review and spotting a possible NPE in my 1st patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1805141 13f79535-47bb-0310-9956-ffa450edef68
2017-08-16 06:34:56 +00:00
Nicolas Malin cb175c71f7 Fixed: Missing fieldInfo when call constructor for ModelFormField Password, File and Lookup
(OFBIZ-9577)

When you create a form with an entity or service auto fields, the three previous form field call only "super(fieldSource, modelFormField);" in their constructor or this initialise a TextField with the fieldInfo FieldInfo.TEXT.
I force the field info when the super constructor is called

This missing has been found during investigation on the issue OFBIZ-9577 to improve auto-fields-service with a file upload



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1805011 13f79535-47bb-0310-9956-ffa450edef68
2017-08-14 15:47:36 +00:00
Jacques Le Roux 6d55e9342b No functional changes, fixes JavaDoc issues
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804973 13f79535-47bb-0310-9956-ffa450edef68
2017-08-14 10:04:34 +00:00
Jacques Le Roux a85c94dc2f Implemented: New UtilMisc method collectionToString(...) building safely a
String with the given collection and delimiter
(OFBIZ-9397)

The added method UtilMisc.collectionToString(Collection values, String delimiter) 
creates a String from the values of a collection, separated with the given 
delimiter. This is done in a safe way without a "null" literal.

Thanks: Martin Becker

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804970 13f79535-47bb-0310-9956-ffa450edef68
2017-08-14 09:52:49 +00:00
Jacques Le Roux 514cdb1ae5 Improved: GenericServiceJob.failed(Throwable) avoid logging stacktraces for
non technical service semaphore exceptions
(OFBIZ-9400)

GenericServicejob.failed(...) logs a stacktrace on every SemaphoreWait and 
SemaphoreFail exception. The patch changes this for the non-technical service 
semaphore exceptions to a one liner error logging to avoid polluting the logfile 
with stacktraces e.g. in a scenario where a service is scheduled in short 
intervals and fails expected while the former one is still running.

jleroux: I agree the case Martin describes must be quite annoying, especially in 
production!

Thanks: Martin Becker

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804962 13f79535-47bb-0310-9956-ffa450edef68
2017-08-14 09:47:36 +00:00
Jacques Le Roux bfd533ccc3 Improved: [DEPRECATION] Replace BigDecimal.ROUND_* by RoundingMode.*
(OFBIZ-9571)

No functional change.

We read at http://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html : 
<<Using the integer fields in this class (such as ROUND_HALF_UP) to represent 
rounding mode is largely obsolete; the enumeration values of the RoundingMode 
enum, (such as RoundingMode.HALF_UP) should be used instead.>>

That's an easy global replacement. But it also needs to import the RoundingMode 
class. It was 26 files so I decided to rather clean all the imports in all files
 with the help of Eclipse.

This is a 1st step. I will need to closely look at 2 special class: UtilNumber
and Calculate.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804953 13f79535-47bb-0310-9956-ffa450edef68
2017-08-14 08:32:21 +00:00
Jacques Le Roux a938fcfbc9 Implemented: ServiceSemaphore: Check for Transaction before suspending it in
dbWrite(...)
(OFBIZ-9401)

In ServiceSemaphore.dbWrite(...) the transaction is suspended without checking 
if there is a transaction in place. This results in logging a warning each time 
the TransactionUtil.suspend() method is invoked without a current transaction in
 place. The given patch cuts this unnecessary logging by checking if there is an
 transaction in place to suspend. If a transaction exists - suspend it.

Thanks: Martin Becker

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804940 13f79535-47bb-0310-9956-ffa450edef68
2017-08-13 19:20:14 +00:00
Jacques Le Roux 1eb540f616 No functional change.
This has been deprecated for 5+ years, time for action!

Uses digestHash() methods instead of getDigestHash(). Easily replaceable...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804880 13f79535-47bb-0310-9956-ffa450edef68
2017-08-13 07:21:01 +00:00
Nicolas Malin 082d629aa9 Implemented: Connect OFBiz to a read only database (OFBIZ-6401)
Add a DAO helper class to use a datasource as readonly
This helper is disable by default. To enable it change the helper class on your datasource use in entityengine.xml like

    <datasource name="localderby"
            helper-class="org.ofbiz.entity.datasource.ReadOnlyHelperDAO"
            schema-name="OFBIZ" ...



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804826 13f79535-47bb-0310-9956-ffa450edef68
2017-08-11 17:09:08 +00:00
Nicolas Malin 8deead6052 Fixed: Related to the issue OFBIZ-6401Connect OFBiz to a read only database
Escape null pointer exception stack trace when the helper return no value 


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804824 13f79535-47bb-0310-9956-ffa450edef68
2017-08-11 17:02:34 +00:00
Nicolas Malin 703148c27e Implemented: Manage deprecated service in the ModelService (OFBIZ-9558)
When you want to remove a service we add a new xml element <deprecated/> that you can put on the service definition like this

<service name="oldService" ...>
    <deprecated use-instead="newService" since="theReleaseXXX">The reason to move it as deprecated</deprecated>
    <implements service="newService"/>
</service>

A deprecated service generate a warning log each time it is called
When you navigate on webtools a deprecated service is strike in the service list and display deprecated reason on the service definition detail page.

Thanks to Scott, Deepak, Taher and Jacques for sharing on this subject

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804786 13f79535-47bb-0310-9956-ffa450edef68
2017-08-11 12:41:22 +00:00
Jacques Le Roux b6e860f6b7 Improved: [FB] Package org.apache.ofbiz.base.metrics
(OFBIZ-9567)

Changes a division with two long variables whose result was casted into a double
Now it performs a proper double division

Thanks: Dennis Balkir (and FB ;))

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804656 13f79535-47bb-0310-9956-ffa450edef68
2017-08-10 10:27:57 +00:00
Jacques Le Roux 6d67c194a0 Improved: [FB] Package org.apache.ofbiz.base.config
(OFBIZ-9566)

MainResourceHandler
 The protected fields were set to private since the class is not extended 
 anywhere. If they need to be accessed in the future, getter that return an 
 unmodifiable version should be implemented (Collections.unmodifiableXXX).

Refactor:
 Uses multi exceptions catch (explicitly to not catch, hence somehow swallow, 
 RuntimeException)
 Uses return instead of else when appropriate
 Extracts a getLoader() handy method
 Removes an useless thrown exception in invalidateDocument()
 Removes an useless Document cast
 Removes an useless ResourceLoader null initialisation 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804639 13f79535-47bb-0310-9956-ffa450edef68
2017-08-10 07:52:16 +00:00
Jacques Le Roux 98e89f33ff No functional trivial changes
When reviewing code, Eclipse complains: "Javadoc: Invalid param tag name"
when a param tag name "contains" a colon at end

Weirdly it does not complain about @return. Go figure! But I'll apply the same!

This removes all cases found in trunk. Another way could be to add a space 
between the tag and the colon. But that's not how it's recommended to write

http://www.oracle.com/technetwork/articles/java/index-137868.html

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804637 13f79535-47bb-0310-9956-ffa450edef68
2017-08-10 07:21:22 +00:00
Jacques Le Roux d0dd85d890 Improved: [FB] Package org.apache.ofbiz.base.container
(OFBIZ-9563)

Fixes some diamond operators

ComponentContainer.java
  deleted multiple unnecessary nullchecks
  added nullcheck, because sortedComponentNames could possibly be assigned as 
    null through the method list()

ContainerConfig.java
  deleted multiple unnecessary else-blocks
  deleted two initializations to shorten the code and return the value directly

Thanks: Dennis Balkir


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804636 13f79535-47bb-0310-9956-ffa450edef68
2017-08-10 07:10:55 +00:00
Jacques Le Roux 75c40fef71 No functional trivial changes
When reviewing code, Eclipse complains: "Javadoc: Invalid param tag name"
when a param tag name "contains" a colon at end

This removes all cases found in trunk. Another way could be to add a space 
between the tag and the colon. But that's not how it's recommended to write

http://www.oracle.com/technetwork/articles/java/index-137868.html

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804635 13f79535-47bb-0310-9956-ffa450edef68
2017-08-10 06:31:38 +00:00
Jacques Le Roux d34d77bde3 Improved: [FB] Package org.apache.ofbiz.base.concurrent
(OFBIZ-9562)

Fixes some diamond operators
Implementes equals method to fix potential problems
Implementes hashCode method because I implemented equals method
Implementes timeDiff method to keep the code DRY

Thanks: Dennis Balkir

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804634 13f79535-47bb-0310-9956-ffa450edef68
2017-08-10 06:11:26 +00:00
Jacques Le Roux 89eca637b8 Improved: [FB] Package org.apache.ofbiz.base.lang.test
(OFBIZ-9565)

Fixes some diamond operators

Thanks: Dennis Balkir

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804558 13f79535-47bb-0310-9956-ffa450edef68
2017-08-09 15:46:11 +00:00
Jacques Le Roux d232eae643 Improved: [FB] Package org.apache.ofbiz.base.lang
(OFBIZ-9564)

Implemented method hashCode() because method equals() was implemented
Changed Exception to RuntimeException because no exception was thrown and the 
only occurring exception could be a runtimeexception

Thanks: Dennis Balkir

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804556 13f79535-47bb-0310-9956-ffa450edef68
2017-08-09 15:44:00 +00:00
Jacques Le Roux f1fb12bd0b Improved: Refactor EntityListIterator
(OFBIZ-9549)

The EntityListIterator contains duplicate code and has need for refactoring in 
general.

Thanks: Tobias Laufkötter

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804328 13f79535-47bb-0310-9956-ffa450edef68
2017-08-07 12:43:54 +00:00
Jacques Le Roux 82ce693f5a Fixed: Bug SQL Count Distinct command in GenericDAO.java
(OFBIZ-5701)

jleroux: Kieuanhvu's explanation was not totally clear. So I rather provide
Renuka Srishti's at OFBIZ-9428 "getResultsSizeAfterPartialList() return wrong 
count with distinct() for View Entity"

Here is the code sample to test the issue:

EntityListIterator productAssocListItr = null;
productAssocListItr = from("ProductAndAssoc").distinct().queryIterator();
productAssocListSize = productAssocListItr.getResultsSizeAfterPartialList();

productAssocListSize will differ from the actual distinct records in the 
ProductAndAssoc View Entity.
This issue exists because it gives distinct records on the basis of the 
first column in the table.

Thanks: Kieuanhvu for the patch, Renuka Srishti for a clear explanation and a 
simple way to test (in a groovy for me)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804319 13f79535-47bb-0310-9956-ffa450edef68
2017-08-07 10:40:32 +00:00
Jacques Le Roux f41feebf57 Completed: Remove the never implemented deleteParty (pre Apache era)
(OFBIZ-9556)

In dev ML in this thread https://s.apache.org/pc90 
I suggested to remove the never implemented deleteParty (pre Apache era)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804315 13f79535-47bb-0310-9956-ffa450edef68
2017-08-07 10:00:55 +00:00
Deepak Dixit ca74d2496a Improved: Remove unnecessary field types (OFBIZ-9351)
Applied patch from jira issue, also removed -ne field refereces from code.

Thanks Aditya Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804031 13f79535-47bb-0310-9956-ffa450edef68
2017-08-03 18:11:45 +00:00
Deepak Dixit a0d99ed40f Improved: Replace fields with id-ne, id-long-ne and id-vlong-ne by id, id-long and id-vlong respectively which are not primary keys (OFBIZ-9355)
Thanks Aditya Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804026 13f79535-47bb-0310-9956-ffa450edef68
2017-08-03 17:51:07 +00:00
Deepak Dixit fcb3ea53ae Improved: Removing Assignment between UserLogin and SecurtyGroup does not work, (OFBIZ-9543)
Updated label from remove to expire while removing security group from user login, also added new entity-auto service to expire user login security group record. 

Thanks S. Yazied for reporting the issue. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1803561 13f79535-47bb-0310-9956-ffa450edef68
2017-07-31 18:34:18 +00:00
Nicolas Malin a697277bbf Fixed: no functional change, correct empty body on xml element hyperlink
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1803538 13f79535-47bb-0310-9956-ffa450edef68
2017-07-31 13:38:10 +00:00
Nicolas Malin 6da5d7cf2e Fixed: Set first letter to upper case for xls macro library to keep the coherence with other macro library. This error was introduce by me so I repair :)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1803391 13f79535-47bb-0310-9956-ffa450edef68
2017-07-29 20:18:16 +00:00
Deepak Dixit 5f54acf159 Fixed: Corrected condition to ignore type check for datetime and time field.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1803025 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 08:14:17 +00:00
Nicolas Malin e193e14ccd Improved: Improve groovy DSL, runService call makeValidContext (OFBIZ-9523)
When you call run service with groovy, you need to be sure that all parametes are good for the service call.
This improvement simplify this dsl with an automatic parameters check so you can call directly like that
run service : createProduct, with: context

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802798 13f79535-47bb-0310-9956-ffa450edef68
2017-07-24 12:17:01 +00:00
Deepak Dixit bedad64f14 Fixed: Added check to avoid datetime and time field warning (OFBIZ-9496)
The warning message generated by OFBiz is a false positive caused by the fact that the way OFBiz performs the check is too simplistic: OFBiz parses for the content of the "()" in the fieldtype mapping and assumes that it is the column size.
However, in MySQL and possibly other database management systems, this is only true for varchar field definitions but not for datetime fields.
The column size for DATETIME(3) is not 3.
We should probably refactor the code in DatabaseUtil to compare the SQL field type from the JDBC driver, if possible to retrieve, (i.e. from the database) with the whole content (without any sting manipulation) of the attribute sql-type of the element field-type-def type (in fieldtype*.xml) i.e. "DATETIME(3)"; if they differ then a warning should be printed.
In this way we will have a more generic, simpler and more reliable tool to spot differences in the database

This is a workaround to fix the warning.
Thanks Jacopo.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802693 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 13:14:43 +00:00
Pranay Pandey e6f6490649 Fixed: Adding condition in price rule on 'Role Type' showing incorrect result.
(OFBIZ-7275)

The issue exists because in role type list there are multiple occurrences of substring "CUSTOMER". The existing check was just checking the occurrence of a substring in the string and found this value more than once in the list so the last option gets selected. Applied equality check to find the exact match.

Thanks Aditi Patidar for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802690 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 13:06:12 +00:00
Arun Patidar 028cafb30e Fixed issue due to incorrect comparision operation.(OFBIZ-9254)
Thanks Rohit Rai for reporting.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802685 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 12:38:44 +00:00
Nicolas Malin 7d3ad82758 Improved: for EntityQuery.findOne() with context,
Instead of iterating fields, used GenericPk class object to get the PK fileds from parameters/fieldMap.
Thanks Deepak for this nice improvement

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802684 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 12:23:59 +00:00
Nicolas Malin 966b1755a0 Improved: set auto completion only in lookup field (OFBIZ-9378)
Add a new option presentation none for the lookup element to don't display the link for display the search form bu only use autocompletion.
In the initial path from Pierre Gaudin the presentation name was autocompletion-only but I prefer change it to none because the link is just not preent.
Thanks Pierre Gaudin for this proposal and patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802682 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 12:14:59 +00:00
Arun Patidar 001bbe9a52 Integrating google phone number library for validating telecom numbers. (OFBIZ-9358)
Applied slightly modified patch. Thanks Suraj Khurana and Renuka Srishti for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802661 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 09:10:50 +00:00
Nicolas Malin 3080813151 Improved: Improve EntityQuery.queryOne() function to resolve a record by auto matching the primary key on a given context. (OFBIZ-9447)
Like that :
     GenericValue product = from('Product').where(context).queryOne()
This improvement simulate the minilang element <entity-one entity-name=Product value-name=product/> for helping the minilang migration to groovy
Thanks Jacopo to help the conception, Taher for the review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802660 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 09:02:44 +00:00
Taher A. Alkhateeb 609c7d37e3 Improved: minor refactoring to remove miscellanous warnings
Minor code cleanup to remove:
- unused private variables
- unused imports
- improper object castings



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802172 13f79535-47bb-0310-9956-ffa450edef68
2017-07-17 16:59:18 +00:00
Taher A. Alkhateeb 3ed1891429 Improved: removed unused private final variables in UtilValidate.java
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801431 13f79535-47bb-0310-9956-ffa450edef68
2017-07-10 09:05:51 +00:00
Jacques Le Roux 4a8ec59b63 Improved: ServiceSemaphore.waitOrFail() remove redundant logging
(OFBIZ-9399)

Removes the redundant logging done in ServiceSemaphore.waitOrFail() since the
 error will be logged by the ServiceEngine anyway.

Thanks: Martin Becker

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801380 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 16:37:10 +00:00
Arun Patidar 509adfee36 Improved: Cut of unnecessary auto-stamp fields from Visit, ServerHit and ServerHitBin. (OFBIZ-9402)
Thanks Martin for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801343 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 23:55:33 +00:00
Deepak Dixit e95c7eb261 Fixed: fix tag "disable-if-empty" in menus if field has no value (OFBIZ-9377)
Thanks Gaudin Pierre and Humera Khan for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801336 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 22:54:06 +00:00
Arun Patidar 44c0caa799 Improved: Set autocomplete to off for all the password fields.(OFBIZ-9471)
Thanks Ritesh Kumar for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801324 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 21:07:51 +00:00
Deepak Dixit 70ea1b55c2 Fixed sequencing for ILS locale description.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801314 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 18:44:48 +00:00
Arun Patidar e85c824585 Improved: Use serviceUtil() in place of hard-coded error/success messages. (OFBIZ-9466)
Thanks Pawan Verma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801313 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 18:43:54 +00:00
Deepak Dixit 7bb7ac13ea Added mistakenly removed valued for ILS entity uiLabel.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801312 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 18:42:29 +00:00
Deepak Dixit 0d6bc54720 Fixed: Removed duplicate uiLable for ILS currency, also fix translation for French locale. (OFBIZ-9413)
Thanks Jacques for reporting

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801311 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 18:39:30 +00:00
Deepak Dixit 14f9c7331d Improved: Following uiLabels should move from ProductUiLabels.xml to CommonEntityLabels.xml. (OFBIZ-9408)
ProductShipmentUomAbbreviation_LEN_in
    ProductShipmentUomAbbreviation_WT_g
    ProductShipmentUomAbbreviation_WT_kg
    ProductShipmentUomAbbreviation_WT_lb
    These labels should be written in similer pattern as other labels of "Uom" entity are written in CommonEntityLabels.xml, for example :
    ProductShipmentUomAbbreviation_LEN_in will be written as
    Uom.abbreviation.LEN_in
    <entityName>.<fieldName>.<PrimaryKey>

Thanks Renuka for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801281 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 11:36:50 +00:00
Arun Patidar 8763342f1e Improved: Inconsistent String Comparisons. (OFBIZ-9254).
Thanks Devanshu Vyas for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801268 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 09:15:03 +00:00