Commit Graph
10472 Commits
Author SHA1 Message Date
Michael Brohl c06f835668 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.entity.jdbc.
(OFBIZ-9782)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817637 13f79535-47bb-0310-9956-ffa450edef68
2017-12-09 17:34:02 +00:00
Jacques Le Roux 0ab019569e No functional change, fixes a typo in comment
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817574 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 21:28:12 +00:00
Michael Brohl 49c1a38107 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.widget.
(OFBIZ-9724)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817571 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 21:19:32 +00:00
Michael Brohl 6ff220a8ec Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.entity.datasource.
(OFBIZ-9723)

Did some additional cleanup by removing commented out code.

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817570 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 21:13:26 +00:00
Michael Brohl a5947f39ed Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.util.test.
(OFBIZ-9722)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817568 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 21:05:00 +00:00
Michael Brohl 1f2d67a35f Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.entityext.data.
(OFBIZ-9721)

The changes for EntityDataLoadContainer had to be applied manually 
because of changes made in between.

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817566 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 21:02:21 +00:00
Michael Brohl f56feb90fa Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.entity.util.
(OFBIZ-9720)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817562 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 20:49:28 +00:00
Michael Brohl 4af8b2491d Improved: removed unnecessary condition check.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817561 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 20:48:14 +00:00
Michael Brohl a72f027892 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.entity.model.
(OFBIZ-9719)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817559 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 20:18:41 +00:00
Michael Brohl c02d9de3ab Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.entity.connection.
(OFBIZ-9718)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817552 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 19:44:27 +00:00
Michael Brohl 29d09d0cd5 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.entity.config.model.
(OFBIZ-9717)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817550 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 19:38:12 +00:00
Jacques Le Roux cac7d76cba Implemented: Handle service response effectively
(OFBIZ-9981)
Included Debug.logError in ServiceUtil.returnProblem so that in case of any 
error occurred and handled, it will always be logged on the console.
jleroux: I put a toString() there, Debug.logError() does not work with maps

Also no functional change (better code) in QRCodeEvents
jleroux: I also replaced tabs by spaces there 
            and put debug info in exceptions

Thanks: Suraj Khurana

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817455 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 05:04:23 +00:00
Jacques Le Roux cc50483f1d Implemented: Add logVerbose to GroovyBaseScript.groovy
(OFBIZ-10025)

Thanks: Dennis Balkir 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817454 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 04:49:03 +00:00
Jacques Le Roux cd94e1167c Documented: Document how the thread-pool max-threads works
(OFBIZ-10002)

Minimalist documentation with reference to stackoverflow itself referencing
Brian Goetz's and co's "Java Concurrency in Practice" after discussion at 
http://markmail.org/message/ksutqpuyyd4kmbl2


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817040 13f79535-47bb-0310-9956-ffa450edef68
2017-12-03 16:16:24 +00:00
Jacques Le Roux 8021fd3717 Improved: Upgrade Jquery 1.11.0 to JQuery 3.2.1
(OFBIZ-9978)

Includes following changes
jQuery UI upgraded to 1.12.1
Included CSS files to theme properties and screens.

Manually added datepicker-en.js and datepicker-it-CH.js a new candidate added 
it to jsLanguageFilesMapping
Updated defaultDateTime path of dateTime picker it was having path of 
timepicker files.

I18n files for datepicker renamed from jquery.ui.datepicker- to datepicker- 
as comes with the JQuery ui package so that we don’t have to rename files 
manually everytime we upgrade.
https://github.com/jquery/jquery-ui/tree/master/ui/i18n
Can’t get jquery-ui-i18n.js file though it was not used either.

I have not updated jQuery.cookie-1.4.0.js as it is related to jstree and we will 
update & move it when we will update jstree.

Jeditable 1.7.2 upgraded to 1.7.3

I feel JQuery ui should also be in plugins folder with other JQuery plugin

Thanks: Aditya

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817026 13f79535-47bb-0310-9956-ffa450edef68
2017-12-03 10:15:55 +00:00
Michael Brohl 86da261be5 Improved: Update build.gradle to the latest dependencies.
(OFBIZ-10026)

This is the first pass updating all possible dependencies. Apache Tomcat
is updated to the latest 8.5.24 version.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816968 13f79535-47bb-0310-9956-ffa450edef68
2017-12-02 17:27:31 +00:00
Jacques Le Roux 04f84bac79 Improved: Make the general.SystemPropertyValue same than the related property
in general properties
(OFBIZ-9924)

only VISUAL_THEME value was concerned

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816899 13f79535-47bb-0310-9956-ffa450edef68
2017-12-01 19:10:00 +00:00
Jacques Le Roux 95b17d4d23 Improved: The main logo in screen upper part shows distorted
(OFBIZ-9990)

Fixes this issue in Tomahawk and Flat Grey themes by using ofbiz_logo.png, 
instead of the old logo deprecated ofbiz_logo.gif 

While at it use the same logo everywhere it's possible. It was needed for links 
to http://ofbiz.apache.org/images/ofbiz_logo.gif which no longer exists 
(actually seems only used for tests so could stay like that but better not refer 
to it anyway)

Also use this logo for Bluelight theme where it fits. 

It could not be used in Rainbow themes because they are using a Scalable Vector 
Graphics file (ofbiz-white.svg) that can't be replaced by the new png logo file
BTW this file still uses a TM symbol instead of a ®

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816897 13f79535-47bb-0310-9956-ffa450edef68
2017-12-01 18:45:50 +00:00
Jacques Le Roux 796d098e67 Fixed: Replace org.apache.commons.lang.StringEscapeUtils.unescapeHtml() method
by org.jsoup.parser.Parser.unescapeEntities()
(OFBIZ-10023)

StringEscapeUtils.unescapeHtml() is deprecated or at least not reliable

After few tests using the Parser.unescapeEntities() strict mode seems OK


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816461 13f79535-47bb-0310-9956-ffa450edef68
2017-11-27 15:19:47 +00:00
Nicolas Malin d5898e6401 Implemented: improve makeValue in groovy DSL to load directly with a map (OFBIZ-10020)
When you create a GenericValue with groovy, you need to initial it with makeValue and after set all fields.
***
GenericValue product = makeValue('Product')
product.internalName = parameters.internalName
***

I simplified this dsl with an automatic parameters check so you can directly write :
***
GenericValue product = makeValue('Product', parameters)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816437 13f79535-47bb-0310-9956-ffa450edef68
2017-11-27 11:38:24 +00:00
Jacques Le Roux b7127e1ed2 Improved: Upgrade Jquery 1.11.0 to JQuery 3.2.1
(OFBIZ-9978)

Upgrades jQuery Timepicker Addon to 1.6.3 
https://github.com/trentrichardson/jQuery-Timepicker-Addon/
 jQuery UI Slider Access comes with JQuery Timepicker addon package.
 Moved localization to i18n (as comes with package) & made changes accordingly
 Working well with even jQuery UI 1.10.

Steps to verify:
https://localhost:8443/ordermgr/control/ListQuoteRoles?quoteId=CQ0001
https://localhost:8443/example/control/FormWidgetExamples
https://localhost:8443/catalog/control/EditProduct

Interestingly it supports Millisecond, Microsecond and Time Zone too.

jleroux: as required with such changes I ran the createJsLanguageFileMapping 
service to create or update the JsLanguageFilesMapping class content (this is
documented in JsLanguageFileMappingCreator class
We got some new ones:
-fa.js
-lv.js
-mk.js
-sl.js
-sq.js
but lost CZ (not quite sure about that one, I vaguely remember something we
discussed with Aditya )

Thanks: Aditya 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816377 13f79535-47bb-0310-9956-ffa450edef68
2017-11-26 10:18:36 +00:00
Nicolas Malin faadb7dca4 Fixed: forget to add the class GroovyScriptTestCase.java ans the simple groovy test-suite in the previous commit related to issue OFBIZ-9996
Correct introduced typo in framework/testtools/dtd/test-suite.xsd

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816345 13f79535-47bb-0310-9956-ffa450edef68
2017-11-25 20:05:29 +00:00
Nicolas Malin 48f90d5b74 Implemented: Implement Groovy test in testtools (OFBIZ-9996)
With the minilang deprecation and the migration to groovy, I implemented on the ofbiz testtools the possibility to use groovy for write new integration test or convert current simple xml test.
Now you can define a new element as child of test-group on your xml test-suite file like
        <groovy-test-suite name=simple location=component://base/groovyScript/test/SimpleTests.groovy/>

To Write your test, you need to create a Groovy class that extends GroovyScriptTestCase class :
    import org.apache.ofbiz.testtools.GroovyScriptTestCase
    class BaseTest extends GroovyScriptTestCase {
        void testTrue() {
            assert 1, 1
        }
    }
All your function will execute as TestCase.

For more information on groovy specific testing language see http://groovy-lang.org/testing.html

At this time the OFBiz Groovy DSL isn't supported to write groovy test case but you have access to the delegator and the disphatcher as native class variable.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816335 13f79535-47bb-0310-9956-ffa450edef68
2017-11-25 17:35:20 +00:00
Jacques Le Roux ffa5438ff8 Improved: Replace request-redirect w/ no redirect-param attribute by
request-redirect-no-param
(OFBIZ-9997)

Not sure why this one missed in r1816183 (looks like it was reverted)



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816188 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 19:41:01 +00:00
Jacques Le Roux 17d7246e06 Improved: Replace request-redirect w/ no redirect-param attribute by
request-redirect-no-param
(OFBIZ-9997)

There was a typo in r1816180 , this fixes it and adds plugins part



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816183 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 18:42:23 +00:00
Jacques Le Roux dfc7fb084a Improved: Replace request-redirect w/ no redirect-param attribute by
request-redirect-no-param
(OFBIZ-9997)

This follows the discussion at http://markmail.org/message/sbfdlhntdzziqeyz



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816180 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 18:21:51 +00:00
Jacques Le Roux 14ea2a64eb After OFBIZ-9537, OFBIZ-9653, OFBIZ-9914 use Deepak's suggestion at
http://markmail.org/message/fnanwil63wogsfqc to update the documentation

We need now to check that the request-redirect which use no 
redirect-param attribute are doing what they are supposed to do...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816167 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 16:13:43 +00:00
Jacques Le Roux c1a11e83ae Fixed: Fix Default or Empty Catch block in Java and Groovy files
(OFBIZ-8341)

While reviewing r1812057 I spotted a bunch of swallowed ClassCastExceptions

I then reviewed all ClassCastExceptions and this fixes all of them with a 
minimal logging

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1815797 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 12:32:44 +00:00
Jacques Le Roux 3933ba15c0 No functional change, fixes typos and formatting
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1815774 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 07:34:07 +00:00
Jacques Le Roux 212a9c2a4e No functional change, simpler code is best
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1815302 13f79535-47bb-0310-9956-ffa450edef68
2017-11-15 10:54:28 +00:00
Jacques Le Roux 34dbb04abd Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.start.
(OFBIZ-9573)

No functional change, while reviewing r1811413
I noticed we can use a try-with-ress here

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1815119 13f79535-47bb-0310-9956-ffa450edef68
2017-11-13 17:06:24 +00:00
Deepak Dixit e8079f171d Improved: Use FlexibleLocation.resolveLocation to resolve the fop.path and fop.font.base.url (OFBIZ-9974)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814708 13f79535-47bb-0310-9956-ffa450edef68
2017-11-09 08:25:36 +00:00
Deepak Dixit 7976ea3ff3 Reverted: At r#1814155 RuntimeException was added to handle runtime exception as per pattern/best practise, but to maintain backward compatibility we need to handle Exception instead of throwing it.
Reason: When the field is encrypted with the old algorithm (3-DES), the new Shiro code will fail to decrypt it (using AES) and then it will
throw an org.apache.shiro.crypto.CryptoException that is a RuntimeException.
For backward compatibility we want instead to catch the exception and decrypt the code using the old algorithm.
This has been discussed at https://s.apache.org/b520

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814704 13f79535-47bb-0310-9956-ffa450edef68
2017-11-09 05:45:47 +00:00
Deepak Dixit 4577532666 Reverted: Unwanted changes from url.properties done at r#1345849, this commit was reverted in r#1446913, but url.properties changes missed during revert.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814703 13f79535-47bb-0310-9956-ffa450edef68
2017-11-09 05:18:26 +00:00
Jacques Le Roux 5b311d6be2 Fixed: EntityListIterator.getComplateList returns error randomly
(OFBIZ-9919)
Using a dynamic view entity containing groupBy clause and after calling 
getCompleteList method, I am getting an error and it got fixed when I removed 
that ArrayList sizing.
IMO, it might be occurring due to improper size initialization and I see no 
reason for this and it is handled in ArrayList dynamically.

jleroux: moreover there is not much gain for cases where the pre-allocation
makes sense

Thanks: Suraj Khurana

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814561 13f79535-47bb-0310-9956-ffa450edef68
2017-11-08 09:17:41 +00:00
Jacques Le Roux a1c52626e1 Implemented: Token Based Authentication
(OFBIZ-9833)

Update the comments about ExternalServerJwtMasterSecretKey

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814467 13f79535-47bb-0310-9956-ffa450edef68
2017-11-07 08:58:16 +00:00
Jacques Le Roux 88d1dc8008 Implemented: Token Based Authentication
(OFBIZ-9833)

Comment about production server

I thought it was obvious that you should not keep this file on a production
server after having changed the default value of 
ExternalServerJwtMasterSecretKey

Moreover we recommend to have the value of ExternalServerJwtMasterSecretKey 
dynamically generated during each build to increase security

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814402 13f79535-47bb-0310-9956-ffa450edef68
2017-11-06 12:41:33 +00:00
Jacques Le Roux 0d0badf38e Implemented: Token Based Authentication
(OFBIZ-9833)

I have tested the Token Based Authentication between my local machine and the 
trunk demo. It works as expected.

This completes the previous commit by:
  adding a new externalServerLoginCheck pre processor
  Documenting how to set the ExternalServerJwtMasterSecretKey in production
    using sed and uuidgen
  Adding documenting properties in security.properties, not set to be used OOTB
   but ready to be set in production

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814363 13f79535-47bb-0310-9956-ffa450edef68
2017-11-05 17:33:30 +00:00
Jacques Le Roux 8289e03096 Fixed: Secure the login.secret_key_string
(OFBIZ-9966)

When OFBIZ-4983 was implemented I missed that we put the login.secret_key_string
 as a property in security properties. This should not have been because it 
eases attackers work.

The recommended way is to have it as a private static final String that can be 
changed just when compiling using sed and uuidgen. So then the key is temporay 
and final and it gets quite harder for a possible attacker to use this mean.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814349 13f79535-47bb-0310-9956-ffa450edef68
2017-11-05 11:28:42 +00:00
Jacques Le Roux 77be02222b Reverts, this slipped in inadvertently with r1814292
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814348 13f79535-47bb-0310-9956-ffa450edef68
2017-11-05 11:07:50 +00:00
Michael Brohl 4a698b614b Improved: Remove deprecated method
GenericDelegator.decryptFieldValue(String, String).
(OFBIZ-9916)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814327 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 22:23:20 +00:00
Michael Brohl 002fe23568 Fixed: UtilMisc.ensureLocale does not always return a valid Locale.
(OFBIZ-9964)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814319 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 19:38:12 +00:00
Jacques Le Roux 8693fb0bdc Improved: Replace Inline Javascript with External Javascript
(OFBIZ-9465)

As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m 
inline javascript for various macros like renderLookupField, makeHyperlinkString,
shortDateInput etc in HtmlFormMacroLibrary.ftl should be replaced with a generic 
code written as external javascript. Generic Javascript code should be written 
in OfbizUtil.js and appropriate classes or identifiers should be used for 
applying that. Any additional data can be passed with HTML 5 custom data attribute 
(https://www.w3.org/TR/2011/WD-html5-20110525/elements.html
#embedding-custom-non-visible-data-with-the-data-attributes).


Deepak: I think we can use data-mask attribute to recognize the element instead 
of adding class. 

jeloux: I noticed a MaskFieldExampleForm was introduced with r1804027 but
not used in FormWidgetExampleScreens.xml so was not visible


Thanks: Aditya and Deepak


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814292 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 14:06:56 +00:00
Michael Brohl 4dd29160eb Improved: make utility function findWebsite public to be usable from
outside. This matches the pattern from other worker classes like 
PartyWorker.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814279 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 11:50:07 +00:00
Michael Brohl fb12f1fb4d Fixed: Corrected wrong FindBugs/refactoring change introduced in
r1813640.
(OFBIZ-9716)

Thanks Suraj Khurana for reporting and Dennis Balkir for providing the
patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814230 13f79535-47bb-0310-9956-ffa450edef68
2017-11-03 17:47:41 +00:00
Deepak Dixit ae6440d8c1 Improved: Added toString() method in ServiceEcaAction class file
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814161 13f79535-47bb-0310-9956-ffa450edef68
2017-11-03 10:31:06 +00:00
Deepak Dixit aae3cebccc Improved: Add ability to disable entity eca rule (OFBIZ-9897)
We have enabled flag in EntityEcaRule class, if its set false then entity eca rule will not be execute.
But there is not way to disable entity eca.

We can add enabled flag in Entity ECA definition to disable the existing entity eca rule.

    Add new attribute on entity eca tag named enabled
    Default value will be true for this.
    If user want to disable existing OOTB entity eca rule, then user can define same rule in custom component and set the enabled=false

Also as per current flow if same seca rule is define more then once, system will execute all the rule, ideally it should not execute same rule (same rule, condition and action) if its defined more than one.

Also need to ovride hasCode, equals and toString method for EntityEcaRule, EntityEcaAction and EntityEcaCondition class file.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814160 13f79535-47bb-0310-9956-ffa450edef68
2017-11-03 10:28:05 +00:00
Jacques Le Roux 4785a20bb5 No functional change, completes r1813964 as suggested on dev ML
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814155 13f79535-47bb-0310-9956-ffa450edef68
2017-11-03 09:49:21 +00:00
Jacques Le Roux a0e85e028a Fixed: Error on first access to Online Help
(OFBIZ-9925)

There are maybe better fixes but adding a default theme when it's null works

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814116 13f79535-47bb-0310-9956-ffa450edef68
2017-11-02 21:58:37 +00:00
Deepak Dixit 1738e721b8 Fixed: doDecrypt method may return ClassNotFoundException, BadPaddingException,so instead of handling GeneralException used Exception class to handle all exception
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1813964 13f79535-47bb-0310-9956-ffa450edef68
2017-11-01 10:43:14 +00:00