org.apache.ofbiz.entity.datasource.
(OFBIZ-9723)
Did some additional cleanup by removing commented out code.
Thanks Julian Leichert for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817570 13f79535-47bb-0310-9956-ffa450edef68
org.apache.ofbiz.entityext.data.
(OFBIZ-9721)
The changes for EntityDataLoadContainer had to be applied manually
because of changes made in between.
Thanks Julian Leichert for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817566 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9981)
Included Debug.logError in ServiceUtil.returnProblem so that in case of any
error occurred and handled, it will always be logged on the console.
jleroux: I put a toString() there, Debug.logError() does not work with maps
Also no functional change (better code) in QRCodeEvents
jleroux: I also replaced tabs by spaces there
and put debug info in exceptions
Thanks: Suraj Khurana
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817455 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9978)
Includes following changes
jQuery UI upgraded to 1.12.1
Included CSS files to theme properties and screens.
Manually added datepicker-en.js and datepicker-it-CH.js a new candidate added
it to jsLanguageFilesMapping
Updated defaultDateTime path of dateTime picker it was having path of
timepicker files.
I18n files for datepicker renamed from jquery.ui.datepicker- to datepicker-
as comes with the JQuery ui package so that we don’t have to rename files
manually everytime we upgrade.
https://github.com/jquery/jquery-ui/tree/master/ui/i18n
Can’t get jquery-ui-i18n.js file though it was not used either.
I have not updated jQuery.cookie-1.4.0.js as it is related to jstree and we will
update & move it when we will update jstree.
Jeditable 1.7.2 upgraded to 1.7.3
I feel JQuery ui should also be in plugins folder with other JQuery plugin
Thanks: Aditya
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817026 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9990)
Fixes this issue in Tomahawk and Flat Grey themes by using ofbiz_logo.png,
instead of the old logo deprecated ofbiz_logo.gif
While at it use the same logo everywhere it's possible. It was needed for links
to http://ofbiz.apache.org/images/ofbiz_logo.gif which no longer exists
(actually seems only used for tests so could stay like that but better not refer
to it anyway)
Also use this logo for Bluelight theme where it fits.
It could not be used in Rainbow themes because they are using a Scalable Vector
Graphics file (ofbiz-white.svg) that can't be replaced by the new png logo file
BTW this file still uses a TM symbol instead of a ®
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816897 13f79535-47bb-0310-9956-ffa450edef68
by org.jsoup.parser.Parser.unescapeEntities()
(OFBIZ-10023)
StringEscapeUtils.unescapeHtml() is deprecated or at least not reliable
After few tests using the Parser.unescapeEntities() strict mode seems OK
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816461 13f79535-47bb-0310-9956-ffa450edef68
When you create a GenericValue with groovy, you need to initial it with makeValue and after set all fields.
***
GenericValue product = makeValue('Product')
product.internalName = parameters.internalName
***
I simplified this dsl with an automatic parameters check so you can directly write :
***
GenericValue product = makeValue('Product', parameters)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816437 13f79535-47bb-0310-9956-ffa450edef68
With the minilang deprecation and the migration to groovy, I implemented on the ofbiz testtools the possibility to use groovy for write new integration test or convert current simple xml test.
Now you can define a new element as child of test-group on your xml test-suite file like
<groovy-test-suite name=simple location=component://base/groovyScript/test/SimpleTests.groovy/>
To Write your test, you need to create a Groovy class that extends GroovyScriptTestCase class :
import org.apache.ofbiz.testtools.GroovyScriptTestCase
class BaseTest extends GroovyScriptTestCase {
void testTrue() {
assert 1, 1
}
}
All your function will execute as TestCase.
For more information on groovy specific testing language see http://groovy-lang.org/testing.html
At this time the OFBiz Groovy DSL isn't supported to write groovy test case but you have access to the delegator and the disphatcher as native class variable.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816335 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8341)
While reviewing r1812057 I spotted a bunch of swallowed ClassCastExceptions
I then reviewed all ClassCastExceptions and this fixes all of them with a
minimal logging
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1815797 13f79535-47bb-0310-9956-ffa450edef68
Reason: When the field is encrypted with the old algorithm (3-DES), the new Shiro code will fail to decrypt it (using AES) and then it will
throw an org.apache.shiro.crypto.CryptoException that is a RuntimeException.
For backward compatibility we want instead to catch the exception and decrypt the code using the old algorithm.
This has been discussed at https://s.apache.org/b520
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814704 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9919)
Using a dynamic view entity containing groupBy clause and after calling
getCompleteList method, I am getting an error and it got fixed when I removed
that ArrayList sizing.
IMO, it might be occurring due to improper size initialization and I see no
reason for this and it is handled in ArrayList dynamically.
jleroux: moreover there is not much gain for cases where the pre-allocation
makes sense
Thanks: Suraj Khurana
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814561 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9833)
Comment about production server
I thought it was obvious that you should not keep this file on a production
server after having changed the default value of
ExternalServerJwtMasterSecretKey
Moreover we recommend to have the value of ExternalServerJwtMasterSecretKey
dynamically generated during each build to increase security
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814402 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9833)
I have tested the Token Based Authentication between my local machine and the
trunk demo. It works as expected.
This completes the previous commit by:
adding a new externalServerLoginCheck pre processor
Documenting how to set the ExternalServerJwtMasterSecretKey in production
using sed and uuidgen
Adding documenting properties in security.properties, not set to be used OOTB
but ready to be set in production
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814363 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9966)
When OFBIZ-4983 was implemented I missed that we put the login.secret_key_string
as a property in security properties. This should not have been because it
eases attackers work.
The recommended way is to have it as a private static final String that can be
changed just when compiling using sed and uuidgen. So then the key is temporay
and final and it gets quite harder for a possible attacker to use this mean.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814349 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9465)
As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m
inline javascript for various macros like renderLookupField, makeHyperlinkString,
shortDateInput etc in HtmlFormMacroLibrary.ftl should be replaced with a generic
code written as external javascript. Generic Javascript code should be written
in OfbizUtil.js and appropriate classes or identifiers should be used for
applying that. Any additional data can be passed with HTML 5 custom data attribute
(https://www.w3.org/TR/2011/WD-html5-20110525/elements.html
#embedding-custom-non-visible-data-with-the-data-attributes).
Deepak: I think we can use data-mask attribute to recognize the element instead
of adding class.
jeloux: I noticed a MaskFieldExampleForm was introduced with r1804027 but
not used in FormWidgetExampleScreens.xml so was not visible
Thanks: Aditya and Deepak
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814292 13f79535-47bb-0310-9956-ffa450edef68
We have enabled flag in EntityEcaRule class, if its set false then entity eca rule will not be execute.
But there is not way to disable entity eca.
We can add enabled flag in Entity ECA definition to disable the existing entity eca rule.
Add new attribute on entity eca tag named enabled
Default value will be true for this.
If user want to disable existing OOTB entity eca rule, then user can define same rule in custom component and set the enabled=false
Also as per current flow if same seca rule is define more then once, system will execute all the rule, ideally it should not execute same rule (same rule, condition and action) if its defined more than one.
Also need to ovride hasCode, equals and toString method for EntityEcaRule, EntityEcaAction and EntityEcaCondition class file.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814160 13f79535-47bb-0310-9956-ffa450edef68