Commit Graph
10472 Commits
Author SHA1 Message Date
Rishi Solanki bc4a0cbfc3 Improved: Remove Entity suffix from title of all entities. In all EntityModel.xml files, title should not contain Entity as suffix.
(OFBIZ-10408)
Thanks to Suraj Khurana for reporting the improvement and providing fix for that.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832235 13f79535-47bb-0310-9956-ffa450edef68
2018-05-25 12:19:07 +00:00
Jacques Le Roux fc8348f410 Improved: Refactor JavaEventHandler class
(OFBIZ-10410)

Instead of relying on manual synchronisation, use a concurrent map for caching 
loaded classes.  
Inline private `invoke` delegate which intent was fuzzy.  
Spread arguments when calling `Method::invoke` and `Class::getMethod`.

jleroux: interesting, it's the 1st use in OFBiz of the "::" syntax for calling
methods
(cf. https://docs.oracle.com/javase/specs/jls/se8/html/jls-15.html#jls-15.13-500)
I note that the string "::" is used in many places as a separator, notably
in caches, as  cache key separator but this should not be confusing.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832199 13f79535-47bb-0310-9956-ffa450edef68
2018-05-24 20:42:19 +00:00
Jacques Le Roux affc8a17cc Improved: Remove UtilValidate::isEmpty(String) method
(OFBIZ-10412)

UtilValidate class contains a `isEmpty` method both for `CharSequence` and for 
`String` types but since the first is an interface for the other and that the 
implementation are the same we don't need to keep the one for the concrete type.

Additionnaly I have removed the unused Generic type for the remaining 
implementation.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832170 13f79535-47bb-0310-9956-ffa450edef68
2018-05-24 13:36:08 +00:00
Jacques Le Roux 1840297cac Improved: Secure HTTP headers
(OFBIZ-6766)

After reading https://www.fastly.com/blog/headers-we-dont-want and more in the
Jira, only improves UtilHttp.setResponseBrowserProxyNoCache() by adding 
Cache-Control:private to avoid caching in proxy.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832128 13f79535-47bb-0310-9956-ffa450edef68
2018-05-23 20:53:45 +00:00
Jacques Le Roux 257dd146a4 Improved: XML schemas should use predefined boolean type
(OFBIZ-10411)

To define boolean values, some ad-hoc enumeration of "true" and "false" are 
repeatedly used.  Since XML Schema defines a standard boolean datatype 
better to use it. 

For now only `site-conf.xsd` is fixed 

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831930 13f79535-47bb-0310-9956-ffa450edef68
2018-05-20 10:19:29 +00:00
Gil Portenseigne 9fbb3765e4 Implemented : File transfer management with communicationEvent and new contactMech FTP_ADDRESS
(OFBIZ-10245)

This commit introduce a new way to manage file transfer in OFBiz.
Inspired by mailing communication event management, a new communicationEventTypeId is created ('FILE_TRANSFER_COMM').

Such commEvent with classics : partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job (like sendEmailDated), to send associated contents to a configured FTP/SFTP/FTPS server. If failure happens, it is catched and stored in communicationEvent, waiting for a new try.

For this purpose :

A new contactMechTypeId is introduced (FtpAddress), with its corresponding table. This contactMech store needed information for basic user/password authentication (server url and protocol, port, username, password, etc.)
A new service sendFileTransferDated that will look for pending file transfer and call following service.
A new service sendCommEventAsFtp that take a selected commEvent, check its structure and manage its status after trying the associated content file transfers.
A new service sendContentToFtp, that take a content and transfer it to a given FtpAddress.
A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural content file transfer, creating children communicationEvent to follow each content transfer separately (only for several content transfers).
A new Interface FtpClientInterface, with the 3 implementations of FTP, FTPS (To Implement), SFTP clients to manage Ftp connection and transfer.
A new property file to enable and manage redirection for testing purpose.

With this implementation, creating a communicationEvent, with a FtpAddress contactMechIdTo, and sendFileTransferDated job planned, the file is transfered to the ftp : communication event status set to COM_COMPLETE, if error occured the communication event status is set to COM_BOUNCED with error message on communicationEvent note.

Thanks Rishi for your feedbacks

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831867 13f79535-47bb-0310-9956-ffa450edef68
2018-05-18 15:53:35 +00:00
Michael Brohl 9341c23b0f Reverted: Undo remove of test files in r1831567
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831846 13f79535-47bb-0310-9956-ffa450edef68
2018-05-18 10:48:44 +00:00
Jacques Le Roux 62fce8c184 Fixed:: Dynamic values not rendering properly in property tag of fail-property
attribute
(OFBIZ-10406)

While calling checkProductRelatedPermission, if permission is failed ten 
fail-property tag uses ${checkActionLabel} which is not handled properly in 
MessageElement.java.
There are 2-3 other occurrences as well of such type but not in working 
condition.

Thanks: Suraj

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831831 13f79535-47bb-0310-9956-ffa450edef68
2018-05-18 08:11:55 +00:00
Gil Portenseigne a71f88b1ad Fixed : change OFBiz always log level to OFF log4j level, instead of using FATAL log4j level
(OFBIZ-6206)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831788 13f79535-47bb-0310-9956-ffa450edef68
2018-05-17 15:02:03 +00:00
Michael Brohl 5c547ae60e Fixed: Removed unnecessary class and folders.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831567 13f79535-47bb-0310-9956-ffa450edef68
2018-05-14 13:34:03 +00:00
Jacques Le Roux a5a90ab1dc Fixed: The "request" attribute type of the userLogin service is wrong
(OFBIZ-10304)

Now that we use Tomcat 9 this problem is over

Thanks: Jacopo for upgrading to Tomcat 9 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831078 13f79535-47bb-0310-9956-ffa450edef68
2018-05-07 07:48:57 +00:00
Jacopo Cappellato 59f97f6549 Implemented: Upgraded to latest Tomcat (9.0.7).
(OFBIZ-10036)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831074 13f79535-47bb-0310-9956-ffa450edef68
2018-05-07 06:41:47 +00:00
Jacques Le Roux 1848294a22 Documented: New documentation for EntitySync
(OFBIZ-10390)

Adds the PDF generation information for stand alone document

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831017 13f79535-47bb-0310-9956-ffa450edef68
2018-05-06 07:20:56 +00:00
Jacques Le Roux 1129ac14c7 Documented: New documentation for EntitySync
(OFBIZ-10390)

The current EntitySync documentation in wiki is POS oriented so somehow 
deprecated.
I have recently worked on a project with EntitySync and collected as much 
possible information. 
I also got David E. Jones's agreement to reuse the part on EntitySync in his 
2006 "Apache OFBiz Advanced Framework - Training Video Transcription" document.

So this is a new replacing asciidoc document, it's a WIP...

Thanks: David for agreement on reusing his doc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830972 13f79535-47bb-0310-9956-ffa450edef68
2018-05-05 13:13:58 +00:00
Deepak Dixit d358bc4471 Improved: Added missing condition-service in entity-eca.xsd file
(OFBIZ-10220)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830960 13f79535-47bb-0310-9956-ffa450edef68
2018-05-05 10:45:00 +00:00
Deepak Dixit 645e6e1c47 Fixed: Fix typo 'paramters' => 'parameters'
(OFBIZ-10394)
Thanks Mathieu Lirzin for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830936 13f79535-47bb-0310-9956-ffa450edef68
2018-05-04 19:34:07 +00:00
Jacques Le Roux e551e6cf8d Improved: Generalize toMap to abitrary key types
(OFBIZ-10354)

The `toMap` static method doesn't use its 'K' generic type in its implementation

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830588 13f79535-47bb-0310-9956-ffa450edef68
2018-04-30 13:30:35 +00:00
Rishi Solanki cfef87d6f1 Improved: Remove empty field values from xml data files so that it will not override existing data with empty values. Removed all empty data fields from data files.
(OFBIZ-10282)
Thanks to Arun Patidar for reporting and review.
Thanks to Suraj Khurana for providing patch for the improvement.
Thanks to Jacques for discussion and finalizing the work.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830545 13f79535-47bb-0310-9956-ffa450edef68
2018-04-30 10:52:55 +00:00
Nicolas Malin 8e2d65f4d6 Fixed: ConfigXMLReader - Events are not executed in the order defined
(OFBIZ-10369)
The events contained in the controller configuration for first-visit, pre-post processor and before-after login are executed in arbitrary order rather than the defined order.
If we define an event configuration as follow:

    <after-login>
        <event name=keepCartUpdated type=java path=org.apache.ofbiz.order.shoppingcart.ShoppingCartEvents invoke=keepCartUpdated/>
        <event name=restoreAutoSaveList type=java path=org.apache.ofbiz.order.shoppinglist.ShoppingListEvents invoke=restoreAutoSaveList/>
        <event name=saveCartToAutoSaveList type=java path=org.apache.ofbiz.order.shoppinglist.ShoppingListEvents invoke=saveCartToAutoSaveList/>
    </after-login>

We wait that OFBIz run keepCartUpdated, restoreAutoSaveList and after saveCartToAutoSaveList event but the HashMap who organise them return arbitrary order and can return saveCartToAutoSaveList, keepCartUpdated and restoreAutoSaveList. Convert the HashMap to LinkedHashMap help to keep the loaded order.

Thanks to Vikas Mayur for solve this issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830303 13f79535-47bb-0310-9956-ffa450edef68
2018-04-27 07:26:58 +00:00
Nicolas Malin b48d0cadc5 revert revision 1830301 that contains mix improvement, i will recommit them correclty
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830302 13f79535-47bb-0310-9956-ffa450edef68
2018-04-27 07:26:33 +00:00
Nicolas Malin 2695743cae Fixed: ConfigXMLReader - Events are not executed in the order defined
(OFBIZ-10369)
The events contained in the controller configuration for first-visit, pre-post processor and before-after login are executed in arbitrary order rather than the defined order.
If we define an event configuration as follow:

    <after-login>
        <event name=keepCartUpdated type=java path=org.apache.ofbiz.order.shoppingcart.ShoppingCartEvents invoke=keepCartUpdated/>
        <event name=restoreAutoSaveList type=java path=org.apache.ofbiz.order.shoppinglist.ShoppingListEvents invoke=restoreAutoSaveList/>
        <event name=saveCartToAutoSaveList type=java path=org.apache.ofbiz.order.shoppinglist.ShoppingListEvents invoke=saveCartToAutoSaveList/>
    </after-login>

We wait that OFBIz run keepCartUpdated, restoreAutoSaveList and after saveCartToAutoSaveList event but the HashMap who organise them return arbitrary order and can return saveCartToAutoSaveList, keepCartUpdated and restoreAutoSaveList. Convert the HashMap to LinkedHashMap help to keep the loaded order.

Thanks to Vikas Mayur for solve this issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830301 13f79535-47bb-0310-9956-ffa450edef68
2018-04-27 07:21:47 +00:00
Gil Portenseigne d046d17f35 Reverted : Add a link onto a crashed Job to reset it
(OFBIZ-10371)

Thanks Scott for the review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830294 13f79535-47bb-0310-9956-ffa450edef68
2018-04-27 05:55:43 +00:00
Gil Portenseigne bed2be5f53 Improved: Change the display condition on the added link
(OFBIZ-10371)

This way to write the condition is easier for the eye, thanks Nicolas for the suggestion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830238 13f79535-47bb-0310-9956-ffa450edef68
2018-04-26 15:45:31 +00:00
Gil Portenseigne ea020fe32a Implemented: Add a link onto a crashed Job to reset it
(OFBIZ-10371)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830236 13f79535-47bb-0310-9956-ffa450edef68
2018-04-26 15:27:50 +00:00
Deepak Dixit 1e70d74d55 Fixed: Typo done at r#1829690
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1829691 13f79535-47bb-0310-9956-ffa450edef68
2018-04-21 05:26:17 +00:00
Deepak Dixit 676a92959b Improved: Update Currency UOM data as per iso amendment 164, 165 and 166
(OFBIZ-10364)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1829690 13f79535-47bb-0310-9956-ffa450edef68
2018-04-21 05:22:19 +00:00
Jacques Le Roux 9e41a4a174 Improved: EntityUtilProperties
(OFBIZ-7112)

Remove useless redundant code.

results map is already initialised in the beginning with isExistInDb 
as "N" and value as "".
These values only changed when systemProperty != null. S
o except for this condition if we return results at any point it will have 
isExistInDb as "N" and value as "". 
If we remove the lines I removed in the patch, it will only remove put 
operations that are not necessary.

Thanks: Aditya

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1828217 13f79535-47bb-0310-9956-ffa450edef68
2018-04-03 10:51:29 +00:00
Julien Nicolas ba3d988d2d Improved: open the SQL screen straight to ofbiz instead of tenant
OFBIZ-10323

Just define the default selected id in the dropdown list

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1828071 13f79535-47bb-0310-9956-ffa450edef68
2018-03-30 16:01:26 +00:00
Gil Portenseigne 78bf31c937 Fixed: Convert README.md to README.adoc.
(OFBIZ-10272)

Complete Jacques Fix, replacing all README.md occurence with README.adoc.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1827470 13f79535-47bb-0310-9956-ffa450edef68
2018-03-22 08:54:00 +00:00
Jacques Le Roux 6813d5d2b1 Fixed: Convert README.md to README.adoc.
(OFBIZ-10272)

Not sure why it went unnoticed so long, but by removing README.md 
(replacing README.adoc) r1827046 brokes testZipReadme

Not a big deal, we can just replace the file in the test (from README.md to 
README.adoc). We could chose a more sure to remain file, but I guess that now we 
are going with asciidoc and README.adoc should stay

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1827457 13f79535-47bb-0310-9956-ffa450edef68
2018-03-22 05:30:39 +00:00
Jacques Le Roux 0d919a3774 Fixed: Token Based Authentication
(OFBIZ-9833)

Reverts change in ContextFilter.java committed with 1813679, was wrong

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1827441 13f79535-47bb-0310-9956-ffa450edef68
2018-03-21 20:59:49 +00:00
Jacques Le Roux 58ad9fd42d Fixed: The "request" attribute type of the userLogin service is wrong
(OFBIZ-10304)

It should have been org.apache.catalina.connector.RequestFacade"
instead of javax.servlet.http.HttpServletRequest see the Jira for details

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1827439 13f79535-47bb-0310-9956-ffa450edef68
2018-03-21 20:53:41 +00:00
Jacques Le Roux 7ff43dd657 Improved: no functional change, fixes a format issue in LoginWorker
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1827407 13f79535-47bb-0310-9956-ffa450edef68
2018-03-21 12:30:21 +00:00
Nicolas Malin 73bd798dda Fixed: HttpClient failed to return the error result
(OFBIZ-10281)

When you call the HttpClient on Rest API on url that return you an error, the HttpClient failed to give you the error stream:
    callResult = restClient.getStream();

If the flow is an error in the catch block with the line 
    in = con.getInputStream();
that return a FileNotFoundException

To solve if, if the connexion is an instance of HttpURLConnection we resolve this error inputStream contains the error message

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1827212 13f79535-47bb-0310-9956-ffa450edef68
2018-03-19 16:04:21 +00:00
Michael Brohl 4b7ef47a59 Improved: Standardise Layout throughout Applications.
(OFBIZ-10242)

This contains the improvements for common.

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1827076 13f79535-47bb-0310-9956-ffa450edef68
2018-03-17 11:39:03 +00:00
Michael Brohl 4d3ad30996 Improved: Standardise Layout throughout Applications.
(OFBIZ-10242)

This contains the improvements for webtools.

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1827072 13f79535-47bb-0310-9956-ffa450edef68
2018-03-17 11:31:26 +00:00
Jacques Le Roux 1592f169af Improved: Token Based Authentication
(OFBIZ-9833)

Removes the code I temporarily removed on trunk demo (controversial) to test my 
changes

Also adds the LoginWorker.autoLoginSet()

This is just a commit to go ahead, later I will revert all related and provide 
a patch for discussion at OFBIZ-9833.

I'll also certainly use Deepak's JWTManager.createJwt() instead of mine, it's
more general and I actually only need to pass the userLoginId. We have though
to discuss that anyway, I see some differences...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826949 13f79535-47bb-0310-9956-ffa450edef68
2018-03-16 10:02:03 +00:00
Jacques Le Roux d354300e69 Fixed: Logout do not remove autoLogin
(OFBIZ-4959)

I used the only available (and I must say confusing) WebappInfo.getName() when
I needed the webAppName not the WebappInfoName. So this put in a new 
WebappInfo.getMountPoint() and use it in getWebappInfo

Also use LoginWorker.autoLoginSet() in different places where I missed it. In 
other words all autoUserLogin coockies are deleted on login and logout, and
an autoUserLogin cookie is created when going locally from a webapp to another,
with checkExternalLoginKey


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826938 13f79535-47bb-0310-9956-ffa450edef68
2018-03-16 09:35:06 +00:00
Michael Brohl 7bc137dd35 Improved: Extended UtilFormatOut with new method formatPercentageRate.
(OFBIZ-10199)

Thanks Martin for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826679 13f79535-47bb-0310-9956-ffa450edef68
2018-03-13 20:16:12 +00:00
Michael Brohl 0cb4f4af16 Improved: Extend updatePassword service API with optional parameter
requirePasswordChange.
(OFBIZ-10201)

Thanks Martin Becker for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826678 13f79535-47bb-0310-9956-ffa450edef68
2018-03-13 20:10:31 +00:00
Michael Brohl 02c37dc314 Fixed: EmailServices.sendMailFromScreen attachment rendering broken.
(OFBIZ-10246)

Thanks Martin for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826674 13f79535-47bb-0310-9956-ffa450edef68
2018-03-13 19:46:28 +00:00
Michael Brohl 1885f9a0a0 Improved: Change log level from INFO to VERBOSE for detail logging in
UtilCache.findSizeInByte
(OFBIZ-10200)

Thanks Martin Becker for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826597 13f79535-47bb-0310-9956-ffa450edef68
2018-03-12 22:08:42 +00:00
Michael Brohl aebec6aafc Fixed: UtilCodec URL decoding breaks values with german umlauts.
(OFBIZ-10275)

Thanks Martin Becker for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826592 13f79535-47bb-0310-9956-ffa450edef68
2018-03-12 21:43:48 +00:00
Deepak Dixit c609f5f530 Improved: Update postgres datasource name in entityengine file for consistency
OFBIZ-10273


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826502 13f79535-47bb-0310-9956-ffa450edef68
2018-03-12 06:40:19 +00:00
Taher A. Alkhateeb 19b879e257 Reverted: commit r1825436, inconsistency in results between me and buildbot
WIP, to investigate


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825438 13f79535-47bb-0310-9956-ffa450edef68
2018-02-27 10:53:59 +00:00
Taher A. Alkhateeb cc022f8c4a Fixed: a bug in loading seed-only data into the system
When calling OFBiz with the command gradlew "ofbiz -l readers=seed-initial"
the system crashes. The reason is because of a faulty dependency of
"seed-initial" data in the entityext component to "seed" data in the security
component. The fix is simply to change the type of reader for the requested
data in SecurityPermissionSeedData.xml from "seed" to "seed-initial"


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825436 13f79535-47bb-0310-9956-ffa450edef68
2018-02-27 10:41:14 +00:00
Gil Portenseigne 65fe235f51 Implemented: Add the ability in performFind service to set OR search criteria
(OFBIZ-10195)

This improvement add a way to specify a condition-group attribute on search fields, for performFind service usage.
The same group conditions are gathered with AND operator, and each group is added with a OR
The resulting condition is added to the other with AND operator.
Thanks Taher for your reviews and ideas

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825350 13f79535-47bb-0310-9956-ffa450edef68
2018-02-26 09:57:36 +00:00
Michael Brohl 441673a2bd Improved: Improve layout and structure of forms.
(OFBIZ-10221)

This includes the webtools templates. 

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825261 13f79535-47bb-0310-9956-ffa450edef68
2018-02-24 16:23:19 +00:00
Arun Patidar 51f51c1623 Improved:Update regex used for validating credit cards.
(OFBIZ-9761)
Thanks Amit Gadaley for your contribution and Michael Brohl for reviewing patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825216 13f79535-47bb-0310-9956-ffa450edef68
2018-02-24 11:32:18 +00:00
Deepak Dixit 23e4b72f17 Fixed: Alert message : Developer: for lookups to work you must provide a form name! appears when try to select contentId from Lookup.
(OFBIZ-10012)
Applied slightly modified patch 
Thanks  Sonal for reporting and Aditya Sharma for providing patch for the issue


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825205 13f79535-47bb-0310-9956-ffa450edef68
2018-02-24 10:22:18 +00:00