Commit Graph
10472 Commits
Author SHA1 Message Date
Deepak Dixit a52c62d726 Improved: In 'ValidateMethod.java', when we don't pass any className from xml files. default value 'org.apache.ofbiz.base.util.UtilValidate' should be set for className. (OFBIZ-9969)
Thanks Suraj Khurana and Sonal Patwari for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825197 13f79535-47bb-0310-9956-ffa450edef68
2018-02-24 08:31:14 +00:00
Arun Patidar ac125443c7 Improved: Introduce support for condition-service for entity eca's as well.
(OFBIZ-10220)
Thanks Suraj Khurana for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825191 13f79535-47bb-0310-9956-ffa450edef68
2018-02-24 07:27:54 +00:00
Jacques Le Roux 5977381e62 Reverted: Secure the login.secret_key_string
(OFBIZ-9966)

I forgot to revert this part; I guess got conflict issues and then forgot.

I'll also revert in R16 and R17 and close as won't fix, I gave my arguments
that's enough for me.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824855 13f79535-47bb-0310-9956-ffa450edef68
2018-02-20 11:59:07 +00:00
Jacques Le Roux 84bc50b994 Fixed: Logout do not remove autoLogin
(OFBIZ-4959)

Logout method do not disable autoLogin functionality. 
Instead of that it just initializes autoLogin in session and request.

jleroux: this was also needed by OFBIZ-10206 "Security issue in Token Based 
Authentication". 
This creates a keep-autologin-cookie boolean attribute in the webapp element of 
the  ofbiz-component.xml, documented in ofbiz-component.xsd
This attribute is used to get the value from the ofbiz-component.xml files in a
new autoLogoutCleanCookies() LoginWorker method. This method is used not only 
when login out but also when login in. This to be sure that in every cases the 
cookies related to the webapps are removed.
For now only the ecommerce, ecomseo et webpos webapps are keeping and using 
their autologin cookies

Thanks: Roberto Benítez Monje for report and Taher for discussion and suggestion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824803 13f79535-47bb-0310-9956-ffa450edef68
2018-02-19 19:23:36 +00:00
Deepak Dixit ae496e98c1 Improved: Show title information on Entity Data Maintenance page (OFBIZ-10207)
Thanks Aditya Sharma for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824659 13f79535-47bb-0310-9956-ffa450edef68
2018-02-18 10:23:12 +00:00
Jacques Le Roux dbc3c80b44 Improved: Use Tomcat default ciphers
(OFBIZ-10223)

Tomcat provides a default ciphers definition better to use it and let Tomcat 
handles that for us, we know Tomcat security is strong

Thanks: Paul Foxworthy for the help understanding the syntax :)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824316 13f79535-47bb-0310-9956-ffa450edef68
2018-02-15 14:38:51 +00:00
Nicolas Malin 6a5ffb512e Implemented: Add CustomScreen entity copy from CustomMethod pattern (OFBIZ-10186)
With this entity we can define some different widget screens available on the system (organised by type) to link with other entities for resolve a specific screen to use for a specific context (future actual case to implement, select a invoice pdf screen linked to a party) without framework modification

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824274 13f79535-47bb-0310-9956-ffa450edef68
2018-02-14 23:15:11 +00:00
Jacques Le Roux a4d20dfc52 Improved: Token Based Authentication
(OFBIZ-9833)

No functional change, removes TODOs that I recently 
(1 week ago in r1823324) put to myself to quickly check. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824260 13f79535-47bb-0310-9956-ffa450edef68
2018-02-14 16:40:19 +00:00
Jacques Le Roux f26b20885a No functional change, removes reference to MD5 in comments. It's not used anymore
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824128 13f79535-47bb-0310-9956-ffa450edef68
2018-02-13 12:51:30 +00:00
Jacques Le Roux 630d993a21 Improved: [DEPRECATION] Replace BigDecimal.ROUND_* by RoundingMode.*
(OFBIZ-9571)

No functional change, just better JavaDoc 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824124 13f79535-47bb-0310-9956-ffa450edef68
2018-02-13 12:45:13 +00:00
Jacques Le Roux 6ce8dd89e3 Improved: [DEPRECATION] Replace BigDecimal.ROUND_* by RoundingMode.*
(OFBIZ-9571)

No functional change, simply better JavaDoc for deprecated 
getBigDecimalRoundingMode() methods

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824104 13f79535-47bb-0310-9956-ffa450edef68
2018-02-13 09:30:34 +00:00
Jacques Le Roux b06570590e Improved: [DEPRECATION] Replace BigDecimal.ROUND_* by RoundingMode.*
(OFBIZ-9571)

UtilNumber class
 Deprecates and replaces both getBigDecimalRoundingMode() by getRoundingMode()
 Deprecates toPercentString()
 Puts a log for a NumberFormatException

Calculate class
 Uses RoundingMode where necessary. No deprecation, this should be only used
 by Minilang

The rest
 Adapts the whole code for that
 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823931 13f79535-47bb-0310-9956-ffa450edef68
2018-02-12 10:04:29 +00:00
Jacques Le Roux 35679e415b Fixed: UtilNumber.getBigDecimalRoundingMode() returns a wrong value
(OFBIZ-10218)

While working on OFBIZ-9571 I found that getBigDecimalRoundingMode() returns  
DEFAULT_BD_SCALE when the passed value for the file parameter is emtpy. 
This has certainly be C/P from getBigDecimalScale() and never found before.

While at it I refactored a bit getBigDecimalRoundingMode()  and 
getBigDecimalScale() 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823876 13f79535-47bb-0310-9956-ffa450edef68
2018-02-11 18:51:07 +00:00
Jacques Le Roux 0940288cba Fixed: rename the common-theme component directory
(OFBIZ-10175)

Some of the remnants were still left. I got stuck with 
JsLanguageFileMappingCreator, so changed other left outs too.

This also fixes OFBIZ-10113  - Replace Asm select plugin with Select2.

Thanks: Aditya

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823826 13f79535-47bb-0310-9956-ffa450edef68
2018-02-11 09:46:53 +00:00
Gil Portenseigne fba4f5b235 Implemented : Add new FileUtil methods for zip management (OFBIZ-10188)
Add zipFileStream method that will zip FileStream to a zipped one.
Add unzipFileToFolder method to unzip a given archive to a given Folder.
Add fileUtil groovy test suite that create zip file containing README.md, then unzip it to tmp folder and compare original and unzipped files.
Thanks Jacques for the review.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823567 13f79535-47bb-0310-9956-ffa450edef68
2018-02-08 15:32:31 +00:00
Jacques Le Roux f5ba435024 Completed: Security issue in Token Based Authentication
(OFBIZ-10206)

No functional change, just better syntax

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823562 13f79535-47bb-0310-9956-ffa450edef68
2018-02-08 15:01:54 +00:00
Jacques Le Roux 619d31e331 Completed:: Security issue in Token Based Authentication
(OFBIZ-10206)

Updates the security.properties content related to JWT
 Refers to the last up to date external-server-test-example.patch at OFBIZ-10206
 Makes demo-trunk.ofbiz.apache.org default external-server-name so that anybody
 can try the feature from own machine. The use-external-server=Y was already set

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823467 13f79535-47bb-0310-9956-ffa450edef68
2018-02-07 14:17:51 +00:00
Nicolas Malin f1534bd1d6 Improved: Convert CommonPermissionServices.xml mini lang to groovy (OFBIZ-9993)
convert services genericBasePermissionCheck, commonGetAllCrudPermissions and visualThemePermissionCheck from minilang to groovy.
The simple method genericBasePermissionCheck is maintain but indicate as deprecated in log to don't break direct call from other mini-lang script.

Thanks to Dennis Balkir for this patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823397 13f79535-47bb-0310-9956-ffa450edef68
2018-02-06 22:01:52 +00:00
Jacques Le Roux 97a9b690dd Fixed: Security issue in Token Based Authentication
(OFBIZ-10206)

The version I committed so far in OFBIZ-9833 has a small security issue.
See the Jira description for all details

To test I have attached a OFBIZ-10206-external-server-test-example.patch to 
the Jira

This removes the external-server-query property now useless

In  ContextFilter the getHeader (wrapper) now uses an autoLoginCookie to get 
the userLoginId passed in the JWT instead of externalServerUserLogin parameter.
A sourceServerWebappName parameter must be passed from the client request to
allow reading the autoLoginCookie.

This userLoginId is then retrieved on the target server from the JWT in the 
externalServerLoginCheck which is simplified.

In LoginWorker
  getAutoLoginCookieName() has now 2 versions to allow to pass a webappname

  A new autoLogoutFromAllBackendSessions() method has been added but for now 
  commented out. Decommenting it out will be submitted as a patch in OFBIZ-4959.

Thanks: Leila Mekika for reporting the security issue directly to me

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823324 13f79535-47bb-0310-9956-ffa450edef68
2018-02-06 13:17:57 +00:00
Nicolas Malin 21fa500df1 Improved: complete previous commit to add security in groovy context (OFBIZ-10196)
add security on groovy junit test
add security on eclipse and intellij groovy dsl definition
Thanks to Dennis Balkir for the suggest

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823028 13f79535-47bb-0310-9956-ffa450edef68
2018-02-03 14:16:16 +00:00
Nicolas Malin 5588618e0f Improved: Convert CategoryServices.xml mini lang to groovy (OFBIZ-10031)
thanks to Dennis Balkir for this help to minilang conversion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1822912 13f79535-47bb-0310-9956-ffa450edef68
2018-02-01 22:33:59 +00:00
Nicolas Malin 460c680e60 Improved: Set security object on groovy context (OFBIZ-10196)
In a groovy service to call the security object you need to do : Security security = dispatcher.dispatchContext.security
For simplification, I set the security object in groovy context like dispatcher and delegator to call directly security.hasPermission()

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1822908 13f79535-47bb-0310-9956-ffa450edef68
2018-02-01 20:54:17 +00:00
Jacques Le Roux 714e6e3521 Improved: Token Based Authentication
(OFBIZ-9833)

I just thought that for security it's best to have both the source and 
target server using the use-external-server property.

Also default to N when requesting this property

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1822882 13f79535-47bb-0310-9956-ffa450edef68
2018-02-01 15:27:17 +00:00
Jacques Le Roux 9b6e65bd20 No functional change, clarifies for demo
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1822877 13f79535-47bb-0310-9956-ffa450edef68
2018-02-01 14:41:48 +00:00
Jacques Le Roux 492c78a4d5 No functional change, just clarifies things a bit
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1822518 13f79535-47bb-0310-9956-ffa450edef68
2018-01-29 15:27:25 +00:00
Jacques Le Roux 6ab3f9e738 Fixed: EntitySaxReader mostly-insert (store after create-error) Fix
(OFBIZ-1032)

This changes the label for more clarity. Actually there is not only inserts but
no replacements. Because you can also create and delete. This has been defined
after this label was created with OFBIZ-4949. So we have EntitySaxReader Action
enum and it's used in this this context.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1822383 13f79535-47bb-0310-9956-ffa450edef68
2018-01-27 10:27:31 +00:00
Jacques Le Roux 030b6b59de Fixed: EntitySaxReader mostly-insert (store after create-error) Fix
(OFBIZ-1032)

Karl:
Avoids rollback on create error to be able to store the entity instead 
(previous mostly-inserts feature).

Matin:
I think, the data load with "mostly inserts" activated should fail on a 
create-failure (what it does indeed already), so I see no need for a working 
solution of a fallback store attempt. Consistently the Feature should be renamed 
in the frontend from "mostly inserts" to "only inserts".

Kyra:
Additional trivial refactoring in the patch: I reduced the full qualified 
classname of org.xml.sax.SAXException in method signatures to the simple name.

This incorperates the changes that Martin has mentioned above. 
The unnecessary call to store() is removed, simplifying the process of creating 
and deleting entities. (These changes were already in Martins old patch but had 
the wrong format.) This means that the flag "mostly Inserts?" is not accurately 
worded since as long as there is only create fail, all operations are rolled 
back. So the second patch renames the flag and all appropriate parameters to 
"onlyInserts". 

jleroux: I made few no functional changes, apart not swallowing an exception

Thanks: Thanks Karl for the 1st patch, Martin to get further, and Kyra to 
complete the whole with a final touch and help to quickly test

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1822310 13f79535-47bb-0310-9956-ffa450edef68
2018-01-26 15:13:42 +00:00
Deepak Dixit 47837aad8a Improved:Removed unused import.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1822125 13f79535-47bb-0310-9956-ffa450edef68
2018-01-24 17:26:12 +00:00
Deepak Dixit 1b141c9b97 Improved: No functional change, Rearrange GeoAssoc data alphabetically
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821630 13f79535-47bb-0310-9956-ffa450edef68
2018-01-19 12:22:19 +00:00
Deepak Dixit c6fcbc5a73 Fixed: GeoAssoc data is missing for Telangana state of India (OFBIZ-10172)
Thanks Suraj Khurana for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821628 13f79535-47bb-0310-9956-ffa450edef68
2018-01-19 12:20:27 +00:00
Jacques Le Roux 0ca7c12475 Improved: Token Based Authentication
(OFBIZ-9833)

No functional change

As reported by Jinghai on dev ML we should better use "Authorization" than
 "Authorisation" when retrieving the JWT token, even if both are accepted
https://en.wikipedia.org/wiki/List_of_HTTP_header_fields
Also improves the comment on token ttl

Thanks: Jinghai for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821600 13f79535-47bb-0310-9956-ffa450edef68
2018-01-19 08:39:05 +00:00
Rishi Solanki 7d29cd1888 Implemented: Add ability to record Return Communication. Added support to record communication event against return. Added new entity CommunicationEventReturn, crund and supporting screens. Also added support in the existing email services to handle the return cases.
(OFBIZ-9911)
Thanks to Ratnesh Upadhyay for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821486 13f79535-47bb-0310-9956-ffa450edef68
2018-01-18 11:34:01 +00:00
Jacques Le Roux 5e1d1f763e Improved: Make xssi prefix configurable
(OFBIZ-9169)

In OFBIZ-5409 a prefix was added for GET ajax requests.
It would be beneficial if the prefix could be configured instead of hard coded

jleroux: at r1777942 I missed the general.properties change

Thanks: Michael Brohl for reporting the issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821386 13f79535-47bb-0310-9956-ffa450edef68
2018-01-17 15:28:51 +00:00
Jacques Le Roux 4922cc9fbb Fixed: Fix the HttpServletRequestWrapper in ContextFilter.doFilter()
(OFBIZ-10167)

As reported by Deepak on dev ML the returned name should be a parameter and not 
enforced to "Authorisation"

This removes a wrong comment (no functional change)

Thanks: Deepak for bug report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821230 13f79535-47bb-0310-9956-ffa450edef68
2018-01-16 11:02:17 +00:00
Jacques Le Roux 4365984e18 Fixed: Fix the HttpServletRequestWrapper in ContextFilter.doFilter()
(OFBIZ-10167)

As reported by Deepak on dev ML the returned name should be a parameter and not 
enforced to "Authorisation"

Thanks: Deepak for bug report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821226 13f79535-47bb-0310-9956-ffa450edef68
2018-01-16 10:25:41 +00:00
Jacques Le Roux edd922a62f Improved: Update Geo information according to ISO notifications, Mali
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15836 and INFRA-15842,
so will be backported

Thanks: Kyra Pritzel-Hentley 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821219 13f79535-47bb-0310-9956-ffa450edef68
2018-01-16 07:58:49 +00:00
Jacques Le Roux 65a24ca17f Improved: Update Geo information according to ISO notifications, Moldova
(the Republic of)/
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15836, so will be backported

Thanks: Kyra Pritzel-Hentley 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821186 13f79535-47bb-0310-9956-ffa450edef68
2018-01-15 17:47:05 +00:00
Jacques Le Roux 978360b471 Improved: Update Geo information according to ISO notifications, Lao People's
Democratic Republic (the)
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15836, so will be backported

Thanks: Kyra Pritzel-Hentley 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821144 13f79535-47bb-0310-9956-ffa450edef68
2018-01-15 10:45:33 +00:00
Jacques Le Roux 7de1951eee Improved: Update Geo information according to ISO notifications, Korea
(the Democratic People's Republic of)
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15836, so will be backported

Thanks: Kyra Pritzel-Hentley 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821112 13f79535-47bb-0310-9956-ffa450edef68
2018-01-14 18:23:57 +00:00
Jacques Le Roux e45a869e17 Fixed: streaming large content cause out of memory exception.
(OFBIZ-10133)

No functional change in trunk
Slightly improves formatting in streamContent() in trunk. 

Uses the same code in R16, notably for setting
byte[] buffer = new byte[bufferSize];
that guarantee no issues, and using try-with-ressource

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821054 13f79535-47bb-0310-9956-ffa450edef68
2018-01-13 09:37:38 +00:00
Jacques Le Roux 67d62f9ad6 No functional changes.
Replaces close() in finally by try-with-ressource



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821039 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 22:37:25 +00:00
Jacques Le Roux 823cc0bf99 Fixed: streaming large content cause out of memory exception.
(OFBIZ-10133)

When ofbiz streams a large content (eg. video file), get out of memory exception.

To reproduce the issue see the Jira

jleroux: I just removed final for bufferSize, I see no needs for that local
variable

Thanks: Wai for the patch Michael for the discussion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821036 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 21:59:22 +00:00
Jacques Le Roux 19d9b3ca30 Improved: Replace Asm select plugin with Select2.
(OFBIZ-10113)

Current Asm Select Plugin 
http://www.ryancramer.com/journal/entries/asmselect_v104/
can be replaced with Select2 (https://select2.org/).

* Select2 has much better community support on GitHub with 386 contributors 
  while Asm Select Plugin is handled by Ryan Cramer on http://www.ryancramer.com/.
* Select2 has 37 releases while Asm select has very few releases yet.
* Both the plugin has MIT license.

Refer https://select2.org/ and  
https://github.com/select2/select2 for more features and other information.

Added i18n support so added logic in JsLanguageFileMappingCreator and 
JsLanguageFilesMapping accordingly.
Added some custom CSS as the Select2 seems to be too fancy in accordance 
with the current OFBiz themes

Verify:
Multiple drop-downs field in FormWidgetExamples.
https://localhost:8443/example/control/FormWidgetExamples

Find Request page with StatusId , CustRequestId
https://localhost:8443/ordermgr/control/FindRequest

I have replaced the plugins though I feel the implementation of select multiple 
js code is to be reviewed & refactored. I will pick when I am done with all my 
current tasks if I get some consensus.

Thanks: Aditya 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821001 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 15:47:47 +00:00
Jacques Le Roux cf0c677e10 Improved: Clean images, among them logos, in all locations used
(OFBIZ-10128)

Fix my previous commits, there is no themes webapp so no URL at 
/themes/common/webapp/images/ofbiz_logo.png
It's only images/ofbiz_logo.png


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820978 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 12:56:30 +00:00
Jacques Le Roux 7b9792b509 Fixed: Correcting findOne() in OfbizDslDescriptorForEclipse.dsld
(OFBIZ-10159)

The method findOne() which is set in the OfbizDslDescriptorForEclipse.dsld is 
wrong, since there is no implementation for this method, which only has a String 
and a List as parameters. I changed it to the correct method, so it can be used 
within groovy properly, also I put an implementation in the GroovyBaseScriptFile

Thanks: Dennis Balkir

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820966 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 11:24:48 +00:00
Jacques Le Roux 55ba682e2c No functional change, replace tabs by spaces
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820965 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 11:22:31 +00:00
Jacques Le Roux b964875337 Improved: Clean images, among them logos, in all locations used
(OFBIZ-10128)

The ofbiz_logo.png is now in theme. This is only the framework part. 
I have also made change in theme but I need to review again and perhaps create 
a patch for others to review...
Note: testUpdatePartyGroup is OK

Then I'll also rename the logo in site to use the same name before maybe
referring to svn trunk repo to use only 1 file everywhere, same for the .ico
file

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820862 13f79535-47bb-0310-9956-ffa450edef68
2018-01-11 11:05:26 +00:00
Deepak Dixit 471198e9eb Fixed: Shipping Label printing not working (OFBIZ-10153)
Added viewShipmentLabel in http-request map so that pdf will be able to print the shipping lable.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820823 13f79535-47bb-0310-9956-ffa450edef68
2018-01-11 05:49:53 +00:00
Jacques Le Roux fbba91bbcd Improved: Update Geo information according to ISO notifications
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

Here are China, Germany, Hungary and Indonesia

Thanks: Kyra Pritzel-Hentley 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820644 13f79535-47bb-0310-9956-ffa450edef68
2018-01-09 11:30:39 +00:00
James Yong b2004efd5a Improved: ID should be the abbreviation for identity in English
(OFBIZ-100131)

Cover translations that are missed earlier.
Also cover non-English translations.

Thanks: Jacques for the additional patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820451 13f79535-47bb-0310-9956-ffa450edef68
2018-01-07 12:16:21 +00:00