Commit Graph
10472 Commits
Author SHA1 Message Date
Julien Nicolas 995a39461a fixed: Change the Menu extends-resource management to allow structure changes by themes
(OFBIZ-10600)

Fixed the lack of menu theme definition in the xsd file

Thanks: To Jacques Le Roux for being more attentive to the log file than I have been ;)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1844697 13f79535-47bb-0310-9956-ffa450edef68
2018-10-23 20:11:00 +00:00
Jacques Le Roux 0e33487170 Documented: Document the automated authentification from a domain to another
(OFBIZ-10562)

Renames the file using "SSO" instead of "auto-auth-navigation"
Completes the documentation

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1844235 13f79535-47bb-0310-9956-ffa450edef68
2018-10-18 12:43:49 +00:00
Julien Nicolas de65cd9acd Improved: Change the Menu extends-resource management to allow structure changes by themes
(OFBIZ-10600)
Thanks: Nicolas MALIN, Leila MEKIKA and Gil PORTENSEIGNE

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1844068 13f79535-47bb-0310-9956-ffa450edef68
2018-10-17 07:33:12 +00:00
Gil Portenseigne 161172b3ff Improved: Improve entityConditionVisitor basic test
(OFBIZ-10593)

Use print instead of println to avoid newline failure on windows, thanks Jacques for the feedback.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1843936 13f79535-47bb-0310-9956-ffa450edef68
2018-10-15 19:16:17 +00:00
Jacques Le Roux eb4e142a7e Improved: Refactor ICalendar support
(OFBIZ-10602)

Adds missing imports after errors in Buildbot Javadoc creation

https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/454/steps/shell_2/logs/stdio

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1843921 13f79535-47bb-0310-9956-ffa450edef68
2018-10-15 16:01:08 +00:00
Jacques Le Roux 6dab6dd2e9 Improved: Refactor ICalendar support
(OFBIZ-10602)

Rewrites documentation to remove Javadoc warnings and improves implementation 
by avoiding classes with only one method.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1843916 13f79535-47bb-0310-9956-ffa450edef68
2018-10-15 14:52:32 +00:00
Jacques Le Roux c61e220821 Improved: Cleanup JavaDocs to be standards compliant
(OFBIZ-7775)

Removes some javadoc warnings.  This is done by removing some redundant javadoc 
comments that are already well written in the implemented interface.

Ref: https://docs.oracle.com/javase/7/docs/technotes/tools/solaris/javadoc.html#inheritingcomments

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1843837 13f79535-47bb-0310-9956-ffa450edef68
2018-10-14 13:42:19 +00:00
Gil Portenseigne 699bbb9cf9 Improved: Rewrite EntityConditionVisitor interface to respect visitor Pattern
(OFBIZ-10593)

Remove visit methods from current EntityConditionBase type hierarchy.
Add or rewrite accept method in EntityCondition type hierachy.
Add documentation in EntityConditionVisitor, introducing implementation examples.
Add junit test validating documented examples.
Thanks to Mathieu Lirzin for your contribution, and Jacques for the review.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1843780 13f79535-47bb-0310-9956-ffa450edef68
2018-10-13 19:50:27 +00:00
Jacques Le Roux c440f65a99 Improved: sorts a label and removes a duplicated one
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1843413 13f79535-47bb-0310-9956-ffa450edef68
2018-10-10 09:13:38 +00:00
Jacques Le Roux 260c38590d Documented: Wrong handling of response type "cross-redirect"
(OFBIZ-10569)

The documentation was wrong, this fixes it

Thanks: Dennis Balkir for the report and discussion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1843225 13f79535-47bb-0310-9956-ffa450edef68
2018-10-09 08:16:01 +00:00
Jacques Le Roux 48a774fbe4 Fixed: Service Log screen is broken
(OFBIZ-10342)

Steps to regenerate

    Navigate to Logging menu under webtools
    https://demo-trunk.ofbiz.apache.org/webtools/control/LogView

    Select Service Log menu, see NPE error

Thanks: Swapnil M Mane for report and Swapnil and Rishi Solanki for reviews

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1842372 13f79535-47bb-0310-9956-ffa450edef68
2018-09-30 13:49:30 +00:00
Gil Portenseigne 54ad6c68fa Fixed : Impersonation of userLogin feature
(OFBIZ-10515)

Fix default value of impersonation feature to true (unchanged after last test before commit...) 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1842111 13f79535-47bb-0310-9956-ffa450edef68
2018-09-27 16:11:40 +00:00
Gil Portenseigne a61c98775f Implemented : Impersonation of userLogin feature
(OFBIZ-10515)

Introduce a new feature that allow the impersonation of a login by an authorized user.
Add the documentation with all the details in security-impersonation.adoc.
Big thanks to Leila, Nicolas and Jacques for your contribution to this implementation.
Big thanks to Mathieu, Jacques, Pierre and Taher for your remarks and reviews that
improved this contribution quality. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1842110 13f79535-47bb-0310-9956-ffa450edef68
2018-09-27 16:01:35 +00:00
Aditya Sharma bc64d45f51 Improved: Using 'buttontext' styling for buttons inside the ListEntities table
(OFBIZ-10465)
Thanks Dennis Balkir for reporting and providing the patch.
Thanks Garima Jain for the patch review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1841670 13f79535-47bb-0310-9956-ffa450edef68
2018-09-22 11:36:38 +00:00
Jacques Le Roux 217a8719cb Documented: Document the automated authentification from a domain to another
(OFBIZ-10562)

Renames the file using "cross" instead of "inter"

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1841480 13f79535-47bb-0310-9956-ffa450edef68
2018-09-20 15:19:48 +00:00
Jacques Le Roux 72fbfdda3c Documented: Document the automated authentification from a domain to another
(OFBIZ-10562)

Renames the file using "cross" instead of "inter"

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1841479 13f79535-47bb-0310-9956-ffa450edef68
2018-09-20 15:00:23 +00:00
Jacques Le Roux 5cf707e55a Documented: Document the automated authentification from a domain to another
(OFBIZ-10562)

Commits WIP before changing the file name (cross fits more than inter)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1841478 13f79535-47bb-0310-9956-ffa450edef68
2018-09-20 14:59:18 +00:00
Gil Portenseigne 00f47d07dc Improved : Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead.
(OFBIZ-10566)

Deprecation of findOne DSL method in favor of entityQuery from DSL method

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840898 13f79535-47bb-0310-9956-ffa450edef68
2018-09-14 08:19:39 +00:00
Jacques Le Roux 52ed40f643 No functional change. Sets the svn:props after having set them on OFBiz
svn repo root

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840888 13f79535-47bb-0310-9956-ffa450edef68
2018-09-14 07:19:06 +00:00
Jacopo Cappellato 1d1b12400e Improved: Upgraded Freemarker to the latest stable version (from
2.3.27-incubating to 2.3.28).


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840828 13f79535-47bb-0310-9956-ffa450edef68
2018-09-13 14:49:25 +00:00
Suraj Khurana 20af1d3319 Improved: Arranged framework UI labels in alphabetic order.
(OFBIZ-7345)
Thanks Shivangi for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840815 13f79535-47bb-0310-9956-ffa450edef68
2018-09-13 13:31:51 +00:00
Jacques Le Roux ad793ccf4e Documented: Document the automated authentification from a domain to another
(OFBIZ-10562)

This is a WIP to inly define the structure, no real content yet...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840811 13f79535-47bb-0310-9956-ffa450edef68
2018-09-13 13:07:05 +00:00
Jacques Le Roux d9fcb5f8f3 Documented: Create an empty document templates for webapp socumentation
(OFBIZ-10564)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840810 13f79535-47bb-0310-9956-ffa450edef68
2018-09-13 13:03:50 +00:00
Nicolas Malin 7648f27f75 Fixed: On FecthLogs screen order the file log list drop-down to help the search
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840789 13f79535-47bb-0310-9956-ffa450edef68
2018-09-13 08:34:39 +00:00
Suraj Khurana 84f99c8cbd Improved: Modified QRCodeServices.java and used EntityUtilProperties. Removed unused data variables and used them directly inside the service.
(OFBIZ-7037)
Thanks everyone for your suggestions and review.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840564 13f79535-47bb-0310-9956-ffa450edef68
2018-09-11 13:30:10 +00:00
Nicolas Malin dfbda6210a Improved: Async persist service on error no restart by default
(OFBIZ-10557)
Related to the discussion on dev [1] I turn off by default the indefinitely restart when a service async failed.
When a service run by async with persistence (eg: dispatcher.runAsync('returnErrorService', context, true)), the default value set on jobsandbox.maxRetry is now 0 instead of -1 before.

If you want run indefinitely an async service while isn't a success, set on your service definition max-retry='-1'.

[1] https://s.apache.org/EBhf

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840526 13f79535-47bb-0310-9956-ffa450edef68
2018-09-11 07:42:19 +00:00
Nicolas Malin 86ddaf83da Fixed: Display in log the file location who failed when the ConfigXMLReader throw an exception during the xml parsing
Currently only the Exception is visible that can't help to spot quickly the origin component.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840258 13f79535-47bb-0310-9956-ffa450edef68
2018-09-06 18:50:01 +00:00
Jacques Le Roux 4c57553e93 Improved: Update Geo information according to ISO notifications
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

It updates 
MX <https://www.iso.org/obp/ui/#iso:code:3166:MX> 2017-11-23 /Mexico/
and adds
NR <https://www.iso.org/obp/ui/#iso:code:3166:NR> 2017-11-23 /Nauru/
PA <https://www.iso.org/obp/ui/#iso:code:3166:PA> 2017-11-23 /Panama/
PK <https://www.iso.org/obp/ui/#iso:code:3166:PK> 2017-11-23 /Pakistan/
QA <https://www.iso.org/obp/ui/#iso:code:3166:QA> 2017-11-23 /Qatar/
TG <https://www.iso.org/obp/ui/#iso:code:3166:TG> 2017-11-23 /Togo/
TJ <https://www.iso.org/obp/ui/#iso:code:3166:TJ> 2017-11-23 /Tajikistan/
UG <https://www.iso.org/obp/ui/#iso:code:3166:UG> 2017-11-23 /Uganda/

Thanks: Kyra Pritzel-Hentley for doing all the work!

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840254 13f79535-47bb-0310-9956-ffa450edef68
2018-09-06 17:56:01 +00:00
Jacques Le Roux 290f649b6e Fixed: Action (find) button not visible in LabelManager search screen
(OFBIZ-10549)

When a user executes a search/find action in the Label Manager, and there are 
duplicated labels the 'Find' button is not visible anymore.

Thanks: Pierre Smits

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840199 13f79535-47bb-0310-9956-ffa450edef68
2018-09-06 09:53:23 +00:00
Jacques Le Roux a5fd3fd7eb Implemented: Implement Depends on support for Component Loading.
(OFBIZ-10368)

Components are loaded in the order they are found (i.e. alphabetic or creation 
date). 

Here is a feature which supports in ofbiz-component to create a series of 
dependencies for components loading, before loading a particular component.
We can define a dependency for a component, like component ebaystore is 
dependent on Component ebay (even multiple dependencies for a single component 
is supported). 

We can declare it in this fashion in ofbiz-component.xml file.
  <ofbiz-component name="ebaystore" enabled="true"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/ofbiz-component.xsd">
  <depends-on component-name="ebay"/>

If any anomaly is found loading of components will stop.  

Thanks: Pradhan Yash Sharma

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840141 13f79535-47bb-0310-9956-ffa450edef68
2018-09-05 16:29:48 +00:00
Jacques Le Roux e62d31667e Implemented: Implement Depends on support for Component Loading.
(OFBIZ-10368)

Components are loaded in the order they are found (i.e. alphabetic or creation 
date). 

Here is a feature which supports in ofbiz-component to create a series of dependency for component loading, before loading a particular component.
 
Here we can define dependency for a component like Component ebaystore is dependent on Component ebay (even multiple dependencies for a single component is also supported). We can declare it in this fashion in ofbiz-component.xml file.
 

<ofbiz-component name="ebaystore" enabled="true"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/ofbiz-component.xsd">
<depends-on component-name="ebay"/>

 
Now we can declare dependency and if any anomaly is found loading of components will stop.  

Thanks:

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840139 13f79535-47bb-0310-9956-ffa450edef68
2018-09-05 16:23:04 +00:00
Gil Portenseigne 3f23e45b7b Implemented: Refactor EntityUtil findBy methods using Stream API
(OFBIZ-10537)

Fixed variable name to make it more meaningful

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1839926 13f79535-47bb-0310-9956-ffa450edef68
2018-09-03 09:33:21 +00:00
Gil Portenseigne e316f2165d Implemented: Refactor EntityUtil findBy methods using Stream API
(OFBIZ-10537)

Thanks Jacques and Mathieu for the review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1839763 13f79535-47bb-0310-9956-ffa450edef68
2018-08-31 15:32:02 +00:00
Suraj Khurana 2d2aba0a4c Improved: Empty header row should not render if list to render in file is empty.
(OFBIZ-7598)
Thanks everyone for your inputs and suggestions.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1839729 13f79535-47bb-0310-9956-ffa450edef68
2018-08-31 06:33:07 +00:00
Deepak Dixit f1ba3ae6a8 Improved: Removed comment from ServerHitBin.java related to mysql Fractional Seconds related issue, this issue fixed under OFBIZ-9337
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1839655 13f79535-47bb-0310-9956-ffa450edef68
2018-08-30 09:35:25 +00:00
Jacques Le Roux 7f4dec9441 Fixed: Add method attribute to request-map to controll a uri can be called GET
or POST only
(OFBIZ-10438)

The problem was r1838081 prevented to serialise requests.

Like in ordermgr/control/updateCheckoutOptions/quickcheckout where 
updateCheckoutOptions and quickcheckout are serialised to update the check out 
after updateCheckoutOptions is done and then get back to the screen with 
quickcheckout. 

CheckoutOptions.ftl is a good example of this usage.

Thanks: Deepak Nigam for initial report and Mathieu for fixing it

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1839451 13f79535-47bb-0310-9956-ffa450edef68
2018-08-28 16:06:23 +00:00
Suraj Khurana 5d317c08de Reverted: Empty header row should not render if list to render in file is empty.
(OFBIZ-7598)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838823 13f79535-47bb-0310-9956-ffa450edef68
2018-08-24 11:37:16 +00:00
Jacques Le Roux e073f7d29e Improved: no functional change
Previous commit 
    "Fixes the API doc, removes a return when there is not"
was wrong, the return missed a description rather


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838419 13f79535-47bb-0310-9956-ffa450edef68
2018-08-20 09:55:32 +00:00
Jacques Le Roux a7dd9efb2b Improved: no functional change
Fixes the API doc, removes a return when there is not

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838418 13f79535-47bb-0310-9956-ffa450edef68
2018-08-20 09:53:50 +00:00
Aditya Sharma 24f846174c Improved: Remove checks to store only 250 characters of URL in VisitHandler.getVisit() & ServerHitBin.saveHit()
(OFBIZ-10508)
When the code was committed the 'URL' field type had a size of 255 characters only which was later changed to 2000 characters. So, the above code logic to restrict no of characters can be removed now. 
Removed null pointer check for initialRequest and initialReferrer as it is already handled while setting the values in UtilHttp.setInitialRequestInfo() method.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838256 13f79535-47bb-0310-9956-ffa450edef68
2018-08-17 12:46:59 +00:00
Shi Jinghai ddf3540817 Implemented: Add method attribute to request-map to controll a uri can be called GET or POST only
OFBIZ-10438

Thanks: Mathieu Lirzin for the contribution.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838081 13f79535-47bb-0310-9956-ffa450edef68
2018-08-15 11:45:45 +00:00
Shi Jinghai c9f5a346ec Implemented: Remove org.apache.tomcat.util.net.secure_protocol_version from json output
OFBIZ-10443

Add org.apache.tomcat.util.net.secure_protocol_version to ignoreAttrs.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838080 13f79535-47bb-0310-9956-ffa450edef68
2018-08-15 11:40:19 +00:00
Deepak Dixit 2fe25b3d79 Improved: Replace #assign with #local in all the ftl macros
(OFBIZ-10516)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837830 13f79535-47bb-0310-9956-ffa450edef68
2018-08-10 18:49:03 +00:00
Deepak Dixit e7a7ba4876 Improved: Rendering different HTML container types with ScreenRenderer
(OFBIZ-10495)
Applied slightly modified patch 
Thanks Dennis Balkir for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837827 13f79535-47bb-0310-9956-ffa450edef68
2018-08-10 18:23:11 +00:00
Taher A. Alkhateeb 6c28c16c58 Improved: disable DTDs for XML-RPC requests
(OFBIZ-10509)

Disable any doctype declarations in XML-RPC requests to OFBiz to enhance
performance and security.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837697 13f79535-47bb-0310-9956-ffa450edef68
2018-08-09 08:27:57 +00:00
Jacques Le Roux 73096d0962 Improved: no functional change, was missing the ASL2 license
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837642 13f79535-47bb-0310-9956-ffa450edef68
2018-08-08 11:42:12 +00:00
Gil Portenseigne 266b63ac12 Fixed: Initial set of hasLoggedOut flag when logging in
(OFBIZ-10506)

Thanks Dennis for your patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837584 13f79535-47bb-0310-9956-ffa450edef68
2018-08-07 09:34:53 +00:00
Gil Portenseigne ceea6ce791 Improved : Remove all unnecessary boxing and unboxing in Java classes
(OFBIZ-10504)

Thanks Taher, Jacques, Mathieu and Rishi for the review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837577 13f79535-47bb-0310-9956-ffa450edef68
2018-08-07 07:30:43 +00:00
Taher A. Alkhateeb 22d780cdae Improved: Further refactor MapContext and MapStack
(OFBIZ-10485)

This commit applies multiple new refactoring enhancements as follows:
- rename stackList to contexts (the data structure holding the context Deque)
- refactor the size function to utilize streams to sum all keys
- Implement a function "entryStream()" that returns a stream of all keys in the
  correct sequential order and utilize this function in multiple functions for
  iterating over the keys including "containsValue", "values" and "entrySet".
  This implementation is necessary to avoid code repetition and ensure correct
  order with no duplicates
- Re-design the get functions of the context map to use a generic function with
  a functional interface "withMapContainingKey". The purpose of it is to avoid
  checking for nulls and instead use the "containsKey" function followed by the
  injected lambda expressions in both signatures of the get function

Thanks: Mathieu Lirzin for the patch and implementing suggested changes.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837462 13f79535-47bb-0310-9956-ffa450edef68
2018-08-05 12:36:09 +00:00
Gil Portenseigne d3021c213b Improved : Use the stream API in FormRenderer
(OFBIZ-10505)

Thanks Mathieu for the patches

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837460 13f79535-47bb-0310-9956-ffa450edef68
2018-08-05 09:18:20 +00:00