Commit Graph
10472 Commits
Author SHA1 Message Date
Jacques Le Roux 8ffbe06fa5 Improved: LoginWorker.autoLoginCheck performance improvement
(OFBIZ-10709)

LoginWorker.autoLoginCheck does not check if the attribute "autoUserLogin" is 
not already filled and executes even if it is not needed. A check on the 
attribute beforehand can improve performance significantly.

Thanks: Benjamin Jugl

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848926 13f79535-47bb-0310-9956-ffa450edef68
2018-12-14 11:08:52 +00:00
Jacques Le Roux d89b68face Improved: Splitting CommonRate and CommonProductRating
(OFBIZ-3844)

Simplifies and adds comments for clarity

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848923 13f79535-47bb-0310-9956-ffa450edef68
2018-12-14 10:38:18 +00:00
Jacques Le Roux 5597b1d65a Improved: Splitting CommonRate and CommonProductRating
(OFBIZ-3844)

The CommonRate label is currently not used coherently throughout the application 
stack. The existing translations suggest that the commonly understood meaning of 
CommonRate is a rate as a tariff or day rate. However, in the product management 
GUI, the CommonRate label is used to demark the section where ProductRating 
setting are made.

The provided fix splits CommonRate into two labels, CommonRatioRate and 
CommonAssessRate (product rating). Also, the application/product/webapp/ form 
definition now references the CommonAssessRate label.

Thanks: Carsten Schinzer for report and patch, Adrian for suggestion and Markus
May for discussion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848834 13f79535-47bb-0310-9956-ffa450edef68
2018-12-13 09:43:03 +00:00
Jacques Le Roux e7ceacdce8 Improved: Convert Minilang to Groovy Guide into asciidoc
(OFBIZ-10300)

Convert Dennis Balkirs Minilang to Groovy Guide into AsciiDoc.

Thanks: Benjamin Jugl

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848745 13f79535-47bb-0310-9956-ffa450edef68
2018-12-12 11:41:25 +00:00
Jacques Le Roux 47954445b4 Improved: Replace Callable objects with lambda expressions
(OFBIZ-10488)

Remove unused imports

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848744 13f79535-47bb-0310-9956-ffa450edef68
2018-12-12 11:07:01 +00:00
Jacques Le Roux 0fb2991e16 FIxed: Replace Callable objects with lambda expressions
(OFBIZ-10488)

urlExists in UelFunctions is not used at all OOTB but its initialisation 
remained


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848674 13f79535-47bb-0310-9956-ffa450edef68
2018-12-11 13:49:51 +00:00
Jacques Le Roux bbfc62d47a Improved: Fix or Silence various warnings
(OFBIZ-10701)

In order to detect potential issues early, the linting compiler option should be 
used by default and disabled with {{./gradlew -PXlint:none build}}.

Additionally it is important to reduce the number of warnings otherwise new 
warnings will remain unnoticed.

The warning related to the com.googlecode.concurrentlinkedhashmap dependency 
should resolves itself once we handle upgrade to Caffeine like proposed in 
OFBIZ-6747.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848673 13f79535-47bb-0310-9956-ffa450edef68
2018-12-11 13:33:49 +00:00
Jacques Le Roux 13f8b82f51 Improved: Replace Callable objects with lambda expressions
(OFBIZ-10488)

Since Java 8 it is possible to instantiate functional interfaces 
(interfaces with one non-static method) with lambda expressions instead 
of anonymous classes.

This replaces the creation of callable objects with lambda expressions.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848514 13f79535-47bb-0310-9956-ffa450edef68
2018-12-09 13:04:23 +00:00
Michael Brohl 4260c161d1 Improved: ControlEventListener - Change Log-Level
(OFBIZ-10330)

The Log-Level of the Message "Could not find visit value object in 
session..." is changed from "warning" to "info".

Thanks Benjamin Jugl for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848467 13f79535-47bb-0310-9956-ffa450edef68
2018-12-08 12:51:27 +00:00
Michael Brohl 50a68ddae5 Seed data sequence bug regarding "MIDNIGHT_DAILY" TemporalExpression.
(OFBIZ-10533)

The TemporalExpression for "MIDNIGHT_DAILY" has to be loaded as seed 
data instead of initial-seed data to be available for other seed-initial
usages of this TemporalExpression.
The fix moves this TemporalExpression to the other TemporalExpression 
seed data in ServiceSeedData.xml.

Thanks Martin Becker for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848449 13f79535-47bb-0310-9956-ffa450edef68
2018-12-08 09:49:21 +00:00
Jacques Le Roux 5f1773068a Fixed: User's name is displayed on ecommerce even after user logs out
(OFBIZ-10666)

Steps to regenerate:
Open URL: https://demo-trunk.ofbiz.apache.org/ecommerce/control/main. 
  Welcome is displayed and user's name is not displayed when URL is opened.
Login at ecommerce, username will be displayed after user logs in.
Logout of ecommerce by clicking on logout. User will be logged out and login 
  link will be displayed in place of logout link, but the name of user is still 
  displayed.

Actual: Username is still displayed after user logs out
Expected: Username should not be displayed after the user logs out

Note: Similar issue also exists when the user clicks on (Not You?) link.

Thanks: Arpit Mor for detailled report, Deepak Dixit for discussion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848398 13f79535-47bb-0310-9956-ffa450edef68
2018-12-07 13:14:48 +00:00
Jacques Le Roux a5f6489a5f Improved: no functional change, just formatting
Put a couple of brackets to make things clearer


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848315 13f79535-47bb-0310-9956-ffa450edef68
2018-12-06 14:09:45 +00:00
Jacques Le Roux 0d5c18dc22 Improved: no functional change, just order the imports
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1847954 13f79535-47bb-0310-9956-ffa450edef68
2018-12-02 10:35:08 +00:00
Jacques Le Roux a05421414d Fixed: Create a PoC for a documentation system for OFBiz based on Asciidoc
(OFBIZ-9873)

I wrongly added ServerTableEntryTest.java at some point, this removes it

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1847891 13f79535-47bb-0310-9956-ffa450edef68
2018-12-01 12:35:17 +00:00
Jacques Le Roux 426df38d97 Fixed: Create a PoC for a documentation system for OFBiz based on Asciidoc
(OFBIZ-9873)

At r1831619 we committed a workaround to "turn off PDF in windows for now"

I have found a real solution for this bug which prevents to check PDF results in 
Windows because the PDF were not generated there.

I found this solution at 
https://github.com/asciidoctor/asciidoctorj-pdf/issues/8. 
After reading https://github.com/asciidoctor/asciidoctor-pdf/issues/850 
I checked it also works on Linux.

It uses the last version of jruby-complete.

I guess the gradle-versions-plugin should be able to warn us when an upgrade of 
jruby-complete is available like it does for junitReport.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1847890 13f79535-47bb-0310-9956-ffa450edef68
2018-12-01 12:30:50 +00:00
Jacques Le Roux b31fd85dc1 Improved: Multi Part Input Parameters not Available in Groovy Event
(OFBIZ-5048)

If a form is of type enctype="multipart/form-data" and we are handling its 
submission through Groovy Event then in the parameters Map Ofbiz does not set 
the multipart input parameters from request parameters.

The same are available when multipart form submission is handled through service.

The reason being the code that sets the multipart parameters in request 
attribute is only available in ServiceEventHandler.java and in 
GroovyEventHandler the multipart are never set.

So I have created a method getMultiPartParameterMap in the class UtilHttp.java 
and put the common logic in that method so that when getCombinedMap method is 
called from the GroovEventHandler the method also call getMultiPartParameterMap 
and in the ServiceEventHandler I have written a call for 
getMultiPartParameterMap method.

Thanks: Vikramjit Singh for report and initial patch, Rohit Koushal for updated
and revised patch with some minor changes.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1847478 13f79535-47bb-0310-9956-ffa450edef68
2018-11-26 16:41:52 +00:00
Jacques Le Roux f5cd96479b Documented: no functional change
Fixes security-impersonation.adoc file name to sy-impersonation.adoc



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1847224 13f79535-47bb-0310-9956-ffa450edef68
2018-11-23 08:53:02 +00:00
Jacques Le Roux 558e58b10a Documented: no functional change
Fixes levels, I did not get that AsciiDoctor is handling that automatically


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1847223 13f79535-47bb-0310-9956-ffa450edef68
2018-11-23 08:43:42 +00:00
Jacques Le Roux 78940e209d Documented: no functional changes
Formats too long lines in wa-cross-domains-SSO.adoc 
Fixes references in bt-creating reports.adoc
Fixes text in bt-report master creation.adoc

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1847177 13f79535-47bb-0310-9956-ffa450edef68
2018-11-22 15:07:19 +00:00
Jacques Le Roux 159fb21f80 Documented: no functional change
Renames the security doc dir to docs as requested by documentation guidelines
Includes webapp.adoc in developer-manual.adoc



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1847078 13f79535-47bb-0310-9956-ffa450edef68
2018-11-21 08:15:36 +00:00
Jacques Le Roux d3e8d41da3 Improved: Remove duplicated code when running login/logout events
(OFBIZ-10474)

In an effort of refactoring the RequestHandler class, I have factored the code 
from runAfterLoginEvents and runBeforeLogoutEvents using a FunctionalInterface

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846899 13f79535-47bb-0310-9956-ffa450edef68
2018-11-19 14:31:21 +00:00
Jacques Le Roux 5d94c98350 Improved: Use ‘String#equalsIgnoreCase’ in ‘RequestHandler#doRequest’
(OFBIZ-10451)

Use String#equalsIgnoreCase instead of combining String#equals and 
String#toUpperCase. Additionally this avoids having to check the emptiness 
of the X-Forwarded-Proto request header.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846793 13f79535-47bb-0310-9956-ffa450edef68
2018-11-17 12:32:04 +00:00
Jacques Le Roux 057e8341ce Improved: Remove useless ControlServlet code
(OFBIZ-10447)

It seems better to remove some code and rely on method/contructor dispatch.

jleroux: w/o specific implementations, there is no point indeed

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846790 13f79535-47bb-0310-9956-ffa450edef68
2018-11-17 09:49:56 +00:00
Jacques Le Roux 6898087988 Improved: Override ‘GenericServlet::init’ instead of ‘Servlet::init’
(OFBIZ-10446)

This is done to remove the manual call to {{super}} which is done in
{{GenericServlet}} instead.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846789 13f79535-47bb-0310-9956-ffa450edef68
2018-11-17 09:41:17 +00:00
Jacques Le Roux b82c69b594 Improved: Inline ‘ControlServlet::getRequestHandler’ method
(OFBIZ-10445)

There was only two local callers of this trivial method, so remove it.
Rename requestHandler in doGet local variable to handler.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846784 13f79535-47bb-0310-9956-ffa450edef68
2018-11-17 09:22:22 +00:00
Jacques Le Roux 6b357486e2 Improved: Simplification of the service callback handling
(OFBIZ-10649)

The service callback handling done in 
  org.apache.ofbiz.service.engine.AbstractEngine 
can be rewritten more nicely without explicit iterators. 
Additionally it is not nice that the engine is responsible for removing 
disabled callbacks. The ServiceDispatcher should be responsible for removing 
them.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846783 13f79535-47bb-0310-9956-ffa450edef68
2018-11-17 08:57:19 +00:00
Jacques Le Roux b0478d13f0 Improved: XML schemas should use predefined boolean type
(OFBIZ-10411)

To define boolean values, some ad-hoc enumeration of "true" and "false" are 
repeatedly used.  Since XML Schema defines a standard boolean datatype it's 
better to use it.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846727 13f79535-47bb-0310-9956-ffa450edef68
2018-11-16 16:38:24 +00:00
Aditya Sharma 780cc1af3e Fixed: Missing Security and Cache Headers in CMS Events
(OFBIZ-10597)
Instead of having multiple null checks for viewMap separately for each security header we can have a single combined null check at the top in setResponseBrowserDefaultSecurityHeaders() method.

With increasing security headers these may become expensive.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846632 13f79535-47bb-0310-9956-ffa450edef68
2018-11-15 10:40:55 +00:00
Jacques Le Roux c1d09961dd Improved: Clean some Groovy files in base component
(OFBIZ-10646)

Following discussion at https://markmail.org/message/y3izmnxd7jd6jbkf 
this cleans some Groovy files in the base component, notably:

* remove ant-scripts folder and its content.
* Rename framework/base/groovyScript to framework/base/groovyScripts;
* Move GroovyInit.groovy and GroovyServiceTest.groovy respectively to 
  framework/base/groovyScripts and framework/common/groovyScripts 
  and change their paths where used.
* Removes GroovyInit.groovy from excludedConfigFiles in build.gradle
* After OFBIZ-10611 it's possible to move GroovyBaseScript.groovy  from
  framework/service/src/main/java/org/apache/ofbiz/service/engine
  to
  framework/service/src/main/groovy/org/apache/ofbiz/service/engine
* Removes FileUtilTests.groovy from basetests.xml (missed it in OFBIZ-10611)
* Fixes a typo in test-suite.xsd

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846485 13f79535-47bb-0310-9956-ffa450edef68
2018-11-13 05:03:51 +00:00
Jacques Le Roux 7cc7fd2cea Improved: Allow unit tests to be written in Groovy
(OFBIZ-10611)

Since OFBIZ-9996 it is possible to write integration tests in Groovy, meaning 
test that depend on the dispatcher and the delegator. It would be nice if the 
unit tests could be written in Groovy too.

The major benefit of writing tests in Groovy is that you create inputs and 
expected outputs more easily with objects literals. 
For example the following java code:

Map<String, Integer> input = new HashMap<>();
  input.put("foo", 42);
  input.put("bar", 37);

can be rewritten in Groovy like this:
  def input = [foo: 42, bar: 37]

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846393 13f79535-47bb-0310-9956-ffa450edef68
2018-11-12 10:57:27 +00:00
Rishi Solanki a3ab29266f Improved: Introduce ability to clear specific cache from cache maintenance. Import the specific classes those are required instead of complete util package.
(OFBIZ-10402)
Thanks to Aditya Sharma for review and feedback.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846298 13f79535-47bb-0310-9956-ffa450edef68
2018-11-10 11:30:42 +00:00
Jacques Le Roux fceb3e087c Improved: remove deprecated and not used PhoneNumber functions
(OFBIZ-10631)

Several phone number validation functions have been deprecated (and are not used in framework code).
This concerns:
    isUSPhoneNumber
    isUSPhoneAreaCode
    isUSPhoneMainNumber
    isInternationalPhoneNumber

Thanks: Pierre Smits

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846213 13f79535-47bb-0310-9956-ffa450edef68
2018-11-09 08:01:49 +00:00
Jacques Le Roux 30a514870c Improved: Add the ability to schedule a job to run as a system/service user
(OFBIZ-9557)

When scheduling a job it automatically schedules it to run as the user that 
created the schedule. The issue comes up when that users password changes. 

If your are forced to change your password automatically you have to delete all 
previously scheduled jobs and recreate them. 

This adds a checkbox to run a job as system on Schedule Job screen as system user
Permissions are used to guarantee security.

Thanks: Matthew Mulligan for report and Rohit Koushal for discussion and patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846137 13f79535-47bb-0310-9956-ffa450edef68
2018-11-08 13:20:32 +00:00
Jacques Le Roux 03009b3c83 Fixed: Error in GetLocaleListTests.java
(OFBIZ-10641)

A test error related to GetLocaleListTests.java seems to happen only on a fresh 
trunk install when running unit tests. It's no stopping tests. 

I'm not sure yet if R17 is concerned. I did not try, but will 1st confirm with
this commit with trunk demo error.loç

Mathieu suggested to  replace the location 
component://base/config/GroovyInit.groovy 
with ofbizhome://framework/base/config/GroovyInit.groovy
because GroovyUtil [should not] depend on the component container in the 
1st place, and it seems to work.

Thanks: Mathieu for the idea.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845933 13f79535-47bb-0310-9956-ffa450edef68
2018-11-06 16:33:11 +00:00
Rishi Solanki 4dc6101ce2 Improved: Introduce ability to clear specific cache from cache maintenance. After this user can bulk select the caches and clear them. Single clear and all clear caches works as is.
(OFBIZ-10402)
Thanks to Yogesh Naroliya for providing the patch and Suraj Khurana for reporting the ticket.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845572 13f79535-47bb-0310-9956-ffa450edef68
2018-11-02 11:18:52 +00:00
Jacques Le Roux 102dd5d242 Fixed: Correct behaviour of Autologin cookies
(OFBIZ-10635)

Renames "keep-autologin-cookie" to "use-autologin-cookie", and only create 
Autologin cookies when needed. No need to create Autologin cookies in 
applications that don't need it.

Don't pass webAppName to LoginWorker::getSecuredUserLoginId, that can be handled
with improved LoginWorker::getSecuredLoginIdCookieName

Removes LoginWorker::autoLogoutCleanCookies, no longer needed since only those
needed are created and kept (1 year at least after creation).

For both autoLogin and securedLoginId cookies sets the path to the application.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845558 13f79535-47bb-0310-9956-ffa450edef68
2018-11-02 09:46:42 +00:00
Jacques Le Roux a1e28bf1e2 Fixed: ComponentConfig::getAppBarWebInfos creates infos only for components
without <<app-bar-display="false">>
(OFBIZ-10637)

LoginWorked::getAppBarWebInfos is used to define the apps menus in themes so we
need to also check that no menuName is passed to 
ComponentConfig::getAppBarWebInfos. Else all menus appears in the secondary menu
bars


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845552 13f79535-47bb-0310-9956-ffa450edef68
2018-11-02 08:48:31 +00:00
Jacques Le Roux da591d600d Fixed: ComponentConfig::getAppBarWebInfos creates infos only for components
without <<app-bar-display="false">>
(OFBIZ-10637)

It makes no sense since if the menuName var is empty the infos are returned.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845544 13f79535-47bb-0310-9956-ffa450edef68
2018-11-02 07:59:16 +00:00
Jacques Le Roux 5d14a3a77f Implemented: Navigate from a domain to another with automated signed in
authentication
(OFBIZ-10307)

While working on OFBIZ-10635 I spotted that I used a root path for 
securedLoginId cookies. It's better to set it to the webapp name like it's done
by Tomcat for the JSESSIONID cookie. This fixes it.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845502 13f79535-47bb-0310-9956-ffa450edef68
2018-11-01 17:23:46 +00:00
Jacques Le Roux 4553b14814 Implemented: Navigate from a domain to another with automated signed in
authentication
(OFBIZ-10307)

While working on OFBIZ-10635 I spotted that at r1844880 I forgot to put a call
to LoginWorker::createSecuredLoginIdCookie in LoginWorker::checkExternalLoginKey
in the general case (when the user log in for the 1st time). This fixes it.
Also makes the comment makes sense.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845497 13f79535-47bb-0310-9956-ffa450edef68
2018-11-01 16:29:08 +00:00
Jacques Le Roux ff1d9bb77f Improved: no functional change, just some formatting
Thanks: Taher for review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845466 13f79535-47bb-0310-9956-ffa450edef68
2018-11-01 12:55:26 +00:00
Jacques Le Roux 115d59916d Fixed: Missing Security and Cache Headers in CMS Events
Fixed:
(OFBIZ-10597)

While rendering the view through the controller request we set the important 
security headers like x-frame-options, strict-transport-security, 
x-content-type-options, X-XSS-Protection and Referrer-Policy etc. in the 
response object. (Please see the 'rendervView' method of RequestHandler class.) 
 
In the similar line, we set the cache related headers like Expires, 
Last-Modified, Cache-Control, Pragma.
 
But these security headers are missing in the pages rendered through CMS. 
(Please visit the CmsEvents class).
 
These headers are very crucial for the security of the application as they help 
to prevent various security threats like cross-site scripting, 
cross-site request forgery, clickjacking etc. 

Thanks: Deepak Nigam for initial patch and review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845418 13f79535-47bb-0310-9956-ffa450edef68
2018-11-01 09:36:35 +00:00
Jacques Le Roux 8d82646206 Improved: Correct behaviour of Autologin cookies
(OFBIZ-10635)

While working on this issue I spotted that securedLoginId has the same duration 
(1 year) than autoUserLoginId. 
I have reduced it to the browser session which is the purpose.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845341 13f79535-47bb-0310-9956-ffa450edef68
2018-10-31 15:36:11 +00:00
Jacques Le Roux 45ba53e982 Improved: Remove unused ‘RequestHandler::doRequest’ method
(OFBIZ-10452)

The RequestHandler#doRequest is only a wrapper for an overload.  
Since it is not used anywhere in the framework, just remove it.

jleroux: jaz (Andrew Zeneski) added it as a "convenience". I see no problems
removing it

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845208 13f79535-47bb-0310-9956-ffa450edef68
2018-10-30 09:37:08 +00:00
Suraj Khurana 9ca5823a8a Improved: Consistency and Readability improvements for include-menu tag.
(OFBIZ-8972)
Thanks Ankush Upadhyay for reporting and Devanshu Vyas for providing the updated patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845088 13f79535-47bb-0310-9956-ffa450edef68
2018-10-29 08:29:43 +00:00
Jacques Le Roux 16c821cc54 Improved: no functional change, just some formatting I forgot at r1844729
The whole file is in need, but that would mean to blur things in svn history...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1844909 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 15:53:46 +00:00
Jacques Le Roux fbfa0daa5a Implemented: Navigate from a domain to another with automated signed in
authentication
(OFBIZ-10307)

This uses a JWT Token authentication to get from one domain, where you are 
signed in, to another domain where you get signed in automatically. 
Something like ExternalLoginKey or Tomcat SSO, but not on the same domain.

In the example component, the FormWidgetExamples screen contains 2 new fields 
in the LinksExampleForm which demonstrate the use from a local instance to the
trunk demo instance.

A simple documentation is available in 
  framework\webapp\src\docs\asciidoc\_include\wa-cross-domains-SSO.adoc

Thanks: Taher for review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1844880 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:46 +00:00
Jacques Le Roux a9c4eb3427 Implemented: Token Based Authentication
(OFBIZ-9833)

This uses the JJWT library to implement a lightweight but complete solution 
to provide a web token authentication mechanism for clients performing API 
calls to OFBiz and other possibilities offered by using a JWT (JSON Web Token)

Here is the dev list discussion for token based authentication work:
http://markmail.org/message/vyskeh2wujqpkbwg

Thanks: Deepak Dixit for the patch. Jacopo and Nicolas for the discussion about
how to enforce the storing of the secret key. This will be continued on the 
dev ML

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1844865 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 07:09:10 +00:00
Jacques Le Roux d5925e6128 Improved: Remove few request-map "edit" attributes in controllers
(OFBIZ-10608)

As documented, currently

    Reserved for future use (not used yet).

I checked, it's still not implemented. So no need to confuse people for now, 
better to remove until it's really used.




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1844744 13f79535-47bb-0310-9956-ffa450edef68
2018-10-24 08:57:03 +00:00
Jacques Le Roux a6ba3b215c Improved: Create an "url-redirect" response type
(OFBIZ-10599)

As discussed with Dennis in OFBIZ-10569, the idea is to implement an 
"url-redirect" response type where an external URL can be set with redirected 
parameters like it's done with request-redirect which is only internal.

Thanks: Dennis Balkir

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1844729 13f79535-47bb-0310-9956-ffa450edef68
2018-10-24 07:55:37 +00:00