Commit Graph
10472 Commits
Author SHA1 Message Date
Jacques Le Roux ad21c41b34 Improved: Improve ObjectInputStream class
(OFBIZ-10837)

Fixes CVE-2019-0189

The white list was still not complete as reported by Ed Mack
This adds 
org.apache.ofbiz.widget.model.ModelTheme
java.util.Collections 
java.util.LinkedList 
java.util.ArrayList
java.util.TimeZonz


Thanks: Ed Mack at OFBIZ-10876

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856484 13f79535-47bb-0310-9956-ffa450edef68
2019-03-28 15:36:13 +00:00
Jacques Le Roux 495a76f886 Improved: Improve ObjectInputStream class
(OFBIZ-10837)

Fixes CVE-2019-0189

There was a recurring typo in previous commit.
For arrays of primitives it should be 
"\\[Z","\\[B","\\[S","\\[I","\\[J","\\[F","\\[D","\\[C"
and not 
"[Z","[B","[S","[I","[J","[F","[D","[C"
It shows how tired I'm :/


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856460 13f79535-47bb-0310-9956-ffa450edef68
2019-03-28 08:30:21 +00:00
Jacques Le Roux 0cc1913a34 Improved: Improve ObjectInputStream class
(OFBIZ-10837)

Fixes CVE-2019-0189

There was a recurring typo in previous commit.
For arrays of primitives it should be 
"[Z","[B","[S","[I","[J","[F","[D","[C"
and not 
"[Z ","[B ","[S ","[I ","[J ","[F ","[D ","[C "
Just spotted that while reviewing again (did not have the time to test)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856459 13f79535-47bb-0310-9956-ffa450edef68
2019-03-28 08:18:19 +00:00
Jacques Le Roux 87a1138fb2 Improved: Improve ObjectInputStream class
(OFBIZ-10837)

Fixes CVE-2019-0189

The white list was still not complete as reported by Ed Mack
This adds all arrays of primitives and java.math.BigDecimal 

Thanks: Ed Mack at OFBIZ-10876

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856455 13f79535-47bb-0310-9956-ffa450edef68
2019-03-28 07:50:32 +00:00
Jacques Le Roux 6f8cb540eb Improved: Improve ObjectInputStream class
(OFBIZ-10837)

Fixes CVE-2019-0189

The white list was still not complete as reported by Wolfgang Rauchholz on user
ML 
This adds java.math.BigDecimal and "[B" (ie [B == byte[] and I don't understand
why in this case "byte[]" does not work)

It seems the warning in SafeObjectInputStream::resolveClass is not enough. 
Anyway I'll not change it.

Thanks: Ingo Wolfmayr at OFBIZ-10870

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856405 13f79535-47bb-0310-9956-ffa450edef68
2019-03-27 14:16:24 +00:00
Nicolas Malin 2e1cacb2a8 Improved: Improve error message page to support Theming
(OFBIZ-10753)

When OFBiz raise an error, the framework use a jsp page to display it.
I improved the error page generation to support also ftl template rendering and by this way extend the theme engine to support to overide it

On controler.xml we can now use :
    <errorpage>/error/error.jsp</errorpage>
or 
    <errorpage>component://common/webcommon/error/Error.ftl</errorpage> (default configuration)

On your theme you can add your own error page :
    <template> 
      ...
      <template-file widget=menu location=component://common-theme/template/macro/HtmlMenuMacroLibrary.ftl/>
    + <template-file widget=error location=component://common-theme/template/ErrorPage.ftl/>
    </template>

The component://common/webcommon/error/Error.ftl contains the logic theming connection and to simplify source code, all framework old error page (error.jsp) have been removed to centralize all on this new page.

Thanks to Marine Desmarchelier for the error page design

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856175 13f79535-47bb-0310-9956-ffa450edef68
2019-03-25 09:31:02 +00:00
Swapnil Mane 29f2e071eb Improved: Moved the nodeType check after node.getTextContent() method call
(OFBIZ-10832)

Since most nodes will contain text then it will be more efficient to do a null check after retrieving nodeValue.

Thanks: Scott for your valuable inputs.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1855898 13f79535-47bb-0310-9956-ffa450edef68
2019-03-20 12:15:59 +00:00
Mathieu Lirzin d90431a3f5 Fixed: Adapt some javadoc to let the build succeed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1855674 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 23:23:09 +00:00
Deepak Dixit 3facb0a7ac Reverted: Changes done at r#1854306, Removed the extra space from CommonBranch uiLabel values
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1855497 13f79535-47bb-0310-9956-ffa450edef68
2019-03-14 09:25:30 +00:00
Jacques Le Roux 458f2217b8 Improved: Improve ObjectInputStream class
(OFBIZ-10837)

Fixes CVE-2019-0189

The white list was still not complete as reported by Wolfgang Rauchholz on user
ML 
This adds java.util.Date

It seems the warning in SafeObjectInputStream::resolveClass is not enough. 
Anyway I'll not change it.

Thanks: Wolfgang Rauchholz

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1855492 13f79535-47bb-0310-9956-ffa450edef68
2019-03-14 08:28:27 +00:00
Jacques Le Roux f94a5b94d0 Improved: Improve ObjectInputStream class
(OFBIZ-10837)

Fixes CVE-2019-0189

The white list was still not complete as reported by Wolfgang Rauchholz on user
ML 
This adds java.sql.Timestamp

It seems the warning in SafeObjectInputStream::resolveClass is not enough. 
Anyway I'll not change it.

Thanks: Wolfgang Rauchholz

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1855488 13f79535-47bb-0310-9956-ffa450edef68
2019-03-14 07:42:17 +00:00
Swapnil Mane ff17b108c5 Fixed: simpleTypeConvert always returns Null for Document, Document Type and Notation Node
(OFBIZ-10832)

As per the code, getTextContent() method is used get text content of the node and its descendants but the node.getTextContent() always return Null for the following Node type
DOCUMENT_NODE, DOCUMENT_TYPE_NODE, NOTATION_NODE [1]

Since we can't get the text value of Document, Document Type and Notation Node, thus simply return the same object.

[1] https://docs.oracle.com/javase/7/docs/api/org/w3c/dom/Node.html#getTextContent()

Thanks: Deepak Dixit for reviewing the code.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1855403 13f79535-47bb-0310-9956-ffa450edef68
2019-03-13 12:27:13 +00:00
Rishi Solanki 8d1d113148 Implemented: Short Messaging Service(SMS) Gateway Integration. Added data model, configuration settings, data and services to support the sms services. For the specific service provider user of this implementaion needs to go for custom implementation. That means ticket contains the example of the integration how to use with sample plugin for message91 services.
(OFBIZ-10457)
Thanks to Pritam Kute for your contribution. 
Thanks to Pierre Smits and Michael Brohi for your review and inputs.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1855389 13f79535-47bb-0310-9956-ffa450edef68
2019-03-13 10:02:15 +00:00
Jacques Le Roux 40a9d42769 Improved: Improve ObjectInputStream class
(OFBIZ-10837)

Fixes CVE-2019-0189

The white list was still not complete as reported by Deepak at OFBIZ-10837
This adds sun.util.calendar.ZoneInfo

It seems the warning in SafeObjectInputStream::resolveClass is not enough. 
Anyway I'll not change it.

Thanks: Deepak Dexit

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1855371 13f79535-47bb-0310-9956-ffa450edef68
2019-03-13 08:19:32 +00:00
Jacques Le Roux 02157fa5b0 Improved: Improve ObjectInputStream class
(OFBIZ-10837)

Fixes CVE-2019-0189

The white list was still not complete as reported by Rohit at OFBIZ-10573
This adds FlexibleStringExpander

It seems the warning in SafeObjectInputStream::resolveClass is not enough. 
Anyway I'll not change it.

Thanks: Rohit Koushal

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1855287 13f79535-47bb-0310-9956-ffa450edef68
2019-03-12 08:29:37 +00:00
Deepak Dixit d8592b950b Modify the log level from info to verbose if internal sso is disabled.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854979 13f79535-47bb-0310-9956-ffa450edef68
2019-03-07 13:15:21 +00:00
Deepak Dixit 7b9ea305d7 Preparation for JDK11 update, Updated following code to fix warning with respect to JDK11
- Replaced Class::newInstance occurrences 
- Removed deprecated override method Object::finalize
(OFBIZ-10757)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854683 13f79535-47bb-0310-9956-ffa450edef68
2019-03-03 10:27:29 +00:00
Mathieu Lirzin e8ea418cb6 Improved: Rewrite ‘ComponentConfig’ constructor (OFBIZ-10829)
Previouly this constructor was containing a lot of duplicated code
that is now factorized by using the newly added ‘collectElements’
private method.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854671 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 20:28:36 +00:00
Mathieu Lirzin 617b762915 Improved: Disallow extension of the script helper bindings (OFBIZ-10825)
‘ScriptHelper’ is a mechanism used to add some useful bindings to
scripts.  This feature has been introduced in revision 1299924 by
Adrian Crum as part of an general effort of supporting the Generic
Scripting Engine specified by JSR-223.

Previously this mechanism was extensible, however it appears to be
undesirable (nor used in practice) to extend the bindings available to
services since the internal service implementations are highly coupled
to those bindings.  As a consequence the usage of the Abstract Factory
pattern which was used for that purpose is now removed.

The side effect of this change is that we have now simpler code.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854668 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 19:40:48 +00:00
Mathieu Lirzin 4fbb189ac9 Improved: Use ‘FlexibleLocation#resolveLocation(String)’ when possible (OFBIZ-10821)
Previously the artifact info classes were using the
‘FlexibleLocation#resolveLocation(String, ClassLoader)’ method by
passing ‘null’ as the second argument which is equivalent to calling
the more specific ‘FlexibleLocation#resolveLocation(String)’ method
with the same first argument.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854667 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 19:31:44 +00:00
Mathieu Lirzin 10891b6022 Improved: Remove ‘GroovyUtil#loadClass’ (OFBIZ-10820)
The ‘GroovyUtil#loadClass’ method was not used anywhere in the
framework.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854665 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 19:19:40 +00:00
Mathieu Lirzin dea9ca9445 Improved: Rewrite ‘GroovyUtil#parseClass’ (OFBIZ-10822)
The ‘parseClass(InputStream in, String location)’ and
‘parseClass(InputStream in, String location, GroovyClassLoader
groovyClassLoader)’ methods from GroovyUtil are now merged in a
private and documented method.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854663 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 19:14:24 +00:00
Mathieu Lirzin 7c5cebbc55 Improved: Rewrite ‘AbstractEngine#createLocationMap’ (OFBIZ-10810)
This adds some documentation and uses the ‘forEach’ method instead of
a ‘for’ loop.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854659 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 17:35:23 +00:00
Mathieu Lirzin 9833660662 Improved: Rewrite ‘AbstractEngine#getLocation’ (OFBIZ-10809)
The AbstractEngine#getLocation method is now documented and rewritten
using a single statement.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854658 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 17:26:25 +00:00
Mathieu Lirzin f58f0697ed Improved: Inline ‘serviceInvoker’ method in Groovy engine (OFBIZ-10808)
The ‘runSync’ method of the Groovy engine was only passing its
arguments to the serviceInvoker method which was private and used only
by the ‘runSync’ method.  By inlining this private method the work is
now done directly in the ‘runSync’ method.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854656 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 17:16:47 +00:00
Mathieu Lirzin 4af444183d Improved: Rewrite ‘GroovyUtil#runScriptAtLocation’ (OFBIZ-10807)
The ‘GroovyUtil#runScriptAtLocation’ method has now a javadoc and is
rewritten as a simple ternary expression.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854653 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 17:09:54 +00:00
Mathieu Lirzin 164849a796 Improved: Remove Groovy Base script redundancy (OFBIZ-10806)
According to Groovy documentation [1] the following construction:

    CompilerConfiguration cfg = new CompilerConfiguration();
    cfg.setScriptBaseClass(scriptBaseClass);
    groovyClassLoader =
        new GroovyClassLoader(GroovyUtil.class.getClassLoader(), cfg);

is equivalent to running the a script containing the ‘@BaseScript’
annotation.  Previously in ‘org.apache.ofbiz.base.util.GroovyUtil’
instead of choosing one solution, we were doing both.  Now we only
rely on the construction described above.

[1] http://docs.groovy-lang.org/latest/html/documentation/#_script_base_classes


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854652 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 17:02:32 +00:00
Mathieu Lirzin e6a00e6427 Improved: Disallow alternate test dispatcher/delegator (OFBIZ-10723)
Previously the way integration tests were run allows having a specific
dispatcher and delegator for each test.  Removing this feature helps
future simplification of the way integration tests are actually run by
allowing the algorithm to assume only one dispatcher and delegator for
all the tests.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854650 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 16:23:39 +00:00
Jacopo Cappellato 7fb91f15ef Implemented: Added ability to configure the embedded Tomcat instance to
communicate using the HTTP/2 protocol, when the client supports it.

With this commit HTTP/2 is enabled by default, by setting upgradeProtocol=true 
in the http and https connectors of Tomcat; however the connectors will continue 
to support HTTP/1.1 (the switch to HTTP/2 is negotiated with the client using 
the "HTTP Upgrade Protocol"); if the new "upgradeProtocol" property, introduced 
in this commit for this specific purpose, is not set (as it would be the case in 
custom configuration files) then the new protocol will not be enabled.

Additional Tomcat specific configuration options are available (see 
https://tomcat.apache.org/tomcat-9.0-doc/config/http2.html) but this commit 
doesn't implement the ability to set them (this is left to a future enhancement, 
if there will be a requirement to change the default values).


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854532 13f79535-47bb-0310-9956-ffa450edef68
2019-02-28 15:12:20 +00:00
Mathieu Lirzin a274e0f74c Fixed: Add missing tests for ‘WebAppCache’ (OFBIZ-10606)
This adds a test file which should have been added in revision 1854430
but was forgotten by accident.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854434 13f79535-47bb-0310-9956-ffa450edef68
2019-02-26 23:09:10 +00:00
Mathieu Lirzin 9b5340fd3a Improved: Use Optional for ‘getWebappInfo’ (OFBIZ-10606)
Adapt ‘LoginWorker#autoLoginSet’ which is its unique caller.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854433 13f79535-47bb-0310-9956-ffa450edef68
2019-02-26 22:58:53 +00:00
Mathieu Lirzin 9d209d919a Improved: Inline getAppBarWebInfos(String, Comparator, String) private method (OFBIZ-10606)
The comparator argument of this method was always ‘null’.  Use
‘java.util.TreeMap()’ constructor in the inlined function which is
equivalent to passing ‘null’ to ‘java.util.TreeMap(Comparator)’.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854432 13f79535-47bb-0310-9956-ffa450edef68
2019-02-26 22:57:50 +00:00
Mathieu Lirzin 6be4f5e37f Improved: Refactor ‘WebAppCache’ (OFBIZ-10606)
This makes use of streams and lambdas.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854431 13f79535-47bb-0310-9956-ffa450edef68
2019-02-26 22:57:00 +00:00
Mathieu Lirzin d0356437c8 Improved: Add tests for ‘WebAppCache’ (OFBIZ-10606)
Those tests requires additional constructors for ‘ComponentConfig’
and ‘ComponentConfig.WebappInfo’ to be able to instantiate them
without an XML element.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854430 13f79535-47bb-0310-9956-ffa450edef68
2019-02-26 22:52:27 +00:00
Mathieu Lirzin 4aa65a5b68 Improved: Add ‘WebAppCache’ (OFBIZ-10606)
This improves the cohesion of the ‘ComponentConfig’ class by
extracting the webapps cache related methods into a separate
‘WebAppCache’ class.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854429 13f79535-47bb-0310-9956-ffa450edef68
2019-02-26 22:47:58 +00:00
Jacques Le Roux 96d1388d13 Improved: no functional change
Fixes a typo in comment. I checked it's still not implemented in last DBCP (2.6.0)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854366 13f79535-47bb-0310-9956-ffa450edef68
2019-02-26 10:09:40 +00:00
Jacques Le Roux c6d9585411 Improved: no functional change
A missing space before CommonBranch label made the word trunkbranch instead of
trunk branch.

I'll backport this

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854306 13f79535-47bb-0310-9956-ffa450edef68
2019-02-25 10:33:53 +00:00
Deepak Dixit a2c3965fe5 Improved: Updated code to fix some deprecated method call warnings
(OFBIZ-10757)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1853905 13f79535-47bb-0310-9956-ffa450edef68
2019-02-19 18:05:43 +00:00
Jacques Le Roux 40c971275a Improved: Improve ObjectInputStream class
(OFBIZ-10837)

Fixes CVE-2019-0189

The white list I used was not complete.
This adds "java.util.HashMap", "Boolean", "Number", "Integer" which are the ones
missing I found so far. 
Maybe other classes could still miss OOTB. So I added a warning in 
SafeObjectInputStream::resolveClass

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1853745 13f79535-47bb-0310-9956-ffa450edef68
2019-02-17 12:38:06 +00:00
Jacques Le Roux cd5ba2b8ce Improved: Improve ObjectInputStream class
(OFBIZ-10837)

Fixes CVE-2019-0189

As reported by FindBugs and Sonar, it's troubling (a Bad practice in Sonar[1], 
a code smell in Findbugs[2]) when extending to use the same name than the 
extended Object

[1] https://sbforge.org/sonar/rules/show/findbugs:NM_SAME_SIMPLE_NAME_AS_SUPERCLASS?layout=false
[2] https://logging.apache.org/log4j/log4j-2.2/log4j-jul/findbugs.html

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1853691 13f79535-47bb-0310-9956-ffa450edef68
2019-02-16 09:42:03 +00:00
Michael Brohl 1a196b977f Fixed: Error parsing JWT
(OFBIZ-10814)

Fixes incorrect retrieval of the Authorization header JWT token. 
Fixes wrong API usage for the key parameter which assumed the key is
provided in BAS64 format.
Refactored the code to use helper methods for key and auth header 
retrieval.
Javadoc corrections and enhancements.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1852882 13f79535-47bb-0310-9956-ffa450edef68
2019-02-04 09:22:19 +00:00
Taher A. Alkhateeb 61b35b92d0 Improved: Refactor the startup API to completely remove the startup loaders collection
This commit refactors the startup bootstrapping logic to remove any references to the
StartupLoader API and any related files. This is due to the fact that any loaders
including the old POS is completely removed from the system. Thus this improvement
simplifies the startup logic and makes it easier to maintain.

Thank you: Mathieu Lirzin for the patch, careful review and patience


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1852847 13f79535-47bb-0310-9956-ffa450edef68
2019-02-03 19:47:27 +00:00
Arun Patidar 8ef6a2b7ac Fixed: Services of EntitySync Push and Pull functionalities
(OFBIZ-10818)

Set transaction timeout of 2hrs for the actual data transmission services.
Removed unwanted service updateEntitySyncRunning
Called the tracking and status update services in new transaction so that record can be maintain after current transaction rollback

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1852587 13f79535-47bb-0310-9956-ffa450edef68
2019-01-31 11:54:45 +00:00
Nicolas Malin af382be977 Fixed: Disable widget verbose property on context doesn't works for rendering ftl template
When OFBiz render a platform specific with a ftl template file, the widget verbosity throw function ModelWidget.widgetBoundary() was called with parameters as context. However this function control if a parameters is already present, so if you set a context.widgetVerbose = false, is was ignored and widget verbosity was present for ftl rendering.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1852532 13f79535-47bb-0310-9956-ffa450edef68
2019-01-30 16:18:00 +00:00
Jacques Le Roux 193bd6b75c Fixed: Impossible secure and autologin cookie names when mountpoint contains a
slash inside its name
(OFBIZ-10766)

Deepak Nigam reported on dev ML:
When there is one web app with the empty mount point (i.e. deployed on root), 
the auto-login cookie will not work for that particular webapp due to the change 
in the path of the cookie from "/" to "/" + applicationName. Because the system 
will try to find the cookie at the "/" but it is actually at "/" + applicationName.

Thanks Deepak for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851998 13f79535-47bb-0310-9956-ffa450edef68
2019-01-24 08:17:38 +00:00
Arun Patidar 6ae8fe69b8 Fixed: EntitySync Push and Pull functionalities
(OFBIZ-10818)

Removed unneccessary service implementation and used entity-auto
Fixed some create/update code block in the flow

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851805 13f79535-47bb-0310-9956-ffa450edef68
2019-01-22 11:51:46 +00:00
Jacques Le Roux c4c5c8a142 Improved: ‘ObjectType’ contains unneeded code
(OFBIZ-10771)

The ObjectType class contains utilities that extends the Java reflection API by 
defining methods which accepts string representation of Java types and classes.
It appears that this class contains unneeded code which is either dead or is 
redundant with the services already defined in the reflection API

Removes the useless isOrSubOf, instanceOf and interfaceOf methods. 
Additionally it removes the getInstance method which is not used anywhere in 
the framework or in the plugins.

Also includes similar changes in 
AbstractConverter.java
Converters.java 
DateTimeConverters.java 
GenericEntity.java
IfInstanceOf.java

Thanks: Mathieu

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851701 13f79535-47bb-0310-9956-ffa450edef68
2019-01-20 09:39:30 +00:00
Jacques Le Roux 4e5ffc7118 Improved: Added translations es and es-CL
(OFBIZ-10815)

Adds translations es, es-CL in files:

    CommonUiLabels
    PartyUiLabels
    MarketingUiLabels
    HumanResUiLabels

jleroux: I removed duplicates in
CommonListAll
CommonLookupWhitepages
CommonManage
CommonNbr
CommonNoRecordFound

Seems CommonListAll and CommonNbr came from OFBIZ-7345 but I can't understand 
why they only show now

Thanks: Jonathan Cardenasvar 



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851611 13f79535-47bb-0310-9956-ffa450edef68
2019-01-18 09:02:12 +00:00
Taher A. Alkhateeb df59ff8c72 Fixed: bug in which fields of a form do not sort if it has a parent
The ModelForm.java is using an incorrect parameter name for sorting if a form
extends from another form. This fixes it by using the correct parameter name.

Thanks: Gil Portenseigne for reviewing and providing a better implementation


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851426 13f79535-47bb-0310-9956-ffa450edef68
2019-01-16 10:07:52 +00:00
Jacques Le Roux 6393eca331 Improved: ObjectType::doRealCompare returns null instead of a boolean in few
places
(OFBIZ-10812)

While reviewing OFBIZ-10811 I found that I could improve ObjectType class on 2 
points:
    doRealCompare returning null instead of a boolean
    simpleTypeOrObjectConvert Javadoc (2 other instance not documented)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851363 13f79535-47bb-0310-9956-ffa450edef68
2019-01-15 14:22:31 +00:00