Commit Graph
10472 Commits
Author SHA1 Message Date
Jacques Le Roux 9b00fd0dce renderLookupField macro comments improvement
Simple formatting (tabs to 2 spaces)
Fixes a bug which prevented to show an i18n "clear" text when layered lookups were used in read only mode from FTL templates
Fixes a bug which prevented to clear the description (at right of button) when layered lookups were used in read only mode 


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369561 13f79535-47bb-0310-9956-ffa450edef68
2012-08-05 11:48:44 +00:00
Jacques Le Roux e23033e569 Tiny ajaxAutoCompleter comment improvement
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369560 13f79535-47bb-0310-9956-ffa450edef68
2012-08-05 11:44:17 +00:00
Jacques Le Roux 5d358537a3 No functional change: simple formatting (tabs to 2 spaces)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369559 13f79535-47bb-0310-9956-ffa450edef68
2012-08-05 11:43:34 +00:00
Jacques Le Roux 9fd4ddb462 Closes "correct "javascript:void();" to "javascript:void(0);" to make it syntax valid" reported by Leon https://issues.apache.org/jira/browse/OFBIZ-4970
Firefox will throw syntax error if you call javascript void function without parameter.

jleroux: I did not reproduce with FF14 on XP (modern browsers correct by themselves) but I agree it's a better syntax. So I changed all where it was needed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369555 13f79535-47bb-0310-9956-ffa450edef68
2012-08-05 11:27:20 +00:00
Adrian Crum b3fc79770b Moved method used exclusively by PersistedServiceJob from JobManager to PersistedServiceJob. Also added some JavaDocs.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369543 13f79535-47bb-0310-9956-ffa450edef68
2012-08-05 09:43:59 +00:00
Adrian Crum 4de5aaf712 Refactored PersistedServiceJob.java so that it contains the GenericValue it represents. This improves throughput because the original code retrieved the JobSandbox entity value about 10 times for each job, and with this change the JobSandbox entity value is retrieved twice per job.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369536 13f79535-47bb-0310-9956-ffa450edef68
2012-08-05 08:01:29 +00:00
Adrian Crum a324ef7bb3 Some JavaDocs to help explain the Job behavior.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369491 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 22:17:02 +00:00
Adrian Crum 5779419ca3 Fixed a costly call to UtilValidate:
UtilValidate.isEmpty(Object) calls ObjectType.isEmpty(Object) - which performs a series of instanceof checks. Calling UtilValidate.isEmpty(String) avoids the expensive instanceof checks.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369486 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 22:07:18 +00:00
Adrian Crum 55f2c7de7e Fixed a bug in GenericServiceJob where the failed method would get called twice.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369485 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 22:06:24 +00:00
Adrian Crum 541679a972 Removed unnecessary Date object creation from GenericAsyncEngine.java.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369469 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 21:25:21 +00:00
Adrian Crum 6fdee332f5 Refactored Job implementations so they implement a state machine. This approach makes the code much simpler.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369467 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 21:24:27 +00:00
Erwan de Ferrieres c40c76c80c using for each in testtools
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369430 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 20:34:25 +00:00
Erwan de Ferrieres 51c8310aae Fix javadoc for PersistedServiceJob.java
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369409 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 18:54:05 +00:00
Erwan de Ferrieres 342c56d85c correcting javadoc for DynamicViewEntity.java
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369406 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 18:47:26 +00:00
Erwan de Ferrieres aa4a3b0730 Missed this one at rev 1369357
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369404 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 18:45:44 +00:00
Erwan de Ferrieres 7901b55e95 Fixing the javadoc for ServiceDispatcher.java
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369401 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 18:41:50 +00:00
Erwan de Ferrieres 1c15d2ab3e correcting an error with my search and replace at rev 1369357
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369360 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 16:23:21 +00:00
Erwan de Ferrieres a41366e95f as suggested by Adrian, replacing @see by @Override in commit 1367751
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369357 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 16:15:36 +00:00
Adrian Crum 58aaab37cc A bunch of fixes for JobManager and JobPoller:
1. Fixed some concurrency issues during object construction.
2. Cleaned up some feature-envy code.
3. Added code for orderly startup and shutdown.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369298 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 12:00:07 +00:00
Adrian Crum f89887fe40 JobManager.java and JobPoller.java code formatting - no functional change.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369291 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 08:57:19 +00:00
Erwan de Ferrieres 6f363f4480 updating javadoc for Container#init
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1367751 13f79535-47bb-0310-9956-ffa450edef68
2012-07-31 20:25:26 +00:00
Erwan de Ferrieres ebad9a93df missing ending } in javadoc
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1367750 13f79535-47bb-0310-9956-ffa450edef68
2012-07-31 20:24:42 +00:00
Jacopo Cappellato e8a43a2101 Upgrade of embedded Tomcat from 7.0.28 to 7.0.29
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1367029 13f79535-47bb-0310-9956-ffa450edef68
2012-07-30 08:30:14 +00:00
Jacques Le Roux 3c90c4204b While working on OFBIZ-4978, I changed for getDependentDropdownValues.js to load values unselected instead of loading them all selected one by one, then only the last being selected. This was actually a bug and I already wondered why the list had the last option selected by default instead of the 1st. This fixes this last aspect.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1366660 13f79535-47bb-0310-9956-ffa450edef68
2012-07-28 12:46:22 +00:00
Jacopo Cappellato 12a1c7dbae Improved an old comment based on feedback from Jacques Le Roux
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1366294 13f79535-47bb-0310-9956-ffa450edef68
2012-07-27 06:31:36 +00:00
Jacopo Cappellato b0ec84fa8d Fixes to groovy script required after the recent refactoring of service code.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1366028 13f79535-47bb-0310-9956-ffa450edef68
2012-07-26 14:53:40 +00:00
Jacopo Cappellato ea6cbf8ba9 Made locationMap thread safe using static initialization and immutability.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1365895 13f79535-47bb-0310-9956-ffa450edef68
2012-07-26 07:03:46 +00:00
Jacopo Cappellato 0abd7c2f6d Moved some (commented out) container definitions to the components they belong to.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1365889 13f79535-47bb-0310-9956-ffa450edef68
2012-07-26 05:51:54 +00:00
Jacopo Cappellato bf1241a4b7 Refactored artifact info classes to run some of the long running tasks in parallel threads by using the GLOBAL_EXECUTOR thread pool. Now it can be significantly faster (in a system with a quad-core processor it takes less than half time).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1365670 13f79535-47bb-0310-9956-ffa450edef68
2012-07-25 17:16:56 +00:00
Jacopo Cappellato ec8a3624a7 Small change to skip the annoying thread sleep when no JMS configuration is found.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1365038 13f79535-47bb-0310-9956-ffa450edef68
2012-07-24 13:27:30 +00:00
Jacopo Cappellato 7a45106e87 Some minor cleanups
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364998 13f79535-47bb-0310-9956-ffa450edef68
2012-07-24 12:10:09 +00:00
Jacopo Cappellato fdacdb49c4 Refactored all JMS service related code to not depend on the ServiceDispatcher.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364990 13f79535-47bb-0310-9956-ffa450edef68
2012-07-24 11:47:12 +00:00
Adrian Crum bdc878b98e Now that client code no longer references the GenericDispatcher class, we can hide it in the factory.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364982 13f79535-47bb-0310-9956-ffa450edef68
2012-07-24 11:30:12 +00:00
Jacopo Cappellato bf7606987c changed some comments/docs to refer to LocalDispatcher instead of ServiceDispatcher
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364980 13f79535-47bb-0310-9956-ffa450edef68
2012-07-24 11:25:08 +00:00
Adrian Crum c1c4af837a Code cleanups/fixups and JavaDocs for the new service component classes.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364972 13f79535-47bb-0310-9956-ffa450edef68
2012-07-24 10:46:08 +00:00
Jacopo Cappellato 955ae9eee1 A rather important refactoring of service related code:
* new factory interface for LocalDispatcher objects
* new factory implementation of GenericDispatcher
* new ServiceContainer container that initializes the factory (based on a configuration parameter)
* moved the getLocalDispatcher method out of GenericDispatcher and refactored (in a thread safe way) into ServiceContainer/GenericDispatcherFactory
* ServiceContainer also maintains the cache of LocalDispatchers that was managed by GenericDispatcher
* added code to ServiceContainer to deregister LocalDispatchers at shutdown: this finally fix the current code that was broken because the thread pool maintained by the JobPoller was never closed because of an issue with LocalDispatchers not being deregistered when not started by the ContextFilter
* change all code to call the ServiceContainer rather than GenericContainer to get a LocalDispatcher: now the implementation is no more directly referenced by calling code


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364952 13f79535-47bb-0310-9956-ffa450edef68
2012-07-24 09:16:26 +00:00
David E. Jones 3ec005ae79 Changed so that cus-obj element value is not in a CDATA block; it is already hex encoded so does not need to be in a CDATA block, and in entity exports of the RuntimeData entity it ends up being causing a nested CDATA block, which is not allowed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364822 13f79535-47bb-0310-9956-ffa450edef68
2012-07-23 22:10:29 +00:00
Jacopo Cappellato 2bff493b7a Removed a few useless/incorrect references to the ServiceDispatcher class.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364615 13f79535-47bb-0310-9956-ffa450edef68
2012-07-23 12:51:12 +00:00
Jacopo Cappellato 7dcbf47605 Refactored DispatchContext class to be thread safe thru immutability; resorted its methods to improve the readability; added some comments to better describe it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364564 13f79535-47bb-0310-9956-ffa450edef68
2012-07-23 10:15:13 +00:00
Jacopo Cappellato 788647f571 Further cleanups to the DispatchContext class:
* service definitions are created automatically by the setDispatcher method in order to guarantee the validity of the object status
* removed get/setAttributes (and supporting field) that were an old and not used feature
* made the "name" field final (small step in the direction of improving the thread safety of the class, there is still some work to do here)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364512 13f79535-47bb-0310-9956-ffa450edef68
2012-07-23 06:35:03 +00:00
Jacopo Cappellato 85ee9e142b Small change to javadoc: it is not a good practice to refer to a specific implementation class in an interface method description
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364511 13f79535-47bb-0310-9956-ffa450edef68
2012-07-23 06:30:11 +00:00
Jacopo Cappellato bf8f4a1308 Removed invalid references to non existing resources.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364247 13f79535-47bb-0310-9956-ffa450edef68
2012-07-22 09:54:02 +00:00
Jacopo Cappellato e3ad85e49f First pass of a rather relevant cleanup of service related code:
* removed the support for serviceReaderUrls for local services specified in the WEB-INF folder; this feature was not used in years and OFBiz has better mechanisms to define services in components;
* as a consequence of the previous point, a lot of code has been cleaned in the DispatchContext class; in this refactoring, I have fixed some non thread safe code (but this is only a first step and this class needs to be enhanced under this aspect)
* greatly simplified the static instance creator and constructors of ServiceDispatcher and  GenericDispatcher to reflect the changes in DispatchContext but also removed old unused code, simplified code for readability, added some comments to better document it


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364222 13f79535-47bb-0310-9956-ffa450edef68
2012-07-22 07:33:48 +00:00
Jacques Le Roux e3d7c51870 A patch from Leon for "IndexOutOfBoundsException thrown by ServerHitBin.countHit" https://issues.apache.org/jira/browse/OFBIZ-4969
This exception thrown out when initiated a "json" request.

    229156224 [http-bio-0.0.0.0-443-exec-6138] ERROR org.ofbiz.webapp.control.ControlServlet -
    ---- runtime exception report --------------------------------------------------
    Error in request handler:
    Exception: java.lang.IndexOutOfBoundsException
    Message: index: 0
    ---- stack trace ---------------------------------------------------------------
    java.lang.IndexOutOfBoundsException: index: 0
    javolution.util.FastList.add(FastList.java:228)
    org.ofbiz.webapp.stats.ServerHitBin.countHit(ServerHitBin.java:210)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364046 13f79535-47bb-0310-9956-ffa450edef68
2012-07-21 08:43:19 +00:00
Jacopo Cappellato 519465c113 Made constructor private according to the design of this class (instances are created using the static getModelReader that also takes care of managing the cache).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364045 13f79535-47bb-0310-9956-ffa450edef68
2012-07-21 08:39:11 +00:00
Jacopo Cappellato 6d0ba853f5 removed unused field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1364044 13f79535-47bb-0310-9956-ffa450edef68
2012-07-21 08:34:17 +00:00
Jacopo Cappellato 0ab73e004f Fixed a comment.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1363701 13f79535-47bb-0310-9956-ffa450edef68
2012-07-20 09:58:57 +00:00
Jacopo Cappellato bfbf80afdb Small enhancements to log messages
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1363699 13f79535-47bb-0310-9956-ffa450edef68
2012-07-20 09:58:08 +00:00
Jacopo Cappellato 7d473126d3 removed unused imports.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1363698 13f79535-47bb-0310-9956-ffa450edef68
2012-07-20 09:57:13 +00:00
Jacques Le Roux 368c3d43a2 Fixes generic warning
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1363690 13f79535-47bb-0310-9956-ffa450edef68
2012-07-20 09:10:30 +00:00