Commit Graph
10472 Commits
Author SHA1 Message Date
Jacques Le Roux fbfd7246de Adrian remarked there was no need to use class fields
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1421738 13f79535-47bb-0310-9956-ffa450edef68
2012-12-14 08:53:09 +00:00
Jacques Le Roux b7192d8409 At Adrian and Adam's request, allow to use cache here, use default constructor
Also refactored things a bit: 
* uses getPropertyAsBoolean
* set default property values

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1421651 13f79535-47bb-0310-9956-ffa450edef68
2012-12-14 03:27:40 +00:00
Jacques Le Roux 03a62ac947 A slightly modified patch from Sumit Pandit for "Additional Validation for Password : Make password pattern driven" https://issues.apache.org/jira/browse/OFBIZ-4958
Provides an additional validation for password  with following capability to the system:

Admin can enable/disable pattern based password capability of system. Configuration will reside in security.property file.
 To enable : security.login.password.pattern.enable=true
 To disable: security.login.password.pattern.enable=false

Admin is flexible to provide his pattern string by making pattern more/less restrictive as per system requirement. Configuration will reside in security.property file.
 Example: security.login.password.pattern=^.*(?=. {5,})(?=.[a-zA-Z])(?=.[!@#$%^&*]).*$

Admin can provide custom error message string which will display to end user if wrong password is entered. Configuration will reside in security.properity file.

jleroux: I quickly handled the error message localisation for the OOTB case. It's more complicated when the pattern gets complex...


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1418996 13f79535-47bb-0310-9956-ffa450edef68
2012-12-09 14:59:52 +00:00
Scott Gray 04df9cb162 Add a bunch of missing Override annotations
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1418651 13f79535-47bb-0310-9956-ffa450edef68
2012-12-08 12:06:40 +00:00
Scott Gray 0af4184d61 Remove a bunch of unnecessary casts
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1418650 13f79535-47bb-0310-9956-ffa450edef68
2012-12-08 12:06:01 +00:00
Scott Gray f180a447c7 Remove redundant implements declarations where the interface is already implemented by the base class
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1418649 13f79535-47bb-0310-9956-ffa450edef68
2012-12-08 12:04:37 +00:00
Scott Gray 5df3e3f70b Remove a bunch of unused imports, no functional changes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1418646 13f79535-47bb-0310-9956-ffa450edef68
2012-12-08 12:03:52 +00:00
Scott Gray b9aba41be6 Add missing deprecated annotations
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1418645 13f79535-47bb-0310-9956-ffa450edef68
2012-12-08 12:02:14 +00:00
Adam Heath bca838aa2a OPTIMIZE: Now that absolute() does the correct thing for 0, fix
getPartialList() to use absolute(start - 1), instead of working around
the bug itself.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1417213 13f79535-47bb-0310-9956-ffa450edef68
2012-12-04 21:54:49 +00:00
Adam Heath 9c7c925a4c OPTIMIZE: Remove the use of numRetrieved as a check to see how much has
been fetched.  Either list.size() could be used, or, even better, just
decrement the number wanted, and continue until everything is fetched.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1417212 13f79535-47bb-0310-9956-ffa450edef68
2012-12-04 21:54:42 +00:00
Adam Heath 7228abe497 TYPO: s/numRetreived/numRetrieved/
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1417211 13f79535-47bb-0310-9956-ffa450edef68
2012-12-04 21:54:35 +00:00
Adam Heath fc81ed5fb1 FIX: Some jdbc drivers don't like absolute(0), even though this is
allowed.  As such, call beforeFirst() instead.  Technically, these
broken jdbc drivers should have the same kind of work-around.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1417210 13f79535-47bb-0310-9956-ffa450edef68
2012-12-04 21:54:28 +00:00
Jacopo Cappellato a17e2d812b Fixed code that was broken a lot of time ago by commit 883226; this prevented the (seldom used) screen.use-cache attribute to work properly. Thanks to K Sharad Bhushan for the patch (OFBIZ-5080).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1416497 13f79535-47bb-0310-9956-ffa450edef68
2012-12-03 13:05:39 +00:00
Jacopo Cappellato f6244c689f Trivial fixes for some typos in Java comments.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1416451 13f79535-47bb-0310-9956-ffa450edef68
2012-12-03 11:15:44 +00:00
Jacques Le Roux e6ede1ca2e Reverts r1310983 (related to https://issues.apache.org/jira/browse/OFBIZ-4792 )for 2 reasons:
* I missed to put in LICENSE and NOTICE
* It's an issue for Birt, see OFBIZ-5070


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1416358 13f79535-47bb-0310-9956-ffa450edef68
2012-12-03 07:02:38 +00:00
Sascha Rodekamp ce90d2929e Replace all getIdName() calls in the MacroFormRenderer class with the central method getCurrentContainerId from the ModelFormField class. This method uses now the FlexibleStringExpander that makes the form widgets able to interpret ${} variables in the id fields
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1413492 13f79535-47bb-0310-9956-ffa450edef68
2012-11-26 07:34:56 +00:00
Jacques Le Roux 6dc2929e10 A patch from Sergei Biletnikov "Remote services via XMLRpc ignore the locale which is passed as the service parameter, the default locale is used forever" https://issues.apache.org/jira/browse/OFBIZ-5083
This code replaces the possible locale from parameters by default locale.

// add the locale to the context
context.put("locale", Locale.getDefault());

The solution is simple: firstly check, if we have the locale as the parameter, if no, use the default locale.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1413307 13f79535-47bb-0310-9956-ffa450edef68
2012-11-25 09:20:23 +00:00
Jacques Le Roux ecd2de6362 A patch from Naofumi Fukue "Japanese patch" https://issues.apache.org/jira/browse/OFBIZ-5061
Completed Japanese translation

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1412997 13f79535-47bb-0310-9956-ffa450edef68
2012-11-23 17:35:16 +00:00
Jacopo Cappellato 6565a78ee0 OFBIZ-5072 Committed slightly different version of the patch contributed by Rene Frauli: the delegator, dispatcher and security objects are required in the session in multitenant mode.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1411196 13f79535-47bb-0310-9956-ffa450edef68
2012-11-19 14:25:55 +00:00
Adrian Crum 417a8c1d4e Screen widget XML schema cleanup first pass: remove unnecessary attribute groups.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1407843 13f79535-47bb-0310-9956-ffa450edef68
2012-11-10 16:07:58 +00:00
Jacques Le Roux f7b662bc46 A patch from Nicolas Malin for "Entity-Auto Engine : manage [create|lastModified]Date field" https://issues.apache.org/jira/browse/OFBIZ-5010
When a entity have fields createDate, lastModifiedDate, createByUserLogin and updateByUserLogin, the entity-auto engine set them.

Also makes all entities that have one of fields [create|lastModified][Date|ByUserLogin] to be consistent and have four fields

Impacted entityies:

    [Quote|Order|Return]Adjustment
    OrderPaymentPreference
    AcctgTrans
    GlReconciliation
    ValueLinkKey


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1407578 13f79535-47bb-0310-9956-ffa450edef68
2012-11-09 18:26:19 +00:00
Erwan de Ferrieres 4e60dbe157 Upgrading to latest tomcat release 7.0.32
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1405298 13f79535-47bb-0310-9956-ffa450edef68
2012-11-03 07:09:41 +00:00
Jacques Le Roux b46c7a2c06 A patch from Naofumi Fukue "Japanese patch" https://issues.apache.org/jira/browse/OFBIZ-5061
Got an issue merging GeoData_JP.xml with Subclipse, using Toirtoise solved it

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1403746 13f79535-47bb-0310-9956-ffa450edef68
2012-10-30 15:48:42 +00:00
Jacques Le Roux e381dea7a3 Better French label
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1403655 13f79535-47bb-0310-9956-ffa450edef68
2012-10-30 10:35:01 +00:00
Jacques Le Roux af2f71f48f Import/export https://issues.apache.org/jira/browse/OFBIZ-5047
This fix a random issue which appears sometimes on Ubuntu (it seems beginning from Ubuntu 12.04, maybe related to Open jdk)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1402766 13f79535-47bb-0310-9956-ffa450edef68
2012-10-27 09:26:03 +00:00
Scott Gray a2a2857bef Replace more misc. webSiteId retrievals with calls to WebSiteWorker.getWebSiteId(request). Deprecated CatalogWorker.getWebSiteId(request) and CatalogWorker.getWebSite(request).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1400626 13f79535-47bb-0310-9956-ffa450edef68
2012-10-21 11:27:10 +00:00
Scott Gray 47abb49013 Replaced direct access to webSiteId from the servlet context attributes with calls to WebSiteWorker.getWebSiteId(request)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1400601 13f79535-47bb-0310-9956-ffa450edef68
2012-10-21 08:53:04 +00:00
Scott Gray 206d159601 Avoid potential NPE
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1400574 13f79535-47bb-0310-9956-ffa450edef68
2012-10-21 05:09:46 +00:00
Adrian Crum bd722a7f97 User Name is two words.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1400388 13f79535-47bb-0310-9956-ffa450edef68
2012-10-20 08:47:52 +00:00
Sascha Rodekamp 1fbfbaea83 Upgrade jQuery Validation to Version 1.10
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1399132 13f79535-47bb-0310-9956-ffa450edef68
2012-10-17 07:14:00 +00:00
Sascha Rodekamp a567174540 - Upgrade Timepicker to version 1.0.5
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1399128 13f79535-47bb-0310-9956-ffa450edef68
2012-10-17 07:01:03 +00:00
Sascha Rodekamp 17f95ebca0 Upgrade jQuery to Version 1.8.2
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1398800 13f79535-47bb-0310-9956-ffa450edef68
2012-10-16 13:55:23 +00:00
Sascha Rodekamp 72318d523a Upgrade jQuery UI to Version 1.9
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1398771 13f79535-47bb-0310-9956-ffa450edef68
2012-10-16 12:57:46 +00:00
Jacques Le Roux ee091b11d5 A Christoph Neuroth's idea "Include complete stack trace in groovy script exception messages" https://issues.apache.org/jira/browse/OFBIZ-5049
When a groovy script fails, currently you can only follow the stack trace to rg.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:348), but not into the failed script itself, which makes debugging really hard.

This can easily be improved by wrapping the exception there:

-            throw new IllegalArgumentException(errMsg);
+            throw new IllegalArgumentException(errMsg, e);



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1398679 13f79535-47bb-0310-9956-ffa450edef68
2012-10-16 07:09:54 +00:00
Jacques Le Roux 88dfaa9bb4 Just to clarify, when you check all you don't check views. I just changed English and French labels
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1397809 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 10:24:49 +00:00
Jacques Le Roux 06025d5235 A patch from Leon "very trivial update to fieldlookup.js in case of "null object" failure for weird unknonw reason" https://issues.apache.org/jira/browse/OFBIZ-4911
I cannot find the root cause and it's hard to reproduce, but it does happen sometimes. The web browser reports "null object" exception when it tries to evaluate following codes in fieldlookup.js: 
{quote}
var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
{quote}

window.opener is there but window.opener.lookups is null.

jleroux: better be safe than sorry, even if it hides the original reason this no functional change can't have any side effects.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1395460 13f79535-47bb-0310-9956-ffa450edef68
2012-10-08 07:26:02 +00:00
Jacques Le Roux 1daa9d0525 While testing for https://issues.apache.org/jira/browse/OFBIZ-5047 with trunk (instead of 10.04) I got an issue introduced by http://svn.apache.org/viewvc?view=revision&revision=950764 but actually the FTL code did not make any sense, why using a static call to isNotEmpty when you have ?has_content?
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1395296 13f79535-47bb-0310-9956-ffa450edef68
2012-10-07 13:24:44 +00:00
Jacques Le Roux 8e6e049ad5 A patch from Varun Bhansaly "Email configuration - mail.smtp.starttls.enable ignored" https://issues.apache.org/jira/browse/OFBIZ-4943
The email configuration setting mail.smtp.starttls.enable is ignored by the system.
I encountered this while configuring OFBiz an email server which had TLS enabled.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1395104 13f79535-47bb-0310-9956-ffa450edef68
2012-10-06 16:18:09 +00:00
Jacques Le Roux cc5ddd92da Remove trailing blanks
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1395035 13f79535-47bb-0310-9956-ffa450edef68
2012-10-06 12:53:28 +00:00
Jacques Le Roux ac9f940790 A modified patch from Jyoti Sharma https://issues.apache.org/jira/browse/OFBIZ-5043
When i worked with Url Rewrite Filter, i faced the following issue:-
In case of http protocol in the url, https links on th epage were not being rewritten and when their was https url, http links were not rewritten.

The issue behind this what i found is that in RequestHandler.java encodeUrl() is not called in the above given case.
So, if we place response.encodeUrl() their the issue is resolved. 

jleroux: This makes sense since we are still in the "if (encode) {" block. I just noticed that response != null was checked above so I placed the same check before encoding

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1394995 13f79535-47bb-0310-9956-ffa450edef68
2012-10-06 10:59:12 +00:00
Jacques Le Roux 6eb198e3c2 No functional change, just swap parameters positions in JavaDoc, while reading fast I got confused
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1393556 13f79535-47bb-0310-9956-ffa450edef68
2012-10-03 15:38:21 +00:00
Jacques Le Roux d652185fce Adds a new line
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1393369 13f79535-47bb-0310-9956-ffa450edef68
2012-10-03 09:26:15 +00:00
Jacques Le Roux 899598caba Moves throwRequestHandlerExceptionOnMissingLocalRequest from general.properties to requestHandler.properties
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1393367 13f79535-47bb-0310-9956-ffa450edef68
2012-10-03 09:25:19 +00:00
Adrian Crum 423947d9ed Small improvement to Web Tools Find Values screen - order values by pk.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1393258 13f79535-47bb-0310-9956-ffa450edef68
2012-10-03 02:30:19 +00:00
Sascha Rodekamp 959321e0f1 Bug Fix: No Url encoding for get parameters (https://issues.apache.org/jira/browse/OFBIZ-2628). Thanks Wojciech Szymanowski for the hint. This Patch fixes the problems with parameters from hidden fields sending with POST method and parameters sending during "request-redirect" response type
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1392766 13f79535-47bb-0310-9956-ffa450edef68
2012-10-02 07:22:05 +00:00
Jacques Le Roux ecfc317a79 Closes "ControlServlet - Exception thrown for requests not defined by controller.xml" https://issues.apache.org/jira/browse/OFBIZ-5037
This has been tested in a custom project and work as expected it does not add any functional features for OFBiz if you don't use external requests in controllers. So should have any impacts OOTB

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1391037 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 14:49:20 +00:00
Sascha Rodekamp 49adbc5bcc Bug Fix: No Url encoding for get parameters (https://issues.apache.org/jira/browse/OFBIZ-2628). Thanks Wojciech Szymanowski for the hint. The CatalinaContainer.createConnector() method does not initialize Connector.URIEncoding property from ContainerConfig class.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1390542 13f79535-47bb-0310-9956-ffa450edef68
2012-09-26 15:03:23 +00:00
Adrian Crum a8793d83dd Fixed a bug introduced in rev 1334336 - do not throw an exception if the web.xml file does not exist.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1389802 13f79535-47bb-0310-9956-ffa450edef68
2012-09-25 11:12:34 +00:00
Jacques Le Roux 73324f3b4a A patch from Daniel Riquelme " Improve Tree Widget to support Multiple PK Entities" https://issues.apache.org/jira/browse/OFBIZ-4971
The PKs are used to keep track of which nodes have been rendered when performing recursion inside Tree Widget rendering code.
Currently Multiple PKs Entities can't be used as nodes in a Tree Widget because the rendering code does not handle them.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1387884 13f79535-47bb-0310-9956-ffa450edef68
2012-09-20 07:06:17 +00:00
Jacques Le Roux 3d1ccc11ed Closes "UtilXml firstChildElement should use getNodeName instead of getLocalName " https://issues.apache.org/jira/browse/OFBIZ-4441
The previous solution was not complete and prevented SOAP call to work correctly (see http://markmail.org/message/sz5esi3j6ombmrte).
This guarantee best of both worlds: uses getLocalName for SOAP if not null, else fall-backs to getNodeName


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1387878 13f79535-47bb-0310-9956-ffa450edef68
2012-09-20 06:57:10 +00:00