Commit Graph
10472 Commits
Author SHA1 Message Date
Jacques Le Roux c5f187beb6 A patch from Michael Ende for "SimpleMethod parameters doesnt work with prefix" https://issues.apache.org/jira/browse/OFBIZ-5371
I experienced some problems when a form submitted parameters with prefix directly to a SimpleMethod (through the controller request). 
In this case the prefix is not stripped from the parameter name. The patch updates the method ModelService.java:makePrefixMap().

The idea of the prefixMap is: 
If you have some fields like packageweight_1(value=55), packageweight_2(value=65) ... in a form and in a service you need a map called packageweight with the following key values 

packageweight{1=55;2=56;...}

The Problem is that the function makePrefixMap doesn't replace the Prefix.

For Example:
On the "Complete" button of the Facility->Shipment screen we call an event and not the completePack service directly.
The event checks some user rights and after that he call the completePack service. If we call the service from an event there throws an NumberFormatException because the packeweight-PrefixMap contains the prefixes.

This is my event description:
 <simple-method method-name="completePackCheckPermission"
        short-description="Check if this user has permission to create a picklist role"
        login-required="true">
        <check-permission permission="LOGISTICS_CREATE">
            <alt-permission permission="LOGISTICS_ADMIN"/>
            <fail-property resource="EcommerceLogisticsErrorUiLabels" property="NoPermissionForUsage" />
        </check-permission>
        <check-errors />

        <session-to-field field="packingSession"/>
        <set field="parameters.packingSession" from-field="packingSession"/>

        <set-service-fields service-name="completePack" to-map="serviceParameters"
            map="parameters" />
        <call-service service-name="completePack" in-map-name="serviceParameters" />
        <return />
    </simple-method>

jleroux: I'm not quite sure there are no side-effects, but I was not able to find one. So I will wait some time before backporting...



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1559814 13f79535-47bb-0310-9956-ffa450edef68
2014-01-20 19:38:45 +00:00
Jacques Le Roux 747a4a3154 This is a major update of jQuery and related, it contains:
jquery-1.8.2 to jquery-1.10.2 which implies using jquery-migrate-1.2.1 for plugins compatiblities
    jquery-ui-timepicker-addon-1.0.5 to jquery-ui-timepicker-addon-1.4.3 (using min now, better i18n)
    jquery-ui-1.9.0 to jquery-ui-1.10.3
    removes jquery.ui.datepicker.js now integrated in jquery.ui
    jquery.hotkeys-0.7.9 to jquery.hotkeys-0.8
    jquery.maskedinput-1.2.2 to jquery.maskedinput-1.3.1
    jquery.validate 1.10.0 to 1.11.1 
        I never realised how much efforts have been put in this plugin!  
        I fixed an issue in JsLanguageFilesMapping generation
        I removed the messages_ptbr.js and messages_ptpt.js files and the related conundrum in JsLanguageFileMappingCreator.java
        untested, found not use cases OOTB
    jquery.jcarousel ?(2006) to 0.3.0 (2013)
        untested, found not use cases OOTB
    jquery.flot 0.7 to 0.8.2 (lot of changes, still works)
        removes useless flotpie.ftl 
        removes empty flotr folder
    jquery.mobile-1.1.0-rc.1 to jquery.mobile-1.4.0
        untested, found not use cases OOTB
    jquery.cookie to jquery.cookie-1.4.0    


Removes all useless/redundant js files (not only jQuery unused old versions)
    notably removes all under images/jquery/ui/development-bundle/ui
    removes now useless GooglemapMarkers.js and GooglemapSimple.js

Flat Grey application.js
    moves jQuery(document).ready(function() at bottom (spotted in Chrome console) 
    
css
    I did not find much issues, I spotted the title bar of the lookups, but got it fixed after some efforts.    

Issues:
    Imagemanagement:  I got issues while testing, actually I'm not quite qure how it works, even in stable demo. It should be validated again. I commit nevertheless my changes:
        moves js part from product to images component
        removes useless calls to js files (mostly in imagemanagement, but not only)
        renames jquery.min.js to sizzle.min.js. 
        Inside sizzle.min.js, updates the Dojo part to v1.10.17-pre and removes the jQuery part
        changes to use ofbizContentUrl macro for generating js calls
        jquery.rotate.js NOT! It's jQueryRotateCompressed.js http://markmail.org/message/dit3dlh3ph4jnenp
        Got ERROR 22001: A truncation error was encountered trying to shrink VARCHAR 'D:\projectsASF\ofbizClean\framework\images\webapp\images\pro&' to length 100.  I opened OFBIZ-5501 for that
    I tried to update jstree  to jstree 3 but gave up. I let the jquery.jstree-3.0.0-beta3 files in place in case someone would give it a chance...
    
Not related but while a it:
    removes <!--flot example requests--> from birt controller (moved recently to example component)
    
    

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1559769 13f79535-47bb-0310-9956-ffa450edef68
2014-01-20 16:27:09 +00:00
Jacques Le Roux 3334d1b3ca A patch from Leon for "Form pagination fails if total length of search condition is more than about 2~3k bytes" https://issues.apache.org/jira/browse/OFBIZ-5478
Since it uses "GET" method to submit the pagination request, it's restricted by the URL max length limitation.
The patch attached changes the submit way from GET to "POST" if total length of URL > 2k.


jleroux: I also sort of (found after it was due to it) reverted r1204170, I don't see the reason for this now, and it was uselessly duplicating the current entry in the page size dropdown


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1559338 13f79535-47bb-0310-9956-ffa450edef68
2014-01-18 10:19:44 +00:00
Jacques Le Roux 92b42b5aef A completing patch from Olivier for "NPE thrown out while rendering disabled menu item" https://issues.apache.org/jira/browse/OFBIZ-5451
Last typo correction was'nt complete.

jleroux: this incidentally and fortunately fixes also "The Orders sub-menus don't work in Catalog and Party Profile" https://issues.apache.org/jira/browse/OFBIZ-5477

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1559328 13f79535-47bb-0310-9956-ffa450edef68
2014-01-18 08:37:58 +00:00
Adrian Crum 27d57465bf Small rewrite in JobManager.java to fix a bug where jobs could be duplicated under certain conditions. https://issues.apache.org/jira/browse/OFBIZ-5496
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1558774 13f79535-47bb-0310-9956-ffa450edef68
2014-01-16 12:48:44 +00:00
Jacques Le Roux 0c9fccc6c8 Upgrades to Tomcat latest bug fix release: 7.0.50
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1557593 13f79535-47bb-0310-9956-ffa450edef68
2014-01-12 18:55:53 +00:00
Jacques Le Roux 2bbdd3366b This should be better private + better comment
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1557521 13f79535-47bb-0310-9956-ffa450edef68
2014-01-12 12:38:32 +00:00
Jacques Le Roux 9d2e62ecf6 A modified patch from Gareth Carter for "JSON Response does not set http status on error" https://issues.apache.org/jira/browse/OFBIZ-5409
This is rather a defensive patch which secure json response on services calls. 
It might need some changes in custom code if (not recommended) an Ajax GET response is used... The util.js scrpt is introduced for that, though normally should not be needed... 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1557462 13f79535-47bb-0310-9956-ffa450edef68
2014-01-11 20:26:30 +00:00
Jacques Le Roux 64d21b3a29 Completes r1557447, the annoyances of blind reverting
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1557457 13f79535-47bb-0310-9956-ffa450edef68
2014-01-11 20:04:19 +00:00
Jacques Le Roux c06bd63860 This fixes "Set field in (at least) widget screen does not take into account a locale for (at least) the Float type" https://issues.apache.org/jira/browse/OFBIZ-5453
It actually does more than that. It follows Adrian's proposition of improving the GeoPoint data model. 
I did not applies all of Adrian's proposition (see our conversation in the Jira issue). Feel free to apply it completely if you are inclined so. 

I will also add an entry in wiki page "Revisions Requiring Data Migration (upgrade ofbiz)" at https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=7045166

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1557447 13f79535-47bb-0310-9956-ffa450edef68
2014-01-11 19:39:23 +00:00
Adrian Crum 6a42559853 Updated XStream library to latest version.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1557440 13f79535-47bb-0310-9956-ffa450edef68
2014-01-11 19:23:58 +00:00
Adrian Crum fe9cd1f776 Added the ability to exclude certain classes from XML serialization/deserialization.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1557427 13f79535-47bb-0310-9956-ffa450edef68
2014-01-11 17:39:38 +00:00
Jacques Le Roux b3767764d7 Updates java mail-1.4.jar to mail-1.5.1.jar (tests passes)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1557410 13f79535-47bb-0310-9956-ffa450edef68
2014-01-11 15:24:10 +00:00
Jacques Le Roux a08c142ee7 Updates icu4j-49_1.jar to icu4j-52_1.jar (tests passes)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1557409 13f79535-47bb-0310-9956-ffa450edef68
2014-01-11 14:52:23 +00:00
Jacques Le Roux 6f114277d4 Better for nowadays!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1557195 13f79535-47bb-0310-9956-ffa450edef68
2014-01-10 16:58:26 +00:00
Jacques Le Roux 344a93d20a Fixes a typo introduced at r1553887 for "NPE thrown out while rendering disabled menu item" https://issues.apache.org/jira/browse/OFBIZ-5451
Spotted by Olivier

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1557185 13f79535-47bb-0310-9956-ffa450edef68
2014-01-10 16:43:39 +00:00
Jacques Le Roux 0eb2088f5c Unfortunately adding a line is not enough for Aptana js editor to separate comments, so better to put comments in the function itself
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1555516 13f79535-47bb-0310-9956-ffa450edef68
2014-01-05 14:31:46 +00:00
Jacques Le Roux ab73f5348e Damn, this was unintended
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1555507 13f79535-47bb-0310-9956-ffa450edef68
2014-01-05 13:55:45 +00:00
Jacques Le Roux 94e4a25400 Adds a line between the license header and the getDependentDropdownValues() function documentation. My JS editor in Eclipse (Aptana) was hiding it all together with the license header
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1555506 13f79535-47bb-0310-9956-ffa450edef68
2014-01-05 13:54:39 +00:00
Jacques Le Roux 676997b394 I did not get a chance to test my last editGeoLocation related change, here is the definitive version
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1554787 13f79535-47bb-0310-9956-ffa450edef68
2014-01-02 11:14:01 +00:00
Jacques Le Roux 98d5af4a8e Keeps the hack clean, sync is not needed here
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1554764 13f79535-47bb-0310-9956-ffa450edef68
2014-01-02 08:17:23 +00:00
Jacques Le Roux 8b547d6b69 This is a temporary hack waiting for a better geolocation data model, related with OFBIZ-5453
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1554706 13f79535-47bb-0310-9956-ffa450edef68
2014-01-02 00:15:38 +00:00
Jacques Le Roux d57782908a Completes "Set field in (at least) widget screen does not take into account a locale for (at least) the Float type" https://issues.apache.org/jira/browse/OFBIZ-5453 for minilang.
Removes dead code.
Locale applies only when the type is also passed, like in widgets.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1554685 13f79535-47bb-0310-9956-ffa450edef68
2014-01-01 22:02:17 +00:00
Jacques Le Roux 22cdda72c4 This closes "Set field in (at least) widget screen does not take into account a locale for (at least) the Float type" https://issues.apache.org/jira/browse/OFBIZ-5453
And definitively fixes issues with i18n of geolocation 

It introduces a "locale" attribute to the "set" operation in widget (I only tested screen, form is quite similar, should be ok) and minilang.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1554681 13f79535-47bb-0310-9956-ffa450edef68
2014-01-01 21:30:12 +00:00
Jacques Le Roux c28edba6d8 This fixes the geolocation in OFBiz, for both Google Maps and OpenLayers. It seems few changes, it took me more time than I thought. I hope this will last few years again, and it should be easier to maintain now.
What I did:
Upgraded from Google Maps API 2 to 3, which also means removing the keys in general.properties. They are no longer needed in API-3 (at least for our demo and local test uses), one worry less!
Refactored Google Maps code in geolocation.ftl: put more things in common,  simplified code (the API-3 is better from this POV).

For OpenLayers, due to most browsers now rejecting mixed content (HTTP vs HTTPS), I had to follow their advice and put OpenLayers-2.13.1.js + images and theme(finally not used) in the framework. Not a big deal in term of size but again one more lib to worry about. Anyway geolocation is not vital for OFBiz. I have also added a zoom and navigation widget in maps. Note that IE warns about mixed content, but you can bypass it.

While working on editGeoLocation (in Party) I noticed it does not update the elevation. I found it was possible http://www.daftlogic.com/sandbox-google-maps-find-altitude.htm but I did not implement it, lack of time...
Also I got once a NPE in CallSimpleMapProcessor (when using editGeoLocation) but was unable to reproduce (w/o changes before and after)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1554536 13f79535-47bb-0310-9956-ffa450edef68
2013-12-31 15:22:21 +00:00
Jacopo Cappellato 692a5ab569 Upgrade to the latest official major version of Groovy: 2.2.1
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1554242 13f79535-47bb-0310-9956-ffa450edef68
2013-12-30 14:44:32 +00:00
Jacques Le Roux 398aeffd7f Oops my bad, I forgot that I had downloaded the cobertura-1.9.4.1.jar locally so I had no issues after an ant clean but Buildbot had
So finally removes last change in framework/base/build.xml related to Cobertura

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1554018 13f79535-47bb-0310-9956-ffa450edef68
2013-12-29 12:15:47 +00:00
Jacques Le Roux 5b7572d537 Finally commits change in framework/base/build.xml, the Buildbot error was not related to this change (did not make sense, as long this target is not used at least)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1554016 13f79535-47bb-0310-9956-ffa450edef68
2013-12-29 11:52:15 +00:00
Jacques Le Roux 92525ea290 I was too fast with the Cobertura changes in previous commit, I forgotI did not test those yet.
So I revert them for now, they are not needed yet for the INFRA-3590 progresses anyway, only the portoffset parameter is needed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1553975 13f79535-47bb-0310-9956-ffa450edef68
2013-12-28 23:43:53 +00:00
Jacques Le Roux 4c0b42b9d2 This completes "set different ports for testing in a CI environment (e.g. Jenkins)" https://issues.apache.org/jira/browse/OFBIZ-4794
This was waiting for a moment in my working copy after I found that there was an issue with testSOAPSimpleService when portoffset was used with run-tests target.
I have still no resolved this issue, but since I got a better way to run simultaneous Buildbot instances this is no longer an issue for run-tests target.
So I commit these small pending changes in order to allow to run Sonar on OFBiz https://issues.apache.org/jira/browse/INFRA-3590.
The cobertura target does not work yet but what's committed here is needed anyway to progress with INFRA-3590.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1553962 13f79535-47bb-0310-9956-ffa450edef68
2013-12-28 23:09:01 +00:00
Adrian Crum d79ac2631a Upgrade Derby to 10.10.1.1.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1553893 13f79535-47bb-0310-9956-ffa450edef68
2013-12-28 19:20:08 +00:00
Adrian Crum 7cad5f6af5 A small code cleanup in the entity engine - remove deprecated functionality. Originally, the "blob" field type was used as a catch-all for java.sql.Blob, byte[], and java.lang.Object. Now each Java type has its own field type - so you must specify the correct one.
IMPORTANT: This commit might break some applications. If you get ClassCastExceptions, then you need to change the field type in your entity from blob to either byte-array or object. The change will have no effect on your database - because they are all persisted as BLOB SQL types.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1553890 13f79535-47bb-0310-9956-ffa450edef68
2013-12-28 19:15:58 +00:00
Jacques Le Roux ede1994465 A patch from Leon for "NPE thrown out while rendering disabled menu item" https://issues.apache.org/jira/browse/OFBIZ-5451
The method "renderLink" of new class MacroMenuRenderer calls the WidgetWorker.determineAutoLinkType. When menuItem.getDisabled() is true, the link target will be set to null and NPE occurs.

jleroux: This was related with r1517353 and r1537833. The Leon's patch fixes r1517353 and this commits also reverts r1537833


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1553887 13f79535-47bb-0310-9956-ffa450edef68
2013-12-28 18:55:53 +00:00
Adrian Crum 2d81f9049e An improvement to the Mini-language <set-service-fields> element - now you can specify the service attributes mode: IN or OUT.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1553776 13f79535-47bb-0310-9956-ffa450edef68
2013-12-28 01:17:40 +00:00
Adrian Crum 4b8948664b A fix for some Chinese translations. Patch contributed by Leon - https://issues.apache.org/jira/browse/OFBIZ-5446
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1553663 13f79535-47bb-0310-9956-ffa450edef68
2013-12-27 11:20:11 +00:00
Jacques Le Roux 1276dc8eb8 Removes an useless debug log error, caught around anyway
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1552311 13f79535-47bb-0310-9956-ffa450edef68
2013-12-19 13:17:03 +00:00
Jacques Le Roux c75405ca4a Even if I don't like much never-ending stacks in logs, this adds a log error in case the exception would be swallowed (recommended practice)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1552249 13f79535-47bb-0310-9956-ffa450edef68
2013-12-19 08:08:16 +00:00
Jacques Le Roux 748770fb6d No functional change. As suggested Adrian on dev ML, creates the AtomicReference update outside the try-catch block.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1552120 13f79535-47bb-0310-9956-ffa450edef68
2013-12-18 21:56:33 +00:00
Jacques Le Roux be880e2c5f No functional automated changes
Add @Override annotations
Fixes comments indentation
Removes trailing blanks


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1552077 13f79535-47bb-0310-9956-ffa450edef68
2013-12-18 20:12:37 +00:00
Jacques Le Roux 60597ea005 Fixes <<FIXME: Replace DCL code with AtomicReference>>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1552073 13f79535-47bb-0310-9956-ffa450edef68
2013-12-18 19:46:50 +00:00
Jacques Le Roux 3d458932c5 A slightly modified patch from Leon for "sequence-bank-size attributes does not work anymore" https://issues.apache.org/jira/browse/OFBIZ-5429
No matter how I set "sequence-bank-size" for an entity (in my example, its "EntityAuditLog"), the bank size is always default value "10".
It seems that this feature was lost by a serials update of revision 922724 to 922733 submitted by doogie.

jleroux: This thread http://markmail.org/message/ifosqek74gqtv7fz trace the root cause
Leon's fix is safe from a concurrency perspective. I just added a check on SequenceBank.maxBankSize and put some doc in the XSD

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1551744 13f79535-47bb-0310-9956-ffa450edef68
2013-12-17 22:45:20 +00:00
Jacques Le Roux eb01bb126d Misc. cleaning in labels
Removes all empty ones
Removes some redundant/duplicates ones (please committers don't commit those again, I know it's not easy to catch, hopefully now we should have less of them)
Automatically replaces some tabs
Few French labels improvements
Removes 2 orphan entries ("ja" & "cs")
Fixes the schema header of WebtoolsUiLabels.xml


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1551594 13f79535-47bb-0310-9956-ffa450edef68
2013-12-17 16:00:50 +00:00
Jacques Le Roux 4c3e9b7ec8 No functional changes:
Removes all remaining unchecked warnings
Automatically adds some @Override

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1551207 13f79535-47bb-0310-9956-ffa450edef68
2013-12-16 13:30:46 +00:00
Jacques Le Roux 576a213948 No functional changes, code improvements
Fixes some dead code entries
Automatically adds some override annotations


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1550429 13f79535-47bb-0310-9956-ffa450edef68
2013-12-12 14:53:38 +00:00
Jacques Le Roux f477c73ae7 A patch from Gareth Carter for "htmlFormMacroLibrary.ftl renderNextPrev does not calculate number of pages correctly" https://issues.apache.org/jira/browse/OFBIZ-5422
There are 2 issues with the existing code.
1 - floor is applied to viewSize only not the computed value
2 - if the listSize divides with viewSize evenly, you'll get one extra
eg
24/2=12 - no of pages = 13
24/5=4.8 - no of pages = 5

Change to correctly calculate the number of pages using ceiling rather than floor

To repoduce this I went into find party screen, search for all and manually set the view size (I had to click next and change the VIEW_SIZE parameter in the url).

In my description I mention 24/2=12 and 24/5=4.8,
24 is number of parties I had
2/5 is the view size

It does not matter what the item size is (as long as its more than 0), you just have to make sure listSize divides by viewSize evenly. In my case 24/2 divided evenly and which should have have given 12 pages but gave 13.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1550201 13f79535-47bb-0310-9956-ffa450edef68
2013-12-11 17:48:37 +00:00
Jacques Le Roux 4c49d987f2 No functional changes.
Not a big deal(because it should be very rarely changed during a session + with cache cleared) but I did not want to have final here. I tried this "save action" in Eclipse (on private variable) but finally decided to remove it.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1549026 13f79535-47bb-0310-9956-ffa450edef68
2013-12-08 13:01:46 +00:00
Jacques Le Roux 80b881bd11 No functional change: removes trailing spaces
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1549017 13f79535-47bb-0310-9956-ffa450edef68
2013-12-08 11:07:20 +00:00
Jacques Le Roux 082d2ec52f In r1533839 (related to https://issues.apache.org/jira/browse/OFBIZ-4794 "Set different ports for testing in a CI environment (e.g. Jenkins)"
Which will mostly be used to simultaneously run official demos without having to create patches, I forgot the portOffset for websites and url.properties ports values.
This fixes this point. I also did in it RequestHandler class though the getDefaultServerRootUrl() method is now deprecated.
To be consistent with r1547186 I will backport in R13.07

People should be aware that this will change the ports values of websites and url.properties ports values which in some cases could be an unwanted side effect. 
Anyway the portOffset feature is not destined to be used in production environments where websites and url.properties ports values are often changed purposely

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1549015 13f79535-47bb-0310-9956-ffa450edef68
2013-12-08 10:48:18 +00:00
Adrian Crum fb23ff7e09 Improved error message in GenericEntity.java - no functional change. The improved message should help developers solve the problem causing the exception.
This has been discussed before, but I will mention it again for instruction: GenericEntity instances that are kept in the entity cache are shared among multiple threads. Therefore, they must be immutable. If you get a GenericEntity instance from the cache and you want to modify it, you must clone it first.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1547790 13f79535-47bb-0310-9956-ffa450edef68
2013-12-04 12:43:24 +00:00
Adrian Crum 63462fa908 Added a new attribute to the ofbiz-component.xml <webapp> element - access-permission. It is used to specify an explicit permission to allow access to the web application, instead of the implied permissions specified in the base-permission attribute (which causes unpredictable behavior).
Also moved web application authorization code from the Flat Grey visual theme to LoginWorker.java. This change needs to be copied to other visual themes as well.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1546891 13f79535-47bb-0310-9956-ffa450edef68
2013-12-02 04:19:48 +00:00