I determined that Malaysia GeoData does not exist OOTB while importing customer records from a legacy system so OFBiz should be improved to include it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1583427 13f79535-47bb-0310-9956-ffa450edef68
ofbizCurrency transform does not honor the rounding passed in ofbizCurrency macro. OfbizCurrency transform always used the default rounding set in general.properties file.
jleroux:I apply Deepak's patch, seems good to me. If someone thinks there might be a better solution, please reopen
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1583040 13f79535-47bb-0310-9956-ffa450edef68
This to facilitate the creation of Git repositories where empty folders needs a file in or must be ignored
Especially when you want to keep the OFBiz Subversion repository inside the Git repository (useful for committers)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1580865 13f79535-47bb-0310-9956-ffa450edef68
In the file ./framework/common/data/CurrencyData.xml there are two records for israeli currency ILS (israeli sheckel) and NIS (new israeli Shekel).
ILS record need to be removed, its was replaced by NIS 30 years a go.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1579309 13f79535-47bb-0310-9956-ffa450edef68
While working on this I spotted another error introduced earlier with r1533839. Now, status and stop work again as before.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1577744 13f79535-47bb-0310-9956-ffa450edef68
When you use the paginate = true in a screen and the total number of rows returned is greater than 999 the string is formatted with a coma and an exception is thrown when trying to convert it to an Integer.
jleroux: this depends on language (French would be space) but Simon's fix works for all (we are only dealing with integers there)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1577268 13f79535-47bb-0310-9956-ffa450edef68
Scenario:
1. Go to Content webapp
2. Go to CompDoc menuitem
3. Search
4. Go to 'Tree' view
5. We can not use 'Up' and 'Down' function
When menu with linktype="hidden-form" was render for each menu, they has the same name for form element, so it cause error.
My solution is add extra attribute(extra-index) for Menu, and then in menu definition we provide this attribute and the forms with different name will be rendered.
My implement was tested in this bug for Content webapp
jleroux: I have simply amended the up and down labels to have them more legible. I'd have preferred to not have all uppercased, but ran out of time for such a trivial change
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1576891 13f79535-47bb-0310-9956-ffa450edef68
Then with https://issues.apache.org/jira/browse/OFBIZ-3128 contains became the default
But this was working only when defining a text-field. When auto-fields-entity (and I guess auto-fields-service, not tested) was used then like/begins-with was still the default.
This commit changes that and makes things consistent: contains is now always used and set as default everywhere (no longer need to specify the text-field when using auto-fields-* to have contains as default)
Note: I'm not quite sure why like/begins-with was still used as default, since it was no longer the default in widget-form.xsd, but anyway making contains default there works. Also in ModelFormField.java to have things consistent
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1576276 13f79535-47bb-0310-9956-ffa450edef68
Scenario:
1. Load-seed
2. Create-admin-user
3. Access: /catalog/control/main
4. Login
5. Change password for the first use
After password change, web browser redirect user to /catalog/control/main with an error
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1575508 13f79535-47bb-0310-9956-ffa450edef68
Completes code in Config.java for start-debug only (adds "start-debug" to pick start.properties when portoffset is used).
The rest of the changes is only refactoring to have the replacement to pick start.properties only in getInstance()
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1574404 13f79535-47bb-0310-9956-ffa450edef68
The service "renderSingleFormString" check the previous field position to see if the current field must be displayed after the previous field or on a new line.
When the previous field has a use-when condition that is not valid, it remains as the currentFormField and the next field is compared with this "not rendered" field. If the position of this previous field is the same as the current field, the current is displayed on the next line.
To reproduce, add in a single form the three fields below :
<field position="1" name="first"><display description="first"/></field>
<field position="2" name="second" use-when="true"><display description="second"/></field>
<field position="2" name="second" use-when="false"><display description="second"/></field>
The field second is rendered on a new line
jleroux: this second version works correctly
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1574019 13f79535-47bb-0310-9956-ffa450edef68
The service "renderSingleFormString" check the previous field position to see if the current field must be displayed after the previous field or on a new line.
When the previous field has a use-when condition that is not valid, it remains as the currentFormField and the next field is compared with this "not rendered" field. If the position of this previous field is the same as the current field, the current is displayed on the next line.
To reproduce, add in a single form the three fields below :
<field position="1" name="first"><display description="first"/></field>
<field position="2" name="second" use-when="true"><display description="second"/></field>
<field position="2" name="second" use-when="false"><display description="second"/></field>
The field second is rendered on a new line
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1573161 13f79535-47bb-0310-9956-ffa450edef68
A good example is in order creation page, open the customer lookup and then try to close it.
I think we should not fiddle with the theme, there is a faster and easier solution: center all lookups in the screen by default. It will not fix but hide the issue for now. Anyway the awful dropdown menu behaviour must be fixed and i will open another Jira for that.
You may ask why I'm concerned with a theme which is no longer bundled in future releases? It's because some custom projects still use it...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1563238 13f79535-47bb-0310-9956-ffa450edef68
Revision 1560176 introduces a change to FindGeneric.groovy that extracts some logic into UtilMisc. However, this class is not imported in the file and results in a MissingProperty exception.
This patch adds the import statement which resolves this bug.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1560699 13f79535-47bb-0310-9956-ffa450edef68
The last index (used on the last button) is not calculated correctly in ftl or the renderer classes. It currently users floor which works only for list sizes that are not multiples of the view size. When you have a list size which is a multiple of the view size, it does not subtract 1 for zero based index and therefore the last button goes to the last page + 1
Examples
listSize = 1
viewSize = 10
listSize / viewSize = 0.1
floor(0.1) = 0
This one produces the correct value
listSize = 20
viewSize = 10
listSize / viewSize = 2
floor(2) = 2
Last index should be 1 because of zero based index but never occurs
To reproduce, enter a view with a list and paging functionality, the list size must be a multiple of the view size
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1560176 13f79535-47bb-0310-9956-ffa450edef68