Author SHA1 Message Date
Jacques Le Roux 32a310ca14 Improved: Comment out the SOAP and HTTP engines (OFBIZ-12212)
The SOAP and HTTP engines are open doors to security issues.
At https://markmail.org/message/pgtjyh23bazq4s2w I proposed to comment them out
as we did for RMI in the past.
Of cause it must be clearly documented how to use them if needed.

Here is the email content:

    After the recent fix for the CVE-2021-26295[1] we discussed with the security
    team about the opportunity need to comment out the SOAP and HTTP engines
    like we did in the past for RMI[2], this obviously for security reason.

    [1] OFBIZ-12167 "Adds a blacklist (to be
    renamed soon to denylist) in Java serialisation (CVE-2021-26295)"
    [2] OFBIZ-6942 "Comment out RMI related
    code because of the Java deserialization issue [CVE-2016-2170] "

I just put a small comment in webtools and scrumm controllers, it should be
enough.

The tests pass

Conflicts handled by hand
  scrum/servicedef/services.xml
2021-03-29 13:24:08 +02:00
Michael Brohl 63df767bee Improved: Switch from jCenter to mavenCentral to handle the jCenter
shutdown (OFBIZ-12171)
2021-02-27 14:43:06 +01:00
Jacques Le Roux e7f198427b Fixed: Exception error on ecommerce portal while trying to register new user
(OFBIZ-)

Missing import statement in the groovy script on the new customer registration
page.

Thanks: Pradeep Choudhary
2021-02-27 14:10:59 +01:00
Pawan Verma 38419ef257 Fixed: Visit disabling causes NullPointerException on ecomm groovy script(OFBIZ-12173)
Used UtilHttp.getSessionId() instead of visit to get session Id.

Thanks: Giulio, Jacopo and Deepak.
2021-02-12 09:27:36 +05:30
6 changed files with 19 additions and 14 deletions
@@ -18,6 +18,7 @@
*/
import org.apache.ofbiz.base.util.UtilProperties
import org.apache.ofbiz.base.util.UtilHttp
import org.apache.ofbiz.base.util.UtilMisc
import org.apache.ofbiz.product.store.ProductStoreWorker
@@ -54,5 +55,5 @@ if (userInfoMap) {
request.getSession().setAttribute("userInfoMap", userInfoMap)
}
donePage = "main;" + parameters.visit.sessionId
donePage = "main;" + UtilHttp.getSessionId(request)
context.donePage = donePage
@@ -25,7 +25,7 @@ under the License.
<handler name="java" type="request" class="org.apache.ofbiz.webapp.event.JavaEventHandler"/>
<handler name="groovy" type="request" class="org.apache.ofbiz.webapp.event.GroovyEventHandler"/>
<handler name="soap" type="request" class="org.apache.ofbiz.webapp.event.SOAPEventHandler"/>
<!-- <handler name="soap" type="request" class="org.apache.ofbiz.webapp.event.SOAPEventHandler"/> -->
<handler name="service" type="request" class="org.apache.ofbiz.webapp.event.ServiceEventHandler"/>
<handler name="service-multi" type="request" class="org.apache.ofbiz.webapp.event.ServiceMultiEventHandler"/>
<handler name="simple" type="request" class="org.apache.ofbiz.webapp.event.SimpleEventHandler"/>
@@ -134,7 +134,7 @@ under the License.
<request-map uri="setSessionLocale">
<security https="false" auth="false"/>
<event type="java" path="org.apache.ofbiz.common.CommonEvents" invoke="setSessionLocale"/>
<response name="success" type="request-redirect" value="fromSetSessionLocale"/>
<response name="success" type="request-redirect" value="fromSetSessionLocale"/>
<response name="error" type="view" value="main"/>
</request-map>
+1 -1
View File
@@ -18,5 +18,5 @@
*/
dependencies {
pluginLibsCompile 'org.jasig.cas:cas-server-core:3.3.5'
pluginLibsCompile 'org.apereo.cas:cas-server-support-ldap-core:5.0.10'
}
@@ -29,7 +29,8 @@ import javax.naming.directory.InitialDirContext;
import javax.naming.directory.SearchControls;
import javax.naming.directory.SearchResult;
import org.jasig.cas.util.LdapUtils;
import org.apereo.cas.util.LdapUtils;
import org.ldaptive.LdapEntry;
import org.apache.ofbiz.base.util.UtilXml;
import org.apache.ofbiz.ldap.commons.AbstractOFBizAuthenticationHandler;
import org.w3c.dom.Element;
@@ -91,7 +92,8 @@ public final class OFBizActiveDirectoryAuthenticationHandler extends AbstractOFB
}
String filter = UtilXml.childElementValue(rootElement, "Filter", "(objectclass=*)");
String attribute = UtilXml.childElementValue(rootElement, "Attribute", "uid=%u");
attribute = LdapUtils.getFilterWithValues(attribute, username);
LdapEntry entry = new LdapEntry(username);
attribute = LdapUtils.getString(entry, attribute);
NamingEnumeration<SearchResult> answer = ctx.search(baseDN,
// Filter expression
"(&(" + filter + ") (" + attribute +"))",
@@ -27,7 +27,8 @@ import javax.naming.directory.DirContext;
import javax.naming.directory.InitialDirContext;
import javax.naming.directory.SearchControls;
import javax.naming.directory.SearchResult;
import org.jasig.cas.util.LdapUtils;
import org.apereo.cas.util.LdapUtils;
import org.ldaptive.LdapEntry;
import org.apache.ofbiz.base.util.UtilXml;
import org.apache.ofbiz.ldap.commons.AbstractOFBizAuthenticationHandler;
import org.w3c.dom.Element;
@@ -76,7 +77,8 @@ public final class OFBizLdapAuthenticationHandler extends AbstractOFBizAuthentic
}
String filter = UtilXml.childElementValue(rootElement, "Filter", "(objectclass=*)");
String attribute = UtilXml.childElementValue(rootElement, "Attribute", "uid=%u");
attribute = LdapUtils.getFilterWithValues(attribute, username);
LdapEntry entry = new LdapEntry(username);
attribute = LdapUtils.getString(entry, attribute);
NamingEnumeration<SearchResult> answer = ctx.search(baseDN,
// Filter expression
"(&(" + filter + ") (" + attribute +"))",
+6 -6
View File
@@ -221,14 +221,14 @@ under the License.
<service name="checkSprintStatus" engine="simple" auth="true"
location="component://scrum/minilang/ScrumServices.xml" invoke="checkSprintStatus">
</service>
<service name="checkScrumPlanHour" engine="simple" auth="true"
<service name="checkScrumPlanHour" engine="simple" auth="true"
location="component://scrum/minilang/ScrumServices.xml" invoke="checkScrumPlanHour">
<attribute name="workEffortId" type="String" mode="IN" optional="true"/>
<attribute name="custRequestId" type="String" mode="IN" optional="true"/>
<attribute name="planHours" type="Double" mode="IN" optional="true"/>
<attribute name="allow" type="Boolean" mode="OUT" optional="false"/>
</service>
<service name="reOrderProductBacklogItemSequenceNumber" engine="simple" auth="true"
<service name="reOrderProductBacklogItemSequenceNumber" engine="simple" auth="true"
location="component://scrum/minilang/ScrumServices.xml" invoke="reOrderProductBacklogItemSequenceNumber">
<attribute name="productId" type="String" mode="IN" optional="false"/>
</service>
@@ -250,11 +250,11 @@ under the License.
<description>Updates the Timesheet status back to in process to be able to correct errors</description>
<auto-attributes include="pk" mode="IN" optional="false"/>
</service>
<service name="updateScrumRevision" engine="soap" export="true"
<!-- The service below has been commented out for security reason, see OFBIZ-12212 -->
<!-- <service name="updateScrumRevision" engine="soap" export="true"
location="http://www.example.com/webtools/control/SOAPService" invoke="updateScrumRevisionChange">
<implements service="updateScrumRevisionChange"/>
</service>
</service> -->
<service name="updateScrumRevisionChange" engine="simple" export="true" validate="false" require-new-transaction="true"
location="component://scrum/minilang/ScrumServices.xml" invoke="updateScrumRevisionChange">
<description>Update Scrum Revision Change</description>
@@ -287,7 +287,7 @@ under the License.
<service name="linkToProduct" engine="java" auth="true"
location="org.apache.ofbiz.scrum.ScrumServices" invoke="linkToProduct">
<description>check when a comunication event is created if the subject contains the PD# string, if so
<description>check when a comunication event is created if the subject contains the PD# string, if so
try to find the customer request and link it to the communication event..
</description>
<attribute name="communicationEventId" type="String" mode="IN" optional="false"/>