Commit Graph
4139 Commits
Author SHA1 Message Date
Pritam Kute df753f80b2 Adding new plugin for integration of First Data payment gateway with Apache OFBiz. (OFBIZ-11837) 2020-06-24 17:40:55 +05:30
Pawan Verma 57fd870878 Improved: Replace anonymous types with lambda expressions(OFBIZ-11833) 2020-06-24 14:11:38 +05:30
Jacques Le Roux 17c42bcddc Fixed: Error while uploading file in Ecommerce Profile's File Manager (OFBIZ-10746)
This is only fixing the UI where you did not see the file to upload you selected

There is still an issue to upload the file

Thanks: Priya Sharma for testing
2020-06-23 14:54:53 +02:00
Pawan Verma 32f3e468da Improved: Replace try-finally with try with resources(OFBIZ-11826)
Set checkstyleMain.maxErrors to 26678 (-4)

Thanks: Jacques for the review.
2020-06-22 21:37:00 +05:30
Pawan Verma 8dd7f30247 Improved: Replace for-loop with forEach loop(OFBIZ-11829)
Also modified some checkstyle issues.

Set checkstyleMain.maxErrors to 26684 (-61)

Thanks: Jacques for the review.
2020-06-22 21:19:40 +05:30
Jacques Le Roux 670c08e7a3 Improved: Use a .asf.yaml file for more information in OFBiz GitHub repos
Same for ofbiz-plugins than for ofbiz-framework, not enough place for details
2020-06-22 08:36:05 +02:00
Priya SharmaandPriya Sharma 3fe12199d3 Improved: Convert FixedAssetMaintTests.xml to groovy (OFBIZ-11444) (#29)
* [Improved] Convert FixedAssetMaintTests.xml to groovy
Done the following
- Removed the xml tests file
- Updated the test suite mappings to point to the groovy test file
- Added Groovy implementation for all the test cases in FixedAssetMaintTests.xml

(OFBIZ-11444)

* [Improved]: Removed the userlogin fetching logic as the userlogin is already available in the groovy context. (OFBIZ-11444)

Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>
2020-06-16 10:49:02 +05:30
Suraj Khurana b4bdfcdf92 Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component. (#28)
* Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component.
(OFBIZ-11804)
2020-06-13 14:42:35 +05:30
Priya SharmaandPriya Sharma dd1d408bc8 [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762) (#24)
* [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

* [Improved]: Updated all ocurances where we only needed to pass the throwable object, without a message
- We have now added one more utility method to handle these cases. (OFBIZ-11762)

Co-authored-by: Priya Sharma <priya.sharma@example.com>
2020-06-08 13:39:42 +02:00
Suraj Khurana 9c447f2486 Improved: Enforce noninstantiability to LdapLoginWorker, OFBizSolrLoginWorker class. (#23)
(OFBIZ-11747)

Made class as final, added private constructor and made static variables as private.
2020-06-07 10:55:56 +05:30
Suraj Khurana b08fa4a944 Improved: Enforce noninstantiability to FinAccountHelper Class. (#22)
(OFBIZ-11723)

Made class as final, added private constructor, also made data members as private, defined getter and changed related occurrences.
2020-06-05 13:14:11 +05:30
Aditya Sharma 12e9f087a4 Improved: Breadcrumbs should be shown on all the pages of eCommerce application
(OFBIZ-2584)
Right now in OOTB eCommerce application breadcrumbs are only shown for catalog pages. It should be available on other pages too.

Added breadcrumb for ContactUs and Anonymous ContactUs page

Thanks Pranay Pandey for reporting the issue and Aishwary Shrivastava for providing the patch
2020-06-02 19:20:59 +05:30
Jacques Le Roux a133199830 Improved: adds pull_request_template.md (OFBIZ-11722) 2020-05-31 09:18:47 +02:00
Suraj Khurana ae31c01fa7 Improved: Change resources with proper naming convention in all plugin components.
(OFBIZ-11739)
Also, made MODULE as private data member of class instead of public. Thanks Jacques for review.
2020-05-29 13:14:02 +05:30
Suraj Khurana 2c65f7d17b Improved: Improved: Added UI labels for success/error messages for scrum component.
(OFBIZ-7696)
Thanks Deepak Nigam for reporting and Sourabh Punyani for the patch.
2020-05-24 13:09:47 +05:30
Suraj Khurana ade15ec80a Improved: Improvement of Quick Add screen according to new bootstrap framework.
(OFBIZ-11386)
Thanks Nitish Mishra for reporting and providing the patch.
2020-05-23 11:03:37 +05:30
Suraj Khurana 7aa38a284b Improved: UI markup Improvement of Inline promotion screen according to latest bootstrap.
(OFBIZ-11397)
Thanks Nitish Mishra for reporting and providing the patch.
2020-05-23 10:50:32 +05:30
Suraj Khurana 9c6838ef0b Improved: Refactor simple methods names as per naming convention best practices. (#20)
(OFBIZ-11700)
2020-05-23 10:34:37 +05:30
Pawan Verma 9c369dc489 Improved: Expansion of form widget field disabled atrribute with xsd improvement (#21)
(OFBIZ-10432)

Added disabled attribute support in ModelFormField with xs: boolean type
Removed specific field level disabled attribute support for CheckField and TextField
Modified existing usage of the disabled attribute as per new implementation.
Added new DisabledFieldExampleForm under Form Widget Examples for all the fields with disabled attributes.

Thanks: Rishi for the report and Taher, Gil and Jacques for the feedback
2020-05-19 17:37:19 +05:30
James Yong e7f587d8af Improved: Apply multi-block attr to each application (OFBIZ-11706)
Fix regression
2020-05-16 19:40:27 +08:00
Suraj Khurana 9428ee9579 Improved: Updated service name and removed duplicate service. (#16)
* Improved: Updated service name and removed duplicate service.
(OFBIZ-11616)

Please check dependent PR (https://github.com/apache/ofbiz-framework/pull/88) for more details.
2020-05-16 13:47:16 +05:30
James Yong 2e937378f4 Improved: Apply multi-block attr to each application (OFBIZ-11706)
Fix regression
2020-05-16 15:12:28 +08:00
James Yong ca5e6b45f1 Improved: Apply multi-block attr to each application (OFBIZ-11706)
For remaining plugin applications.
2020-05-16 13:37:43 +08:00
James Yong a802ae0a02 Improved: Apply multi-block attr to each application (OFBIZ-11706)
For eCommerce application.
2020-05-16 12:31:24 +08:00
Pierre Smits 071240205f Fixed: Application 'ismgr' doesn't show up
(OFBIZ-11704)

fixed: app-bar-display (from 'false' to 'true'
added: OFBTOOLS to base-permission
2020-05-14 14:13:01 +02:00
Pawan Verma b7baeb2b5f Fixed: Improve the buttons on edit credit card page
(OFBIZ-10975)

Thanks: Sourabh and Suraj for your contribution.
2020-05-10 14:11:38 +05:30
Pierre Smits bd50c1417b Improved: move demo data from optional plugin to base application
(OFBIZ-6110)

removed: marketing component related data in ecommerce plugin
removed: reference to marketing demo data in component.xml of ecommerce plugin
2020-05-05 15:51:20 +02:00
Pierre Smits c46a9c4db2 Improved: demo data regardng rental assets
(OFBIZ-10862)

updated fixed assets
2020-05-05 13:42:55 +02:00
Jacques Le Roux 2c98bc3835 reverted: CLONE - Use only HTTPS in OFBiz
(OFBIZ-11643)

Reverted, this needs more work
2020-05-04 13:22:10 +02:00
Jacques Le Roux 40143e6dba Fixed: CLONE - Use only HTTPS in OFBiz
(OFBIZ-11643)

When doing OFBIZ-6849 I forgot to take care of the https attribute of the
security element used in controllers.

It's not used anymore since we used HTTPS everywhere but in request listed in
http.request-map.list property of url.properties. It's even enforced by HSTS for
requests that are not listed in this property.

This removes the https attribute and removes its usage in in controllers.
2020-05-04 13:10:29 +02:00
Pawan Verma f572e74e7e Improved: Used utility provided by OFBizTestCase class for userLogin instead of fetching from DB test cases also removed unused fetching of userLogin in some cases
(OFBIZ-11618)
2020-04-30 22:01:29 +05:30
Jacques Le Roux ba246299d9 Improved: Convert testSendOrderChangeNotification to Groovy
(OFBIZ-11233)

In the XML version we were sending note (Test note) and comments
(Test Comments) as well in serviceCtx, but in the converted version we are
not sending these fields.

Thanks: Suraj for spotting it and alerting me on dev ML
2020-04-27 18:47:12 +02:00
Jacques Le Roux 1cacb15000 Improved: Update build.gradle to the latest dependencies
(OFBIZ-11603)

I tried to update to Groovy 3 but got a compile issue with commons-cli.
I did not dig further.
2020-04-21 12:00:32 +02:00
Jacques Le Roux 208ef1b1be Improved: replaces module by MODULE everywhere 2020-04-06 12:14:23 +02:00
Jacques Le Roux aa26d8f0cf Adds the meta CSRF token for Ajax 2020-04-04 18:22:26 +02:00
Jacques Le Roux cf272a9750 Improved: POC for CSRF Token
(OFBIZ-11306)

There is no need to change it in common-controller because, apart the ecommerce
application, there are no applications that requires an anonymous flow.
It should be only changed in ecommerce controller.
2020-04-04 18:22:26 +02:00
Pawan Verma 6b0c188f5a Fixed: Product Images not rendering on One Page Checkout
(OFBIZ-11400)

Thanks: Archana Asthana for the report and Devanshu Vyas for the patch.
2020-03-28 15:47:12 +05:30
Jacques Le Roux 492dcb9208 Improved: fixes a typo due to OFBIZ-11030
Thanks: Pierre Smits for spotting it
2020-03-26 16:11:09 +01:00
Jacques Le Roux 417c3e4243 Improved: formatting
Implemented:
Documented:
Completed:
Reverted:
Fixed:

(OFBIZ-)
Explanation
Thanks:
2020-03-26 16:09:22 +01:00
Jacques Le Roux a8d3781cc6 Fixed: Convert DimensionServices.xml minilang to groovy
(OFBIZ-10948)

Now correctly creates the CurrencyDimension using currency.uomId
No need for delegator.setNextSeqId(), looking at (now removed)
DimensionServices.xml confused me.

Thanks: Pierre Smits for report
2020-03-21 19:36:39 +01:00
Pawan Verma 38112fb346 Fixed: prepareProductDimensionData does not load correct fields in ProductDimension
(OFBIZ-11465)

Thanks: Pierre Smits for your contribution.
2020-03-21 17:23:05 +05:30
Jacques Le Roux d267d161e0 Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies.
(OFBIZ-11470)

As reported by OWASP ZAP:
A cookie has been set without the SameSite attribute, which means that the
cookie can be sent as a result of a 'cross-site' request. The SameSite attribute
is an effective counter measure to cross-site request forgery, cross-site script
inclusion, and timing attacks.

The solution was not obvious in OFBiz for 2 reasons:

1. There is no HttpServletResponse::setHeader. So we need to use a filter
  (SameSiteFilter) and even that is not enough because of 2:
2. To prevent session fixation we force Tomcat to generates a new jsessionId,
ultimately put in cookie, in LoginWorker::login. So we need to add a call to
SameSiteFilter::addSameSiteCookieAttribute in
UtilHttp::setResponseBrowserDefaultSecurityHeaders.
2020-03-20 17:51:00 +01:00
Jacques Le Roux cca9d4d783 Improved: "auth" should be true for all the request url used for Application
components

(OFBIZ-4956)

Put back getAssociatedStateList requesdt in ecommerce to auth="false" to allow
the anonymous flow

Thanks: Deepak for spotting an reporting the issue (twice, inadvertently I
removed the complete file, I have no ideas how I did that :/)
2020-03-17 11:38:52 +01:00
Jacques Le Roux 350571deaa Fixed: Convert DimensionServices.xml minilang to groovy
(OFBIZ-10948)

There is a bug with loadCurrencyDimension in DimensionServices.groovy
It shows when running quickInitDataWarehouse.

The problem is this Minilang expression is missing in DimensionServices.groovy:
<sequenced-id sequence-name="CurrencyDimension" field="currencyDim.dimensionId"/>

Adding
  delegator.setNextSeqId(currencyDim)
is enough.
2020-03-17 08:49:05 +01:00
Jacques Le Roux 9f87efe7ba Improved: "auth" should be true for all the request url used for Application
components

(OFBIZ-4956)

Put back getAssociatedStateList requesdt in ecommerce to auth="false" to allow
the anonymous flow

Thanks: Deepak for spotting an reporting the issue
2020-03-16 11:31:48 +01:00
Jacques Le Roux e4388ba7c4 Improved: no functional change
Follows the "How to apply the Apache License to your work" section at
https://www.apache.org/licenses/LICENSE-2.0
2020-03-14 12:33:13 +01:00
Jacques Le Roux e72e1348c1 Improved: "auth" should be true for all the request url used for Application
components

(OFBIZ-4956)

Currently there are some URLs present in application components with
auth="false". So anyone can hit these URLs and access these resources without
authorization.

I think all the URLs should be secure with auth="true"

Thanks: Amardeep Singh Jhajj for report and initial fix
2020-03-14 08:49:54 +01:00
Jacques Le Roux 7a0386a68c Implemented: have a license
(OFBIZ-11451)

Fixes missing sections in LICENCE and adds NOTICE

I have also removed the plugins prefix in "URIs" because we are under plugins

Thanks: Jacopo for spotting missing sections
2020-03-14 08:29:22 +01:00
Michael Brohl b50d949376 Improved: Convert FactServices.xml minilang to groovy.
(OFBIZ-11030)

Thanks Pierre Smits for reporting and Sebastian Berg for providing the
patch.
2020-03-13 17:44:51 +01:00
Michael Brohl d5731824c2 Implemented: Remove the user login security question.
(OFBIZ-11244)

Thanks Wiebke Pätzold for providing the patch.
2020-03-13 17:35:45 +01:00