This is only fixing the UI where you did not see the file to upload you selected
There is still an issue to upload the file
Thanks: Priya Sharma for testing
* [Improved] Convert FixedAssetMaintTests.xml to groovy
Done the following
- Removed the xml tests file
- Updated the test suite mappings to point to the groovy test file
- Added Groovy implementation for all the test cases in FixedAssetMaintTests.xml
(OFBIZ-11444)
* [Improved]: Removed the userlogin fetching logic as the userlogin is already available in the groovy context. (OFBIZ-11444)
Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>
* [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)
* [Improved]: Updated all ocurances where we only needed to pass the throwable object, without a message
- We have now added one more utility method to handle these cases. (OFBIZ-11762)
Co-authored-by: Priya Sharma <priya.sharma@example.com>
(OFBIZ-2584)
Right now in OOTB eCommerce application breadcrumbs are only shown for catalog pages. It should be available on other pages too.
Added breadcrumb for ContactUs and Anonymous ContactUs page
Thanks Pranay Pandey for reporting the issue and Aishwary Shrivastava for providing the patch
(OFBIZ-10432)
Added disabled attribute support in ModelFormField with xs: boolean type
Removed specific field level disabled attribute support for CheckField and TextField
Modified existing usage of the disabled attribute as per new implementation.
Added new DisabledFieldExampleForm under Form Widget Examples for all the fields with disabled attributes.
Thanks: Rishi for the report and Taher, Gil and Jacques for the feedback
(OFBIZ-6110)
removed: marketing component related data in ecommerce plugin
removed: reference to marketing demo data in component.xml of ecommerce plugin
(OFBIZ-11643)
When doing OFBIZ-6849 I forgot to take care of the https attribute of the
security element used in controllers.
It's not used anymore since we used HTTPS everywhere but in request listed in
http.request-map.list property of url.properties. It's even enforced by HSTS for
requests that are not listed in this property.
This removes the https attribute and removes its usage in in controllers.
(OFBIZ-11233)
In the XML version we were sending note (Test note) and comments
(Test Comments) as well in serviceCtx, but in the converted version we are
not sending these fields.
Thanks: Suraj for spotting it and alerting me on dev ML
(OFBIZ-11306)
There is no need to change it in common-controller because, apart the ecommerce
application, there are no applications that requires an anonymous flow.
It should be only changed in ecommerce controller.
(OFBIZ-10948)
Now correctly creates the CurrencyDimension using currency.uomId
No need for delegator.setNextSeqId(), looking at (now removed)
DimensionServices.xml confused me.
Thanks: Pierre Smits for report
(OFBIZ-11470)
As reported by OWASP ZAP:
A cookie has been set without the SameSite attribute, which means that the
cookie can be sent as a result of a 'cross-site' request. The SameSite attribute
is an effective counter measure to cross-site request forgery, cross-site script
inclusion, and timing attacks.
The solution was not obvious in OFBiz for 2 reasons:
1. There is no HttpServletResponse::setHeader. So we need to use a filter
(SameSiteFilter) and even that is not enough because of 2:
2. To prevent session fixation we force Tomcat to generates a new jsessionId,
ultimately put in cookie, in LoginWorker::login. So we need to add a call to
SameSiteFilter::addSameSiteCookieAttribute in
UtilHttp::setResponseBrowserDefaultSecurityHeaders.
components
(OFBIZ-4956)
Put back getAssociatedStateList requesdt in ecommerce to auth="false" to allow
the anonymous flow
Thanks: Deepak for spotting an reporting the issue (twice, inadvertently I
removed the complete file, I have no ideas how I did that :/)
(OFBIZ-10948)
There is a bug with loadCurrencyDimension in DimensionServices.groovy
It shows when running quickInitDataWarehouse.
The problem is this Minilang expression is missing in DimensionServices.groovy:
<sequenced-id sequence-name="CurrencyDimension" field="currencyDim.dimensionId"/>
Adding
delegator.setNextSeqId(currencyDim)
is enough.
components
(OFBIZ-4956)
Put back getAssociatedStateList requesdt in ecommerce to auth="false" to allow
the anonymous flow
Thanks: Deepak for spotting an reporting the issue
components
(OFBIZ-4956)
Currently there are some URLs present in application components with
auth="false". So anyone can hit these URLs and access these resources without
authorization.
I think all the URLs should be secure with auth="true"
Thanks: Amardeep Singh Jhajj for report and initial fix
(OFBIZ-11451)
Fixes missing sections in LICENCE and adds NOTICE
I have also removed the plugins prefix in "URIs" because we are under plugins
Thanks: Jacopo for spotting missing sections