(OFBIZ-11874)
This fixes following checkstyle issues:
'{' is not preceded with whitespace.
'{' is not followed by whitespace.
'}' is not followed by whitespace.
'}' is not preceded with whitespace.
'typecast' is not followed by whitespace.
'try' is not followed by whitespace.
';' is preceded with whitespace.
Sometimes use wrong type castings for BigDecimal:
I have observed that for typecasting in groovy, we have used the wrong coding
pattern like
(BigDecimal) 0
It should be like
0 as BigDecimal
Note that this does not apply to decimal because in case of decimal, the default
type is always BigDecimal in Groovy.
Thanks: Pritam Kute for spotting the issue in OFBIZ-11843
Comments out FirstDataDemoData.xml loading because it makes fail
auto-accounting-transaction-tests-sales
Thanks: Pritam Kute for the lead on data error
In Java SE 7 and later, a single catch block can handle more than one type of exception. This feature can reduce code duplication and lessen the temptation to catch an overly broad exception.
Thanks: Jacques for the review.
This is only fixing the UI where you did not see the file to upload you selected
There is still an issue to upload the file
Thanks: Priya Sharma for testing
* [Improved] Convert FixedAssetMaintTests.xml to groovy
Done the following
- Removed the xml tests file
- Updated the test suite mappings to point to the groovy test file
- Added Groovy implementation for all the test cases in FixedAssetMaintTests.xml
(OFBIZ-11444)
* [Improved]: Removed the userlogin fetching logic as the userlogin is already available in the groovy context. (OFBIZ-11444)
Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>
* [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)
* [Improved]: Updated all ocurances where we only needed to pass the throwable object, without a message
- We have now added one more utility method to handle these cases. (OFBIZ-11762)
Co-authored-by: Priya Sharma <priya.sharma@example.com>
(OFBIZ-2584)
Right now in OOTB eCommerce application breadcrumbs are only shown for catalog pages. It should be available on other pages too.
Added breadcrumb for ContactUs and Anonymous ContactUs page
Thanks Pranay Pandey for reporting the issue and Aishwary Shrivastava for providing the patch
(OFBIZ-10432)
Added disabled attribute support in ModelFormField with xs: boolean type
Removed specific field level disabled attribute support for CheckField and TextField
Modified existing usage of the disabled attribute as per new implementation.
Added new DisabledFieldExampleForm under Form Widget Examples for all the fields with disabled attributes.
Thanks: Rishi for the report and Taher, Gil and Jacques for the feedback
(OFBIZ-6110)
removed: marketing component related data in ecommerce plugin
removed: reference to marketing demo data in component.xml of ecommerce plugin
(OFBIZ-11643)
When doing OFBIZ-6849 I forgot to take care of the https attribute of the
security element used in controllers.
It's not used anymore since we used HTTPS everywhere but in request listed in
http.request-map.list property of url.properties. It's even enforced by HSTS for
requests that are not listed in this property.
This removes the https attribute and removes its usage in in controllers.
(OFBIZ-11233)
In the XML version we were sending note (Test note) and comments
(Test Comments) as well in serviceCtx, but in the converted version we are
not sending these fields.
Thanks: Suraj for spotting it and alerting me on dev ML