Commit Graph
4216 Commits
Author SHA1 Message Date
Jacques Le Roux 9bf5e044f7 Improved: Have a readme in every component (OFBIZ-6243)
Not sure why we have this problem (according to
https://docs.github.com/en/github/authenticating-to-github/about-anonymized-image-urls
could be to missing cache control in our site server)

As I was fed up not viewing the OFBIz logo anywhere, and mostly in GH,
but just in browser at https://ofbiz.apache.org/images/ofbiz_logo.png
and I noticed I was viewing it well locally at
https://github.com/apache/ofbiz-framework/tree/trunk/themes/rainbowstone
so decided to use this URL everywhere rather!
2020-08-29 13:36:23 +02:00
Jacques Le Roux 7d140f3e27 Improved: Have a readme in every component (OFBIZ-6243)
This preludes the move of content of README.md files into the asciidoc
documentation

Updates the link to OFBiz-logo.png (also in ReportDesignGenerator.java)
Removes deprecated information related to Svn, Jira and Confluence
We will move the wiki pages to wiki attic with OFBIZ-11619
2020-08-29 11:52:35 +02:00
Jacques Le Roux c8d22ed72a Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)
All final data members of the class must match this naming pattern
'^[A-Z][A-Z0-9](_[A-Z0-9]+)$'

I added the changes in CommonScreens.xml but forgot to push this one in ecommerce
2020-08-28 09:38:31 +02:00
Suraj Khurana 33d4d6c915 Improved: Corrected class names, method names, data members of class and variables names in plugins component.
(OFBIZ-11926)
Also corrected some formatting and line length related checkstyle issues.
2020-08-26 21:42:06 +05:30
Akash Jain 27c1bbed7e Improved: Additional images not showing correctly on product detail page (OFBIZ-11981) 2020-08-25 21:37:20 +05:30
Akash Jain d4a41e39ef Fixed: Distorted Final Checkout Review page when Credit card is selected as Payment option (OFBIZ-11920)
Thanks, Rashi Dhagat for reporting
2020-08-25 20:55:31 +05:30
James Yong 1c9f2ab9c6 Improved: multi-block attribute for html-template tag (OFBIZ-11686)
Not important to track server hits for getJs request
2020-08-25 21:58:26 +08:00
Jacques Le Roux 031a16026d Improved: enclose productsummary list in div.row to better use the screen/plugins (OFBIZ-11979)
It's not about div.row only, in productdetail, the reason field was outside the
summary box.

I've moved the reason inside the summary box, as a generic parameter, highlightLabel.

Thanks: Alex Bodnaru
2020-08-25 09:04:23 +02:00
Jacques Le Roux ba565306ad Improved: removes a duplicated price for PEPPERS-G
PriceServices |I| There is more than one DEFAULT_PRICE with the currencyUomId
USD and productId PEPPERS-G, using the latest found with price: 1.000
2020-08-24 18:22:44 +02:00
girishvasmatkar dce5c976f7 Added support to read children attributes of the service for rendering openapi spec (#40) 2020-08-23 11:58:19 +05:30
Pawan Verma 5545b13b13 Improved: Replace .size() == 0 with isEmpty() in Java files(OFBIZ-11944)
Thanks, priya for the report and patch and jacques for the review.
2020-08-22 19:18:38 +05:30
pritambkute 964a0790a9 Fixed: issue with return service. Alsoo, done improvements to auth service to handle more errors.(OFBIZ-11837) (#39) 2020-08-22 18:57:32 +05:30
Jacques Le Roux 809d2ce300 Improved: bootstrap-bundle*.js contains bootstrap*.js (OFBIZ-11969)
Non-bundle is redundant, with performance hit.

I also replaced in multiflex theme

Thanks: Alex Bodnaru
2020-08-22 11:08:59 +02:00
James Yong 429c9b4acd Improved: Move page-specific script links to html template (OFBIZ-11799)
Use importLibrary js function to load jstree and cookies js at ProductCategories.ftl
2020-08-22 15:53:53 +08:00
Suraj Khurana 1207d24062 Improved: Make data members of class as private and added accessor methods for the same, also corrected occurences of the same in plugins component.
(OFBIZ-11963)
Also made some related checkstyle code enhancements.
Thanks jacques for finalizing Javadoc pattern during this effort.
2020-08-22 13:22:19 +05:30
Girish Vasmatkar 2841acfb81 Fixed: OpenApi mapping for Integer.
Improved: Added missing OpenApi mapping for BigInteger.(OFBIZ-11328)
2020-08-21 16:06:32 +05:30
Girish Vasmatkar ad4bb6ec86 Improved: Added missing OpenApi mapping for Boolean and Java Collection types(OFBIZ-11328) 2020-08-21 15:44:03 +05:30
Suraj Khurana 403fc39d7f Improved: Added missing Javadocs for some methods, this is required for all classes which looks like designed for extension (can be subclassed).
(OFBIZ-11947)
This is done for plugins component. Also corrected some variables as per naming convention best practices.
Thanks Jacques for review.
2020-08-17 12:29:08 +05:30
Girish Vasmatkar bcfa194edf Fixed: Removed HELP and LICENSE files 2020-08-15 23:41:05 +05:30
girishvasmatkar 13e465109b Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz. (#35)
* First commit with REST support for exportable services

* Update README.adoc

* Updated Terms of Service and Contact email address for OpenApi

* Added a new BasicAuthFilter to generate JWT API token

* Updated README

* Removed README.md

* Fixed checkstyle error
2020-08-14 21:38:23 +05:30
James Yong 76b5ef7932 Improved: Move page-specific script links to html template (OFBIZ-11799)
Moved OpenLayer js and css to html template
Tested on https://localhost:8443/partymgr/control/PartyGeoLocation?partyId=DemoCustomer
2020-08-13 22:27:36 +08:00
Priya SharmaandPriya Sharma 01e2e16681 Improved: Move 'SecurityPermission' data to seed data files (OFBIZ-10575) (#38)
Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>
2020-08-11 16:01:46 +02:00
James Yong 2989420294 Fixed: Unable to add product to cart in ecommence (OFBIZ-11899)
Incorrect markup in ConfigProductDetail.ftl affected jsoup (when multi-block=true) to parse and output the file correctly. Let me know if not fixed.

Thanks: Jacques for reporting
2020-08-09 22:09:25 +08:00
Jacques Le Roux 882246204e Improved: Can't enter decimals when ordering on ecommerce (OFBIZ-11899)
I found the reason of this regression. It's due to
https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=a802ae0

This reverts Suraj's workaround and the change in ConfigProductDetail.ftl by
commit a802ae0. I'll ask James to fix the root of the issue in OFBIZ-11706.
2020-08-09 08:41:25 +02:00
Jacques Le Roux 5366f7d85e Improved: Can't enter decimals when ordering on ecommerce (OFBIZ-11899)
In stable demo, and R18 locally, you can order a half pizza, that's no longer
possible in trunk demo.

Moreover you can't use the Add button in trunk, And if you use the Config button
then it orders. There must be a mix between the 2 buttons, maybe the reason
why we can't no longer enter decimals in trunk...

Suraj: Added a patch with some refactoring of js code and used form attribute to
get quantity value for addform.
This might work with the provided patch but I think a better solution could be
through markup. Also, due to some time constraints, I was not able to dig deep
into how it is working in another branch.

It's a workaround that we can use to continue over OFBIZ-11916.
But I don't like that we have both add_amount and quantity fields out of the
addform form. Actually as I explained at https://markmail.org/message/lnz57yzj3uywcr2y
I don't even understand how this is possible since the FTL source sounds correct...

Thanks: Suraj for the temporary workaround
2020-08-08 16:59:15 +02:00
Priya Sharma 04b8809124 Improved: Removed unused imports from Java files for fixing checkstyle errors
(OFBIZ-11930)
Thanks: Priya Sharma
2020-08-07 18:55:50 +05:30
Priya Sharma fb7bdda1ef Improved: Remove unused imports from Java files (OFBIZ-11930) (#36)
Improved: Remove unused imports from Java files
(OFBIZ-11930)
Thanks: Priya Sharma
2020-08-06 19:49:45 +05:30
Akash Jain 7f462731de Improved: Status ID checkbox for FindTask and FindTimeSheet forms (OFBIZ-11936) 2020-08-04 22:57:24 +05:30
Akash Jain aa2bfde7cc Fixed: Product link on Order confirmation page is not responding (OFBIZ-11735)
Thanks, Rashi Dhagat for reporting.
2020-08-03 18:10:24 +05:30
Suraj Khurana b65d9c94df Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-plugins into trunk 2020-08-03 10:08:06 +05:30
Suraj Khurana 30f796146c Improved: Corrected some line is longer than 150 characters checkstyle issues. Also fixed some extra spaces and naming conventions related checkstyle issues.
(OFBIZ-11921)
2020-08-03 10:07:16 +05:30
Jacques Le Roux 68e603fb4b Fixed: getJs unknown in Webpos (OFBIZ-11932)
R17 is not affected
2020-08-01 13:08:53 +02:00
Pawan Verma b7ef54d494 Improved: Inconsistent String Comparisons(OFBIZ-9254)
There are some inconsistencies in the code for string comparison statusId.equals(PRUN_COMPLETED) whereas it should be written as PRUN_COMPLETED.equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.

Thanks: Devanshu for your contribution.
2020-07-30 17:02:52 +05:30
Suraj Khurana 743c627f40 Improved: Corrected all incorrect indentation level issues in plugins component, also fixed some case indentation checkstyle issues.
(OFBIZ-11922)
2020-07-26 21:07:45 +05:30
Suraj Khurana 4b88493e1b Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-plugins into trunk 2020-07-25 13:49:34 +05:30
Suraj Khurana 78801df453 Improved: Updated case indentation to 0 for all switch statements in plugins component. Also done formatting changes as per checkstyle best practices.
(OFBIZ-11904)
2020-07-25 13:48:25 +05:30
Jacques Le Roux dc55cb4746 Improved: Update markup of Quick Checkout Page according Bootstrap v4.0.0 (OFBIZ-10136)
Fixes a typo
2020-07-25 09:57:39 +02:00
Aditya Sharma cfba1f3fe2 Fixed: ui for the product summary in promotion product list (OFBIZ-11906)
The product summary in the row is too slim, leaving 75% of the place unused.
Added CSS that forces to take 100% width
Thanks Alex Bodnaru for reporting and providing the patch
2020-07-24 16:06:33 +05:30
holivier d349811a26 Documented: migrate help link to asciidoc user manual for Plugin
ProjectMgr (OFBIZ-11587)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, change Project help page to a
short page with a link to the new help

Remove docbook help files for PROJECTMGR
2020-07-22 19:26:24 +02:00
holivier 8d6c36b624 Documented: ofbiz-plugins / ProjectMgr, migration of docbook help files
to asciidoc, most of files have been directly included in
project-mgr.adoc. (OFBIZ-11587)
2020-07-22 19:21:29 +02:00
holivier cb502cae03 Documented: ofbiz-plugins / MyPortal, remove docbook migrated to
asciidoc (only a short introduction) (OFBIZ-11587)
2020-07-22 18:08:18 +02:00
holivier 2a7ea475d3 Documented: ofbiz-plugins / MyPortal, migration for the Help docbook
file to asciidoc (only a short introduction) (OFBIZ-11587)

add in _include directory, two portlet help coming from other components
(commonext and workeffort)
2020-07-22 18:08:18 +02:00
Jacques Le Roux 9c87fb85b1 Improved: Update build.gradle to the latest dependencies (OFBIZ-11903)
See
https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check
for libs not upgraded.
2020-07-21 10:42:14 +02:00
Suraj Khurana 51cb1d7958 Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-plugins into trunk 2020-07-21 12:29:01 +05:30
Suraj Khurana 22ccc6801f Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in plugins component.
(OFBIZ-11886)
2020-07-21 12:28:45 +05:30
Jacques Le Roux a0f7e77e77 Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)
Removes all error*.jsp reference, no longer used
2020-07-20 19:27:23 +02:00
holivier 1d41025097 Documented: ofbiz-plugins / msgGateway, remove docbook file without
migrate them to asciidoc (contain only a title)
(OFBIZ-11587)
2020-07-20 16:12:02 +02:00
holivier cb082af513 Documented: migrate help link to asciidoc user manual for Plugin
BIRT (OFBIZ-11587)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, change BIRT help page to a short
page with a link to the new help

Remove docbook help files for BIRT
2020-07-20 16:08:36 +02:00
holivier bf48bcb098 Documented: ofbiz-plugins / Birt, review existing adoc and migration for
Help docbook file to asciidoc (OFBIZ-11587)

* add license in each file, and remove trailing space
* better numberer list management
* add section Birt in Ofbiz user screen with help migrated file
2020-07-20 15:54:00 +02:00
holivier a321e5f49f Documented: migrate help link to asciidoc user manual for Plugin
EbayStore (OFBIZ-11587)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about
EbayStore and add a short page with a link to the new help

Remove docbook help files for EbayStore
2020-07-20 15:45:35 +02:00