------------------------------------------------------------------------
r1861904 | jleroux | 2019-06-23 11:09:00 +0200 (dim. 23 juin 2019) | 26 lignes
Fixed: Last Categories section is blank
(OFBIZ-10858)
Issue 1:
1. Open https://demo-trunk.ofbiz.apache.org/ecomseo
2. Click on a category from the Categories section
3. Refresh the page
Actual:
1. Last Categories is blank
2. If we refresh the page then only the search category visible with the last
row blank with a bullet.
Issue 2:
1. Open https://demo-trunk.ofbiz.apache.org/ecomseo
2. Click on a category from the Categories section
3. Again, open the https://demo-trunk.ofbiz.apache.org/ecomseo in the new tab
Actual: 1st row is blank with searched categories
As per the initial observation, the issue persists for some specific categories
like Dropship Products, Account Activation and Services.
For all other categories, the last categories section is populated correctly.
So there could be some issue with the data.
jleroux: on Priya warning I modified the descriptions
Thanks: Rashi Dhagat for reporting, Priya Sharma for the fix
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1861907 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: UI issue on the Contact Us page of ecommerce application
(OFBIZ-11061)
Steps to regenerate:
1. Navigate to https://demo-trunk.ofbiz.apache.org/ecomseo/
2. Click on Login
3. Enter valid username and password
4. Click on login button
5. Click on Contact Us
Actual: From, subject and message label are not displayed properly on some resolution.
Note: This issue is resolution specific if you are unable to generate the issue then increase the resolution of your screen or zoom in the page on browser
Thanks: Arpit Mor for reporting and Sasikant Biswal for providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1861827 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1859893 | jleroux | 2019-05-24 19:15:04 +0200 (ven. 24 mai 2019) | 4 lignes
Fixed: Services allow arbitrary HTML for parameters with allow-html set to "safe"
(OFBIZ-5254)
Once again forgot to commit this changes in plugins :/
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1859895 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1859735 | jleroux | 2019-05-22 18:41:04 +0200 (mer. 22 mai 2019) | 12 lignes
Fixed: massPrintOrders service does not work
(OFBIZ-11049)
This problem was similar to what was resolved by r1806237 for OFBIZ-9138.
This fixes it by using the same solution than in r1806237. If the visual theme
is unknown in the the service context get the default theme from
general.properties using ThemeFactory::resolveTheme.
sendPrintFromScreen, createFileFromScreen, sendBirtMail, getXslFo and
printReportPdf (in example) were concerned
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1859739 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1859012 | jleroux | 2019-05-09 16:32:35 +0200 (jeu. 09 mai 2019) | 6 lignes
Fixed: Touch F8 in webpos does not work and generate an error
(OFBIZ-11010)
Adds missing data for POS_SALES_CHANNEL fix this issue, was removed in r1754402.
Thanks: Pawan Verma
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1859014 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1858312 | jleroux | 2019-04-28 12:51:46 +0200 (dim. 28 avr. 2019) | 17 lignes
Fixed: Remove link is not working in shopping list
(OFBIZ-10967)
Steps to reproduce
1. Login with valid username and password.
2. Navigate to ecommerce.
2.1 Adds product/s to the cart
2.2 Add it/them in a shopping list.
4. Navigate to shopping list section.
5. Click on link “Remove"
Expected Result: Product should be removed from shopping list.
Actual Result: Remove link is not working.
jleroux: OFBIZ-7291 broke it. That can be tested on old demo (R13)
Fixed by using a simple submit field
Thanks: Ashish Sharma for report
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1858314 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: FindTask does not allow for all statuses possible to be selected.
(OFBIZ-10913)
Thanks Pierre Smits for repoting, Deepak Dixit for comments/findings and Pawan Verma for providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1858287 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1858141 | jleroux | 2019-04-25 16:27:36 +0200 (jeu. 25 avr. 2019) | 11 lignes
Fixed: Ensure html verbosity is following general setup
(OFBIZ-10940)
Currently the configuration of the Birt and Scrum component does not follow the
- de facto - standard of having the html code reference the OFBiz widget and
templates.
See [1] vs [2]
[1] view-source:https://demo-trunk.ofbiz.apache.org/birt/control/main
[2] view-source:https://demo-trunk.ofbiz.apache.org/accounting/control/main
Thanks: Pierre Smits
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1858143 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10920)
CVE-2019-0232 Apache Tomcat Remote Code Execution on Windows
Severity: Important
Vendor: The Apache Software Foundation
Versions Affected:
Apache Tomcat 9.0.0.M1 to 9.0.17
Apache Tomcat 8.5.0 to 8.5.39
Apache Tomcat 7.0.0 to 7.0.93
Description:
When running on Windows with enableCmdLineArguments enabled, the CGI
Servlet is vulnerable to Remote Code Execution due to a bug in the way
the JRE passes command line arguments to Windows. The CGI Servlet is
disabled by default. The CGI option enableCmdLineArguments is disabled
by default in Tomcat 9.0.x (and will be disabled by default in all
versions in response to this vulnerability). For a detailed explanation
of the JRE behaviour, see Markus Wulftange's blog [1] and this archived
MSDN blog [2].
Mitigation:
Users of affected versions should apply one of the following mitigations:
- Ensure the CGI Servlet initialisation parameter enableCmdLineArguments
is set to false
- Upgrade to Apache Tomcat 9.0.18 or later when released
- Upgrade to Apache Tomcat 8.5.40 or later when released
- Upgrade to Apache Tomcat 7.0.93 or later when released
This announcement is being made before the releases are available as the
change to fix this issue is obviously security related.
Credit:
This issue was identified by an external security researcher and
reported to the Apache Tomcat security team via the bug bounty program
sponsored by the EU FOSSA-2 project.
jleroux: actually Tomcat 9.0.19 was released, here it is
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1857588 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1857173 | jleroux | 2019-04-09 13:49:10 +0200 (mar. 09 avr. 2019) | 8 lignes
Fixed: Error message is displayed while click on create new quotes.
(OFBIZ-10882)
This feature has been removed with OFBIZ-10882,
This removes the "Create New Quote" link, the redundant "Save" link (there is a
Save button) and the OrderCreateQuoteFromShoppingList label which was only used
there
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1857177 13f79535-47bb-0310-9956-ffa450edef68
===
Improved: Amount field is editable at Product Detail Page
(OFBIZ-10663)
Added mising css and js code to show/hide the amount field based on Product.requireAmount field.
Thanks Dikpal Kanungo for reporting the issue.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1857122 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1856917 | jleroux | 2019-04-04 14:17:35 +0200 (jeu. 04 avr. 2019) | 12 lignes
Fixed: Unable to create new quote from cart at eCommerce store
(OFBIZ-10886)
Actually we decided that an external user should not be able to create quotes
but only requests for quote.
This disables creating quotes from the ecommerce. An authorised user can still
do the same from the backedn (order manager)
Thanks: Sanjay Yadav for initial report, Sasikant Biswal for trying, Pierre for
mentioning that this should not be open to external users and Pawan Verma for
the fix
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1856919 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1856802 | jleroux | 2019-04-02 09:52:53 +0200 (mar. 02 avr. 2019) | 17 lignes
Fixed: Error message is displayed in shopping cart when click on recalculate
cart link
(OFBIZ-10852)
Login with valid username and password.
Navigate to ecommerce.
Add multiple product in shopping cart.
Select one product and click on remove selected.
Product should be removed.
Select another product and click on recalculate cart.
Expected result: Product should be recalculate.
Actual result: Error message is displayed as 404. Screen print attached
jleroux: I did not see the error message but the fix makes sense anyway
Thanks: Ashish Sharma for report Sasikant Biswal for the fix
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1856804 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10873)
The HTTP/2 implementation accepted streams with excessive numbers of
SETTINGS frames and also permitted clients to keep streams open without
reading/writing request/response data. By keeping streams open for
requests that utilised the Servlet API's blocking I/O, clients were able
to cause server-side threads to block eventually leading to thread
exhaustion and a DoS.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1856215 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: Product image is not displayed on showcart page of ecommerce.
(OFBIZ-10738)
Thanks Arpit Mor for reporting the issue and Praveen Sharma for providing the patch.
It was occuring due to incorrect encoder type used and so URL was not creating properly to render the image.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1855085 13f79535-47bb-0310-9956-ffa450edef68
===
Improved: Improve ecommerce main-decorator
(OFBIZ-10790)
Added two new section in ecommerce main-decorator, now we don't need to pass right/left bar screen name, instead we can include it directly in decoratot-section.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1851138 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1851068 | jleroux | 2019-01-11 17:12:01 +0100 (ven. 11 janv. 2019) | 12 lignes
Fixed: Add session tracking mode and make cookie secure
(OFBIZ-6655)
Following "Session timeout for webapps" discussion on dev ML
https://markmail.org/message/p6fbiojjrwb2ybxd
We decided to put back the session-timeout value in web.xml files and to remove
the line
session.setMaxInactiveInterval(60*60); //in seconds
from ControlEventListener.java
Thanks: Deepak Nigam for report and Girish Vasmatkar for discussion
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1851072 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: visual-editor not working on ecommerce (OFBIZ-10708)
The main issue was in js file loading, jQuery is being initialised twice thus eltre might not be available in the prototype of reinitialised jQuery object.
Thanks Aditya Sharama for the discussion
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1848922 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1848398 | jleroux | 2018-12-07 14:14:48 +0100 (ven. 07 déc. 2018) | 17 lignes
Fixed: User's name is displayed on ecommerce even after user logs out
(OFBIZ-10666)
Steps to regenerate:
Open URL: https://demo-trunk.ofbiz.apache.org/ecommerce/control/main.
Welcome is displayed and user's name is not displayed when URL is opened.
Login at ecommerce, username will be displayed after user logs in.
Logout of ecommerce by clicking on logout. User will be logged out and login
link will be displayed in place of logout link, but the name of user is still
displayed.
Actual: Username is still displayed after user logs out
Expected: Username should not be displayed after the user logs out
Note: Similar issue also exists when the user clicks on (Not You?) link.
Thanks: Arpit Mor for detailled report, Deepak Dixit for discussion
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1848400 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1848009 | shijh | 2018-12-02 19:51:51 +0100 (dim. 02 déc. 2018) | 16 lignes
Improved: OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
(OFBIZ-10655)
I didn't realized OFBizPricatUtil under org.apache.poi package is a bug
for OFBiz project at the first sight of this issue. When I tried to think from
Jacques view as our project SQA, I understood this OFBizPricatUtil may be missed
during code style check, and this is a major problem :).
Now I moved the OFBizPricatUtil under org.apache.ofbiz.pricat.util package and
changed two other files accordingly.
I upgraded the implement to match the POI 3.7 used in the OFBiz plugins
trunk, and I also tested it with POI 4.0.0 and it worked fine.
Thanks: Jacques for pointing out this issue
------------------------------------------------------------------------
jleroux: I fixed 2 small conflicts by hand in AbstractPricatParser and
SamplePricatParser.java
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1848026 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1847530 | jleroux | 2018-11-27 12:27:39 +0100 (mar. 27 nov. 2018) | 12 lignes
Reverted: User should be redirected to view cart page after adding the product
from compare product screen
(OFBIZ-10667)
Revert r1847478
There was a problem with this fix. It changes the behaviour of additem when you
add an item from the main or another page.
The behaviour is defined by the "Always View Cart After Adding An Item."
checkbox in the cart view.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1847531 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1847528 | jleroux | 2018-11-27 12:18:07 +0100 (mar. 27 nov. 2018) | 19 lignes
Fixed: User should be redirected to view cart page after adding the product
from compare product screen
(OFBIZ-10667)
Currently user is navigating add item page instead of view cart page while
adding product to cart from compare product screen. User gets stuck after
navigating over add item page.
Steps to replicate the issue:
1. Go to eCommerce application.
2. Click on add to compare button for the products -
Round Gizmo and Tiny Chrome Widget.
3. Click on 'Compare Products' from right bar.
4. Click on 'Add to cart' over compare product screen.
Expected behaviour : User should be redirected to view cart page instead
of add item page.
Thanks: Ratnesh Upadhyay for report and Ritesh Kumar for the fix
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1847529 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1847398 | jleroux | 2018-11-25 09:40:23 +0100 (dim. 25 nov. 2018) | 15 lignes
Fixed: Instructions for Configurable PC don't work
(OFBIZ-10542)
This concerns only R16, R17 and the trunk. The "Instructions" button was not
present in R13.
This kind of message shows:
Trunk:
<a href="javascript:showErrorAlert('The following errors occurred','');"
R16:
<a href="javascript:showErrorAlert(" the="" following="" errors="" occurred","")
The same exists for all configurable products, notably Gold Pizza
Thanks: Priya Sharma
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1847400 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1847272 | jleroux | 2018-11-23 15:27:05 +0100 (ven. 23 nov. 2018) | 10 lignes
Fixed: Plugins Asciidoc documentation must be standalone
(OFBIZ-10658)
Completes the standalone document part as required by guidelines.
Note that using ":toclevels: 3" does not work when generating with Gradle
because of the OOTB definition "'toclevels': '5'" in build.gradle
It does when used apart in Asciidoc editors. I believe OOTB a 3 levels is enough
and the numbers are superfluous if not unpleasant.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1847274 13f79535-47bb-0310-9956-ffa450edef68
R17 branch
(OFBIZ-10657)
Convert Birt component doc from Markdown to AsciiDoc
(OFBIZ-10647)
As discussed in https://markmail.org/message/x7sv2mpvtytr4vl4 we decided to
backport the Asciidoc documentation, and means to generate it, to R17 branch
This is related with OFBIZ-10651 and OFBIZ-10652 tasks.
So 2 parts are impacted: code in framework and plugins and Buildbot script.
It's only a copy from the trunk to the R17 branch, including *.adoc files,
related images and the build.gradle script.
I previous commit I missed to remove security-impersonation.adoc now replaced
by sy-impersonation.adoc
Forgot to commit the plugins part. Including replacing Birt Markdown
documentation by Asciidoc (OFBIZ-10647)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1847253 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1845558 | jleroux | 2018-11-02 10:46:42 +0100 (ven. 02 nov. 2018) | 15 lignes
Fixed: Correct behaviour of Autologin cookies
(OFBIZ-10635)
Renames "keep-autologin-cookie" to "use-autologin-cookie", and only create
Autologin cookies when needed. No need to create Autologin cookies in
applications that don't need it.
Don't pass webAppName to LoginWorker::getSecuredUserLoginId, that can be handled
with improved LoginWorker::getSecuredLoginIdCookieName
Removes LoginWorker::autoLogoutCleanCookies, no longer needed since only those
needed are created and kept (1 year at least after creation).
For both autoLogin and securedLoginId cookies sets the path to the application.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1845569 13f79535-47bb-0310-9956-ffa450edef68
=======================================================
Fixed: ECommerce landing page breaks if popular category does not exists.
(OFBIZ-10617)
Thanks Rehan for reporting the issue and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1844947 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: Webpos Keyboard Shortcut keys does not work correctly
(OFBIZ-7945)
Updated wrong function calls in switch case of activateHotKeys(). As support for Pin Payment transactions is still to be added under OFBIZ-5241. Commented code for Pin payment transaction and updated other shortcuts accordingly.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1841651 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1838381 | jleroux | 2018-08-19 17:30:42 +0200 (dim. 19 août 2018) | 8 lignes
Fixed: Search in Ecommerce no longer works
(OFBIZ-10531)
I guess that when I worked on OFBIZ-9164 I broke that.
I found 3 occurences where the dispatcher was not in the session because the
session comes from the request and the request has not it in.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1838383 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: Could not find simple-method createWorkEffortSkillStandard as it was called as simple method and it is converted to entity-auto service.
(OFBIZ-10524)
Thanks Fernando Ortega for reporting the issue.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1838250 13f79535-47bb-0310-9956-ffa450edef68