(OFBIZ-10849)
1. Navigate to demo-trunk ecom
2. Scroll the page and see the last category section in the right column of the screen.
3. The last category section seems to be distorted because of the empty list Screenshot attached for the same.
The patch contains the following:
- Fixed the category section rendering.
- Improved the markup of survey section of the main page.
- Improved the UI/UX of view cart screen
Thanks Garima jain and Nitish Mishra for your contribution
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858265 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10896)
Currently, we are using code39 to generate barcodes but there are some limitations of code39 as it only able to encrypt letters from A to Z, digits from 0 to 9 and an additional set of special characters – “. $ % + – / *”.
Thanks Pawan Verma for reporting, analysis and providing the patch. Thanks everyone else for providing their inputs during discussion on Dev ML.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858243 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10920)
CVE-2019-0232 Apache Tomcat Remote Code Execution on Windows
Severity: Important
Vendor: The Apache Software Foundation
Versions Affected:
Apache Tomcat 9.0.0.M1 to 9.0.17
Apache Tomcat 8.5.0 to 8.5.39
Apache Tomcat 7.0.0 to 7.0.93
Description:
When running on Windows with enableCmdLineArguments enabled, the CGI
Servlet is vulnerable to Remote Code Execution due to a bug in the way
the JRE passes command line arguments to Windows. The CGI Servlet is
disabled by default. The CGI option enableCmdLineArguments is disabled
by default in Tomcat 9.0.x (and will be disabled by default in all
versions in response to this vulnerability). For a detailed explanation
of the JRE behaviour, see Markus Wulftange's blog [1] and this archived
MSDN blog [2].
Mitigation:
Users of affected versions should apply one of the following mitigations:
- Ensure the CGI Servlet initialisation parameter enableCmdLineArguments
is set to false
- Upgrade to Apache Tomcat 9.0.18 or later when released
- Upgrade to Apache Tomcat 8.5.40 or later when released
- Upgrade to Apache Tomcat 7.0.93 or later when released
This announcement is being made before the releases are available as the
change to fix this issue is obviously security related.
Credit:
This issue was identified by an external security researcher and
reported to the Apache Tomcat security team via the bug bounty program
sponsored by the EU FOSSA-2 project.
jleroux: actually Tomcat 9.0.19 was released, here it is
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1857586 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10882)
This feature has been removed with OFBIZ-10882,
This removes the "Create New Quote" link, the redundant "Save" link (there is a
Save button) and the OrderCreateQuoteFromShoppingList label which was only used
there
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1857173 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10663)
Added mising css and js code to show/hide the amount field based on Product.requireAmount field.
Thanks Dikpal Kanungo for reporting the issue.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1857120 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10886)
Actually we decided that an external user should not be able to create quotes
but only requests for quote.
This disables creating quotes from the ecommerce. An authorised user can still
do the same from the backedn (order manager)
Thanks: Sanjay Yadav for initial report, Sasikant Biswal for trying, Pierre for
mentioning that this should not be open to external users and Pawan Verma for
the fix
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1856917 13f79535-47bb-0310-9956-ffa450edef68
cart link
(OFBIZ-10852)
Login with valid username and password.
Navigate to ecommerce.
Add multiple product in shopping cart.
Select one product and click on remove selected.
Product should be removed.
Select another product and click on recalculate cart.
Expected result: Product should be recalculate.
Actual result: Error message is displayed as 404. Screen print attached
jleroux: I did not see the error message but the fix makes sense anyway
Thanks: Ashish Sharma for report Sasikant Biswal for the fix
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1856802 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10873)
The HTTP/2 implementation accepted streams with excessive numbers of
SETTINGS frames and also permitted clients to keep streams open without
reading/writing request/response data. By keeping streams open for
requests that utilised the Servlet API's blocking I/O, clients were able
to cause server-side threads to block eventually leading to thread
exhaustion and a DoS.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1856212 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10738)
Thanks Arpit Mor for reporting the issue and Praveen Sharma for providing the patch.
It was occuring due to incorrect encoder type used and so URL was not creating properly to render the image.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1855082 13f79535-47bb-0310-9956-ffa450edef68
authentication
(OFBIZ-10307)
Non functional change
Removes now useless "webappName" var after I put in the SecuredUserLoginId
cookies.
Thanks: Michael for spotting it in OFBIZ-10814
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1851885 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10790)
Added two new section in ecommerce main-decorator, now we don't need to pass right/left bar screen name, instead we can include it directly in decoratot-section.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1851135 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-6655)
Following "Session timeout for webapps" discussion on dev ML
https://markmail.org/message/p6fbiojjrwb2ybxd
We decided to put back the session-timeout value in web.xml files and to remove
the line
session.setMaxInactiveInterval(60*60); //in seconds
from ControlEventListener.java
Thanks: Deepak Nigam for report and Girish Vasmatkar for discussion
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1851068 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10758)
As of jQuery 3.0, .bind() has been deprecated. It was superseded by the .on() method for attaching event handlers to a document.
Additional change:
Improved boolean returns with single statement, replacing if blocks with explicit boolean return.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1850712 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10767)
Following this discussion on dev ML I decided to test it on Ubuntu in my Windows
7 VM and it works there.
Just that you don't automatically get back to the webpos page when changing theme
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1850552 13f79535-47bb-0310-9956-ffa450edef68
The main issue was in js file loading, jQuery is being initialised twice thus eltre might not be available in the prototype of reinitialised jQuery object.
Thanks Aditya Sharama for the discussion
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1848921 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10701)
In order to detect potential issues early, the linting compiler option should be
used by default and disabled with {{./gradlew -PXlint:none build}}.
Additionally it is important to reduce the number of warnings otherwise new
warnings will remain unnoticed.
The warning related to the com.googlecode.concurrentlinkedhashmap dependency
should resolves itself once we handle upgrade to Caffeine like proposed in
OFBIZ-6747.
Thanks: Mathieu Lirzin
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1848673 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10666)
Steps to regenerate:
Open URL: https://demo-trunk.ofbiz.apache.org/ecommerce/control/main.
Welcome is displayed and user's name is not displayed when URL is opened.
Login at ecommerce, username will be displayed after user logs in.
Logout of ecommerce by clicking on logout. User will be logged out and login
link will be displayed in place of logout link, but the name of user is still
displayed.
Actual: Username is still displayed after user logs out
Expected: Username should not be displayed after the user logs out
Note: Similar issue also exists when the user clicks on (Not You?) link.
Thanks: Arpit Mor for detailled report, Deepak Dixit for discussion
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1848398 13f79535-47bb-0310-9956-ffa450edef68