(OFBIZ-10920)
CVE-2019-0232 Apache Tomcat Remote Code Execution on Windows
Severity: Important
Vendor: The Apache Software Foundation
Versions Affected:
Apache Tomcat 9.0.0.M1 to 9.0.17
Apache Tomcat 8.5.0 to 8.5.39
Apache Tomcat 7.0.0 to 7.0.93
Description:
When running on Windows with enableCmdLineArguments enabled, the CGI
Servlet is vulnerable to Remote Code Execution due to a bug in the way
the JRE passes command line arguments to Windows. The CGI Servlet is
disabled by default. The CGI option enableCmdLineArguments is disabled
by default in Tomcat 9.0.x (and will be disabled by default in all
versions in response to this vulnerability). For a detailed explanation
of the JRE behaviour, see Markus Wulftange's blog [1] and this archived
MSDN blog [2].
Mitigation:
Users of affected versions should apply one of the following mitigations:
- Ensure the CGI Servlet initialisation parameter enableCmdLineArguments
is set to false
- Upgrade to Apache Tomcat 9.0.18 or later when released
- Upgrade to Apache Tomcat 8.5.40 or later when released
- Upgrade to Apache Tomcat 7.0.93 or later when released
This announcement is being made before the releases are available as the
change to fix this issue is obviously security related.
Credit:
This issue was identified by an external security researcher and
reported to the Apache Tomcat security team via the bug bounty program
sponsored by the EU FOSSA-2 project.
jleroux: actually Tomcat 9.0.19 was released, here it is
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1857588 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1857173 | jleroux | 2019-04-09 13:49:10 +0200 (mar. 09 avr. 2019) | 8 lignes
Fixed: Error message is displayed while click on create new quotes.
(OFBIZ-10882)
This feature has been removed with OFBIZ-10882,
This removes the "Create New Quote" link, the redundant "Save" link (there is a
Save button) and the OrderCreateQuoteFromShoppingList label which was only used
there
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1857177 13f79535-47bb-0310-9956-ffa450edef68
===
Improved: Amount field is editable at Product Detail Page
(OFBIZ-10663)
Added mising css and js code to show/hide the amount field based on Product.requireAmount field.
Thanks Dikpal Kanungo for reporting the issue.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1857122 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1856917 | jleroux | 2019-04-04 14:17:35 +0200 (jeu. 04 avr. 2019) | 12 lignes
Fixed: Unable to create new quote from cart at eCommerce store
(OFBIZ-10886)
Actually we decided that an external user should not be able to create quotes
but only requests for quote.
This disables creating quotes from the ecommerce. An authorised user can still
do the same from the backedn (order manager)
Thanks: Sanjay Yadav for initial report, Sasikant Biswal for trying, Pierre for
mentioning that this should not be open to external users and Pawan Verma for
the fix
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1856919 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1856802 | jleroux | 2019-04-02 09:52:53 +0200 (mar. 02 avr. 2019) | 17 lignes
Fixed: Error message is displayed in shopping cart when click on recalculate
cart link
(OFBIZ-10852)
Login with valid username and password.
Navigate to ecommerce.
Add multiple product in shopping cart.
Select one product and click on remove selected.
Product should be removed.
Select another product and click on recalculate cart.
Expected result: Product should be recalculate.
Actual result: Error message is displayed as 404. Screen print attached
jleroux: I did not see the error message but the fix makes sense anyway
Thanks: Ashish Sharma for report Sasikant Biswal for the fix
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1856804 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10873)
The HTTP/2 implementation accepted streams with excessive numbers of
SETTINGS frames and also permitted clients to keep streams open without
reading/writing request/response data. By keeping streams open for
requests that utilised the Servlet API's blocking I/O, clients were able
to cause server-side threads to block eventually leading to thread
exhaustion and a DoS.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1856215 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: Product image is not displayed on showcart page of ecommerce.
(OFBIZ-10738)
Thanks Arpit Mor for reporting the issue and Praveen Sharma for providing the patch.
It was occuring due to incorrect encoder type used and so URL was not creating properly to render the image.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1855085 13f79535-47bb-0310-9956-ffa450edef68
===
Improved: Improve ecommerce main-decorator
(OFBIZ-10790)
Added two new section in ecommerce main-decorator, now we don't need to pass right/left bar screen name, instead we can include it directly in decoratot-section.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1851138 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1851068 | jleroux | 2019-01-11 17:12:01 +0100 (ven. 11 janv. 2019) | 12 lignes
Fixed: Add session tracking mode and make cookie secure
(OFBIZ-6655)
Following "Session timeout for webapps" discussion on dev ML
https://markmail.org/message/p6fbiojjrwb2ybxd
We decided to put back the session-timeout value in web.xml files and to remove
the line
session.setMaxInactiveInterval(60*60); //in seconds
from ControlEventListener.java
Thanks: Deepak Nigam for report and Girish Vasmatkar for discussion
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1851072 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: visual-editor not working on ecommerce (OFBIZ-10708)
The main issue was in js file loading, jQuery is being initialised twice thus eltre might not be available in the prototype of reinitialised jQuery object.
Thanks Aditya Sharama for the discussion
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1848922 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1848398 | jleroux | 2018-12-07 14:14:48 +0100 (ven. 07 déc. 2018) | 17 lignes
Fixed: User's name is displayed on ecommerce even after user logs out
(OFBIZ-10666)
Steps to regenerate:
Open URL: https://demo-trunk.ofbiz.apache.org/ecommerce/control/main.
Welcome is displayed and user's name is not displayed when URL is opened.
Login at ecommerce, username will be displayed after user logs in.
Logout of ecommerce by clicking on logout. User will be logged out and login
link will be displayed in place of logout link, but the name of user is still
displayed.
Actual: Username is still displayed after user logs out
Expected: Username should not be displayed after the user logs out
Note: Similar issue also exists when the user clicks on (Not You?) link.
Thanks: Arpit Mor for detailled report, Deepak Dixit for discussion
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1848400 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1848009 | shijh | 2018-12-02 19:51:51 +0100 (dim. 02 déc. 2018) | 16 lignes
Improved: OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
(OFBIZ-10655)
I didn't realized OFBizPricatUtil under org.apache.poi package is a bug
for OFBiz project at the first sight of this issue. When I tried to think from
Jacques view as our project SQA, I understood this OFBizPricatUtil may be missed
during code style check, and this is a major problem :).
Now I moved the OFBizPricatUtil under org.apache.ofbiz.pricat.util package and
changed two other files accordingly.
I upgraded the implement to match the POI 3.7 used in the OFBiz plugins
trunk, and I also tested it with POI 4.0.0 and it worked fine.
Thanks: Jacques for pointing out this issue
------------------------------------------------------------------------
jleroux: I fixed 2 small conflicts by hand in AbstractPricatParser and
SamplePricatParser.java
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1848026 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1847530 | jleroux | 2018-11-27 12:27:39 +0100 (mar. 27 nov. 2018) | 12 lignes
Reverted: User should be redirected to view cart page after adding the product
from compare product screen
(OFBIZ-10667)
Revert r1847478
There was a problem with this fix. It changes the behaviour of additem when you
add an item from the main or another page.
The behaviour is defined by the "Always View Cart After Adding An Item."
checkbox in the cart view.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1847531 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1847528 | jleroux | 2018-11-27 12:18:07 +0100 (mar. 27 nov. 2018) | 19 lignes
Fixed: User should be redirected to view cart page after adding the product
from compare product screen
(OFBIZ-10667)
Currently user is navigating add item page instead of view cart page while
adding product to cart from compare product screen. User gets stuck after
navigating over add item page.
Steps to replicate the issue:
1. Go to eCommerce application.
2. Click on add to compare button for the products -
Round Gizmo and Tiny Chrome Widget.
3. Click on 'Compare Products' from right bar.
4. Click on 'Add to cart' over compare product screen.
Expected behaviour : User should be redirected to view cart page instead
of add item page.
Thanks: Ratnesh Upadhyay for report and Ritesh Kumar for the fix
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1847529 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1847398 | jleroux | 2018-11-25 09:40:23 +0100 (dim. 25 nov. 2018) | 15 lignes
Fixed: Instructions for Configurable PC don't work
(OFBIZ-10542)
This concerns only R16, R17 and the trunk. The "Instructions" button was not
present in R13.
This kind of message shows:
Trunk:
<a href="javascript:showErrorAlert('The following errors occurred','');"
R16:
<a href="javascript:showErrorAlert(" the="" following="" errors="" occurred","")
The same exists for all configurable products, notably Gold Pizza
Thanks: Priya Sharma
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1847400 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1847272 | jleroux | 2018-11-23 15:27:05 +0100 (ven. 23 nov. 2018) | 10 lignes
Fixed: Plugins Asciidoc documentation must be standalone
(OFBIZ-10658)
Completes the standalone document part as required by guidelines.
Note that using ":toclevels: 3" does not work when generating with Gradle
because of the OOTB definition "'toclevels': '5'" in build.gradle
It does when used apart in Asciidoc editors. I believe OOTB a 3 levels is enough
and the numbers are superfluous if not unpleasant.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1847274 13f79535-47bb-0310-9956-ffa450edef68
R17 branch
(OFBIZ-10657)
Convert Birt component doc from Markdown to AsciiDoc
(OFBIZ-10647)
As discussed in https://markmail.org/message/x7sv2mpvtytr4vl4 we decided to
backport the Asciidoc documentation, and means to generate it, to R17 branch
This is related with OFBIZ-10651 and OFBIZ-10652 tasks.
So 2 parts are impacted: code in framework and plugins and Buildbot script.
It's only a copy from the trunk to the R17 branch, including *.adoc files,
related images and the build.gradle script.
I previous commit I missed to remove security-impersonation.adoc now replaced
by sy-impersonation.adoc
Forgot to commit the plugins part. Including replacing Birt Markdown
documentation by Asciidoc (OFBIZ-10647)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1847253 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1845558 | jleroux | 2018-11-02 10:46:42 +0100 (ven. 02 nov. 2018) | 15 lignes
Fixed: Correct behaviour of Autologin cookies
(OFBIZ-10635)
Renames "keep-autologin-cookie" to "use-autologin-cookie", and only create
Autologin cookies when needed. No need to create Autologin cookies in
applications that don't need it.
Don't pass webAppName to LoginWorker::getSecuredUserLoginId, that can be handled
with improved LoginWorker::getSecuredLoginIdCookieName
Removes LoginWorker::autoLogoutCleanCookies, no longer needed since only those
needed are created and kept (1 year at least after creation).
For both autoLogin and securedLoginId cookies sets the path to the application.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1845569 13f79535-47bb-0310-9956-ffa450edef68
=======================================================
Fixed: ECommerce landing page breaks if popular category does not exists.
(OFBIZ-10617)
Thanks Rehan for reporting the issue and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1844947 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: Webpos Keyboard Shortcut keys does not work correctly
(OFBIZ-7945)
Updated wrong function calls in switch case of activateHotKeys(). As support for Pin Payment transactions is still to be added under OFBIZ-5241. Commented code for Pin payment transaction and updated other shortcuts accordingly.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1841651 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1838381 | jleroux | 2018-08-19 17:30:42 +0200 (dim. 19 août 2018) | 8 lignes
Fixed: Search in Ecommerce no longer works
(OFBIZ-10531)
I guess that when I worked on OFBIZ-9164 I broke that.
I found 3 occurences where the dispatcher was not in the session because the
session comes from the request and the request has not it in.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1838383 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: Could not find simple-method createWorkEffortSkillStandard as it was called as simple method and it is converted to entity-auto service.
(OFBIZ-10524)
Thanks Fernando Ortega for reporting the issue.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1838250 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1837857 | jleroux | 2018-08-11 12:37:40 +0200 (sam. 11 août 2018) | 10 lignes
Fixed: Update Apache Tomcat to 9.0.10 because of CVE-2018-8037
(OFBIZ-10517)
If an async request was completed by the application at the same time as the
container triggered the async timeout, a race condition existed that could
result in a user seeing a response intended for a different user.
An additional issue was present in the NIO and NIO2 connectors that did not
correctly track the closure of the connection when an async request was
completed by the application and timed out by the container at the same time.
This could also result in a user seeing a response intended for another user.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1837862 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1832800 | jleroux | 2018-06-04 10:34:35 +0200 (lun. 04 juin 2018) | 11 lignes
Fixed: Click on category the filter function doesn't work
(OFBIZ-10423)
Click on the left category, the page doesn't refresh, there are two issues.
productCategoryId not set in
ecommerce/groovyScripts/catalog/AjaxBreadcrumbs.groovy
updated data will fill in #div3, but the div id is missing in
ecommerce/widget/CommonScreens.xml
Thanks: Jason Hao
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1832802 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1832727 | jleroux | 2018-06-02 11:11:22 +0200 (sam. 02 juin 2018) | 6 lignes
Fixed: jquery.jgrowl.min.css url out of date
(OFBIZ-10421)
jleroux: this is only in ecommerce and R16 is not concerned
Thanks: Jason Hao
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1832728 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1828569 | jleroux | 2018-04-06 23:06:48 +0200 (ven., 06 avr. 2018) | 12 lines
Fixed: One Page Checkout page cannot move to Step 5 due to javascript errors
(OFBIZ-10329)
When you click on continue to step 5 you encounter some javascript exception
which makes the checkout process hit the wall.
additional-methods.min.js was missing in ecommerce
Thanks: Sameer Gajanan Apte
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1828570 13f79535-47bb-0310-9956-ffa450edef68
===
Improved: UI improvement on various pages
1) Improvement of various button UI.
2) Improvement in layout at some screens.
3) Alignment issues of some card-header.
Thanks Nitish for your contribution
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1824651 13f79535-47bb-0310-9956-ffa450edef68