(OFBIZ-10937)
Since Java 1.7, when defining generic types it is unnecessary to
redefine those types in the constructor when it is already done in the
declared type.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860025 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-11049)
This problem was similar to what was resolved by r1806237 for OFBIZ-9138.
This fixes it by using the same solution than in r1806237. If the visual theme
is unknown in the the service context get the default theme from
general.properties using ThemeFactory::resolveTheme.
sendPrintFromScreen, createFileFromScreen, sendBirtMail, getXslFo and
printReportPdf (in example) were concerned
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1859735 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-11005)
Thank to Pawan Verma who spotted also ProjectMgrNotesCreateNew and removed it from
NoteInfo.ftl. I also removed ProjectMgrNotesCreateNew from ProjectMgrUiLabels.xml
Thanks: Pawan Verma
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858517 13f79535-47bb-0310-9956-ffa450edef68
called directly.
(OFBIZ-10895)
This error happens in many occasions:
Inside another request (eg LookupProduct)
Of after a request (eg login)
It shows only in log and have no effect on UI. Notably the new feature normally
showing an error message in trunk (OFBIZ-10753) does not shows
It happens in all supported releases. IIRW it always happened, only URLs like
https://demo-trunk.ofbiz.apache.org/images/defaultImage.jpg work.
But here it's different because we don't need to call
https://demo-trunk.ofbiz.apache.org/images by hand to get the issue in log.
So it's not very bad since it's has no side effects, just weird and annoying.
Because it might hide something undetected yet...
This issue does not appear in R15, a good place to test is for instance
ordermgr/control/request.
There cal.gif is called by /images/cal.gif and it works (the images appears)
but in more recent versions the call is also done to
/ordermgr/control/images/cal.gif where it fails.
This 1st appears in ControlFilter in the stack trace.
As said Deepak Dixit:
I think we need to fix the image url in css file, it should start with /images,
else browser append this in request info. There is nothing related to java or
tomcat code.
This is a 1st commit for the errors I already reported and I'm sure about
Thanks: Deepak
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858444 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10725)
I was wondering if we should close. I just had a look and using this regexp:
if \(.*\) \{\R.*return true;
I found
* 60 matches in applications
* 138 in framework
* 4 in plugins
I only checked the 1st two in applications and they really match
While at it this improves 3 of the 4 in plugins (the other is in a loop)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858350 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10967)
Steps to reproduce
1. Login with valid username and password.
2. Navigate to ecommerce.
2.1 Adds product/s to the cart
2.2 Add it/them in a shopping list.
4. Navigate to shopping list section.
5. Click on link “Remove"
Expected Result: Product should be removed from shopping list.
Actual Result: Remove link is not working.
jleroux: OFBIZ-7291 broke it. That can be tested on old demo (R13)
Fixed by using a simple submit field
Thanks: Ashish Sharma for report
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858312 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10849)
1. Navigate to demo-trunk ecom
2. Scroll the page and see the last category section in the right column of the screen.
3. The last category section seems to be distorted because of the empty list Screenshot attached for the same.
The patch contains the following:
- Fixed the category section rendering.
- Improved the markup of survey section of the main page.
- Improved the UI/UX of view cart screen
Thanks Garima jain and Nitish Mishra for your contribution
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858265 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10896)
Currently, we are using code39 to generate barcodes but there are some limitations of code39 as it only able to encrypt letters from A to Z, digits from 0 to 9 and an additional set of special characters – “. $ % + – / *”.
Thanks Pawan Verma for reporting, analysis and providing the patch. Thanks everyone else for providing their inputs during discussion on Dev ML.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858243 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10920)
CVE-2019-0232 Apache Tomcat Remote Code Execution on Windows
Severity: Important
Vendor: The Apache Software Foundation
Versions Affected:
Apache Tomcat 9.0.0.M1 to 9.0.17
Apache Tomcat 8.5.0 to 8.5.39
Apache Tomcat 7.0.0 to 7.0.93
Description:
When running on Windows with enableCmdLineArguments enabled, the CGI
Servlet is vulnerable to Remote Code Execution due to a bug in the way
the JRE passes command line arguments to Windows. The CGI Servlet is
disabled by default. The CGI option enableCmdLineArguments is disabled
by default in Tomcat 9.0.x (and will be disabled by default in all
versions in response to this vulnerability). For a detailed explanation
of the JRE behaviour, see Markus Wulftange's blog [1] and this archived
MSDN blog [2].
Mitigation:
Users of affected versions should apply one of the following mitigations:
- Ensure the CGI Servlet initialisation parameter enableCmdLineArguments
is set to false
- Upgrade to Apache Tomcat 9.0.18 or later when released
- Upgrade to Apache Tomcat 8.5.40 or later when released
- Upgrade to Apache Tomcat 7.0.93 or later when released
This announcement is being made before the releases are available as the
change to fix this issue is obviously security related.
Credit:
This issue was identified by an external security researcher and
reported to the Apache Tomcat security team via the bug bounty program
sponsored by the EU FOSSA-2 project.
jleroux: actually Tomcat 9.0.19 was released, here it is
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1857586 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10882)
This feature has been removed with OFBIZ-10882,
This removes the "Create New Quote" link, the redundant "Save" link (there is a
Save button) and the OrderCreateQuoteFromShoppingList label which was only used
there
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1857173 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10663)
Added mising css and js code to show/hide the amount field based on Product.requireAmount field.
Thanks Dikpal Kanungo for reporting the issue.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1857120 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10886)
Actually we decided that an external user should not be able to create quotes
but only requests for quote.
This disables creating quotes from the ecommerce. An authorised user can still
do the same from the backedn (order manager)
Thanks: Sanjay Yadav for initial report, Sasikant Biswal for trying, Pierre for
mentioning that this should not be open to external users and Pawan Verma for
the fix
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1856917 13f79535-47bb-0310-9956-ffa450edef68
cart link
(OFBIZ-10852)
Login with valid username and password.
Navigate to ecommerce.
Add multiple product in shopping cart.
Select one product and click on remove selected.
Product should be removed.
Select another product and click on recalculate cart.
Expected result: Product should be recalculate.
Actual result: Error message is displayed as 404. Screen print attached
jleroux: I did not see the error message but the fix makes sense anyway
Thanks: Ashish Sharma for report Sasikant Biswal for the fix
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1856802 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10873)
The HTTP/2 implementation accepted streams with excessive numbers of
SETTINGS frames and also permitted clients to keep streams open without
reading/writing request/response data. By keeping streams open for
requests that utilised the Servlet API's blocking I/O, clients were able
to cause server-side threads to block eventually leading to thread
exhaustion and a DoS.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1856212 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10738)
Thanks Arpit Mor for reporting the issue and Praveen Sharma for providing the patch.
It was occuring due to incorrect encoder type used and so URL was not creating properly to render the image.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1855082 13f79535-47bb-0310-9956-ffa450edef68
authentication
(OFBIZ-10307)
Non functional change
Removes now useless "webappName" var after I put in the SecuredUserLoginId
cookies.
Thanks: Michael for spotting it in OFBIZ-10814
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1851885 13f79535-47bb-0310-9956-ffa450edef68