(OFBIZ-9375)
I noticed this error in trunk demo error.log but could not reproduce locally
(Windows)
Jinghai suggested the fix committed, Taher mentioned it should be in plugins
Thanks: Jinghai and Taher
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1795781 13f79535-47bb-0310-9956-ffa450edef68
OFBIZ-8316
Updated Solr from 6.2.1 to 6.5.1 and the point fields generated by Lucene are ok now for Solr component.
The 'original UI' link is commented in admin.html and the relative files under solr/webapp/solr/tpl are all removed.
Thanks: Cao Pengan for the patch and Jacques, Michael for the comments and reviews.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1794771 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-7265)
In my last commit (r1792257) I did not use the right location.
It's now in runtime\indexes\solr which is the obviously right place in OFBiz!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1794132 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-7265)
Problem:
I found this message in error.log
xer_default_products
DocumentIndexer
E
Could not obtain Lock on lucene index Lock held by this virtual machine:
C:\projectASF-Mars\ofbiz\runtime\indexes\products\write.lock
Investigation:
I am able to reproduce this on my dev machine.
Here is the steps to regenerate it:
1. Go to https://localhost:8443/content/control/AdminIndex
2. Click on Index Products button.
Solution:
As per my analysis, the reason of error is write lock on lucene indexes
(created by lucene indexing process in lucene component) by Solr.
Have a look on specialpurpose/solr/home/solrdefault/conf/solrconfig.xml line:
<dataDir>${solr.data.dir:runtime/indexes}</dataDir>
Should point to:
<dataDir>${solr.data.dir:specialpurpose/solr/home/solrdefault/runtime/indexes/}
</dataDir>
Solr currently pointing to lucene indexes and creating a lock on it.
We can't index products anymore using lucene indexing as it has lock from Solr.
So currently all the search results we can see on Solr Search
https://localhost:8443/solr/#/solrdefault/query
is lucene indexed results.
We have not created any indexes using Solr itself. Thanks
Thanks: Amardeep Singh Jhajj who did all the work
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791625 13f79535-47bb-0310-9956-ffa450edef68
completes r1781219 by putting svn:eol-style=native to all file types declared
in [auto-props] section of the svn config files.css
Actually this is only a 1st pass, it was too complicated to do it for
all file types at once only concerned here
*.java;*.bsh;*.groovy;*.jsp;*.tld;*.ftl;*.js;*.sql;*.c;*.cpp;*.h;*.txt;*.sgml;
*.properties;*.xml;.classpath;.project;*.sld;*.gml;*.xsl;*.xsd
*.html;*.htm;*.css;*.md;README;NOTICE;LICENSE;rc.ofbiz.*;*.less;*.dsp;*.dsw
Most files should not be concerned by this change, but it's impossible to do
it one by one.
There are also changes in files with have mixed EOLs; because this has no sense
when using native which automatically resolves this issue
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781731 13f79535-47bb-0310-9956-ffa450edef68
At http://markmail.org/message/ffmyw773p65fndey I wrote:
I'd like to follow the suggestion I made in the last message of the linked
thread.
In other words, use
http://subversion.apache.org/docs/release-notes/1.8.html#repos-dictated-confighttp://blogs.collab.net/subversion/the-road-to-repository-dictated-configuration-day-2-autoprops
Then this problem would be over. No longer need to check from time to time that
concerned files, have svn:eol-style=native property set
This imply that all OFBiz users use svn > 1.7, but we can inform them, et voilà
Then at markmail.org/message/h3q2yvj4db544ro7 I wrote:
Actually, since we get new committers now and then and their are able to create
new files I have a warning every 6 months which says "Check Java
files, have all svn:eol-style=native" (I totally forgot that because I assume
the machine knows it and warns me ;))
I could extend that to all files (at least the most prominent types), I'll
see...
This does what the last sentence said for Groovy, XML and few new Birt
Java files.
I'll see if I can implement the svn 1.8 repos-dictated-config ASAP!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781219 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8316)
Change LongPoint and DoublePoint fields to String field to make solr work in trunk version, and I'll change them back when updating to new release of Solr.
Thanks: Jacques Le Roux for reporting the point fields problem.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1780133 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8909)(OFBIZ-8910)(OFBIZ-8911)(OFBIZ-8912)(OFBIZ-8913)(OFBIZ-8914)(OFBIZ-8915)(OFBIZ-8917)(OFBIZ-8918)(OFBIZ-8919)(OFBIZ-8920)(OFBIZ-8921)(OFBIZ-8922)
Thanks: Divesh Dutta for reporting and Amit Gaadaley for providing patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1768168 13f79535-47bb-0310-9956-ffa450edef68
new ControlFilter, from the ContextFilter; modified existing applications to use
the two filters in a chain; removed from the other specialized filters all the
logic that was duplicated or extended from ContextFilter.
A web application, in order to leverage the OFBiz framework, requires that a
series of objects are in its contexts (servlet context, session and request)
such as "delegator", "delegatorName", "dispatcher", "security" etc. etc...
This setup is performed by the logic contained in the servlet filter implemented
by the ContextFilter class.
The execution of this logic is required for the application to run properly.
However, before this commit, in the ContextFilter there was other logic, related
to access control and redirection rules (some of them performed in coordination
with the ControlServlet), making it difficult to deploy this filter in all the
web applications, especially the ones that implement special handling of paths.
In fact, this filter was deployed in most but not all the web application in the
OFBiz codebase: specifically it was not deployed in web applications that
require the execution of other filters (e.g. CatalogUrlFilter, etc...) like the
ones in the "ecommerce" and "solr" components.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761304 13f79535-47bb-0310-9956-ffa450edef68
After commit, please rename readme files of components
manufacturing
assetmaint
birt
ecommerce
lucene
myportal
passport
projectmgr
scrum
solr
jleroux: Due to content I guess Pierre meant to add the .md suffix
I have also removed the useless ASL2 header of example/lib/README file
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1758702 13f79535-47bb-0310-9956-ffa450edef68
Notes:
* Also removes empty framework/base/lib/scripting and useless applications\content\lib\uno\README (miss doc in wiki)
* When jpim-0.1.jar will be (hopefully) replaced we can drop lib ref in framework/base/ofbiz-component.xml
* I wonder if we should let the geronimo component alone with only 2 classes, could we not put that in entity or entityext?
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1755306 13f79535-47bb-0310-9956-ffa450edef68
It is not needed to declare all the dependencies explicitly becuase
all of them are automatically downloaded with the package:
'org.apache.solr:solr-core:5.3.1'
Hence, this makes the build script much shorter and cleaner
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1753887 13f79535-47bb-0310-9956-ffa450edef68
This is the first of two steps in the above mentioned JIRA. This
first step changes the java source directory for every component
from /src to /src/main/java. The next step will be adding unit
tests to every component in /src/test/java
Thank you to Deepak Dixit for tips on how to use the SVN commands
to make the appropriate file moving.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752838 13f79535-47bb-0310-9956-ffa450edef68
This is the first patch that takes OFBiz to the point of no return
in terms of switching from Ant to Gradle build system. Specifically
this patch applies the following items:
- Delete all old Ant and Maven build scripts
- Delete 169 Jar libraries and replace them with remote ones in the
gradle build script
- update the gradle build scripts for the dependencies and other minor
changes needed for the script work correctly
All tests pass with the command ./gradlew cleanAll loadDefault testIntegration
Again, thank you for everyone who contributed valueble time and effort in this
process.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752033 13f79535-47bb-0310-9956-ffa450edef68
(resource == null || resource.length() <= 0)
From Java spec. a String, Collection, Map or CharSequence can't have a negative length, so the pattern above can be reduced to
(resource == null || resource.length() == 0)
which can be replaced using
UtilValidate.isEmpty()
I checked, there are several other occurrences of this pattern (some very old, I guess most were routinely copied from an initial occurrence). I decided to replace all of them, here they are.
I did that already long ago for the
(resource == null || resource.length() == 0)
pattern. It remains 4 of them. Three are justified (because of the dependency on base component or because using isEmpty() on Object is disputable for performance reasons). I took care of the remaining one right aways (in SplashScreen.java)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1747976 13f79535-47bb-0310-9956-ffa450edef68
Adding widgest (screens, forms, etc) so that an end-user can execute a search against the data indexed would enhance the applicability of the application.
This patch is the first increment to address the issue. Please feel free to test drive and provide feedback
Currently it includes the following aspects:
SolrMenus.xml - providing the application menu, items:
main - opening the start screen of the app
admin - opening the Solr admin page in a new target
newquery - opening the query screen
SolrScreens.xml - defining Solr specific screen widgets
CommonScreens.xml - defining the common screens for Solr specific screen widgets
SolrUiLabels.xml - defining Solr app specific labels
SolrForms.xml - defining Solr specific form widgets
controller.xml - (re)defining request-map and view-map re widgets
This file also includes a modification to web.xml of the Solr component, changing the mainDecoratorLocation
This patch currently doesn't include functionality to execute a query through widgets and show the result.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1736878 13f79535-47bb-0310-9956-ffa450edef68
Changes are:
1. Comment out solr eecas.xml as it's duplicated to ecas in eecas_product.xml.
2. Add default-value="solrdefault" to indexName of addToSolr service.
3. Replace some tabs with spaces.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1730790 13f79535-47bb-0310-9956-ffa450edef68
================================
There are three sets of dimensions in the Product entity.
(productHeight, shippingHeight), (productWidth, shippingWidth), (productDepth, shippingDepth) but in case of weight, there is another set of dimension field weight and productWeight which are inconsistent in nature.
Fix this thing and correct all instances of this in the framework.
=================================
Thanks Suraj for reporting the issue and providing the patch for the same. Thanks Jacopo and Pierre for discussing the issue with Suraj.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1720900 13f79535-47bb-0310-9956-ffa450edef68