Commit Graph
3703 Commits
Author SHA1 Message Date
Jacques Le Roux 32e7ea5781 No functional change, completes r179986 which was framework only, this is for
plugins
================================================================================
While checking there were no other cases like in OFBIZ-9432 
(missing path to class), to be consistent I removed the trailing semicolons in 
groovy scripts and made few formatting

================================================================================

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1800450 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 18:50:22 +00:00
Michael Brohl ba62e11375 Fixed: Lucene tests fail due to problems in the test data.
(OFBIZ-9439)

The data is missing some content associations and the test code is not 
reflecting the new data, will fix this. This completes r1800322.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1800376 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 11:56:05 +00:00
Michael Brohl 5d12bb3a88 Fixed: Lucene tests fail due to problems in the test data.
(OFBIZ-9439)

The Lucene test data references to the ownerContentId "CNTGIZMOS" which is not 
defined in the lucene demo data. It was instead defined in the ecommerce demo 
data in the file DemoWebsitePublishPointData.xml. The data is rewritten so that
it is usable for Lucene and does not interfere with other data.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1800322 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 21:22:19 +00:00
Jacques Le Roux c4191565d9 Fixed: Error running the simple-method: Error running groovy script
(OFBIZ-9432)

Steps to reproduce the error:
Add producs to cart (i.e. 2 x RoundGizmo) 
-> [Quick Checkout] 
-> Checkout Without Login: Quick Checkout 
-> Basic Information: fill in required fields 
-> Continue 

Error: unable to resolve class CartItemModifyException

jleroux: Groovy needs the complete path to CartItemModifyException
Found the same in CustomerEvents.xml

Thanks: Daniel Coric for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1799860 13f79535-47bb-0310-9956-ffa450edef68
2017-06-26 08:21:34 +00:00
Jacques Le Roux c3107bff70 Fixed: Error running the simple-method: Error running groovy script
(OFBIZ-9432)

Steps to reproduce the error:
Add producs to cart (i.e. 2 x RoundGizmo) 
-> [Quick Checkout] 
-> Checkout Without Login: Quick Checkout 
-> Basic Information: fill in required fields 
-> Continue 

Error: unable to resolve class CartItemModifyException

jleroux: Groovy needs the complete path to CartItemModifyException
There are 2 cases, I have also removed the trailing semicolons

Thanks: Daniel Coric for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1799859 13f79535-47bb-0310-9956-ffa450edef68
2017-06-26 08:15:35 +00:00
Taher A. Alkhateeb 5bdc75e434 Implemented: removed unnecessary classpath entry from cmssite component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1799778 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 19:46:05 +00:00
Jacques Le Roux c000e5a58d Fixed: Birt plugin depends on example plugin
(OFBIZ-9383)

The BIRT demo data for flexible reports depends on the Example entity from the 
Example plugin.
We should either provide BIRT's own example data with example reports OR 
setup a gradle dependency on the example plugin so that everything is in place.

jleroux: I did not like to duplicate the example data in birt or an alike 
solution.
So I put a gradle dependency on the example plugin. 
If the example plugin misses the birt component can't build. 
I put some comments to explain the possible issue and its solution out of 
demonstration.

Thanks: Michael Brohl for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1799699 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 20:07:47 +00:00
Jacques Le Roux c47f662d38 Fixed: Wiki restructure issues
(OFBIZ-9416)

Replaces a bunch of deprecated links or shortcuts

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1799698 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 19:57:35 +00:00
Shi Jinghai 59ffe3250d Fixed: Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, OAuth2LinkedIn and LinkedInUser entities.
(OFBIZ-9390)

Thanks Renuka Srishti for the report and patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1798029 13f79535-47bb-0310-9956-ffa450edef68
2017-06-08 07:19:38 +00:00
Jacques Le Roux c1f51f2b54 Improved: performFindResults.listIt closed but not in case of exception in 3
Scrum Groovy files
(OFBIZ-9389)

This is an improvement only because no cases were reported. But obviously in 
case of unlucky exception after the call to the performFind service, and before 
it's closed, the EntityListIterator remains in memory.

The solution is to use a try-catch-finally block because Groovy has not 
try-with-ressources.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1797788 13f79535-47bb-0310-9956-ffa450edef68
2017-06-06 13:59:29 +00:00
Jacques Le Roux e44ec8d53d Improved: EntityListIterator closed but not in case of exception
(OFBIZ-9385)

This is an improvement only because no cases were reported. But obviously in 
case of unlucky exception after the EntityListIterator creation and before it's 
closed the EntityListIterator remains in memory. 
It should be closed in EntityListIterator.finalize() but the less happens there 
the better.

The solution is to use try-with-ressources

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1797073 13f79535-47bb-0310-9956-ffa450edef68
2017-05-31 17:04:40 +00:00
Michael Brohl 76ff3a8fe2 Fixed: Corrected the url to the birt component issues page
(it had a line break and was not displayed correctly in the Markdown Viewer)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1797030 13f79535-47bb-0310-9956-ffa450edef68
2017-05-31 12:58:02 +00:00
Deepak Dixit f7eb59f52d Fixed: After the implementation of new servlet filter for controller related logic, the multisite feature was not working properly due to URL modification. This control filter can not be applied to cmssite because that web application is intended to use dynamically publish URL. So we can remove the control filter from web.xml of cmssite.
Thanks Jacopo Cappellato for discussing the possible solution on this issue. (OFBIZ-7120)
  
 Thanks Mohammed Rehan Khan for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1796382 13f79535-47bb-0310-9956-ffa450edef68
2017-05-27 11:42:27 +00:00
Deepak Dixit c1f0182890 Improved: Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne"
with "id", "id-long" and "id-vlong" respectively which are primary keys for plugin components.
(OFBIZ-9351)
Thanks Aditya Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1796380 13f79535-47bb-0310-9956-ffa450edef68
2017-05-27 11:32:18 +00:00
Deepak Dixit a67c08620e Improved: Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne"
with "id", "id-long" and "id-vlong" respectively which are primary keys
(OFBIZ-9351)
Thanks Aditya Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1796379 13f79535-47bb-0310-9956-ffa450edef68
2017-05-27 11:28:36 +00:00
Jacques Le Roux 62abbeffeb Improved: Missing Java Option solr.log.dir. Logging may be missing or incomplete
(OFBIZ-9375)

I noticed this error in trunk demo error.log but could not reproduce locally
(Windows)

Jinghai suggested the fix committed, Taher mentioned it should be in plugins


Thanks: Jinghai and Taher

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1795781 13f79535-47bb-0310-9956-ffa450edef68
2017-05-22 09:18:25 +00:00
Deepak Dixit 18894e6dc0 Improved: Inconsistent String Comparisons, Applied plugins groovy patch from jira issue. (OFBIZ-9254)
I found an inconsistency in the code for string comparison statusId.equals("PRUN_COMPLETED") whereas it should be written as "PRUN_COMPLETED".equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.

Thanks Devanshu Vyas for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1795344 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 17:36:32 +00:00
Jacques Le Roux 91fb6d5f4d No functional changes.
Fixes a comment and formats Java code

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1794974 13f79535-47bb-0310-9956-ffa450edef68
2017-05-12 13:09:35 +00:00
Jacques Le Roux 9c6f278eb0 Fixed: Pub back the Birt order reports
(OFBIZ-9359)

I just spotted that the OrderPortletData.xml seed data have been wrongly removed
 with r1780683 for OFBIZ-6919. This fixes it.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1794957 13f79535-47bb-0310-9956-ffa450edef68
2017-05-12 11:41:41 +00:00
Jacques Le Roux f93941fd5c Improved: Rename Lucene runtime folders to clearly show the origin
(OFBIZ-9357)

Sets the Lucene defaultIndex to runtime/indexes/lucene

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1794937 13f79535-47bb-0310-9956-ffa450edef68
2017-05-12 07:15:59 +00:00
Jacques Le Roux 9101f5b118 No functional change
Forgot to push this file

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1794929 13f79535-47bb-0310-9956-ffa450edef68
2017-05-12 06:56:27 +00:00
Shi Jinghai 82f48257f9 Improved: Update Apache Solr/Lucene to release 6.2.1
OFBIZ-8316

Removed several comments of this issue in ProductDocument.java.

Thanks: Jacques for the comments and reviews.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1794801 13f79535-47bb-0310-9956-ffa450edef68
2017-05-11 09:35:19 +00:00
Shi Jinghai 1192f858e0 Fixed: Update Apache Solr/Lucene to release 6.2.1
OFBIZ-8316

Updated Solr from 6.2.1 to 6.5.1 and the point fields generated by Lucene are ok now for Solr component.
The 'original UI' link is commented in admin.html and the relative files under solr/webapp/solr/tpl are all removed. 

Thanks: Cao Pengan for the patch and Jacques, Michael for the comments and reviews.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1794771 13f79535-47bb-0310-9956-ffa450edef68
2017-05-11 00:10:12 +00:00
Shi Jinghai 37d7c585fc Fixed: Update Apache Solr/Lucene to release 6.2.1
OFBIZ-8316

Updated Lucene from 6.2.1 to 6.5.1 and the point fields generated by Lucene are ok now for Solr component.

Thanks: Cao Pengan for the patch and Jacques, Michael for the comments and reviews.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1794770 13f79535-47bb-0310-9956-ffa450edef68
2017-05-10 23:58:31 +00:00
Jacques Le Roux 232bf736f3 Fixed: Could not obtain Lock on lucene index Lock
(OFBIZ-7265)

In my last commit (r1792257) I did not use the right location.
It's now in runtime\indexes\solr which is the obviously right place in OFBiz!

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1794132 13f79535-47bb-0310-9956-ffa450edef68
2017-05-06 10:53:37 +00:00
Taher A. Alkhateeb ac3b7c14da Fixed: Remove all dependencies from OFBiz framework to plugins
(OFBIZ-9322)
   
This is related to commit r1793170 from ofbiz-trunk where data is moved from
ecommerce to accounting and party components.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1793171 13f79535-47bb-0310-9956-ffa450edef68
2017-04-29 07:09:20 +00:00
Jacques Le Roux 2558dabc92 No functional changes:
Fixes a label
Adds an error label
Uses the error label
Adds the word service in not yet labelised error msg


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1792899 13f79535-47bb-0310-9956-ffa450edef68
2017-04-27 14:06:30 +00:00
Taher A. Alkhateeb bdea0f6740 Implemented: Remove dependencies from OFBiz framework to plugins
(OFBIZ-9322)

This is related to a commit in ofbiz-framework r1792866 in which data 
that is removed in here is added to the framework. There is one modification
to the DemoPurchasing.xml file in which we added a UserLoginSecurityGroup which
is moved from DemoOrderPeopleData.xml because it has dependencies on security
data in ecommerce. Other than that, all data is simply deleted.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1792867 13f79535-47bb-0310-9956-ffa450edef68
2017-04-27 11:40:59 +00:00
Jacques Le Roux bd45c34532 Fixed: Remove the birt.tld file and all related files and lines
(OFBIZ-OFBIZ-9323)

As explained in the Jira, for legal reasons we need to remove the Birt Web 
Viewer from OFBiz



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1792432 13f79535-47bb-0310-9956-ffa450edef68
2017-04-24 07:51:47 +00:00
Jacques Le Roux 17587f85ff Fixed: Could not obtain Lock on lucene index Lock
(OFBIZ-7265)

No functional change, the path should start at home

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1792257 13f79535-47bb-0310-9956-ffa450edef68
2017-04-22 05:06:46 +00:00
Jacques Le Roux e83ec3b8d4 Fixed: Could not obtain Lock on lucene index Lock
(OFBIZ-7265)

Problem:
I found this message in error.log
xer_default_products 	
DocumentIndexer 	
E 	
Could not obtain Lock on lucene index Lock held by this virtual machine: 
C:\projectASF-Mars\ofbiz\runtime\indexes\products\write.lock

Investigation:
I am able to reproduce this on my dev machine. 
Here is the steps to regenerate it:

1. Go to https://localhost:8443/content/control/AdminIndex
2. Click on Index Products button.

Solution:
As per my analysis, the reason of error is write lock on lucene indexes 
(created by lucene indexing process in lucene component) by Solr. 
Have a look on specialpurpose/solr/home/solrdefault/conf/solrconfig.xml line:
 <dataDir>${solr.data.dir:runtime/indexes}</dataDir>
Should point to:
 <dataDir>${solr.data.dir:specialpurpose/solr/home/solrdefault/runtime/indexes/}
 </dataDir>

Solr currently pointing to lucene indexes and creating a lock on it. 
We can't index products anymore using lucene indexing as it has lock from Solr.
So currently all the search results we can see on Solr Search
https://localhost:8443/solr/#/solrdefault/query 
is lucene indexed results.
We have not created any indexes using Solr itself. Thanks


Thanks: Amardeep Singh Jhajj who did all the work

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791625 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 19:44:50 +00:00
Jacques Le Roux f0b890ce60 No functional change, removes empty useless lines
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791575 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 07:32:40 +00:00
Jacques Le Roux b3485c4520 No functional change, only removes trailing blanks
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791574 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 07:31:50 +00:00
Jacques Le Roux 481b890ed6 Improved: My Portal: Align column titles in list forms
(OFBIZ-8486)

Thanks: Aditi Patidar

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791468 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 08:14:43 +00:00
Jacques Le Roux 58f0a1ed2a No functional change, same than r1788752
I decided to sort the flexible report export formats on the enumCode 
(ie alphabetically) rather than using sequenceId which did not make much sense



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791406 13f79535-47bb-0310-9956-ffa450edef68
2017-04-14 20:20:34 +00:00
Jacques Le Roux b559be73bc No functional change, svn:ignore birt/lib/scriptlib
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791340 13f79535-47bb-0310-9956-ffa450edef68
2017-04-14 10:32:55 +00:00
Jacques Le Roux 9feab50685 No functional change, forgot to update the label here when changing the date
in bi.properties from 2023 to 2026. But I no longer see the Birt reports on this
 page, looking at that...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791329 13f79535-47bb-0310-9956-ffa450edef68
2017-04-14 08:41:06 +00:00
Jacques Le Roux 33fd94b143 No functional changes, removes useless forgotten empty actions directories
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791275 13f79535-47bb-0310-9956-ffa450edef68
2017-04-13 16:35:32 +00:00
Jacques Le Roux d215d06b9b No functional change, svn:ignore desktop.ini (I use it to easily find a folder)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791141 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 16:34:45 +00:00
Jacques Le Roux 4e9ddccde9 Fixed: The help button or link does not show for the Birt, BI and example
components
(OFBIZ-9311)

Pricat was also concerned. Unlike hhfacility, I see no reasons why these 
components would use the GlobalDecorator instead of the ApplicationDecorator
(the ApplicationDecorator embeds the GlobalDecorator)

OFBIZ-9312 is a duplicate of this


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791116 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 12:58:38 +00:00
Jacques Le Roux 1bf24662a1 Documented: Complete Birt Flexible Reports documentation
(OFBIZ-9188)

Replaces hardcoded strings in main Birt screen with labels


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791111 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 11:35:24 +00:00
Jacques Le Roux 96dfd1b455 No functional change (demo only), time is passing...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790934 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 07:41:43 +00:00
Jacques Le Roux 81f93c5f78 Fixed: CMS shows error screen on Product Search
(OFBIZ-9308)

Steps to regenerate:
1. Go to Content component 
    https://localhost:8443/content/control/main
2. Click on CMS tab directing to 
    https://localhost:8443/content/control/CMSContentFind
3. Click on Search Products subtab directing to 
    https://localhost:8443/content/control/ProductSearch
4. Provide a Lucene Query and Click submit.
5. Screen renders with ScreenRenderingException

Problem:
1. "ProductSearch" request directs to "ProductSearch" screen in 
    LuceneScreens.xml.
2. On ProductSearch screen, "SearchProducts.groovy" script prepares and hits a 
    search query to Lucene.
3. "BooleanQuery" class is used to match documents with other boolean query 
    combinations.
4. BooleanQuery object is initialised with Its default constructor.
5. With Lucene 5.4.0, this constructor is deprecated.
OFBiz migrated to Lucene 6.3.1: OFBIZ-8316

Solution:
From Lucene 5.4.0 default constructor is deprecated and a new inner class 
Builder is created for queries.

Refer OFBIZ-9301 for detailed explanation.

Thanks: Aditya

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790933 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 07:34:15 +00:00
Jacques Le Roux 6fd8a8fac2 Fixed: Ecommerce component showing error screen on searchContent from
showcontenttree page
(OFBIZ-9309)

Steps to reproduce:
1.Go to Ecommerce component https://localhost:8443/ecommerce/control/main
2.Click on any of the Content from "Browse Content" section of left panel. 
  It will be directed to https://localhost:8443/ecommerce/control/showcontenttree?contentId=STORE_POLICIES&nodeTrailCsv=STORE_POLICIES
3. Click on Search, it directs to https://localhost:8443/ecommerce/control/searchContent?siteId=STORE_POLICIES
4. Screen renders with ScreenRenderingException

Problem:
1. "searchContent" request directs to "searchContent" screen in 
  ContentScreens.xml.
2. On searchContent screen, "/ecommerce/groovyScripts/content/Search.groovy" 
  script prepares and hits a search query to Lucene.
3. "BooleanQuery" class is used to match documents with other boolean query 
  combinations.
4. BooleanQuery object is initialised with Its default constructor.
5. With Lucene 5.4.0, this constructor is deprecated.
OFBiz migrated to Lucene 6.3.1: OFBIZ-8316

Solution:
From Lucene 5.4.0 default constructor is deprecated and a new inner class 
  Builder is created for queries. Refer OFBIZ-9301 for detailed explanation.

Thanks: Aditya

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790810 13f79535-47bb-0310-9956-ffa450edef68
2017-04-10 12:05:36 +00:00
Jacques Le Roux befd697f99 Fixed: CMS shows error screen on clicking Find button
(OFBIZ-9301)

Steps to regenerate :
1. Log in to Content component
2. Go to the CMS tab or directly go to  
	https://localhost:8443/content/control/CMSContentFind
3. Click on "Find" submenu or directly go to 
	https://localhost:8443/content/control/AdminSearch
4. Screen renders with ScreenRenderingException

Problem:
1. "AdminSearch" request directs to "AdminSearch" screen in LuceneScreens.xml.
2. On AdminSearch screen, "Search.groovy" script prepares and hits a search 
	query to Lucene.
3. "BooleanQuery" class is used to match documents with other boolean query 
	combinations.
4. BooleanQuery object is initialised with Its default constructor.
5. With Lucene 5.4.0, this constructor is deprecated.
	OFBiz migrated to Lucene 6.3.1: OFBIZ-8316

Solution:
From Lucene 5.4.0 default constructor is deprecated and a new inner class 
Builder is created for queries.

jleroux: I sorted the imports by hand, and added missing parenthesis at .build

Thanks: Aditya 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790664 13f79535-47bb-0310-9956-ffa450edef68
2017-04-08 08:26:19 +00:00
Jacques Le Roux 78bd8621a4 No functional changes.
BirtServices.java
    Formatting
    Few better comments and some TODOs
    Replaces e.printStackTrace() by Debug.logError(). 
    Adds few missing Debug.logError()
    Adds return ServiceUtil.returnError() 
    Improves an EntityListIterator closing not done, using try-with-ressources
        Not a funct. change, EntityListIterator.finalyse() catches anyway
    Replaces return ServiceUtil.returnError(e.getMessage()) by more explicit 
        messages. Not needs to clutter the UI.
    Uses multi-catches when applicable
    
BirtUtil.java
    Formatting
    Note: the Birt.properties file does not exist OOTB but can be added for 
        convenience, like using the location where you edit with the 
        Birt Report Designer...

ReportDesignGenerator.java
    Formatting
    Removes useless and confusing try and re-thrown exceptions. This allows to 
    fix possible other issues


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790547 13f79535-47bb-0310-9956-ffa450edef68
2017-04-07 13:21:50 +00:00
Jacques Le Roux 901c3418b4 No functional change, clarifies access to "OFBiz Flexible Reports"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790538 13f79535-47bb-0310-9956-ffa450edef68
2017-04-07 11:52:16 +00:00
Jacques Le Roux a078b4bcc5 No functional change
Improves help on top of Birt main screen. 
Includes a link to the "OFBiz Flexible Reports" documentation in wiki

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790537 13f79535-47bb-0310-9956-ffa450edef68
2017-04-07 11:50:08 +00:00
Jacques Le Roux ddce8416ac No functional change, removes commented out useless lines
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790518 13f79535-47bb-0310-9956-ffa450edef68
2017-04-07 08:23:47 +00:00
Jacques Le Roux b839e1dc63 Fixed: Implement and demonstrate few services in Birt Report Builder
(OFBIZ-9192)

This fixes an issue I put in while removing partyName. 
The couple ("Customer", "Customer name") should also have been removed

While at it I formatted to make things more legible

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790501 13f79535-47bb-0310-9956-ffa450edef68
2017-04-07 04:49:50 +00:00