plugins
================================================================================
While checking there were no other cases like in OFBIZ-9432
(missing path to class), to be consistent I removed the trailing semicolons in
groovy scripts and made few formatting
================================================================================
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1800450 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9439)
The data is missing some content associations and the test code is not
reflecting the new data, will fix this. This completes r1800322.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1800376 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9439)
The Lucene test data references to the ownerContentId "CNTGIZMOS" which is not
defined in the lucene demo data. It was instead defined in the ecommerce demo
data in the file DemoWebsitePublishPointData.xml. The data is rewritten so that
it is usable for Lucene and does not interfere with other data.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1800322 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9432)
Steps to reproduce the error:
Add producs to cart (i.e. 2 x RoundGizmo)
-> [Quick Checkout]
-> Checkout Without Login: Quick Checkout
-> Basic Information: fill in required fields
-> Continue
Error: unable to resolve class CartItemModifyException
jleroux: Groovy needs the complete path to CartItemModifyException
Found the same in CustomerEvents.xml
Thanks: Daniel Coric for report
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1799860 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9432)
Steps to reproduce the error:
Add producs to cart (i.e. 2 x RoundGizmo)
-> [Quick Checkout]
-> Checkout Without Login: Quick Checkout
-> Basic Information: fill in required fields
-> Continue
Error: unable to resolve class CartItemModifyException
jleroux: Groovy needs the complete path to CartItemModifyException
There are 2 cases, I have also removed the trailing semicolons
Thanks: Daniel Coric for report
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1799859 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9383)
The BIRT demo data for flexible reports depends on the Example entity from the
Example plugin.
We should either provide BIRT's own example data with example reports OR
setup a gradle dependency on the example plugin so that everything is in place.
jleroux: I did not like to duplicate the example data in birt or an alike
solution.
So I put a gradle dependency on the example plugin.
If the example plugin misses the birt component can't build.
I put some comments to explain the possible issue and its solution out of
demonstration.
Thanks: Michael Brohl for report
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1799699 13f79535-47bb-0310-9956-ffa450edef68
Scrum Groovy files
(OFBIZ-9389)
This is an improvement only because no cases were reported. But obviously in
case of unlucky exception after the call to the performFind service, and before
it's closed, the EntityListIterator remains in memory.
The solution is to use a try-catch-finally block because Groovy has not
try-with-ressources.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1797788 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9385)
This is an improvement only because no cases were reported. But obviously in
case of unlucky exception after the EntityListIterator creation and before it's
closed the EntityListIterator remains in memory.
It should be closed in EntityListIterator.finalize() but the less happens there
the better.
The solution is to use try-with-ressources
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1797073 13f79535-47bb-0310-9956-ffa450edef68
with "id", "id-long" and "id-vlong" respectively which are primary keys for plugin components.
(OFBIZ-9351)
Thanks Aditya Sharma for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1796380 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9375)
I noticed this error in trunk demo error.log but could not reproduce locally
(Windows)
Jinghai suggested the fix committed, Taher mentioned it should be in plugins
Thanks: Jinghai and Taher
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1795781 13f79535-47bb-0310-9956-ffa450edef68
I found an inconsistency in the code for string comparison statusId.equals("PRUN_COMPLETED") whereas it should be written as "PRUN_COMPLETED".equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.
Thanks Devanshu Vyas for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1795344 13f79535-47bb-0310-9956-ffa450edef68
OFBIZ-8316
Updated Solr from 6.2.1 to 6.5.1 and the point fields generated by Lucene are ok now for Solr component.
The 'original UI' link is commented in admin.html and the relative files under solr/webapp/solr/tpl are all removed.
Thanks: Cao Pengan for the patch and Jacques, Michael for the comments and reviews.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1794771 13f79535-47bb-0310-9956-ffa450edef68
OFBIZ-8316
Updated Lucene from 6.2.1 to 6.5.1 and the point fields generated by Lucene are ok now for Solr component.
Thanks: Cao Pengan for the patch and Jacques, Michael for the comments and reviews.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1794770 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-7265)
In my last commit (r1792257) I did not use the right location.
It's now in runtime\indexes\solr which is the obviously right place in OFBiz!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1794132 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9322)
This is related to a commit in ofbiz-framework r1792866 in which data
that is removed in here is added to the framework. There is one modification
to the DemoPurchasing.xml file in which we added a UserLoginSecurityGroup which
is moved from DemoOrderPeopleData.xml because it has dependencies on security
data in ecommerce. Other than that, all data is simply deleted.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1792867 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-7265)
Problem:
I found this message in error.log
xer_default_products
DocumentIndexer
E
Could not obtain Lock on lucene index Lock held by this virtual machine:
C:\projectASF-Mars\ofbiz\runtime\indexes\products\write.lock
Investigation:
I am able to reproduce this on my dev machine.
Here is the steps to regenerate it:
1. Go to https://localhost:8443/content/control/AdminIndex
2. Click on Index Products button.
Solution:
As per my analysis, the reason of error is write lock on lucene indexes
(created by lucene indexing process in lucene component) by Solr.
Have a look on specialpurpose/solr/home/solrdefault/conf/solrconfig.xml line:
<dataDir>${solr.data.dir:runtime/indexes}</dataDir>
Should point to:
<dataDir>${solr.data.dir:specialpurpose/solr/home/solrdefault/runtime/indexes/}
</dataDir>
Solr currently pointing to lucene indexes and creating a lock on it.
We can't index products anymore using lucene indexing as it has lock from Solr.
So currently all the search results we can see on Solr Search
https://localhost:8443/solr/#/solrdefault/query
is lucene indexed results.
We have not created any indexes using Solr itself. Thanks
Thanks: Amardeep Singh Jhajj who did all the work
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791625 13f79535-47bb-0310-9956-ffa450edef68
components
(OFBIZ-9311)
Pricat was also concerned. Unlike hhfacility, I see no reasons why these
components would use the GlobalDecorator instead of the ApplicationDecorator
(the ApplicationDecorator embeds the GlobalDecorator)
OFBIZ-9312 is a duplicate of this
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791116 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9308)
Steps to regenerate:
1. Go to Content component
https://localhost:8443/content/control/main
2. Click on CMS tab directing to
https://localhost:8443/content/control/CMSContentFind
3. Click on Search Products subtab directing to
https://localhost:8443/content/control/ProductSearch
4. Provide a Lucene Query and Click submit.
5. Screen renders with ScreenRenderingException
Problem:
1. "ProductSearch" request directs to "ProductSearch" screen in
LuceneScreens.xml.
2. On ProductSearch screen, "SearchProducts.groovy" script prepares and hits a
search query to Lucene.
3. "BooleanQuery" class is used to match documents with other boolean query
combinations.
4. BooleanQuery object is initialised with Its default constructor.
5. With Lucene 5.4.0, this constructor is deprecated.
OFBiz migrated to Lucene 6.3.1: OFBIZ-8316
Solution:
From Lucene 5.4.0 default constructor is deprecated and a new inner class
Builder is created for queries.
Refer OFBIZ-9301 for detailed explanation.
Thanks: Aditya
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790933 13f79535-47bb-0310-9956-ffa450edef68
showcontenttree page
(OFBIZ-9309)
Steps to reproduce:
1.Go to Ecommerce component https://localhost:8443/ecommerce/control/main
2.Click on any of the Content from "Browse Content" section of left panel.
It will be directed to https://localhost:8443/ecommerce/control/showcontenttree?contentId=STORE_POLICIES&nodeTrailCsv=STORE_POLICIES
3. Click on Search, it directs to https://localhost:8443/ecommerce/control/searchContent?siteId=STORE_POLICIES
4. Screen renders with ScreenRenderingException
Problem:
1. "searchContent" request directs to "searchContent" screen in
ContentScreens.xml.
2. On searchContent screen, "/ecommerce/groovyScripts/content/Search.groovy"
script prepares and hits a search query to Lucene.
3. "BooleanQuery" class is used to match documents with other boolean query
combinations.
4. BooleanQuery object is initialised with Its default constructor.
5. With Lucene 5.4.0, this constructor is deprecated.
OFBiz migrated to Lucene 6.3.1: OFBIZ-8316
Solution:
From Lucene 5.4.0 default constructor is deprecated and a new inner class
Builder is created for queries. Refer OFBIZ-9301 for detailed explanation.
Thanks: Aditya
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790810 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9301)
Steps to regenerate :
1. Log in to Content component
2. Go to the CMS tab or directly go to
https://localhost:8443/content/control/CMSContentFind
3. Click on "Find" submenu or directly go to
https://localhost:8443/content/control/AdminSearch
4. Screen renders with ScreenRenderingException
Problem:
1. "AdminSearch" request directs to "AdminSearch" screen in LuceneScreens.xml.
2. On AdminSearch screen, "Search.groovy" script prepares and hits a search
query to Lucene.
3. "BooleanQuery" class is used to match documents with other boolean query
combinations.
4. BooleanQuery object is initialised with Its default constructor.
5. With Lucene 5.4.0, this constructor is deprecated.
OFBiz migrated to Lucene 6.3.1: OFBIZ-8316
Solution:
From Lucene 5.4.0 default constructor is deprecated and a new inner class
Builder is created for queries.
jleroux: I sorted the imports by hand, and added missing parenthesis at .build
Thanks: Aditya
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790664 13f79535-47bb-0310-9956-ffa450edef68
BirtServices.java
Formatting
Few better comments and some TODOs
Replaces e.printStackTrace() by Debug.logError().
Adds few missing Debug.logError()
Adds return ServiceUtil.returnError()
Improves an EntityListIterator closing not done, using try-with-ressources
Not a funct. change, EntityListIterator.finalyse() catches anyway
Replaces return ServiceUtil.returnError(e.getMessage()) by more explicit
messages. Not needs to clutter the UI.
Uses multi-catches when applicable
BirtUtil.java
Formatting
Note: the Birt.properties file does not exist OOTB but can be added for
convenience, like using the location where you edit with the
Birt Report Designer...
ReportDesignGenerator.java
Formatting
Removes useless and confusing try and re-thrown exceptions. This allows to
fix possible other issues
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790547 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9192)
This fixes an issue I put in while removing partyName.
The couple ("Customer", "Customer name") should also have been removed
While at it I formatted to make things more legible
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790501 13f79535-47bb-0310-9956-ffa450edef68