I put it all in this new version of the patch :
Changed UtilValidate test to Groovy Truth test on string
Changed the big first test by a test on "noConditionFind"
Added some comments
Harmonization of the "if tests"
Removed the uiLabelMap.CommonAny in the file (the two others belonged to another form --> "FindTotalBacklog")
Added a "noConditionFind" field to this form --> "FindTotalBacklog"
jleroux: I removed all remaining tabs in FindProductBacklogItem.groovy
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1754656 13f79535-47bb-0310-9956-ffa450edef68
The Find form for Product Backlog Item does not work in language other than English when no "statusId" or "custRequestTypeId" are selected.
Step to reproduce :
- Go to the Scrum component and select a product
- Go to the "Total Backlog" tab
or use this link : https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1
- Hit the search button, the find action is performed and return a non-empty list.
- Set your language preference to a non english language (french for example).
- Click again on the "Total Backlog" tab, and hit the "Rechercher" button.
- No results are found.
Where does the problem come from ?
The results displayed are from a list named "backlogList" which is built in the following script : FindProductBacklogItem.groovy .
In this script, there were a check on the parameter "custRequestTypeId" and on the parameter "statusId".
But the value was hardcoded :
if("Any".equals(parameters.custRequestTypeId))
and
if(!"Any".equals(parameters.statusId))
Obviously, when the form is in another language than English, those conditions aren't valid anymore (for example, "Any" is "Don't" in French")
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1754051 13f79535-47bb-0310-9956-ffa450edef68
Instead of a quiet S/R action, this was an unexpected pain in the ass. A considerable number of forms:
EmployeeForms.xml
EmploymentForms.xml
EmplPositionForms.xml
GlobalHRSettingForms.xml
RecruitmentForms.xml
QuoteForms.xml
PartyForms.xml
StoreForms.xml
ContactForms.xml
FixedAssetForms.xml
TaskForms.xml
scrumForms.xml
TaskForms.xml
contained a large number of fields with
tooltip="${uiLabelMap.CommonRequired}"
but no
required-field="true"
Of course display and display-entity should not be concerned, I spotted a number of them in the lot.
I also removed a bunch of harcoded * at end of labels (those followed by required-field="true"* and spotted a number of others }*" who still need to be carefully reviewed to see if required=true is not missing there :/
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1709882 13f79535-47bb-0310-9956-ffa450edef68
jleroux: rather than removing I rather commented out the lines related to the ViewSprintItem lines in case the original author decides to use it. I will remove in a week
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1684129 13f79535-47bb-0310-9956-ffa450edef68
To reproduce:
1. In Catalog Manager select the Products menu
2. Click find
3. Click product id GZ-1006-1
4. Click Locations tab
5. In Add Facility Location screenlet select Web Store Warehouse from the Facility Id drop-down list
6. In the Location Seq Id pop up window select Facility Id Web Store Warehouse click find.
7. Select a Location Id
8. In Add Facility Location click Add
Expected: Add location to product record
Actual:
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen component://common/widget/CommonScreens.xml#GlobalDecorator: java.lang.IllegalArgumentException: Return value from use-when condition eval was not a Boolean: null [null] on the field facilityName of form UpdateProductFacilityLocations (Return value from use-when condition eval was not a Boolean: null [null] on the field facilityName of form UpdateProductFacilityLocations)
jleroux: I found some other same cases and fixed them the same way
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1399539 13f79535-47bb-0310-9956-ffa450edef68
Add a 'new backlogitem' button when i selected an existing backlog item
It should be possible to delete a backlog even when hours are attached
the button 'billed' on a backlogitem to set the flag to billed, does not work, get an error message
if for a backlogitem, billed is no, the time entries are not combined into a single item on the invoice.
the email confirmation: Scrum - Your Sprint is started, has the wrong domainname in the sprint url: 127.0.0.1
Convert the service name 'addWorkEffortTimeToInvoice' to 'scrumAddWorkEffortTimeToInvoice' to allow a special grouping
Remove the causes for the entity warnings in the log, there were entity changes inside scrum, we do not expect usingh it yet but we can supply conversion programs if needed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1153071 13f79535-47bb-0310-9956-ffa450edef68