(OFBIZ-8318)
There was an error introduced in r1761111, the open quote for an attribute
was missing.
Thanks: Amardeep Singh Jhajj for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761931 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8088)
Change all form names to upper camel case for consistency. I have slightly modified the patch to have camel case also for the LookupParty form in PartyForms.xml.
Thanks: Tanmay Muley for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761100 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8118)(OFBIZ-8122)(OFBIZ-8123)(OFBIZ-8124)(OFBIZ-8125)(OFBIZ-8126)(OFBIZ-8127)(OFBIZ-8128)(OFBIZ-8129)
Menu names should be in camel case to maintain consistency. I've slightly modified the provided patch to eliminate names with "-" or all lower case also.
Thanks: Tanmay Muley for reporting and providing the patches.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1760059 13f79535-47bb-0310-9956-ffa450edef68
I put it all in this new version of the patch :
Changed UtilValidate test to Groovy Truth test on string
Changed the big first test by a test on "noConditionFind"
Added some comments
Harmonization of the "if tests"
Removed the uiLabelMap.CommonAny in the file (the two others belonged to another form --> "FindTotalBacklog")
Added a "noConditionFind" field to this form --> "FindTotalBacklog"
jleroux: I removed all remaining tabs in FindProductBacklogItem.groovy
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1754656 13f79535-47bb-0310-9956-ffa450edef68
The Find form for Product Backlog Item does not work in language other than English when no "statusId" or "custRequestTypeId" are selected.
Step to reproduce :
- Go to the Scrum component and select a product
- Go to the "Total Backlog" tab
or use this link : https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1
- Hit the search button, the find action is performed and return a non-empty list.
- Set your language preference to a non english language (french for example).
- Click again on the "Total Backlog" tab, and hit the "Rechercher" button.
- No results are found.
Where does the problem come from ?
The results displayed are from a list named "backlogList" which is built in the following script : FindProductBacklogItem.groovy .
In this script, there were a check on the parameter "custRequestTypeId" and on the parameter "statusId".
But the value was hardcoded :
if("Any".equals(parameters.custRequestTypeId))
and
if(!"Any".equals(parameters.statusId))
Obviously, when the form is in another language than English, those conditions aren't valid anymore (for example, "Any" is "Don't" in French")
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1754051 13f79535-47bb-0310-9956-ffa450edef68
===========================================
"Tasks" menu is showing selected when click in scrum component
===========================================
Thanks Pawan Verma for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1751408 13f79535-47bb-0310-9956-ffa450edef68
===================================
Add a look-up for Product Id in Find Revision Screen under scrum component
===================================
Thanks Pawan Verma for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1748943 13f79535-47bb-0310-9956-ffa450edef68
Thanks Vaibhav Jain for reporting the issue and providing initial patch, thanks Amardeep Singh Jhajj and Jacques for reviewing the patch and providing your comments, thanks Montalbano Florian for providing final patch including Scrum component.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1748218 13f79535-47bb-0310-9956-ffa450edef68
Instead of a quiet S/R action, this was an unexpected pain in the ass. A considerable number of forms:
EmployeeForms.xml
EmploymentForms.xml
EmplPositionForms.xml
GlobalHRSettingForms.xml
RecruitmentForms.xml
QuoteForms.xml
PartyForms.xml
StoreForms.xml
ContactForms.xml
FixedAssetForms.xml
TaskForms.xml
scrumForms.xml
TaskForms.xml
contained a large number of fields with
tooltip="${uiLabelMap.CommonRequired}"
but no
required-field="true"
Of course display and display-entity should not be concerned, I spotted a number of them in the lot.
I also removed a bunch of harcoded * at end of labels (those followed by required-field="true"* and spotted a number of others }*" who still need to be carefully reviewed to see if required=true is not missing there :/
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1709882 13f79535-47bb-0310-9956-ffa450edef68
jleroux: rather than removing I rather commented out the lines related to the ViewSprintItem lines in case the original author decides to use it. I will remove in a week
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1684129 13f79535-47bb-0310-9956-ffa450edef68
jleroux: I suspected it was only a matter of replacing "${bsh" by "${groovy" in *.xml. But I had not the guts to get into 11(!) sub tasks.
So, in Eclipse, I simply did a S/R in *.xml and compared parts of my changes with some Pierre's most "complex" patches respectively product, ebaystore, projectmgr and scrum.
They were totally similar (just revisions number changed) so here is the whole.
I will later improve these changes by removing HTML entities when possible, this is a bit more delicate because in some cases the XML schema are not complete (or/and for other still obscure to me reasons) and if you simply replace HTML entities by simple code (eg &Amp; by &) you get issues in logs when the XML parser cross them...
Note: only menus, screen and forms are changed here.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1682118 13f79535-47bb-0310-9956-ffa450edef68
Actually it does paginate but the value is not dependent on widget property widget.form.defaultViewSize which default value is 20. It uses a default value of 50 which is defined by
<set field="viewSize" from-field="parameters.VIEW_SIZE" type="Integer" default-value="3"/>
You can easily test it using https://localhost:8443/manufacturing/control/FindRouting?VIEW_SIZE=3
This is legacy from pre Apache era. I found 143 cases where a default-value is defined in screens for VIEW_SIZE.
I did not look into details for the 143 cases but I believe most are also legacy.
There are few default values: 10, 20, 30, 50, 500 and even an extreme case of 10000 for InventoryItemTotalsExport!
There is only one comment for LookupBulkAddProducts which is also legacy: <!-- 10 rows seems more appropriate given screen size, etc. -->
I suggest to OOTB replace all those by the widget.form.defaultViewSize value.
Things will then be consistent and easily changeable on a global scale using the widget property.
Or if really needed forcing the default-value as it's done now.
So this would be applied on the 143 cases (I checked, viewSizeDefaultValue does not exist in any screen)
<property-to-field resource="widget" property="widget.form.defaultViewSize" field="viewSizeDefaultValue"/>
<set field="viewSize" from-field="parameters.VIEW_SIZE" type="Integer" default-value="${viewSizeDefaultValue}"/>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1526387 13f79535-47bb-0310-9956-ffa450edef68
To reproduce:
1. In Catalog Manager select the Products menu
2. Click find
3. Click product id GZ-1006-1
4. Click Locations tab
5. In Add Facility Location screenlet select Web Store Warehouse from the Facility Id drop-down list
6. In the Location Seq Id pop up window select Facility Id Web Store Warehouse click find.
7. Select a Location Id
8. In Add Facility Location click Add
Expected: Add location to product record
Actual:
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen component://common/widget/CommonScreens.xml#GlobalDecorator: java.lang.IllegalArgumentException: Return value from use-when condition eval was not a Boolean: null [null] on the field facilityName of form UpdateProductFacilityLocations (Return value from use-when condition eval was not a Boolean: null [null] on the field facilityName of form UpdateProductFacilityLocations)
jleroux: I found some other same cases and fixed them the same way
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1399539 13f79535-47bb-0310-9956-ffa450edef68