plugins
================================================================================
While checking there were no other cases like in OFBIZ-9432
(missing path to class), to be consistent I removed the trailing semicolons in
groovy scripts and made few formatting
================================================================================
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1800450 13f79535-47bb-0310-9956-ffa450edef68
Scrum Groovy files
(OFBIZ-9389)
This is an improvement only because no cases were reported. But obviously in
case of unlucky exception after the call to the performFind service, and before
it's closed, the EntityListIterator remains in memory.
The solution is to use a try-catch-finally block because Groovy has not
try-with-ressources.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1797788 13f79535-47bb-0310-9956-ffa450edef68
with "id", "id-long" and "id-vlong" respectively which are primary keys for plugin components.
(OFBIZ-9351)
Thanks Aditya Sharma for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1796380 13f79535-47bb-0310-9956-ffa450edef68
I found an inconsistency in the code for string comparison statusId.equals("PRUN_COMPLETED") whereas it should be written as "PRUN_COMPLETED".equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.
Thanks Devanshu Vyas for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1795344 13f79535-47bb-0310-9956-ffa450edef68
- facility
- marketting
- return
- entitysync
Also moved the permission check from implementation level to service defination level
(OFBIZ-8673)(OFBIZ-8673)(OFBIZ-8674)(OFBIZ-8739)(OFBIZ-8823)(OFBIZ-8825)(OFBIZ-8827)(OFBIZ-8850)(OFBIZ-8876)(OFBIZ-8875)(OFBIZ-8824)(OFBIZ-8826)(OFBIZ-8851)
Thanks Nameet Jain for your contribution
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1768188 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8318)
There was an error introduced in r1761111, the open quote for an attribute
was missing.
Thanks: Amardeep Singh Jhajj for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761931 13f79535-47bb-0310-9956-ffa450edef68
new ControlFilter, from the ContextFilter; modified existing applications to use
the two filters in a chain; removed from the other specialized filters all the
logic that was duplicated or extended from ContextFilter.
A web application, in order to leverage the OFBiz framework, requires that a
series of objects are in its contexts (servlet context, session and request)
such as "delegator", "delegatorName", "dispatcher", "security" etc. etc...
This setup is performed by the logic contained in the servlet filter implemented
by the ContextFilter class.
The execution of this logic is required for the application to run properly.
However, before this commit, in the ContextFilter there was other logic, related
to access control and redirection rules (some of them performed in coordination
with the ControlServlet), making it difficult to deploy this filter in all the
web applications, especially the ones that implement special handling of paths.
In fact, this filter was deployed in most but not all the web application in the
OFBiz codebase: specifically it was not deployed in web applications that
require the execution of other filters (e.g. CatalogUrlFilter, etc...) like the
ones in the "ecommerce" and "solr" components.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761304 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8088)
Change all form names to upper camel case for consistency. I have slightly modified the patch to have camel case also for the LookupParty form in PartyForms.xml.
Thanks: Tanmay Muley for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761100 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8118)(OFBIZ-8122)(OFBIZ-8123)(OFBIZ-8124)(OFBIZ-8125)(OFBIZ-8126)(OFBIZ-8127)(OFBIZ-8128)(OFBIZ-8129)
Menu names should be in camel case to maintain consistency. I've slightly modified the provided patch to eliminate names with "-" or all lower case also.
Thanks: Tanmay Muley for reporting and providing the patches.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1760059 13f79535-47bb-0310-9956-ffa450edef68
After commit, please rename readme files of components
manufacturing
assetmaint
birt
ecommerce
lucene
myportal
passport
projectmgr
scrum
solr
jleroux: Due to content I guess Pierre meant to add the .md suffix
I have also removed the useless ASL2 header of example/lib/README file
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1758702 13f79535-47bb-0310-9956-ffa450edef68
1) Removed 'maincss.css' entry from 'allowedPaths' param of from web.xml
Reason: Since, there is no file like 'maincss.css' exist under any includes directory.
2) Removed the unused references of maincss.css from FTLs, code
<link rel="stylesheet" href="${StringUtil.wrapString(baseUrl!)}/images/maincss.css" type="text/css"/>
has been removed.
Reason: This is an interesting thing, these FTLs were using the maincss.css located under the images directory.
When I look the history of these files, following were my findings,
The 'maincss.css' file under the 'images' directory exist in release4.0
http://svn.apache.org/repos/asf/ofbiz/branches/release4.0/framework/images/webapp/images/
after this release, this files no longer exist there.
3) Also, I have updated one file 'InventoryNoticeEmail.ftl' and used the basic HTML code to style, instead of using style defined in 'maincss.css' which were exist in release-4.0
4) Updated some references from 'maincss.css' to style.css in comments.
5) Also removed the entry of including '/images/maincss.css' and '/images/mainrtl.css' in SimpleDecorator
Since, these files no longer exist after release-4.0.
Thanks Wai for reviewing the work and thanks Swapnil M Mane for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1758389 13f79535-47bb-0310-9956-ffa450edef68
Notes:
* Also removes empty framework/base/lib/scripting and useless applications\content\lib\uno\README (miss doc in wiki)
* When jpim-0.1.jar will be (hopefully) replaced we can drop lib ref in framework/base/ofbiz-component.xml
* I wonder if we should let the geronimo component alone with only 2 classes, could we not put that in entity or entityext?
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1755306 13f79535-47bb-0310-9956-ffa450edef68
I put it all in this new version of the patch :
Changed UtilValidate test to Groovy Truth test on string
Changed the big first test by a test on "noConditionFind"
Added some comments
Harmonization of the "if tests"
Removed the uiLabelMap.CommonAny in the file (the two others belonged to another form --> "FindTotalBacklog")
Added a "noConditionFind" field to this form --> "FindTotalBacklog"
jleroux: I removed all remaining tabs in FindProductBacklogItem.groovy
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1754656 13f79535-47bb-0310-9956-ffa450edef68
The Find form for Product Backlog Item does not work in language other than English when no "statusId" or "custRequestTypeId" are selected.
Step to reproduce :
- Go to the Scrum component and select a product
- Go to the "Total Backlog" tab
or use this link : https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1
- Hit the search button, the find action is performed and return a non-empty list.
- Set your language preference to a non english language (french for example).
- Click again on the "Total Backlog" tab, and hit the "Rechercher" button.
- No results are found.
Where does the problem come from ?
The results displayed are from a list named "backlogList" which is built in the following script : FindProductBacklogItem.groovy .
In this script, there were a check on the parameter "custRequestTypeId" and on the parameter "statusId".
But the value was hardcoded :
if("Any".equals(parameters.custRequestTypeId))
and
if(!"Any".equals(parameters.statusId))
Obviously, when the form is in another language than English, those conditions aren't valid anymore (for example, "Any" is "Don't" in French")
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1754051 13f79535-47bb-0310-9956-ffa450edef68
This is the first of two steps in the above mentioned JIRA. This
first step changes the java source directory for every component
from /src to /src/main/java. The next step will be adding unit
tests to every component in /src/test/java
Thank you to Deepak Dixit for tips on how to use the SVN commands
to make the appropriate file moving.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752838 13f79535-47bb-0310-9956-ffa450edef68
This is the first patch that takes OFBiz to the point of no return
in terms of switching from Ant to Gradle build system. Specifically
this patch applies the following items:
- Delete all old Ant and Maven build scripts
- Delete 169 Jar libraries and replace them with remote ones in the
gradle build script
- update the gradle build scripts for the dependencies and other minor
changes needed for the script work correctly
All tests pass with the command ./gradlew cleanAll loadDefault testIntegration
Again, thank you for everyone who contributed valueble time and effort in this
process.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752033 13f79535-47bb-0310-9956-ffa450edef68
===========================================
"Tasks" menu is showing selected when click in scrum component
===========================================
Thanks Pawan Verma for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1751408 13f79535-47bb-0310-9956-ffa450edef68
I have uploaded a patch for the simple methods schema.
In general, the top level attributes are converted to simpleType, and attributeGroups to complexType.
Changed the following attribute name
1. ‘field’ to ‘fieldType’
2. ‘level’ to ‘levelType'
Denormalize the following attributeGroups
1. attlist.compare
2. attlist.compare-field
Left attributeGroup ‘typeDefaultString’ unchanged, cos it doesn’t matter. Not in use, it seem.
jleroux: we also fixed an issue with
<xs:element name="field" type="fieldType"/>
to
<xs:element ref="field"/>
In the patch
And I found a small issue (not minilang related) in ExampleCompoundWidgets.xml
- <sm:log message="CompoundWidgetsFunc runs" sm:level="info"/>
+ <sm:log message="CompoundWidgetsFunc runs" level="info"/>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1750647 13f79535-47bb-0310-9956-ffa450edef68
Steps to regenerate:
1. Go to FindWorkEffort screen https://localhost:8443/workeffort/control/FindWorkEffort
2. Click on Find button in search option and choose any of the WorkEffort from the list.
3. Go to the Parties tab to check parties assigned to the WorkEffort.
4. Add Work Effort Party Assignment:
- Enter any invalid PartyId (which does not exist in the system e.g, XYZ or ABC)
- Choose any of the roles from the drop-down list.
- Add FromDate.
- Submit the form.
Current Behaviour: System creates a WorkEffortPartyAssignment record with invalid data (partyId).
Expected: System should not create this record as entered data - partyId is invalid.
Exploring around this issue I found that entity definition of WorkEffortPartyAssignment has relation with Person, here I think it is required to create a foreign key rule with Person entity. Also, fk-name has not been created with PartyRole in the entity definition.
I have corrected the definition and attached a patch for the same.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1750166 13f79535-47bb-0310-9956-ffa450edef68
Reverts the simple method to use the original schema without namespace. "Duplicates" simple-methods.xsd in simple-methods-ns.xsd as we did, to get the simple-method namespace for compound-widgets.
For myself: when we will do the 3rd more elegant option (no schema duplication), have been changed also:
minilang-catalog.xml
compound-widgets.xsd
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1749938 13f79535-47bb-0310-9956-ffa450edef68
===================================
Add a look-up for Product Id in Find Revision Screen under scrum component
===================================
Thanks Pawan Verma for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1748943 13f79535-47bb-0310-9956-ffa450edef68