I found an inconsistency in the code for string comparison statusId.equals("PRUN_COMPLETED") whereas it should be written as "PRUN_COMPLETED".equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.
Thanks Devanshu Vyas for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1795344 13f79535-47bb-0310-9956-ffa450edef68
completes r1781219 by putting svn:eol-style=native to all file types declared
in [auto-props] section of the svn config files.css
Actually this is only a 1st pass, it was too complicated to do it for
all file types at once only concerned here
*.java;*.bsh;*.groovy;*.jsp;*.tld;*.ftl;*.js;*.sql;*.c;*.cpp;*.h;*.txt;*.sgml;
*.properties;*.xml;.classpath;.project;*.sld;*.gml;*.xsl;*.xsd
*.html;*.htm;*.css;*.md;README;NOTICE;LICENSE;rc.ofbiz.*;*.less;*.dsp;*.dsw
Most files should not be concerned by this change, but it's impossible to do
it one by one.
There are also changes in files with have mixed EOLs; because this has no sense
when using native which automatically resolves this issue
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781731 13f79535-47bb-0310-9956-ffa450edef68
new ControlFilter, from the ContextFilter; modified existing applications to use
the two filters in a chain; removed from the other specialized filters all the
logic that was duplicated or extended from ContextFilter.
A web application, in order to leverage the OFBiz framework, requires that a
series of objects are in its contexts (servlet context, session and request)
such as "delegator", "delegatorName", "dispatcher", "security" etc. etc...
This setup is performed by the logic contained in the servlet filter implemented
by the ContextFilter class.
The execution of this logic is required for the application to run properly.
However, before this commit, in the ContextFilter there was other logic, related
to access control and redirection rules (some of them performed in coordination
with the ControlServlet), making it difficult to deploy this filter in all the
web applications, especially the ones that implement special handling of paths.
In fact, this filter was deployed in most but not all the web application in the
OFBiz codebase: specifically it was not deployed in web applications that
require the execution of other filters (e.g. CatalogUrlFilter, etc...) like the
ones in the "ecommerce" and "solr" components.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761304 13f79535-47bb-0310-9956-ffa450edef68
This new feature allow to bill task time entries from several projects into one unique Invoice.
Thanks Florian Montalbano for your contribution, i did apply some light improvments in your patch
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761202 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-7650) (OFBIZ-7651) (OFBIZ-7653) (OFBIZ-7660) (OFBIZ-7662) (OFBIZ-7665) (OFBIZ-7666) (OFBIZ-8028)(OFBIZ-8029) (OFBIZ-8255)
Thanks: Anuj Jain and Ratnesh for the pathes and Swapnil Shah for reporting the issues.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761192 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-7549) (OFBIZ-7550)
Added Check box for status fields on Find Qualifications, Find Employment Applications, Find Leave in HR and in Find Tasks, Find TimeSheet in Project components.
Thanks: Mohammad Kathawala for the patch and Swapnil Shah for reporting the issues.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761186 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8088)
Change all form names to upper camel case for consistency. I have slightly modified the patch to have camel case also for the LookupParty form in PartyForms.xml.
Thanks: Tanmay Muley for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761100 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8078)
Change all form names to upper camel case for consistency. I have slightly modified the patch to remove a typo (LookupOrderHeader instead of LSookupOrderHeader) in LookupScreens.xml.
Thanks: Tanmay Muley for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761095 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8154)
It's a pity, because of the translations, but the labels starting by "HumanResServices.", which dates from pre Apache era, are not used OOTB, so I remove them here
.portalPageName. is used by demo data
ProductStoreGroup.productStoreGroupName.NA is used as data by ProductTypeData.xml
FormFieldTitle_timesheetPartyId in ProjectMgrUiLabels.xml seems an error. As it duplicates the same in AccountingUiLabels.xml, which is accurate, I remove it from ProjectMgrUiLabels
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1760995 13f79535-47bb-0310-9956-ffa450edef68
After commit, please rename readme files of components
manufacturing
assetmaint
birt
ecommerce
lucene
myportal
passport
projectmgr
scrum
solr
jleroux: Due to content I guess Pierre meant to add the .md suffix
I have also removed the useless ASL2 header of example/lib/README file
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1758702 13f79535-47bb-0310-9956-ffa450edef68
1) Removed 'maincss.css' entry from 'allowedPaths' param of from web.xml
Reason: Since, there is no file like 'maincss.css' exist under any includes directory.
2) Removed the unused references of maincss.css from FTLs, code
<link rel="stylesheet" href="${StringUtil.wrapString(baseUrl!)}/images/maincss.css" type="text/css"/>
has been removed.
Reason: This is an interesting thing, these FTLs were using the maincss.css located under the images directory.
When I look the history of these files, following were my findings,
The 'maincss.css' file under the 'images' directory exist in release4.0
http://svn.apache.org/repos/asf/ofbiz/branches/release4.0/framework/images/webapp/images/
after this release, this files no longer exist there.
3) Also, I have updated one file 'InventoryNoticeEmail.ftl' and used the basic HTML code to style, instead of using style defined in 'maincss.css' which were exist in release-4.0
4) Updated some references from 'maincss.css' to style.css in comments.
5) Also removed the entry of including '/images/maincss.css' and '/images/mainrtl.css' in SimpleDecorator
Since, these files no longer exist after release-4.0.
Thanks Wai for reviewing the work and thanks Swapnil M Mane for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1758389 13f79535-47bb-0310-9956-ffa450edef68
The Gantt diagram is not generated when at least one of the taks composing it has a non-numerical workEffortId (e.g. A10001).
When importing data or using duplication of workEffort, you can use such id.
How to reproduce :
- Check the Gantt diagram, it should be working fine : https://localhost:8443/projectmgr/control/ganttChart?projectId=9100
- Create a task with a non-numerical id for the project 9100 or iImport this entry :
<entity-engine-xml>
<WorkEffort workEffortId="A1000" sequenceNum="1" workEffortTypeId="TASK" currentStatusId="PTS_CREATED" lastStatusUpdate="2007-12-14 16:45:21.831" workEffortParentId="9101" scopeEnumId="WES_PRIVATE" workEffortName="ProblemTask" estimatedStartDate="2007-12-03 00:00:00.0" estimatedCompletionDate="2007-12-05 00:00:00.0" revisionNumber="1"/>
</entity-engine-xml>
- Check the Gantt diagram again and now it's failing : https://localhost:8443/projectmgr/control/ganttChart?projectId=9100
(there is an error in the javascript console)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1758101 13f79535-47bb-0310-9956-ffa450edef68
Notes:
* Also removes empty framework/base/lib/scripting and useless applications\content\lib\uno\README (miss doc in wiki)
* When jpim-0.1.jar will be (hopefully) replaced we can drop lib ref in framework/base/ofbiz-component.xml
* I wonder if we should let the geronimo component alone with only 2 classes, could we not put that in entity or entityext?
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1755306 13f79535-47bb-0310-9956-ffa450edef68
This is the first of two steps in the above mentioned JIRA. This
first step changes the java source directory for every component
from /src to /src/main/java. The next step will be adding unit
tests to every component in /src/test/java
Thank you to Deepak Dixit for tips on how to use the SVN commands
to make the appropriate file moving.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752838 13f79535-47bb-0310-9956-ffa450edef68
This is the first patch that takes OFBiz to the point of no return
in terms of switching from Ant to Gradle build system. Specifically
this patch applies the following items:
- Delete all old Ant and Maven build scripts
- Delete 169 Jar libraries and replace them with remote ones in the
gradle build script
- update the gradle build scripts for the dependencies and other minor
changes needed for the script work correctly
All tests pass with the command ./gradlew cleanAll loadDefault testIntegration
Again, thank you for everyone who contributed valueble time and effort in this
process.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752033 13f79535-47bb-0310-9956-ffa450edef68
===========================================
Unable to set thru date for List survey screen of project component if more than one survey in available.
===========================================
Thanks Pawan Verma for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1751405 13f79535-47bb-0310-9956-ffa450edef68
I have uploaded a patch for the simple methods schema.
In general, the top level attributes are converted to simpleType, and attributeGroups to complexType.
Changed the following attribute name
1. ‘field’ to ‘fieldType’
2. ‘level’ to ‘levelType'
Denormalize the following attributeGroups
1. attlist.compare
2. attlist.compare-field
Left attributeGroup ‘typeDefaultString’ unchanged, cos it doesn’t matter. Not in use, it seem.
jleroux: we also fixed an issue with
<xs:element name="field" type="fieldType"/>
to
<xs:element ref="field"/>
In the patch
And I found a small issue (not minilang related) in ExampleCompoundWidgets.xml
- <sm:log message="CompoundWidgetsFunc runs" sm:level="info"/>
+ <sm:log message="CompoundWidgetsFunc runs" level="info"/>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1750647 13f79535-47bb-0310-9956-ffa450edef68
Steps to regenerate:
1. Go to FindWorkEffort screen https://localhost:8443/workeffort/control/FindWorkEffort
2. Click on Find button in search option and choose any of the WorkEffort from the list.
3. Go to the Parties tab to check parties assigned to the WorkEffort.
4. Add Work Effort Party Assignment:
- Enter any invalid PartyId (which does not exist in the system e.g, XYZ or ABC)
- Choose any of the roles from the drop-down list.
- Add FromDate.
- Submit the form.
Current Behaviour: System creates a WorkEffortPartyAssignment record with invalid data (partyId).
Expected: System should not create this record as entered data - partyId is invalid.
Exploring around this issue I found that entity definition of WorkEffortPartyAssignment has relation with Person, here I think it is required to create a foreign key rule with Person entity. Also, fk-name has not been created with PartyRole in the entity definition.
I have corrected the definition and attached a patch for the same.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1750166 13f79535-47bb-0310-9956-ffa450edef68
Reverts the simple method to use the original schema without namespace. "Duplicates" simple-methods.xsd in simple-methods-ns.xsd as we did, to get the simple-method namespace for compound-widgets.
For myself: when we will do the 3rd more elegant option (no schema duplication), have been changed also:
minilang-catalog.xml
compound-widgets.xsd
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1749938 13f79535-47bb-0310-9956-ffa450edef68
To regenerate this issue on trunk, here are the steps:
Go to Project --> Projects
Click on New Project
Only enter Project Name and click on save button
Close the current project.
The following error is thrown
Proper fix: issue occurred due to use of inappropriate map. Instead of fetching the value of projectId from parameters, its better to get it from context map as its already set at screen.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1749282 13f79535-47bb-0310-9956-ffa450edef68
Thanks Vaibhav Jain for reporting the issue and providing initial patch, thanks Amardeep Singh Jhajj and Jacques for reviewing the patch and providing your comments, thanks Montalbano Florian for providing final patch including Scrum component.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1748218 13f79535-47bb-0310-9956-ffa450edef68
I removed duplicate paths were componentname was uselessly repeated after component://componentname/script/org/ofbiz (projectmngr was the only one using there project instead)
I had few typos, easily fixed thanks to the tests. There could be still typos but they are unexpected and anyway no-brainer to fix
I'm still wondering about specialpurpose/example/minilang/README.txt.
I changed its content to
"The minilang directory is for static resources that are interpreted at run time rather than being compiled. This goes on the classpath, but does not get built or put into a JAR file."
not sure it makes any sense, I don't see how this relates to the classpath.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1747712 13f79535-47bb-0310-9956-ffa450edef68
Rishi Solanki: patch to fix the issue on sorting by projectId. The field projectId does not exists in the entity used in the perform find (WorkEffortCustRequestView). Uses the proper field workEffortParentId.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1746890 13f79535-47bb-0310-9956-ffa450edef68
The error msg is "The entity name must immediately follow the '&' in the entity reference."
For a reason I'll check later this works in '<set field value="${groovy: ' cases...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1745012 13f79535-47bb-0310-9956-ffa450edef68