At http://markmail.org/message/ffmyw773p65fndey I wrote:
I'd like to follow the suggestion I made in the last message of the linked
thread.
In other words, use
http://subversion.apache.org/docs/release-notes/1.8.html#repos-dictated-confighttp://blogs.collab.net/subversion/the-road-to-repository-dictated-configuration-day-2-autoprops
Then this problem would be over. No longer need to check from time to time that
concerned files, have svn:eol-style=native property set
This imply that all OFBiz users use svn > 1.7, but we can inform them, et voilà
Then at markmail.org/message/h3q2yvj4db544ro7 I wrote:
Actually, since we get new committers now and then and their are able to create
new files I have a warning every 6 months which says "Check Java
files, have all svn:eol-style=native" (I totally forgot that because I assume
the machine knows it and warns me ;))
I could extend that to all files (at least the most prominent types), I'll
see...
This does what the last sentence said for Groovy, XML and few new Birt
Java files.
I'll see if I can implement the svn 1.8 repos-dictated-config ASAP!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781219 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8102) (OFBIZ-8130)
Reverts r1758774 for OFBIZ-8102 w/o reverting changes which slipped in
Reverts r1761687 for OFBIZ-8130
We decided this is not a good way, we prefer to keep the FormFieldTitle_ way
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761923 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8118)(OFBIZ-8122)(OFBIZ-8123)(OFBIZ-8124)(OFBIZ-8125)(OFBIZ-8126)(OFBIZ-8127)(OFBIZ-8128)(OFBIZ-8129)
Menu names should be in camel case to maintain consistency. I've slightly modified the provided patch to eliminate names with "-" or all lower case also.
Thanks: Tanmay Muley for reporting and providing the patches.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1760059 13f79535-47bb-0310-9956-ffa450edef68
There are forms in the ecommerce component referencing the status. This issue is about applying the CommonLabel label where it is possible in these forms.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1758774 13f79535-47bb-0310-9956-ffa450edef68
Currently there are few Groovy scripts not in components WEB-INF/actions sub-folders.
Before moving Groovy scripts as we decided in OFBIZ-6810 we should move the few Groovy scripts not in components WEB-INF/actions sub-folders to these WEB-INF/actions sub-folders. So we will not miss one and it will be a "straightforward" task to move then as we decided in OFBIZ-6810.
Note: most of the Groovy scripts not in components WEB-INF/actions sub-folders are related with events. But not all events related Groovy scripts are not placed components WEB-INF/actions sub-folders, just a very few. There are other cases were Groovy scripts are not in components WEB-INF/actions sub-folders, like ShowProductionRun.groovy and OrderReportPrepare.groovy...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1743949 13f79535-47bb-0310-9956-ffa450edef68
Completes in screens the changes done in forms at r1741873. I then replaced few form lists by grids, where it was possible to do it with regexp.
Also complete StatsForms.xml to use only grids and "searchList" form in ecommerce ContentForms to NOT use grid (not called in screen)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1742196 13f79535-47bb-0310-9956-ffa450edef68
I will double-check all screens changes kept in r1737557 (ie initially committed for subtasks 25 to 32 of OFBIZ-6810)
From 1st investigation I believe there are no others (at least dependency in specialpurpose from applications, I did not check specialpurpose interdependencies yet...)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1737608 13f79535-47bb-0310-9956-ffa450edef68
Error in trunk:
ERROR rendering error page [/error/error.jsp], but here is the error text: org.ofbiz.webapp.control.RequestHandlerException: No definition found for view with name [checkoutpayment]
Error in stable and old:
org.ofbiz.webapp.control.RequestHandlerException: No definition found for view with name [checkoutpayment]
Vyom Jain added a comment - 22/Nov/15 07:50
This is an issue even in 09.04 and 10.04 code, so it has been there for sometime now.
Scott Gray added a comment - 03/Jan/16 05:43
The view-map was moved to ecommerce in r544053. Probably because the view-map wasn't referenced in the controller.xml for ordermgr. It is actually used though as a view override in component://order/webapp/ordermgr/entry/checkoutoptions.ftl
Just needs to be restored in the controller and have the screen moved back.
jleroux: So I moved back from ecommerce to order (with few adaptations)
* the checkoutpayment.ftl file
* the order controller view-map
* the screen name checkoutpayment
I tested in both order and ecommerce, works! I will try to backport, let's see...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1726828 13f79535-47bb-0310-9956-ffa450edef68
Deepak: here is the patch for this issue, found some more places where if-has-permission tag used in different way, will create a new ticket to fix the if-has-permission tags and will used the consistent pattern.
jleroux: I wonder if this commit does not fix some other already reported issues, anyway it's good!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1647266 13f79535-47bb-0310-9956-ffa450edef68
The problem was double. It'd have been easy to add the missing "/js:" patch in allowedPaths in the web.xml of birt component from where the js scripts are now expected to be loaded in trunk.
But then you would need to also copy the js scripst there (in birt component). You could not simply move them because for upcoming branches we also need them in ordermgr component (they were there in images/js) else they would miss again.
This commit rather adds them under a simple ordermgr-js new webapp (simple, ie like framework/images, only to load resources) under commonext: applications/commonext/webapp/ordermgr-js to prevent the duplication maintenance hazards.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1612202 13f79535-47bb-0310-9956-ffa450edef68
jquery-1.8.2 to jquery-1.10.2 which implies using jquery-migrate-1.2.1 for plugins compatiblities
jquery-ui-timepicker-addon-1.0.5 to jquery-ui-timepicker-addon-1.4.3 (using min now, better i18n)
jquery-ui-1.9.0 to jquery-ui-1.10.3
removes jquery.ui.datepicker.js now integrated in jquery.ui
jquery.hotkeys-0.7.9 to jquery.hotkeys-0.8
jquery.maskedinput-1.2.2 to jquery.maskedinput-1.3.1
jquery.validate 1.10.0 to 1.11.1
I never realised how much efforts have been put in this plugin!
I fixed an issue in JsLanguageFilesMapping generation
I removed the messages_ptbr.js and messages_ptpt.js files and the related conundrum in JsLanguageFileMappingCreator.java
untested, found not use cases OOTB
jquery.jcarousel ?(2006) to 0.3.0 (2013)
untested, found not use cases OOTB
jquery.flot 0.7 to 0.8.2 (lot of changes, still works)
removes useless flotpie.ftl
removes empty flotr folder
jquery.mobile-1.1.0-rc.1 to jquery.mobile-1.4.0
untested, found not use cases OOTB
jquery.cookie to jquery.cookie-1.4.0
Removes all useless/redundant js files (not only jQuery unused old versions)
notably removes all under images/jquery/ui/development-bundle/ui
removes now useless GooglemapMarkers.js and GooglemapSimple.js
Flat Grey application.js
moves jQuery(document).ready(function() at bottom (spotted in Chrome console)
css
I did not find much issues, I spotted the title bar of the lookups, but got it fixed after some efforts.
Issues:
Imagemanagement: I got issues while testing, actually I'm not quite qure how it works, even in stable demo. It should be validated again. I commit nevertheless my changes:
moves js part from product to images component
removes useless calls to js files (mostly in imagemanagement, but not only)
renames jquery.min.js to sizzle.min.js.
Inside sizzle.min.js, updates the Dojo part to v1.10.17-pre and removes the jQuery part
changes to use ofbizContentUrl macro for generating js calls
jquery.rotate.js NOT! It's jQueryRotateCompressed.js http://markmail.org/message/dit3dlh3ph4jnenp
Got ERROR 22001: A truncation error was encountered trying to shrink VARCHAR 'D:\projectsASF\ofbizClean\framework\images\webapp\images\pro&' to length 100. I opened OFBIZ-5501 for that
I tried to update jstree to jstree 3 but gave up. I let the jquery.jstree-3.0.0-beta3 files in place in case someone would give it a chance...
Not related but while a it:
removes <!--flot example requests--> from birt controller (moved recently to example component)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1559769 13f79535-47bb-0310-9956-ffa450edef68
Actually it does paginate but the value is not dependent on widget property widget.form.defaultViewSize which default value is 20. It uses a default value of 50 which is defined by
<set field="viewSize" from-field="parameters.VIEW_SIZE" type="Integer" default-value="3"/>
You can easily test it using https://localhost:8443/manufacturing/control/FindRouting?VIEW_SIZE=3
This is legacy from pre Apache era. I found 143 cases where a default-value is defined in screens for VIEW_SIZE.
I did not look into details for the 143 cases but I believe most are also legacy.
There are few default values: 10, 20, 30, 50, 500 and even an extreme case of 10000 for InventoryItemTotalsExport!
There is only one comment for LookupBulkAddProducts which is also legacy: <!-- 10 rows seems more appropriate given screen size, etc. -->
I suggest to OOTB replace all those by the widget.form.defaultViewSize value.
Things will then be consistent and easily changeable on a global scale using the widget property.
Or if really needed forcing the default-value as it's done now.
So this would be applied on the 143 cases (I checked, viewSizeDefaultValue does not exist in any screen)
<property-to-field resource="widget" property="widget.form.defaultViewSize" field="viewSizeDefaultValue"/>
<set field="viewSize" from-field="parameters.VIEW_SIZE" type="Integer" default-value="${viewSizeDefaultValue}"/>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1526387 13f79535-47bb-0310-9956-ffa450edef68
* Now uses real server hour
* Renames getDependentDropdownValues.js into miscAjaxFunctions.js, that it is really
* Introduces a minimized version of date.format: date.format-1.2.3-min.js
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1426904 13f79535-47bb-0310-9956-ffa450edef68