(OFBIZ-9198)
When accessing a file/image in ecomseo (only seo version) that is physically
missing or the dataresource attribute isPublic=="N" the request results
in a loop.
jleroux: to break the loop in case or error, I simply decided to return a
response of type none. I also added the same for io-error which can be returned
by the DataEvents class, also in ecommerce controller
Thanks: Ingo Wolfmayr for report
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781662 13f79535-47bb-0310-9956-ffa450edef68
new ControlFilter, from the ContextFilter; modified existing applications to use
the two filters in a chain; removed from the other specialized filters all the
logic that was duplicated or extended from ContextFilter.
A web application, in order to leverage the OFBiz framework, requires that a
series of objects are in its contexts (servlet context, session and request)
such as "delegator", "delegatorName", "dispatcher", "security" etc. etc...
This setup is performed by the logic contained in the servlet filter implemented
by the ContextFilter class.
The execution of this logic is required for the application to run properly.
However, before this commit, in the ContextFilter there was other logic, related
to access control and redirection rules (some of them performed in coordination
with the ControlServlet), making it difficult to deploy this filter in all the
web applications, especially the ones that implement special handling of paths.
In fact, this filter was deployed in most but not all the web application in the
OFBiz codebase: specifically it was not deployed in web applications that
require the execution of other filters (e.g. CatalogUrlFilter, etc...) like the
ones in the "ecommerce" and "solr" components.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761304 13f79535-47bb-0310-9956-ffa450edef68
component.
This web application was created to provide an example of how to leverage the
mechanism to extend another web application: since then the mechanism has been
adopted by most of the other OFBiz applications, making this example no more
useful.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761301 13f79535-47bb-0310-9956-ffa450edef68
I removed duplicate paths were componentname was uselessly repeated after component://componentname/script/org/ofbiz (projectmngr was the only one using there project instead)
I had few typos, easily fixed thanks to the tests. There could be still typos but they are unexpected and anyway no-brainer to fix
I'm still wondering about specialpurpose/example/minilang/README.txt.
I changed its content to
"The minilang directory is for static resources that are interpreted at run time rather than being compiled. This goes on the classpath, but does not get built or put into a JAR file."
not sure it makes any sense, I don't see how this relates to the classpath.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1747712 13f79535-47bb-0310-9956-ffa450edef68
Currently there are few Groovy scripts not in components WEB-INF/actions sub-folders.
Before moving Groovy scripts as we decided in OFBIZ-6810 we should move the few Groovy scripts not in components WEB-INF/actions sub-folders to these WEB-INF/actions sub-folders. So we will not miss one and it will be a "straightforward" task to move then as we decided in OFBIZ-6810.
Note: most of the Groovy scripts not in components WEB-INF/actions sub-folders are related with events. But not all events related Groovy scripts are not placed components WEB-INF/actions sub-folders, just a very few. There are other cases were Groovy scripts are not in components WEB-INF/actions sub-folders, like ShowProductionRun.groovy and OrderReportPrepare.groovy...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1743949 13f79535-47bb-0310-9956-ffa450edef68
Completes in screens the changes done in forms at r1741873. I then replaced few form lists by grids, where it was possible to do it with regexp.
Also complete StatsForms.xml to use only grids and "searchList" form in ecommerce ContentForms to NOT use grid (not called in screen)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1742196 13f79535-47bb-0310-9956-ffa450edef68
Static["org.ofbiz.base.util.UtilProperties"].getPropertyValue is used in several .ftl files.
Replaces with EnittyUtilProperties variant where appropriate.
jleroux: In this is the 2nd commit from the 3rd patch (the 2nd had issues) I fixed 2 "typos" I spotted while reviewing in
ecommerce/customer/editcontactmech.ftl
ecommerce/customer/newcustomer.ftl
where "UtilProperties" was not replaced
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1729002 13f79535-47bb-0310-9956-ffa450edef68
Static["org.ofbiz.base.util.UtilProperties"].getPropertyValue is used in several .ftl files.
Replaces with EnittyUtilProperties variant where appropriate.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1728959 13f79535-47bb-0310-9956-ffa450edef68
Error in trunk:
ERROR rendering error page [/error/error.jsp], but here is the error text: org.ofbiz.webapp.control.RequestHandlerException: No definition found for view with name [checkoutpayment]
Error in stable and old:
org.ofbiz.webapp.control.RequestHandlerException: No definition found for view with name [checkoutpayment]
Vyom Jain added a comment - 22/Nov/15 07:50
This is an issue even in 09.04 and 10.04 code, so it has been there for sometime now.
Scott Gray added a comment - 03/Jan/16 05:43
The view-map was moved to ecommerce in r544053. Probably because the view-map wasn't referenced in the controller.xml for ordermgr. It is actually used though as a view override in component://order/webapp/ordermgr/entry/checkoutoptions.ftl
Just needs to be restored in the controller and have the screen moved back.
jleroux: So I moved back from ecommerce to order (with few adaptations)
* the checkoutpayment.ftl file
* the order controller view-map
* the screen name checkoutpayment
I tested in both order and ecommerce, works! I will try to backport, let's see...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1726828 13f79535-47bb-0310-9956-ffa450edef68
If you enable Layered Navigation in the ecommerce (via CatalogScreens.xml) the Sub-Category and color filter links have no closing </a> tag.
jleroux: I had also to change LayeredNavigation.groovy
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1724566 13f79535-47bb-0310-9956-ffa450edef68
====================================================================
Small typo in ecommerce productdetail.ftl would prevent similar products by feature from rendering if the related functionality is enabled in ProductDetailgroovy.
<#if comsmonFeatureResultIds?has_content>
should read
<#if commonFeatureResultIds?has_content>
Introduced in markup refactor 816465
====================================================================
Thanks Jason Reast-Jones for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1724402 13f79535-47bb-0310-9956-ffa450edef68
============================================================ HTML clean up for editShoppingList.ftl.
============================================================
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1721092 13f79535-47bb-0310-9956-ffa450edef68
freemarker.core.InvalidReferenceException: The following has evaluated to null or missing:
==> lastContent.description [in template "component://ecommerce/webapp/ecommerce/content/viewcontent.ftl" at line 38, column 38]
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1721067 13f79535-47bb-0310-9956-ffa450edef68
================================
There are three sets of dimensions in the Product entity.
(productHeight, shippingHeight), (productWidth, shippingWidth), (productDepth, shippingDepth) but in case of weight, there is another set of dimension field weight and productWeight which are inconsistent in nature.
Fix this thing and correct all instances of this in the framework.
=================================
Thanks Suraj for reporting the issue and providing the patch for the same. Thanks Jacopo and Pierre for discussing the issue with Suraj.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1720900 13f79535-47bb-0310-9956-ffa450edef68
jleroux: This initially was my error in r1705417, So I simply reverted the change in r1715536 done for OFBIZ-6742 and also reverted r1705417 in this file. I will check other changes done in r1705417
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1715573 13f79535-47bb-0310-9956-ffa450edef68
============================================================
- Added session cookies config for ecommerce,ecomseo and ecomclone web.xml.
- Used web-app 3.0 version for web-app
- Re-arrange description and display-name attribute as per the web-app structure.
Thanks Rahul for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1715506 13f79535-47bb-0310-9956-ffa450edef68
As explained in OFBIZ-6669 last comments, contrary to what I did in ContentWorker class, when I before did the work on *ContentWrapper classes I did not use the sanitizer but only an encoder (either HTML or URL).
Because I wrongly supposed that only plain text was used there and certainly my lazy mind thought it was easier because of the URL encoderType to also handle.
When the encoderType is HTML, we now use the sanitizer in *ContentWrapper classes, and ContentWorker.java has also been adapted.
For that I enhanced the UtilCodec class. The sanitizer is only used when HTML is requested, else the sanitize() method simply calls the encode() method.
I removed the content.sanitize property in content.properties and added a sanitizer.permissive.policy property in the new owasp.properties (in base config) with some explanations. This allows for more configuration.
I changed the line 85 in productsummary.ftl to use an HTML content wrapper, same in minilastviewedcategories.ftl.
To be totally complete, we should change *lines like* in productsummary.ftl line 85 to use an HTML content wrapper.
Not easy to spot but anyway those not done will simply not totally show well, without any security impacts.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1713634 13f79535-47bb-0310-9956-ffa450edef68
I missed this hidden ProductConfigItemContentWrapper class while working on r1705329 and sequels. I checked there are no other *ContentWrapper classes left now.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1707857 13f79535-47bb-0310-9956-ffa450edef68