(OFBIZ-9167)
-go to https://localhost:8443/ordermgr/control/orderentry
-create order for DemoCustomer
-add an item
console output...
java.lang.NullPointerException
at org.apache.ofbiz.content.content.ContentWorker.
renderContentAsText(ContentWorker.java:368) ~[ofbiz.jar:?]
[...]
While at it I also found issues with cartLine.getName() in ftl files. It was
also missing the dispatcher.
This was broken by OFBIZ-9164
Thanks: Wai
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1778889 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-4106)
As explained on dev ML, I prefers to remove the possibility of creating "Tax
Identifications and Exemptions". Because users would actually need to have the
ACCOUNTING_CREATE or ACCOUNTING_ADMIN permissions to do so (or higher admin
permissions) and opening the accounting (or total) admin right to a customer
seems not secure to me.
Moreover the same exists in party and it needs admin rights in both places,
so does not make sense in ecommerce IMO.
Sharan : The only case I can think of is that a customer may want to manage
their own tax info. For example if I know my VAT number or Tax number
- do I add it to my profile, or do I have to wait for it be verified and
completed by the accounting administrator?
Generally I think companies would want an accounting administrator to take
control of this type of tax and exemption information (rather than leave it up
to the customer themselves) as they will need to be responsible for it
and report on it to their tax authorities so they need to make sure it is correct.
Thanks: Michał Cukierman for report and Sharan for functional confirmation
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1764158 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8348)
This was previously fixed with r1763686 by Pawan Verma which was correct.
But Scott reported on dev ML that he was surprised by this bare solution.
We could have kept it because it's js and works, but since we use jQuery and
for consistencey reason Amardeep suggested to rather
$('#selectShoppingList').submit()
This reverts r1763686 and applies Amardeep's solution.
It also removes pending work related with OFBIZ-4106. I have asked a question
about it yesterday and forgot to remove the related change in this unrelated
commit.
Thanks: Scott for report, Amardeep for patch
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1763754 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8265)
The layout of screen "order status" of application "ecommerce" is busted .
I save the html of the screen into my local file, and It works fine. I don't know the reason exactly, but the patch attached by me works correctly.
jleroux: after review I agree it's the right way to fix it. OrderStatus.ftl indirectly calls OrderItems.ftl through the orderitems screen so nothing is lost when the addCommonToCartForm is moved from OrderStatus.ftl to OrderItems.ft, it's only a rearrangement which fixes the issue.
Thanks: fumiyoshi.to
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761431 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8265)
Reverts r1761305, after testing more I found you can no longer submit an order. I have an idea of the problem but I prefer to revert all for now
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761308 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8265)
The layout of screen "order status" of application "ecommerce" is busted .
I save the html of the screen into my local file, and It works fine.
I don't know the reason exactly, but the patch attached by me works correctly.
jleroux: after a quick check it seems this does not introduce regression
Thanks: fumiyoshi.to
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761305 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-7758)
I am running on trunk rev 1751489 on tomahawk theme.
In the browser, right-click and view the page source.
There is duplicate linking of jquery.jgrowl.min.css i.e.
<link rel="stylesheet" href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css" type="text/css"/>
The solution is to remove a hack for JPublish in fex Java classes
and related changes (mostly "page." in ftl and xml files)
Thanks: Rohit Koushal for the path and James Yong the report
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761235 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-7931)
Removed inline js for toggleAll, checkToggle and selectAll calling from ftls in Ecommerce and Ebay component. Add class="selectAll" on parent checkbox element for select all functionality.
Thanks: Amardeep Singh Jhajj for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761195 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-7949)
For improved FTL code readability. Here is the first patch for the effort. There are still files which are required to be formatted.
Thanks: Vaibhav Jain for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761135 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8231)
When I access url https://localhost:8443/ecommerce/control/viewprofile for my profile, State/Province display in addresses shows the geo-id, which is fine for US entities where the GeoID is the state code, but for non-us entities, the GeoID is often something like CountryCode-StateCode, which isn't very nice.
Thanks: fumiyoshi.to for report and patch
jleroux: I have slightly changed the patch for 2 reasons:
* check for null exceptions
* use not deprecated version of getRelatedOne()
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1760406 13f79535-47bb-0310-9956-ffa450edef68
1) Removed 'maincss.css' entry from 'allowedPaths' param of from web.xml
Reason: Since, there is no file like 'maincss.css' exist under any includes directory.
2) Removed the unused references of maincss.css from FTLs, code
<link rel="stylesheet" href="${StringUtil.wrapString(baseUrl!)}/images/maincss.css" type="text/css"/>
has been removed.
Reason: This is an interesting thing, these FTLs were using the maincss.css located under the images directory.
When I look the history of these files, following were my findings,
The 'maincss.css' file under the 'images' directory exist in release4.0
http://svn.apache.org/repos/asf/ofbiz/branches/release4.0/framework/images/webapp/images/
after this release, this files no longer exist there.
3) Also, I have updated one file 'InventoryNoticeEmail.ftl' and used the basic HTML code to style, instead of using style defined in 'maincss.css' which were exist in release-4.0
4) Updated some references from 'maincss.css' to style.css in comments.
5) Also removed the entry of including '/images/maincss.css' and '/images/mainrtl.css' in SimpleDecorator
Since, these files no longer exist after release-4.0.
Thanks Wai for reviewing the work and thanks Swapnil M Mane for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1758389 13f79535-47bb-0310-9956-ffa450edef68
We are getting same console error on following two screens.
Steps to regenerate:
1) Go to eCommerce
2) Click on Register link
3) After click on register link, we can see error on console.
1) Now click on profile link
2) Click on create new contact information link
3) select "postal address" contact type and click on create button
4) After click on create button, we can see error on console.
Console Error:
Error executing FreeMarker template
[java] freemarker.template.TemplateModelException: No error description was specified for this error; low-level message: java.lang.ClassNotFoundException: org.ofbiz.base.util.EntityUtilProperties
[java]
[java] ----
[java] FTL stack trace ("~" means nesting-related):
[java] - Failed at: #assign defaultCountryGeoId = Static[... [in template "component://ecommerce/template/customer/EditContactMech.ftl" at line 185, column 13]
[java] ----
[java] at freemarker.ext.beans.ClassBasedModelFactory.get(ClassBasedModelFactory.java:52) ~[freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.DynamicKeyName.dealWithStringKey(DynamicKeyName.java:140) ~[freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.DynamicKeyName._eval(DynamicKeyName.java:75) ~[freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.Expression.eval(Expression.java:81) ~[freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.Dot._eval(Dot.java:41) ~[freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.Expression.eval(Expression.java:81) ~[freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.MethodCall._eval(MethodCall.java:58) ~[freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.Expression.eval(Expression.java:81) ~[freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.Assignment.accept(Assignment.java:134) ~[freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.Environment.visit(Environment.java:326) [freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.Environment.visit(Environment.java:332) [freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.Environment.visit(Environment.java:332) [freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.Environment.visit(Environment.java:332) [freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.Environment.visit(Environment.java:332) [freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.Environment.visit(Environment.java:332) [freemarker-2.3.24.jar:2.3.24]
[java] at freemarker.core.Environment.process(Environment.java:305) [freemarker-2.3.24.jar:2.3.24]
[java] at org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:261)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1748286 13f79535-47bb-0310-9956-ffa450edef68