Commit Graph
39 Commits
Author SHA1 Message Date
Jacques Le Roux bd45c34532 Fixed: Remove the birt.tld file and all related files and lines
(OFBIZ-OFBIZ-9323)

As explained in the Jira, for legal reasons we need to remove the Birt Web 
Viewer from OFBiz



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1792432 13f79535-47bb-0310-9956-ffa450edef68
2017-04-24 07:51:47 +00:00
Jacques Le Roux f0b890ce60 No functional change, removes empty useless lines
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791575 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 07:32:40 +00:00
Jacques Le Roux b3485c4520 No functional change, only removes trailing blanks
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791574 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 07:31:50 +00:00
Jacques Le Roux 58f0a1ed2a No functional change, same than r1788752
I decided to sort the flexible report export formats on the enumCode 
(ie alphabetically) rather than using sequenceId which did not make much sense



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791406 13f79535-47bb-0310-9956-ffa450edef68
2017-04-14 20:20:34 +00:00
Jacques Le Roux 4e9ddccde9 Fixed: The help button or link does not show for the Birt, BI and example
components
(OFBIZ-9311)

Pricat was also concerned. Unlike hhfacility, I see no reasons why these 
components would use the GlobalDecorator instead of the ApplicationDecorator
(the ApplicationDecorator embeds the GlobalDecorator)

OFBIZ-9312 is a duplicate of this


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791116 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 12:58:38 +00:00
Jacques Le Roux 1bf24662a1 Documented: Complete Birt Flexible Reports documentation
(OFBIZ-9188)

Replaces hardcoded strings in main Birt screen with labels


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791111 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 11:35:24 +00:00
Jacques Le Roux 901c3418b4 No functional change, clarifies access to "OFBiz Flexible Reports"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790538 13f79535-47bb-0310-9956-ffa450edef68
2017-04-07 11:52:16 +00:00
Jacques Le Roux a078b4bcc5 No functional change
Improves help on top of Birt main screen. 
Includes a link to the "OFBiz Flexible Reports" documentation in wiki

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790537 13f79535-47bb-0310-9956-ffa450edef68
2017-04-07 11:50:08 +00:00
Jacques Le Roux 277c25f48a No functional changes
I decided to sort the flexible report export formats on the enumCode 
(ie alphabetically) rather than using sequenceId which did not make much sense
Also fixes a typo in a French error label


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1788752 13f79535-47bb-0310-9956-ffa450edef68
2017-03-26 16:50:42 +00:00
Jacques Le Roux 7ab621a5e3 Improved: Improvement: warn users about sending a flexible report before having
published it
(OFBIZ-9284)

When you create a Flexible Report you get to the EditFlexibleReport screen. 
There is a Preview panel with a Send button. If you send before having 
1) downloaded the file,
2) conveniently edited it in Birt Report Designer
3)  and then uploaded it, 
you get an error which is embarrassing and difficult to avoid 
programmatically. 

I decided to warn users, when necessary (ie when the report is not published) 
at the UI level. This completes OFBIZ-9194



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1788750 13f79535-47bb-0310-9956-ffa450edef68
2017-03-26 16:47:07 +00:00
Jacques Le Roux 78c8440166 No functional changes, fixes a typo in a comment
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1788253 13f79535-47bb-0310-9956-ffa450edef68
2017-03-23 14:16:53 +00:00
Jacques Le Roux fc3e1db4f6 No functional changes
At http://markmail.org/message/ffmyw773p65fndey I wrote:

I'd like to follow the suggestion I made in the last message of the linked 
thread.
In other words, use
http://subversion.apache.org/docs/release-notes/1.8.html#repos-dictated-config
http://blogs.collab.net/subversion/the-road-to-repository-dictated-configuration-day-2-autoprops
Then this problem would be over. No longer need to check from time to time that
concerned files, have svn:eol-style=native property set
This imply that all OFBiz users use svn > 1.7, but we can inform them, et voilà

Then at markmail.org/message/h3q2yvj4db544ro7 I wrote:

Actually, since we get new committers now and then and their are able to create
new files I have a warning every 6 months which says "Check Java 
files, have all svn:eol-style=native" (I totally forgot that because I assume
the machine knows it and warns me ;))
I could extend that to all files (at least the most prominent types), I'll
see...

This does what the last sentence said for Groovy, XML and few new Birt 
Java files.

I'll see if I can implement the svn 1.8 repos-dictated-config ASAP!




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781219 13f79535-47bb-0310-9956-ffa450edef68
2017-02-01 10:58:46 +00:00
Jacques Le Roux 0c35ddda50 No functional changes
Adds a missing BirtOverrideFilters label
Fixes a typo in BirtServices.java and organise imports
Change a button name in BirtForms.xml
Uses the BirtOverrideFilters label in BirtScreens.xml

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781215 13f79535-47bb-0310-9956-ffa450edef68
2017-02-01 10:23:44 +00:00
Nicolas Malin 492772b40a Implemented: Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation. (OFBIZ-6919)
The concept, you define a report domain related to an entity or a service through a master content (master report) and a master search form.
When a high level user create a report on a configured domain, OFBiz prepare an instantiation of the master content (flexible report) that permit
to surcharge the search form (recorded dynamically on the content as ElectronicText) and prepare a rptDesign skeleton.
The high level user can download the rptDesign to edit it trhough the birt editor, with all fields that ofbiz will be load as dataset and when is finish upload the result on the content instantiation.
For the end user, he selected the instantiation report, OFBiz display the report search from the content instantiation and the submission call birt with the search parameters and the linked rptDesign.

The rptDesign file is drive by OFBiz to build the data set by two methods :
 * call the performFind if the domain is related to an entity
 * call the a custom service if the domain is related to a service.
For the last case we need two services, a first who prepare and list available fields for search and display. And a second who realize the search.
By convention currently the first service as the same name that the second service suffixed by 'PrepareFields'

This commit contains :
 * useful UI to create a new content instance from a master content. List, edit, remove a content instance and a simple drop-down to list all instance published (ready to use by end user)
 * all services (with the work flexibleReport) to manage a flexible report, prepare the rptDesign skeleton, reanalyze the rptDesign uploaded, prepare the search form
 * Services interface to define you own search custom method
 * Two examples, one on the entity Exemple and one with the service flexibleReportTurnOver. Warning ! there are raw example without a beautiful rptDesign so you need to update the rptDesign with the birt editor to display something.
Thanks: François Wurmser for initialize this improvement, Jacques and Gil for their time to analyze, document and refactor the code


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1780683 13f79535-47bb-0310-9956-ffa450edef68
2017-01-28 13:22:55 +00:00
Deepak Dixit 15bc40e491 Reverted: Minilang code readability and consistency improvements done at r#1768222, this commit reversed key and description of drop-down in the code.
(OFBIZ-9114)

Thanks  Wei Zhang for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1772880 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 12:37:42 +00:00
Divesh Dutta a4567c2486 Improvement: Minilang code readability and consistency improvements.
(OFBIZ-8929) (OFBIZ-8930) (OFBIZ-8953) (OFBIZ-8965) (OFBIZ-8972) (OFBIZ-8986) (OFBIZ-8991) 

Thanks: Ankush Upadhyay, Anuj Jain, Abhijeet for your patches. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1768222 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:34:00 +00:00
Divesh Dutta 77af05bc8e Improvement: Miniland code readability and consistency improvements
(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) 

Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1768219 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:14:04 +00:00
Divesh Dutta 3a17676024 Improvement: Minilang code readibility and conistency improvements
(OFBIZ-8445) (OFBIZ-8447) (OFBIZ-8448) (OFBIZ-8450) ( OFBIZ-8451) (OFBIZ-8653) (OFBIZ-8740) (OFBIZ-8741) (OFBIZ-8742) (OFBIZ-8743)

Thanks: Devanshu Vyas, Anuj Jain, Sega Patidar, Abhijeet Ashapure for your patches

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1768209 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 12:41:35 +00:00
Jacques Le Roux dcdf708d95 Fixes: Net Before Overhead Report is not working
(OFBIZ-7317)

Here is the patch that removes the NBO(Net Before Overhead) report from the 
trunk. In the patch I have also removed the Demo data which is required by this 
report only.

Note : Please remove below data from existing database to avoid any data 
related problem in OrderPortletData.xml

<PortalPortlet portalPortletId="NBO_Report"
   portletName="Net Before Overhead Report"
   screenName="NetBeforeOverheadReport"
   screenLocation="component://birt/widget/order/OrderScreens.xml"
   description=""/>
<PortletPortletCategory portalPortletId="NBO_Report" portletCategoryId="REPORT"/>
<PortalPagePortlet portalPageId="OrderReportPage" portalPortletId="NBO_Report" 
portletSeqId="00001" columnSeqId="00002" sequenceNum="11"/>


Thanks: Rohit Koushal

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1763132 13f79535-47bb-0310-9956-ffa450edef68
2016-10-03 08:59:10 +00:00
Jacques Le Roux 3ee14fa3fa Fixes: Order By Referrer is not working
(OFBIZ-7318)

See
https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions
Section : Order By Referrer

Found out that in OrderByReferrer.rptdesign we tried to fetch nonexisting fields
like "visitId" and "initialReferrer" from SalesOrderItemFact which causing 
problem in this report. On rev #886743 SalesOrderItemFact extended with visitId 
and initialReferrer and on rev #1055774 these field has been removed.
So I think we need to clean references of visitId and initialReferrer from the 
report and if we removed these fields then report will not make any sense. 
So in my opinion it is better to remove this report from OFBIZ.

Thanks: Rohit Koushalfor report and patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761678 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 06:36:00 +00:00
Deepak Dixit 698e788fad (OFBIZ-7833) Applied patch from jira issue
================================
Redundant options at select filter on find screens
================================
Thanks Deepak N and Renuka for your contribution.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1758032 13f79535-47bb-0310-9956-ffa450edef68
2016-08-27 13:43:34 +00:00
Deepak Dixit 8f3141cd46 (OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752920 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 10:30:49 +00:00
Arun Patidar 798210fd15 Applied patch from jira issue - OFBIZ-7421 - Required client side validation on sending BIRT report by mail. Thanks Anurag Chandak for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1751037 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 08:38:37 +00:00
Jacques Le Roux 4deae05a38 Fixes a "typo" in last commit for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
We used targetNamespace (should only be used in schema) instead of xsi:schemaLocation



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1749634 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 05:58:26 +00:00
Jacques Le Roux a98ac13d9d Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1749489 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:37:47 +00:00
Jacques Le Roux b20816bfa8 Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 by replacing xsd files references in xml files by -ns.xsd files and removing the concerned xsd files
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1749488 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:14:16 +00:00
Deepak Dixit 8ef8f43c0f (OFBIZ-7229) Relocate .groovy files in the product component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1747774 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 18:46:51 +00:00
Deepak Dixit 67b3f23415 (OFBIZ-7273) Applied slightly modified patch from jira ticket
=======================================
Report "Sale Orders By Channel" is not rendering details
=======================================
Thanks Nameet Jain for your contirbution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1747642 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 06:54:06 +00:00
Deepak Dixit c4b52ebe5c (OFBIZ-6810) Removed some unused screen and ftl, found during ftl cleanup. I took extra care while removing these code this should not break anything.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1745500 13f79535-47bb-0310-9956-ffa450edef68
2016-05-25 15:05:50 +00:00
Deepak Dixit 2c25412d8e (OFBIZ-7021) Renamed remaining specialpurpose component ftl file name from lower camel case to upper camel case pattern.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1745115 13f79535-47bb-0310-9956-ffa450edef68
2016-05-23 06:59:04 +00:00
Deepak Dixit 8104342a53 (OFBIZ-6827) Apply patch from jira issue.
============================================================
relocate .ftl files in the specialpurpose/birt component
============================================================


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1737817 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 10:13:18 +00:00
Nicolas Malin 8995c4fd02 Cleaning forms code is needed after setting default-value in list-options and entity-options, patch related to OFBIZ-6524 and follows the resolution of OFBIZ-6490 and OFBIZ-6489. Thanks Gil Portenseigne for this effort
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1686674 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 21:58:05 +00:00
Jacques Le Roux 0d1b915012 A patch from Pierre Smits for "Have PDF reports in BIRT open in new windows" https://issues.apache.org/jira/browse/OFBIZ-6121
Currently the PDF reports open in the same browser window as OFBiz, reducing the user experience.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1663081 13f79535-47bb-0310-9956-ffa450edef68
2015-03-01 11:19:52 +00:00
Jacques Le Roux fa44ffd18d Fixes "Overview of routings does not paginate" https://issues.apache.org/jira/browse/OFBIZ-5322 and more
Actually it does paginate but the value is not dependent on widget property widget.form.defaultViewSize which default value is 20. It uses a default value of 50 which is defined by

<set field="viewSize" from-field="parameters.VIEW_SIZE" type="Integer" default-value="3"/>

You can easily test it using https://localhost:8443/manufacturing/control/FindRouting?VIEW_SIZE=3

This is legacy from pre Apache era. I found 143 cases where a default-value is defined in screens for VIEW_SIZE.

I did not look into details for the 143 cases but I believe most are also legacy.
There are few default values: 10, 20, 30, 50, 500 and even an extreme case of 10000 for InventoryItemTotalsExport!
There is only one comment for LookupBulkAddProducts which is also legacy: <!-- 10 rows seems more appropriate given screen size, etc. -->

I suggest to OOTB replace all those by the widget.form.defaultViewSize value.
Things will then be consistent and easily changeable on a global scale using the widget property.
Or if really needed forcing the default-value as it's done now.

So this would be applied on the 143 cases (I checked, viewSizeDefaultValue does not exist in any screen)

<property-to-field resource="widget" property="widget.form.defaultViewSize" field="viewSizeDefaultValue"/>
<set field="viewSize" from-field="parameters.VIEW_SIZE" type="Integer" default-value="${viewSizeDefaultValue}"/>

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1526387 13f79535-47bb-0310-9956-ffa450edef68
2013-09-26 05:55:32 +00:00
Jacques Le Roux 8362391c91 I18n of FacilityInventoryHistoryReport, I moved the labels from Product to birt application, they could have stayed there, but I preferred to have them in one place. We need to i18n the Birt reports also
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1522782 13f79535-47bb-0310-9956-ffa450edef68
2013-09-13 05:37:37 +00:00
Jacques Le Roux fe8d992996 For "Order Report Issue" https://issues.apache.org/jira/browse/OFBIZ-5297
The quickInitDataWarehouse BI button used these dates (set in BI main screen)

<set field="fromDate" value="2008-01-01 00:00:00.0" type="Timestamp"/>
<set field="thruDate" value="2010-01-01 00:00:00.0" type="Timestamp"/>

This generated 1000+ records. I set 10 years ahead (from sept. 2013) in a new bi.properties file used by the BI main screen. So it generates only 3000+ records (and others related in BI DB) which is still reasonable. A message, placed at the top of the Order Reports page, informs users that for 4 Birt reports s/he needs 1st to run the data warehouse init using the BI button. Also this message clarifies the range, to be certain that in 10 years people will still easily know what to change...

I have also replaced a lot of labels and added English and French translations (by-product: some labels cleaning in CommonUiLabels.xml)

I did not do the same for the accounting paymentReport and ViewFacilityInventoryHistoryReport facility Birt reports which only need translation. 
I noticed that there are no ways to get to ViewFacilityInventoryHistoryReport from UI though!

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1521589 13f79535-47bb-0310-9956-ffa450edef68
2013-09-10 19:08:29 +00:00
Jacques Le Roux 1ccee56b3c A patch from Parimal Gain for "Order Report Issue" https://issues.apache.org/jira/browse/OFBIZ-5297
Reports under Order component has following issues -
1. Following reports are not showing any records due some issue
   a. Last three month sales report.
   b. Sales report.
   c. Sales Order discount code report.
   d. Product demand report.
2. Inconsistency in opening the pdf report - some reports are opening in new tab window but some are in the same window.

Following are the checkpoint -
1) Order should be Approved
2) All Dimension table(CurrencyDimension, DateDimension, ProductDimension)should have record.
3) After approval of order, order record should be created in 'SalesOrderItemFact' table. These is the OLAP table used to display data in reports.

Description -
1) If dimension table doesn't have records then following services should execute from service engine -
a) loadAllProductsInProductDimension
b) loadCurrencyDimension
c) loadDateDimension
2) Calling service to create record in 'SalesOrderItemFact' is updated into patch. On commit operation of service 'changeOrderItemStatus' if order item is approved then 'loadSalesOrderFact' service called through SECAS.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1519544 13f79535-47bb-0310-9956-ffa450edef68
2013-09-03 03:29:45 +00:00
Jacques Le Roux 1aac3779a4 Fixes https://issues.apache.org/jira/browse/OFBIZ-5272 "Sales by Store report generates an error"
jleroux: I vaguely remember a change related to ignore-if-null and ignore-if-empty. Anyway replacing ignore-if-null by ignore-if-empty does the trick, which makes sense

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1512573 13f79535-47bb-0310-9956-ffa450edef68
2013-08-10 07:46:55 +00:00
Jacopo Cappellato 6f42787e73 Moved the "birt" component out of framework to specialpurpose; moved all the birt reports from the applications to the birt component itself, where the application webapps are overriden to inject the reports; the end result is the same but since all these birt reports are simply a proof of concepts that cannot be used in production (for example they use hardcoded userlogin for authentication) the birt component should be probably disabled by default (but this will be discussed in the dev list).
Now it will be very easy to extract the birt component (for OFBiz Extras) or to disable it when deploying to production or when interested in sparing some hardware resources. I did some cursory tests but since the work has been challenging and rather complex I would appreciate testing help and also reviews to finds chunks of code that I could have missed and that could be moved out as well.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1361130 13f79535-47bb-0310-9956-ffa450edef68
2012-07-13 09:48:32 +00:00