(OFBIZ-9383)
The BIRT demo data for flexible reports depends on the Example entity from the
Example plugin.
We should either provide BIRT's own example data with example reports OR
setup a gradle dependency on the example plugin so that everything is in place.
jleroux: I did not like to duplicate the example data in birt or an alike
solution.
So I put a gradle dependency on the example plugin.
If the example plugin misses the birt component can't build.
I put some comments to explain the possible issue and its solution out of
demonstration.
Thanks: Michael Brohl for report
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1799699 13f79535-47bb-0310-9956-ffa450edef68
components
(OFBIZ-9311)
Pricat was also concerned. Unlike hhfacility, I see no reasons why these
components would use the GlobalDecorator instead of the ApplicationDecorator
(the ApplicationDecorator embeds the GlobalDecorator)
OFBIZ-9312 is a duplicate of this
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791116 13f79535-47bb-0310-9956-ffa450edef68
BirtServices.java
Formatting
Few better comments and some TODOs
Replaces e.printStackTrace() by Debug.logError().
Adds few missing Debug.logError()
Adds return ServiceUtil.returnError()
Improves an EntityListIterator closing not done, using try-with-ressources
Not a funct. change, EntityListIterator.finalyse() catches anyway
Replaces return ServiceUtil.returnError(e.getMessage()) by more explicit
messages. Not needs to clutter the UI.
Uses multi-catches when applicable
BirtUtil.java
Formatting
Note: the Birt.properties file does not exist OOTB but can be added for
convenience, like using the location where you edit with the
Birt Report Designer...
ReportDesignGenerator.java
Formatting
Removes useless and confusing try and re-thrown exceptions. This allows to
fix possible other issues
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790547 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9192)
This fixes an issue I put in while removing partyName.
The couple ("Customer", "Customer name") should also have been removed
While at it I formatted to make things more legible
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790501 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9192)
Jacopo reported an issue on dev ML on the Party view profile
The InvoiceItemProductAndParty view use a partyName from the Party
entity, but there is no partyName in the Party.
I simply commented out this line in the view definition.
PartyNameView could be used later there.
I also fixed partyName in BirtMasterReportServices class,
formatted it and used Debug.logError instead of printStackTrace()
Thanks: Jacopo for report
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790499 13f79535-47bb-0310-9956-ffa450edef68
(LEGAL-296)
This has been discussed in the OFBiz project and we preferred to ask legal
before taking a definitive decision.
We read at http://www.apache.org/legal/resolved.html#category-b
For small amounts of source that is directly consumed by the ASF product at
runtime in source form, and for which that source is unmodified and unlikely
to be changed anyway (say, by virtue of being specified by a standard),
inclusion of appropriately labeled source is also permitted. An example of
this is the web-facesconfig_1_0.dtd, whose inclusion is mandated by the JSR
127: JavaServer Faces specification
The question was:
Can the files under folders birt/webapp/birt/webcontent/birt, all licensed
under https://www.eclipse.org/legal/epl-v10.html be included in source form,
without modifications, in an Apache (source) release? It's 160 files and
541 523 bytes at all.
Thanks: Marvin Humphrey for legal advice (the answer is NO)
So this removes the birt/webcontent folder. The related page in wiki has also
been removed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1790442 13f79535-47bb-0310-9956-ffa450edef68
<<No functional changes.
Fixes some unchecked casts by using UtilMisc.toMap
Adds some @SuppressWarnings("unchecked")
Adds few @SuppressWarnings("unused")
Cleans imports
Completes and fixes Javadoc in BirtUtil class>>
Er, of course you can't fix unchecked casts by using UtilMisc.toMap, I intended
to use UtilGenerics.checkMap and got mislead by Eclipse which also hides
unchecked casts warnings when you use UtilMisc.toMap
Then all derailed and I put some @SuppressWarnings("unchecked") to hide warning
on List unchecked casts :/
The rest was correct but a
private GenericValue userLogin;
in ReportDesignGenerator which is really useless
There are still no functional changes but some amended comments (French)
and added TODO
I note that the translated TODO needs a re-visit, smell like factoring is needed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1789381 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9192)
It was a long time I did not revisit this issue. I no longer stumbled upon
issues I reported before in the Jira but found that 2 entities were missing.
I was an easy fix: the ServiceReportsView.xml was missing
Thanks: To Nicolas who in the meantime certainly committed fixes for the other
issues I reported in the Jira
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1789159 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9188)
This is the technical documentation about the Flexible Reports.
It's done with Markdown files with links to Confluence for images
Also the HTML version soon used in the wiki
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1788911 13f79535-47bb-0310-9956-ffa450edef68
Fixes some unchecked casts by using UtilMisc.toMap
Adds some @SuppressWarnings("unchecked")
Adds few @SuppressWarnings("unused")
Cleans imports
Completes and fixes Javadoc in BirtUtil class
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1788869 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9188)
Complete the documentation about the Flexible Reports. Here are the HTML
versions to be used in the "Birt Flexible Reports" wiki page.
Also with an link in "Creating reports.md" to
"Using the Birt Report Designer.md.html"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1788759 13f79535-47bb-0310-9956-ffa450edef68
I decided to sort the flexible report export formats on the enumCode
(ie alphabetically) rather than using sequenceId which did not make much sense
Also fixes a typo in a French error label
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1788752 13f79535-47bb-0310-9956-ffa450edef68
published it
(OFBIZ-9284)
When you create a Flexible Report you get to the EditFlexibleReport screen.
There is a Preview panel with a Send button. If you send before having
1) downloaded the file,
2) conveniently edited it in Birt Report Designer
3) and then uploaded it,
you get an error which is embarrassing and difficult to avoid
programmatically.
I decided to warn users, when necessary (ie when the report is not published)
at the UI level. This completes OFBIZ-9194
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1788750 13f79535-47bb-0310-9956-ffa450edef68
need to do other actions
(OFBIZ-9194)
The solution I provided with revision: 1781218 was wrong. A really satisfying
solution would be to gray the "Send" button on the
birt/control/CreateFlexibleReport page. But that's not something easy to do
because it's generated from a content.
So I decided to remove the part in the PrepareBirtCall.groovy and add an
indication in the BirtErrorNotPublishedReport for users to use their browser
back button. Because you catch a ViewHandlerException in
RequestHandler.renderView() and there is not much you can do at this stage...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1788020 13f79535-47bb-0310-9956-ffa450edef68
Currently the class BirtContainer call the birt engine with hard coded log level ALL that generated huge log file.
We can't implement easily log4j on the birt engine so with this commit I create a quick fix to have matching between the java.util.Logger and org.apache.log4j.Logger level.
You can select the log level from debug.properties to populate the ReportEngine log file.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1782070 13f79535-47bb-0310-9956-ffa450edef68
completes r1781219 by putting svn:eol-style=native to all file types declared
in [auto-props] section of the svn config files.css
Actually this is only a 1st pass, it was too complicated to do it for
all file types at once only concerned here
*.java;*.bsh;*.groovy;*.jsp;*.tld;*.ftl;*.js;*.sql;*.c;*.cpp;*.h;*.txt;*.sgml;
*.properties;*.xml;.classpath;.project;*.sld;*.gml;*.xsl;*.xsd
*.html;*.htm;*.css;*.md;README;NOTICE;LICENSE;rc.ofbiz.*;*.less;*.dsp;*.dsw
Most files should not be concerned by this change, but it's impossible to do
it one by one.
There are also changes in files with have mixed EOLs; because this has no sense
when using native which automatically resolves this issue
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781731 13f79535-47bb-0310-9956-ffa450edef68
At http://markmail.org/message/ffmyw773p65fndey I wrote:
I'd like to follow the suggestion I made in the last message of the linked
thread.
In other words, use
http://subversion.apache.org/docs/release-notes/1.8.html#repos-dictated-confighttp://blogs.collab.net/subversion/the-road-to-repository-dictated-configuration-day-2-autoprops
Then this problem would be over. No longer need to check from time to time that
concerned files, have svn:eol-style=native property set
This imply that all OFBiz users use svn > 1.7, but we can inform them, et voilà
Then at markmail.org/message/h3q2yvj4db544ro7 I wrote:
Actually, since we get new committers now and then and their are able to create
new files I have a warning every 6 months which says "Check Java
files, have all svn:eol-style=native" (I totally forgot that because I assume
the machine knows it and warns me ;))
I could extend that to all files (at least the most prominent types), I'll
see...
This does what the last sentence said for Groovy, XML and few new Birt
Java files.
I'll see if I can implement the svn 1.8 repos-dictated-config ASAP!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781219 13f79535-47bb-0310-9956-ffa450edef68
to do other actions
(OFBIZ-9194)
You need to add the data set fields with the Birt Report Designer
and publish the report. This will be documented with OFBIZ-9188
I thought about graying the button but it was a delicate matter because it uses
a <content element in screen and directly call a view handled from a Groovy
event.
It was easier to fix the PrepareBirtCall Groovy event. But to be totally sure
I also handled the possible NPE in the BirtViewHandler
I also fixed viewLast error in controller
Because the files were not committed with the svn:eol-style native property
you will see false changes in this commit. Some files have their svn:eol-style
native property set. I'll soon commit missing so in new Birt Java files.
I'll also commit a lot of svn:eol-style native property changes for XML and
Groovy files which have been neglected so far. I'm sorry for that because
when we do so we loose the annotations history. I will then definitely put in
place what I suggested in http://markmail.org/message/ffmyw773p65fndey
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781218 13f79535-47bb-0310-9956-ffa450edef68
Adds a missing BirtOverrideFilters label
Fixes a typo in BirtServices.java and organise imports
Change a button name in BirtForms.xml
Uses the BirtOverrideFilters label in BirtScreens.xml
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781215 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9192)
The Birt Report Builder can also use services. for now only the "rotation"
report as been provided. We can provide more examples based on François'
work.
Here are trivial changes
fixes missing Lookup maps and view in controller for the "rotation" report
new needed labels
typos fixed
Thanks:
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781084 13f79535-47bb-0310-9956-ffa450edef68
The code came from a project under ofbiz 13.07 and is still using deprecated delegator.find calls, so I converted them to EntityQuery
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1780800 13f79535-47bb-0310-9956-ffa450edef68
The concept, you define a report domain related to an entity or a service through a master content (master report) and a master search form.
When a high level user create a report on a configured domain, OFBiz prepare an instantiation of the master content (flexible report) that permit
to surcharge the search form (recorded dynamically on the content as ElectronicText) and prepare a rptDesign skeleton.
The high level user can download the rptDesign to edit it trhough the birt editor, with all fields that ofbiz will be load as dataset and when is finish upload the result on the content instantiation.
For the end user, he selected the instantiation report, OFBiz display the report search from the content instantiation and the submission call birt with the search parameters and the linked rptDesign.
The rptDesign file is drive by OFBiz to build the data set by two methods :
* call the performFind if the domain is related to an entity
* call the a custom service if the domain is related to a service.
For the last case we need two services, a first who prepare and list available fields for search and display. And a second who realize the search.
By convention currently the first service as the same name that the second service suffixed by 'PrepareFields'
This commit contains :
* useful UI to create a new content instance from a master content. List, edit, remove a content instance and a simple drop-down to list all instance published (ready to use by end user)
* all services (with the work flexibleReport) to manage a flexible report, prepare the rptDesign skeleton, reanalyze the rptDesign uploaded, prepare the search form
* Services interface to define you own search custom method
* Two examples, one on the entity Exemple and one with the service flexibleReportTurnOver. Warning ! there are raw example without a beautiful rptDesign so you need to update the rptDesign with the birt editor to display something.
Thanks: François Wurmser for initialize this improvement, Jacques and Gil for their time to analyze, document and refactor the code
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1780683 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9023) (OFBIZ-9026)(OFBIZ-9027)(OFBIZ-9032)(OFBIZ-9034)(OFBIZ-9036)(OFBIZ-9030)
Thanks: Divesh Dutta, Amit Gadaley and Shubham Agrawal for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1768189 13f79535-47bb-0310-9956-ffa450edef68