Commit Graph
35 Commits
Author SHA1 Message Date
Jacques Le Roux 78bc570ac8 Reverted: "Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)"
This reverts commit 17eb2e4cf7bfba4e6a6b62117aa8d64cd5774c5e.

It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!

Thanks: James for report
2020-12-18 11:04:16 +01:00
Jacques Le Roux 4d34c9d43f Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)
Same for sub-hyperlink, forgot the plugins with 17eb2e4cf7bfba4e6a6b62117aa8d64cd5774c5e
2020-12-15 09:16:40 +01:00
Jacques Le Roux 4bf7288f24 Improved: use a label for "uploadedFile" in form widgets
ie
<field name="uploadedFile" title="${uiLabelMap.ContentFile}">
instead of only
<field name="uploadedFile">
2020-12-08 17:17:52 +01:00
Jacques Le Roux 77219598cc Fixed: Fix references where Mime type is displayed in HTML encoded pattern
(OFBIZ-9644)

I found various instances where the mimeTypeId is displayed in HTML 
encoded pattern over UI.

jleroux: this also removes 2 duplicated fields in AddLayout form

Thanks: Ankit Joshi

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1806951 13f79535-47bb-0310-9956-ffa450edef68
2017-09-01 12:49:04 +00:00
Jacques Le Roux c1728ab741 Reverts revision: 1806947, changes in UserEvents.xml inadvertently slipped in
Double revert and commit, the joy of separated plugins...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1806949 13f79535-47bb-0310-9956-ffa450edef68
2017-09-01 12:48:10 +00:00
Jacques Le Roux ec483599c7 Fixed: Fix references where Mime type is displayed in HTML encoded pattern
(OFBIZ-9644)

I found various instances where the mimeTypeId is displayed in HTML 
encoded pattern over UI.

jleroux: this also removes 2 duplicated fields in AddLayout form

Thanks: Ankit Joshi

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1806947 13f79535-47bb-0310-9956-ffa450edef68
2017-09-01 12:38:47 +00:00
Deepak Dixit 15bc40e491 Reverted: Minilang code readability and consistency improvements done at r#1768222, this commit reversed key and description of drop-down in the code.
(OFBIZ-9114)

Thanks  Wei Zhang for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1772880 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 12:37:42 +00:00
Divesh Dutta a4567c2486 Improvement: Minilang code readability and consistency improvements.
(OFBIZ-8929) (OFBIZ-8930) (OFBIZ-8953) (OFBIZ-8965) (OFBIZ-8972) (OFBIZ-8986) (OFBIZ-8991) 

Thanks: Ankush Upadhyay, Anuj Jain, Abhijeet for your patches. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1768222 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:34:00 +00:00
Divesh Dutta 77af05bc8e Improvement: Miniland code readability and consistency improvements
(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) 

Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1768219 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:14:04 +00:00
Michael Brohl 479115f0bd Improved: Scrum: Consistent form name.
(OFBIZ-8108)

Change all form names to upper camel case for consistency.

Thanks: Tanmay Muley for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761111 13f79535-47bb-0310-9956-ffa450edef68
2016-09-16 22:45:08 +00:00
Jacques Le Roux 4417afdfd3 An improving patch from Florian Montalbano for "Scrum find Total Backlog Item is not working in non-English language" https://issues.apache.org/jira/browse/OFBIZ-7929
I put it all in this new version of the patch :
    Changed UtilValidate test to Groovy Truth test on string
    Changed the big first test by a test on "noConditionFind"
    Added some comments
    Harmonization of the "if tests"
    Removed the uiLabelMap.CommonAny in the file (the two others belonged to another form --> "FindTotalBacklog")
    Added a "noConditionFind" field to this form --> "FindTotalBacklog"

jleroux: I removed all remaining tabs in FindProductBacklogItem.groovy

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1754656 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 12:13:03 +00:00
Jacques Le Roux 8e3d7dfaef A patch from Florian Montalbano for "Scrum find Total Backlog Item is not working in non-English language" https://issues.apache.org/jira/browse/OFBIZ-7929
The Find form for Product Backlog Item does not work in language other than English when no "statusId" or "custRequestTypeId" are selected.

Step to reproduce :
- Go to the Scrum component and select a product
- Go to the "Total Backlog" tab
or use this link : https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1

- Hit the search button, the find action is performed and return a non-empty list.
- Set your language preference to a non english language (french for example). 
- Click again on the "Total Backlog" tab, and hit the  "Rechercher" button.
- No results are found.

Where does the problem come from ?
The results displayed are from a list named "backlogList" which is built in the following script : FindProductBacklogItem.groovy .
In this script, there were a check on the parameter "custRequestTypeId" and on the parameter "statusId".
But the value was hardcoded :

if("Any".equals(parameters.custRequestTypeId))
and
if(!"Any".equals(parameters.statusId))

Obviously, when the form is in another language than English, those conditions aren't valid anymore (for example, "Any" is "Don't" in French")

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1754051 13f79535-47bb-0310-9956-ffa450edef68
2016-07-25 21:38:11 +00:00
Jacques Le Roux 4deae05a38 Fixes a "typo" in last commit for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
We used targetNamespace (should only be used in schema) instead of xsi:schemaLocation



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1749634 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 05:58:26 +00:00
Jacques Le Roux a98ac13d9d Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1749489 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:37:47 +00:00
Jacques Le Roux b20816bfa8 Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 by replacing xsd files references in xml files by -ns.xsd files and removing the concerned xsd files
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1749488 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:14:16 +00:00
Julien Nicolas 27f0959b02 OFBIZ-7160 correct typo javascrip
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1746536 13f79535-47bb-0310-9956-ffa450edef68
2016-06-02 08:39:28 +00:00
Jacques Le Roux d8e9befe1d Completes r1709882 for <<Remove tooltip="${uiLabelMap.CommonRequired}" from fields>> https://issues.apache.org/jira/browse/OFBIZ-6691
Removes nonsensical required-field="true" for <display* field types

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1710093 13f79535-47bb-0310-9956-ffa450edef68
2015-10-22 20:22:11 +00:00
Jacques Le Roux e45a7b3db2 Removes tooltip="${uiLabelMap.CommonRequired}" from fields, https://issues.apache.org/jira/browse/OFBIZ-6691
Instead of a quiet S/R action, this was an unexpected pain in the ass. A considerable number of forms:
    EmployeeForms.xml
    EmploymentForms.xml
    EmplPositionForms.xml
    GlobalHRSettingForms.xml
    RecruitmentForms.xml
    QuoteForms.xml
    PartyForms.xml
    StoreForms.xml
    ContactForms.xml
    FixedAssetForms.xml
    TaskForms.xml
    scrumForms.xml
    TaskForms.xml
contained a large number of fields with 
  tooltip="${uiLabelMap.CommonRequired}"
but no 
  required-field="true"


Of course display and display-entity should not be concerned, I spotted a number of them in the lot.

I also removed a bunch of harcoded * at end of labels (those followed by required-field="true"* and spotted a number of others }*"  who still need to be carefully reviewed to see if required=true is not missing there :/

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1709882 13f79535-47bb-0310-9956-ffa450edef68
2015-10-21 16:57:25 +00:00
Jacques Le Roux ca86127179 A slightly modified patch from Taher Alkhateeb for <<replace widget-style="required" with required-field="true">> https://issues.apache.org/jira/browse/OFBIZ-6690
jleroux: after a cursory review, I simply did the chunk related to exampleName by hand, it needed more work. I also removed some trailing blanks.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1709872 13f79535-47bb-0310-9956-ffa450edef68
2015-10-21 16:00:02 +00:00
Nicolas Malin 8995c4fd02 Cleaning forms code is needed after setting default-value in list-options and entity-options, patch related to OFBIZ-6524 and follows the resolution of OFBIZ-6490 and OFBIZ-6489. Thanks Gil Portenseigne for this effort
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1686674 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 21:58:05 +00:00
Jacques Le Roux c983fe60e8 A patch from Pierre Smits related with "Form ViewSprintItem is not referenced in screens" https://issues.apache.org/jira/browse/OFBIZ-5975
Removes the lines related to the ViewSprintItem lines after a week

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1685621 13f79535-47bb-0310-9956-ffa450edef68
2015-06-15 16:48:18 +00:00
Jacques Le Roux e4d09db471 A modified patch from Pierre Smits related with "Form ViewSprintItem is not referenced in screens" https://issues.apache.org/jira/browse/OFBIZ-5975
jleroux: rather than removing I rather commented out the lines related to the ViewSprintItem lines in case the original author decides to use it. I will remove in a week

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1684129 13f79535-47bb-0310-9956-ffa450edef68
2015-06-08 09:39:39 +00:00
Jacques Le Roux c5c006c1aa Comments out unused form in Scrum. Thanks to Pierre Smits report at "Form ViewSprintItem is not referenced in screens" https://issues.apache.org/jira/browse/OFBIZ-5975
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1684128 13f79535-47bb-0310-9956-ffa450edef68
2015-06-08 09:31:28 +00:00
Deepak Dixit bab89e9683 OFBIZ-5974: Fixed entity-one tag error for ListProdBacklogNote and ListTaskNote forms.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1679746 13f79535-47bb-0310-9956-ffa450edef68
2015-05-16 14:35:12 +00:00
Jacques Le Roux 12386a7aed A patch from Pierre Smits for "Form TotalProdBacklog has typo in link" https://issues.apache.org/jira/browse/OFBIZ-5979
This bug was introduced in commit: http://svn.apache.org/viewvc?view=revision&revision=1142915

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1652739 13f79535-47bb-0310-9956-ffa450edef68
2015-01-18 11:38:17 +00:00
Jacques Le Roux 18bb9d7c44 Extended from a Tom Burns's patch at https://issues.apache.org/jira/browse/OFBIZ-4851
To reproduce:
1. In Catalog Manager select the Products menu
2. Click find
3. Click product id GZ-1006-1
4. Click Locations tab
5. In Add Facility Location screenlet select Web Store Warehouse from the Facility Id drop-down list
6. In the Location Seq Id pop up window select Facility Id Web Store Warehouse click find.
7. Select a Location Id
8. In Add Facility Location click Add

Expected: Add location to product record
Actual:
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen component://common/widget/CommonScreens.xml#GlobalDecorator: java.lang.IllegalArgumentException: Return value from use-when condition eval was not a Boolean: null [null] on the field facilityName of form UpdateProductFacilityLocations (Return value from use-when condition eval was not a Boolean: null [null] on the field facilityName of form UpdateProductFacilityLocations)

jleroux: I found some other same cases and fixed them the same way

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1399539 13f79535-47bb-0310-9956-ffa450edef68
2012-10-18 07:14:35 +00:00
Jacques Le Roux 3f093889b9 Replaces all remaining title="${uiLabelMap.CommonEmptyHeader}" by title=" ", and specific case in ListPartyCommEvents
This closes the CommonEmptyHeader chapter

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1343016 13f79535-47bb-0310-9956-ffa450edef68
2012-05-27 08:41:47 +00:00
Jacques Le Roux 223ce379eb Adrian suggested to removes all widget-style="tabletext": <<That style was removed from the stylesheet in 2007. All references to it should be removed.>>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1340385 13f79535-47bb-0310-9956-ffa450edef68
2012-05-19 09:32:48 +00:00
Jacques Le Roux 127e509288 Replaces title="${uiLabelMap.CommonEmptyHeader}" by title=" " where it's known to not be a problem. Here with links styled by widget-style="buttontext"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1340373 13f79535-47bb-0310-9956-ffa450edef68
2012-05-19 08:45:18 +00:00
Adam Heath 2551d29ca1 DEPRECATION: specialpurpose/scrum: findByAnd variants replaced with findByAnd that takes a boolean useCache parameter.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1338423 13f79535-47bb-0310-9956-ffa450edef68
2012-05-14 21:03:38 +00:00
Erwan de Ferrieres a1c864425c (typo) Bulk replace planed --> planned
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1294096 13f79535-47bb-0310-9956-ffa450edef68
2012-02-27 10:32:13 +00:00
Erwan de Ferrieres dd2ae932cc Adding missing ASL2 license header in scrum component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1230793 13f79535-47bb-0310-9956-ffa450edef68
2012-01-12 21:29:51 +00:00
Hans Bakker c94ed1285e move the public holiday definition from scrum to the HR component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1170129 13f79535-47bb-0310-9956-ffa450edef68
2011-09-13 11:57:22 +00:00
Hans Bakker 815c8916e1 Scrum component update:
Add a 'new backlogitem' button when i selected an existing backlog item
It should be possible to delete a backlog even when hours are attached
the button 'billed' on a backlogitem to set the flag to billed, does not work, get an error message
if for a backlogitem, billed is no, the time entries are not combined into a single item on the invoice.
the email confirmation: Scrum - Your Sprint is started, has the wrong domainname in the sprint url: 127.0.0.1
Convert the service name 'addWorkEffortTimeToInvoice' to 'scrumAddWorkEffortTimeToInvoice' to allow a special grouping
Remove the causes for the entity warnings in the log, there were entity changes inside scrum, we do not expect usingh it yet but we can supply conversion programs if needed

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1153071 13f79535-47bb-0310-9956-ffa450edef68
2011-08-02 09:00:06 +00:00
Hans Bakker e50c030b65 add support for the scrum framework donated by Antwebsystems Co.Ltd. more info at: http://www.antwebsystems.com/control/ViewBlogArticle?articleContentId=21140&blogContentId=AWS_BLOG
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1142915 13f79535-47bb-0310-9956-ffa450edef68
2011-07-05 08:15:32 +00:00