Commit Graph
961 Commits
Author SHA1 Message Date
Jacques Le Roux b542a38b18 Reverted: work related to PartyRole handling initiated with (OFBIZ-5980)
Currently OFBiz is broken and hard to fix. You can't even create an order !

Revert "Improved: visibility of expire button (OFBIZ-12362) (#331)"
This reverts commit e3b125ef4cb4247233097f3e00f28b10773d708c.

Revert "(OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation (#330)"
This reverts commit a8ab2be55a96a1aeccc4c07887ebbb4d25b2cc28.

Revert "Improved: seed data (OFBIZ-12355) (#328)"
This reverts commit b204b867b40787dbcc5a17a30c1d22ade1a422cc.

Revert "Reverted: Have the ability to revoke (expire) roles of a party (OFBIZ-5980)"
This reverts commit 85e066deb358404b4681c148ba0d296e481bf666.

Revert "Reverted: damn I did not revert the right push :/"
This reverts commit b867b2a89fe36bb7e02b24814b2fb2fc2683f1c4.

Revert "(OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation (#325)"
This reverts commit 8ed2252df82be226d99d97250c659a1f8e3211fe.

Revert "Reverted: Have the ability to revoke (expire) roles of a party (OFBIZ-5980)"
This reverts commit 5b5e03f71b6f94ca3c4a1a1526681634835527a5.

Revert "Improved: Have the ability to revoke (expire) roles of a party (OFBIZ-5980)"
This reverts commit 46f7ee91d3355b3e10a5b2732797591c748a27dd.

Revert "Improved: seed data (OFBIZ-12353) (#324)"
This reverts commit fade92bb57d23333dd648bbab456c23cdb517787.
2021-11-08 20:42:03 +01:00
Pierre Smits a03567363b Improved: party roles (OFBIZ-5980) (#68)
updated data set regarding party roles
2021-10-30 16:39:45 +02:00
Jacques Le Roux 190e816364 Fixed: Add http to https redirect rule for ofbiz.apache.org (OFBIZ-10590)
This prevented to run the stable demo, hence the next, weirdly the trunk had
not this problem. Anyway better safe than sorry... Maybe related to Gradle
version or rather libs loaded?

The reason why the stable (and old) demos were not running is because the
EntitySaxReaderTests did not pass
2021-07-20 07:47:25 +02:00
Jacques Le Roux 6106277bb4 Improved: Add global web.xml to simplify session timeout configuration (OFBIZ-12255)
Currently, session timeout is configured in apps separately, but session is
shared globally, so the smallest one take effects, and it will not take effect
separately for different apps.

Then it is both inconvenient and confusing to increase session timeout value,
as all values in those files need to be updated.

A global web.xml is needed, to simplify session timeout configuration.

Thanks: Xin Wang
2021-06-22 08:52:44 +02:00
Jacques Le Roux e964d61724 Improved: Default ordering of webapps titles in main menu (OFBIZ-12166)
This 1st step sorts the plugins. We need to discuss more...
2021-02-14 21:12:52 +01:00
Deepak Dixit 9cb1101e3f Fixed: Fitering on StatusId in FindTask does not work (#55)
(OFBIZ-10914)
2021-02-12 15:38:41 +05:30
Deepak Dixit 73876cdb14 Removed HelpData file entries from ofbiz-component.xml (#54) 2021-02-12 12:46:59 +05:30
Jacques Le Roux 78bc570ac8 Reverted: "Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)"
This reverts commit 17eb2e4cf7bfba4e6a6b62117aa8d64cd5774c5e.

It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!

Thanks: James for report
2020-12-18 11:04:16 +01:00
Jacques Le Roux 4d34c9d43f Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)
Same for sub-hyperlink, forgot the plugins with 17eb2e4cf7bfba4e6a6b62117aa8d64cd5774c5e
2020-12-15 09:16:40 +01:00
holivier cf28c487ba Documented: Synchronize wiki page End User Documentation (OFBIZ-12059)
- Add assetm.adoc with only overview for plugin assetmaint
- Completed projectmgr overview
2020-11-16 17:06:03 +01:00
holivier eebd368718 Documented: migration to help system using asciidoc files (OFBIZ-11587)
Remove all related help docbook files
2020-10-26 16:06:44 +01:00
Jacques Le Roux a4fb6d22ee Fixed: Add support to read and register resources defined in XML DSL(OFBIZ-11995)
Fixes a JavaDoc issue and while at it replaces
  // TODO Auto-generated catch block
  e.printStackTrace();
by
  Debug.logError(e, MODULE);
2020-09-24 06:59:30 +02:00
Jacques Le Roux b049b93b55 Improved: Update information in README.md files from removed pages in wiki 2020-08-29 17:37:33 +02:00
Jacques Le Roux b9a3be3e1e Reverted: "Improved: Have a readme in every component (OFBIZ-6243)"
This reverts commit 598cf6c27d.

An Apache URL is much easier to have (NO bad idea, does not show like the
camo.githubusercontent.com link does, cache control issue on ASF servers?)
2020-08-29 13:53:36 +02:00
Jacques Le Roux 598cf6c27d Improved: Have a readme in every component (OFBIZ-6243)
An Apache URL is much easier to have
2020-08-29 13:48:57 +02:00
Jacques Le Roux 9bf5e044f7 Improved: Have a readme in every component (OFBIZ-6243)
Not sure why we have this problem (according to
https://docs.github.com/en/github/authenticating-to-github/about-anonymized-image-urls
could be to missing cache control in our site server)

As I was fed up not viewing the OFBIz logo anywhere, and mostly in GH,
but just in browser at https://ofbiz.apache.org/images/ofbiz_logo.png
and I noticed I was viewing it well locally at
https://github.com/apache/ofbiz-framework/tree/trunk/themes/rainbowstone
so decided to use this URL everywhere rather!
2020-08-29 13:36:23 +02:00
Jacques Le Roux 7d140f3e27 Improved: Have a readme in every component (OFBIZ-6243)
This preludes the move of content of README.md files into the asciidoc
documentation

Updates the link to OFBiz-logo.png (also in ReportDesignGenerator.java)
Removes deprecated information related to Svn, Jira and Confluence
We will move the wiki pages to wiki attic with OFBIZ-11619
2020-08-29 11:52:35 +02:00
Pawan Verma 5545b13b13 Improved: Replace .size() == 0 with isEmpty() in Java files(OFBIZ-11944)
Thanks, priya for the report and patch and jacques for the review.
2020-08-22 19:18:38 +05:30
Akash Jain 7f462731de Improved: Status ID checkbox for FindTask and FindTimeSheet forms (OFBIZ-11936) 2020-08-04 22:57:24 +05:30
Suraj Khurana 30f796146c Improved: Corrected some line is longer than 150 characters checkstyle issues. Also fixed some extra spaces and naming conventions related checkstyle issues.
(OFBIZ-11921)
2020-08-03 10:07:16 +05:30
holivier d349811a26 Documented: migrate help link to asciidoc user manual for Plugin
ProjectMgr (OFBIZ-11587)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, change Project help page to a
short page with a link to the new help

Remove docbook help files for PROJECTMGR
2020-07-22 19:26:24 +02:00
holivier 8d6c36b624 Documented: ofbiz-plugins / ProjectMgr, migration of docbook help files
to asciidoc, most of files have been directly included in
project-mgr.adoc. (OFBIZ-11587)
2020-07-22 19:21:29 +02:00
Jacques Le Roux a0f7e77e77 Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)
Removes all error*.jsp reference, no longer used
2020-07-20 19:27:23 +02:00
Suraj Khurana ae31c01fa7 Improved: Change resources with proper naming convention in all plugin components.
(OFBIZ-11739)
Also, made MODULE as private data member of class instead of public. Thanks Jacques for review.
2020-05-29 13:14:02 +05:30
Suraj Khurana 9c6838ef0b Improved: Refactor simple methods names as per naming convention best practices. (#20)
(OFBIZ-11700)
2020-05-23 10:34:37 +05:30
Suraj Khurana 9428ee9579 Improved: Updated service name and removed duplicate service. (#16)
* Improved: Updated service name and removed duplicate service.
(OFBIZ-11616)

Please check dependent PR (https://github.com/apache/ofbiz-framework/pull/88) for more details.
2020-05-16 13:47:16 +05:30
James Yong ca5e6b45f1 Improved: Apply multi-block attr to each application (OFBIZ-11706)
For remaining plugin applications.
2020-05-16 13:37:43 +08:00
Jacques Le Roux 208ef1b1be Improved: replaces module by MODULE everywhere 2020-04-06 12:14:23 +02:00
Jacques Le Roux d267d161e0 Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies.
(OFBIZ-11470)

As reported by OWASP ZAP:
A cookie has been set without the SameSite attribute, which means that the
cookie can be sent as a result of a 'cross-site' request. The SameSite attribute
is an effective counter measure to cross-site request forgery, cross-site script
inclusion, and timing attacks.

The solution was not obvious in OFBiz for 2 reasons:

1. There is no HttpServletResponse::setHeader. So we need to use a filter
  (SameSiteFilter) and even that is not enough because of 2:
2. To prevent session fixation we force Tomcat to generates a new jsessionId,
ultimately put in cookie, in LoginWorker::login. So we need to add a call to
SameSiteFilter::addSameSiteCookieAttribute in
UtilHttp::setResponseBrowserDefaultSecurityHeaders.
2020-03-20 17:51:00 +01:00
James Yong 7cbc4b6d79 Improved: Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
(OFBIZ-11317)

Adding the controlPath attribute to allow the controls by ofbizUrl to support uri to other OFBiz web application.

Thanks: Jacques for the review
2020-01-12 22:34:39 +08:00
Mathieu Lirzin 1158664ba3 Fixed: Add XML declaration in “web.xml” files (OFBIZ-6993)
These declarations avoid SAXParseException traceback when parsing web.xml
the first time in WebappUtil.parseWebXmlFile

A schema conformance issue has been fixed in ecommerce “web.xml”.
2019-12-07 22:52:30 +01:00
Jacques Le Roux f3c3271d12 Improved: Use Groovy Truth instead of UtilValidate Class in Groovy
(OFBIZ-11064)

As we all know, Groovy is a powerful language with great built-in functions. 
Groovy Truth[1] is one of them, which is not used properly in our code base. 
We have used UtilValidate Class to validate arguments for Empty or NotEmpty, 
which can easily be done in groovy with built-in functionality[1].
 
Current Code: if (UtilValidate.isNotEmpty(locations)) { ... }
Groovy Built-in Code: if (locations) { ... }
 
[1] - http://groovy-lang.org/semantics.html#Groovy-Truth
 
We need to careful for some points while we change this:
Like:
maxRetry = 0
if (!maxRetry)
{  // Not set, use a default  maxRetry = -1 }

Because groovy evaluates zero to be false, it wouldn't be possible to set
maxRetry to zero.  So it's best not to use groovy truth for null-checks on
numbers in some cases. 
 
Thanks: Pawan Verma

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860051 13f79535-47bb-0310-9956-ffa450edef68
2019-05-26 10:36:16 +00:00
Jacques Le Roux 8697d231bc Improved: Missing uiLabel for Create New on CMS Content Find Screen
(OFBIZ-11005)

Thank to Pawan Verma who spotted also ProjectMgrNotesCreateNew and removed it from 
NoteInfo.ftl. I also removed ProjectMgrNotesCreateNew from ProjectMgrUiLabels.xml

Thanks: Pawan Verma 


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858517 13f79535-47bb-0310-9956-ffa450edef68
2019-05-02 06:49:50 +00:00
Jacques Le Roux ad14f70944 Improved: Missing uiLabel for Create New on CMS Content Find Screen
(OFBIZ-11005)

Steps to regenerate:
    Go to https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind
    Find missing uiLabel for Create New, showing as CommonCreateNew.

jleroux: This is related with OFBIZ-9905, we decided to use only CommonCreate
This do that and fix others which were missing in OFBIZ-9905

Thanks: Pawan Verma for report, Suraj for comment


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858516 13f79535-47bb-0310-9956-ffa450edef68
2019-05-02 06:44:47 +00:00
Suraj Khurana 0bb4d1cb57 Fixed: FindTask does not allow for all statuses possible to be selected.
(OFBIZ-10913)
Thanks Pierre Smits for repoting, Deepak Dixit for comments/findings and Pawan Verma for providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858285 13f79535-47bb-0310-9956-ffa450edef68
2019-04-27 16:12:04 +00:00
Suraj Khurana 987888ed49 Fixed: Can't set (expected) start and end date of project when creating a project.
(OFBIZ-10927)
Thanks Pierre Smits for reporting, Pawan Verma for the patch and Jacques for review.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858244 13f79535-47bb-0310-9956-ffa450edef68
2019-04-27 06:41:46 +00:00
Deepak Dixit 5579e37bde Improved: Updated plugin code to fix console warning related to deprecated method. Removed Double constructor call as its depracated since jdk 9. Also replace the CellType::getCellTypeEnum method call with CellTyoe::getCellType
(OFBIZ-10757)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1853904 13f79535-47bb-0310-9956-ffa450edef68
2019-02-19 17:30:35 +00:00
Jacques Le Roux 844fc542d8 Fixed: Add session tracking mode and make cookie secure
(OFBIZ-6655)

Following "Session timeout for webapps" discussion on dev ML 
https://markmail.org/message/p6fbiojjrwb2ybxd

We decided to put back the session-timeout value in web.xml files and to remove
the line
    session.setMaxInactiveInterval(60*60); //in seconds
from ControlEventListener.java

Thanks: Deepak Nigam for report and Girish Vasmatkar for discussion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1851068 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 16:12:01 +00:00
Deepak Dixit f5e575a025 Improved: Use input type=submit for form submission
(OFBIZ-10482)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1847351 13f79535-47bb-0310-9956-ffa450edef68
2018-11-24 09:38:14 +00:00
Suraj Khurana c73e1347ed Improved: Consistency and Readability improvements for include-menu tag.
(OFBIZ-8972)
Thanks Ankush Upadhyay for reporting and Devanshu Vyas for providing the updated patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1845090 13f79535-47bb-0310-9956-ffa450edef68
2018-10-29 08:31:17 +00:00
Suraj Khurana 9dfe76971f Improved: Arranged projectmgr UI labels in alphabetic order.
(OFBIZ-7371)
Thanks Shivangi for your contribution and Jacques for review.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1840790 13f79535-47bb-0310-9956-ffa450edef68
2018-09-13 09:37:00 +00:00
Suraj Khurana 855cc73dc1 Fixed: Could not find simple-method createWorkEffortSkillStandard as it was called as simple method and it is converted to entity-auto service.
(OFBIZ-10524)
Thanks Fernando Ortega for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1838249 13f79535-47bb-0310-9956-ffa450edef68
2018-08-17 11:08:18 +00:00
Gil Portenseigne bd389e0fd0 Improved : Remove all unnecessary boxing and unboxing in Java classes
(OFBIZ-10504)

Thanks Taher, Jacques, Mathieu and Rishi for the review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1837578 13f79535-47bb-0310-9956-ffa450edef68
2018-08-07 07:36:13 +00:00
Deepak Dixit 443411cdf4 Improved: Use application/javascript instead of text/javascript
(OFBIZ-10492)
Replace text/javascript with application/javascript in all the script tag

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1836889 13f79535-47bb-0310-9956-ffa450edef68
2018-07-28 11:50:09 +00:00
Deepak Dixit 1f164336e9 Improved: Remove use of deprecated language attribute from script tag
(OFBIZ-10491)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1836546 13f79535-47bb-0310-9956-ffa450edef68
2018-07-24 11:27:20 +00:00
Rishi Solanki c1c14b8e9c Improved: Remove empty field values from xml data files so that it will not override existing data with empty values. Removed all empty data fields from data files plugins components.
(OFBIZ-10282)
Thanks to Arun Patidar for reporting and review.
Thanks to Suraj Khurana for providing patch for the improvement.
Thanks to Jacques for discussion and finalizing the work.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1830546 13f79535-47bb-0310-9956-ffa450edef68
2018-04-30 10:56:31 +00:00
Rishi Solanki b00f7efc1d Fixed: Error on My Portal Request Overview Page. Issue was due to an incorrect path of OverViewRequestItems.ftl in ViewRequest screen.
(OFBIZ-10183)
Thanks Ratnesh Upadhyay for reporting the issue and Yogesh Naroliya for providing patch to fix the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1822512 13f79535-47bb-0310-9956-ffa450edef68
2018-01-29 15:01:59 +00:00
James Yong dae259b009 Improved: ID should be the abbreviation for identity in English
(OFBIZ-100131)

Also cover non-English translations

Thanks: Jacques for the additional patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1820450 13f79535-47bb-0310-9956-ffa450edef68
2018-01-07 12:11:37 +00:00
Deepak Dixit 6063cbcc6d Improved: Moved plugins js from images to common/js (OFBIZ-5776)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1818601 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 18:17:03 +00:00
Deepak Dixit d165a975c1 Fixed: Updated ViewPartyRoles inclusion from include-form to include-grid in projectmgr application
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1818260 13f79535-47bb-0310-9956-ffa450edef68
2017-12-15 10:34:14 +00:00