This prevented to run the stable demo, hence the next, weirdly the trunk had
not this problem. Anyway better safe than sorry... Maybe related to Gradle
version or rather libs loaded?
The reason why the stable (and old) demos were not running is because the
EntitySaxReaderTests did not pass
These declarations avoid SAXParseException traceback when parsing web.xml
the first time in WebappUtil.parseWebXmlFile
A schema conformance issue has been fixed in ecommerce “web.xml”.
(OFBIZ-11064)
As we all know, Groovy is a powerful language with great built-in functions.
Groovy Truth[1] is one of them, which is not used properly in our code base.
We have used UtilValidate Class to validate arguments for Empty or NotEmpty,
which can easily be done in groovy with built-in functionality[1].
Current Code: if (UtilValidate.isNotEmpty(locations)) { ... }
Groovy Built-in Code: if (locations) { ... }
[1] - http://groovy-lang.org/semantics.html#Groovy-Truth
We need to careful for some points while we change this:
Like:
maxRetry = 0
if (!maxRetry)
{ // Not set, use a default maxRetry = -1 }
Because groovy evaluates zero to be false, it wouldn't be possible to set
maxRetry to zero. So it's best not to use groovy truth for null-checks on
numbers in some cases.
Thanks: Pawan Verma
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860051 13f79535-47bb-0310-9956-ffa450edef68
called directly.
(OFBIZ-10895)
This error happens in many occasions:
Inside another request (eg LookupProduct)
Of after a request (eg login)
It shows only in log and have no effect on UI. Notably the new feature normally
showing an error message in trunk (OFBIZ-10753) does not shows
It happens in all supported releases. IIRW it always happened, only URLs like
https://demo-trunk.ofbiz.apache.org/images/defaultImage.jpg work.
But here it's different because we don't need to call
https://demo-trunk.ofbiz.apache.org/images by hand to get the issue in log.
So it's not very bad since it's has no side effects, just weird and annoying.
Because it might hide something undetected yet...
This issue does not appear in R15, a good place to test is for instance
ordermgr/control/request.
There cal.gif is called by /images/cal.gif and it works (the images appears)
but in more recent versions the call is also done to
/ordermgr/control/images/cal.gif where it fails.
This 1st appears in ControlFilter in the stack trace.
As said Deepak Dixit:
I think we need to fix the image url in css file, it should start with /images,
else browser append this in request info. There is nothing related to java or
tomcat code.
This is a 1st commit for the errors I already reported and I'm sure about
Thanks: Deepak
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858444 13f79535-47bb-0310-9956-ffa450edef68