Commit Graph
1128 Commits
Author SHA1 Message Date
Pierre Smits f91339b576 Improved: Dutch labels for Ecommerce UI (OFBIZ-12378) (#69)
added:
Dutch tranlations for various labels in EcommerceUiLabels.xml
2021-11-12 12:52:12 +01:00
Jacques Le Roux 97fe0058a8 Fixed: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
additional-methods.min.js was missing, forgot previously

Unrelated to plugins, but I also tried to use jquery-ui-dist from node
https://www.npmjs.com/package/jquery-ui-dist despite I knew it was less secure
https://www.cvedetails.com/vulnerability-list/vendor_id-6538/product_id-31126/Jquery-Jquery-Ui.html
But it missed at least the lookup icon in Helveticus.

I'll check later when https://www.npmjs.com/package/jquery-ui-dist will provide
a more secure version.

Also in ecommerceI found this error in js console: : "$.timepicker is undefined"
I did not find the reason. Anyway it seems not used in ecommerce.
2021-11-11 11:26:02 +01:00
Pierre Smits a03567363b Improved: party roles (OFBIZ-5980) (#68)
updated data set regarding party roles
2021-10-30 16:39:45 +02:00
Nicolas Malin 553472c052 Fixed: Replace hardcoded label 'Popular categories' (OFBIZ-12323)
Labellise the 'Popular categories' title by adding an EcommerceBestSelling label and replace traduction by 'Best Selling' to avoid confusion with catalog category type 'Most Popular (one)'.

Thanks: Charles STELTZLEN
2021-09-28 16:51:00 +02:00
Nicolas Malin 7b37304043 Fixed: ecommerce head title, no ':' if no title or titleProperty (OFBIZ-12326)
When the page title is empty, avoid the ':' in the navigator tabs title for Ecommerce

Thanks: Charles STELTZLEN
2021-09-28 16:35:14 +02:00
Nicolas Malin 20e00c82a3 Fixed: Add to cart is not working for products with selectable features (OFBIZ-11970)
Two issues were present, first was due to incorrect markup and the second was due to ajax request and response view of the additem request.
In additem request last saved view or the view of the last request is rendered on successful operation and in this case the last request/view is the one which is used to render UOM dropdown.

Thanks: Akash Jain and Ravi Lodhi
2021-09-28 14:11:52 +02:00
Nicolas Malin 209f15f2b6 Fixed: Incorrect price for selected variant shown (OFBIZ-12236)
When the webshop (ecommerce component) has been set up for retail (B2C), with the tax setting 'Show prices with VAT tax included' set to 'Y' in store 9000 the appropriat Tax Auth Geo and Tax Auth set in store 9000 the flag 'Include Tax In Price' set to 'Y' for the Tax Auth the price for a virtual product is shown including VAT.

However, for a selected variant the price shown is without VAT

Thanks: Pierre Smits to raise this issue and Priya Sharma for solved it
2021-09-27 16:28:19 +02:00
Jacques Le Roux 48156518c9 Improved: Adds the HTML <input> accept Attribute in form widgets and Freemaker templates (OFBIZ-12049)
Removes unused OOTB TextImage.ftl
Explain the script in ViewProfile.ftl
"Accepts" CSV files in SamplePricat.ftl
2021-09-21 17:47:20 +02:00
Charles 2218d9f9a1 Replace summary label by common one 2021-09-08 09:53:10 +02:00
Jacques Le Roux 874c830fbb Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Fixes few bugs
2021-08-06 18:16:41 +02:00
Jacques Le Roux 190e816364 Fixed: Add http to https redirect rule for ofbiz.apache.org (OFBIZ-10590)
This prevented to run the stable demo, hence the next, weirdly the trunk had
not this problem. Anyway better safe than sorry... Maybe related to Gradle
version or rather libs loaded?

The reason why the stable (and old) demos were not running is because the
EntitySaxReaderTests did not pass
2021-07-20 07:47:25 +02:00
Jacques Le Roux 6106277bb4 Improved: Add global web.xml to simplify session timeout configuration (OFBIZ-12255)
Currently, session timeout is configured in apps separately, but session is
shared globally, so the smallest one take effects, and it will not take effect
separately for different apps.

Then it is both inconvenient and confusing to increase session timeout value,
as all values in those files need to be updated.

A global web.xml is needed, to simplify session timeout configuration.

Thanks: Xin Wang
2021-06-22 08:52:44 +02:00
Jacques Le Roux e51dccb9bb Fixed: Empty field is reflecting on Contact list section on Profile Page (OFBIZ-10386)
Steps to generate:

Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile

On the profile page, Go down to Contact list
Empty fields are displaying before Verify Subscription button

Expected: The field should have some specifications to be filled up

Thanks: Archana Asthana for report, Devanshu Vyas for suggestion, Praveen Patil
for patch and Thirumurugan for confirming
2021-05-29 15:47:21 +02:00
Jacques Le Roux a3438121d8 Improved: Comment out the SOAP and HTTP engines (OFBIZ-12212)
The SOAP and HTTP engines are open doors to security issues.
At https://markmail.org/message/pgtjyh23bazq4s2w I proposed to comment them out
as we did for RMI in the past.
Of cause it must be clearly documented how to use them if needed.

Here is the email content:

    After the recent fix for the CVE-2021-26295[1] we discussed with the security
    team about the opportunity need to comment out the SOAP and HTTP engines
    like we did in the past for RMI[2], this obviously for security reason.

    [1] OFBIZ-12167 "Adds a blacklist (to be
    renamed soon to denylist) in Java serialisation (CVE-2021-26295)"
    [2] OFBIZ-6942 "Comment out RMI related
    code because of the Java deserialization issue [CVE-2016-2170] "

I just put a small comment in webtools and scrumm controllers, it should be
enough.

The tests pass
2021-03-29 13:29:58 +02:00
Devanshu Vyas c6704e90c3 Fixed: Error message is displayed when user clicks on create link after the user quick chechout and user is not logged in (OFBIZ-12188)
Added missing UtilHttp class import statement
Thanks: Arpit Mor for reporting the issue and Sourabh Punyani for providing the fix.
2021-03-27 14:12:58 +05:30
Jacques Le Roux 35a2eca9b4 Fixed: Exception error on ecommerce portal while trying to register new user
(OFBIZ-)

Missing import statement in the groovy script on the new customer registration
page.

Thanks: Pradeep Choudhary
2021-02-27 14:08:42 +01:00
Jacques Le Roux 2b6da24f7e Fixed: Error while uploading file in Ecommerce Profile's File Manager (OFBIZ-10746)
On uploading File in Ecommerce Profile's File Manager,

"The following required parameter is missing:
[IN] [uploadPartyContentFile.partyContentTypeId]" error is displaying.

Steps to regenerate the issue:
    Open Ecommerce on Ofbiz.
    Login with any user.
    Go to Profile.
    Navigate down to File Manager.
    Select Purpose.
    Seletct Mime Type
    Click upload.

Thanks: Aishwary Shrivastava for report, Priya Sharma fir the fix
2021-02-21 19:20:05 +01:00
Pawan Verma 728354a0cb Fixed: Visit disabling causes NullPointerException on ecomm groovy script(OFBIZ-12173)
Used UtilHttp.getSessionId() instead of visit to get session Id.

Thanks: Giulio, Jacopo and Deepak.
2021-02-12 09:25:01 +05:30
Jacques Le Roux f9069945ad Improved: Rename some connoted words like blacklist and whitelist (OFBIZ-12168)
Renames respectively blacklist and whitelist to denylist and allowlist in
several places.

Renames masters and slaves to mains and replicas in solrconfig.xml inherited
from the Apache Solr version we use. The slave word is still used at
https://cwiki.apache.org/confluence/display/solr/SolrConfigXml referenced from
solrconfig.xml

There are still a lot of master word which can be replaced by main, but not in
contexts where slave is also used. I'll discuss that on dev ML again...
2021-02-09 09:55:43 +01:00
Jacques Le Roux e84c7ada87 Fixed: Lucene TopScoreDocCollector::create wrong call the 2 in Search.groovy scripts (OFBIZ-12087)
I guess it's due to an update of Lucene, easy fix
2020-12-07 13:20:18 +01:00
Saurabh Dixit f25852fef2 Fixed: Product summary cards don't have uniform height. (OFBIZ-11910) (#46)
Done following:
1. Used bootstrap card-deck to equalize the height/width of all the product summary cards.

Reference:
https://v4-alpha.getbootstrap.com/components/card/#card-decks

Thanks Guys: Alex Bodnaru for report and suggestion, Saurabh Dixit for the patch, and Daniel Watford for the test
2020-11-30 10:39:32 +01:00
Jacques Le Roux 7276348269 Fixed: Wrong quote marks (OFBIZ-11972)
Thanks: Alex Bodnaru
2020-10-06 16:01:18 +02:00
Jacques Le Roux 77b9733cf6 Improved: Redundant line in themes (OFBIZ-OFBIZ-11997)
Removes the duplicated line in ecommerce theme and format correctly in multiflex

Thanks: Alex Bodnaru for report
2020-10-06 12:26:13 +02:00
James Yong 9c40c67e7a Improved: Open FTL File from browser (OFBIZ-12018)
Add request map for ecommerce
2020-09-25 22:25:15 +08:00
Jacques Le Roux b1c98eee47 Improved: display/selection of unit of measure is broken/plugins (OFBIZ-11993)
Better code

Thanks: Alex
2020-09-14 07:57:26 +02:00
Suraj Khurana 26ddcc0c8e Improved: Corrected line is longer than 150 characters checkstyle issues in plugins component.
(OFBIZ-11921)
Also fixed some other extra space and naming related checkstyle issues observed.
Thanks Jacques for review.
2020-09-04 12:27:09 +05:30
Suraj Khurana 46e0857e90 Fixed: Typo in class name.
(OFBIZ-11978)
Thanks Alex Bodnaru for reporting and providing the patch.
2020-09-01 15:05:35 +05:30
Jacques Le Roux bf60a20d9d Fixed: display/selection of unit of measure is broken/plugins (OFBIZ-11993)
Allows selection of uom for multiple products on the same web page

Thanks: Alex
2020-08-31 10:08:37 +02:00
Jacques Le Roux b049b93b55 Improved: Update information in README.md files from removed pages in wiki 2020-08-29 17:37:33 +02:00
Jacques Le Roux b9a3be3e1e Reverted: "Improved: Have a readme in every component (OFBIZ-6243)"
This reverts commit 598cf6c27d.

An Apache URL is much easier to have (NO bad idea, does not show like the
camo.githubusercontent.com link does, cache control issue on ASF servers?)
2020-08-29 13:53:36 +02:00
Jacques Le Roux 598cf6c27d Improved: Have a readme in every component (OFBIZ-6243)
An Apache URL is much easier to have
2020-08-29 13:48:57 +02:00
Jacques Le Roux 9bf5e044f7 Improved: Have a readme in every component (OFBIZ-6243)
Not sure why we have this problem (according to
https://docs.github.com/en/github/authenticating-to-github/about-anonymized-image-urls
could be to missing cache control in our site server)

As I was fed up not viewing the OFBIz logo anywhere, and mostly in GH,
but just in browser at https://ofbiz.apache.org/images/ofbiz_logo.png
and I noticed I was viewing it well locally at
https://github.com/apache/ofbiz-framework/tree/trunk/themes/rainbowstone
so decided to use this URL everywhere rather!
2020-08-29 13:36:23 +02:00
Jacques Le Roux 7d140f3e27 Improved: Have a readme in every component (OFBIZ-6243)
This preludes the move of content of README.md files into the asciidoc
documentation

Updates the link to OFBiz-logo.png (also in ReportDesignGenerator.java)
Removes deprecated information related to Svn, Jira and Confluence
We will move the wiki pages to wiki attic with OFBIZ-11619
2020-08-29 11:52:35 +02:00
Jacques Le Roux c8d22ed72a Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)
All final data members of the class must match this naming pattern
'^[A-Z][A-Z0-9](_[A-Z0-9]+)$'

I added the changes in CommonScreens.xml but forgot to push this one in ecommerce
2020-08-28 09:38:31 +02:00
Akash Jain 27c1bbed7e Improved: Additional images not showing correctly on product detail page (OFBIZ-11981) 2020-08-25 21:37:20 +05:30
Akash Jain d4a41e39ef Fixed: Distorted Final Checkout Review page when Credit card is selected as Payment option (OFBIZ-11920)
Thanks, Rashi Dhagat for reporting
2020-08-25 20:55:31 +05:30
James Yong 1c9f2ab9c6 Improved: multi-block attribute for html-template tag (OFBIZ-11686)
Not important to track server hits for getJs request
2020-08-25 21:58:26 +08:00
Jacques Le Roux 031a16026d Improved: enclose productsummary list in div.row to better use the screen/plugins (OFBIZ-11979)
It's not about div.row only, in productdetail, the reason field was outside the
summary box.

I've moved the reason inside the summary box, as a generic parameter, highlightLabel.

Thanks: Alex Bodnaru
2020-08-25 09:04:23 +02:00
Jacques Le Roux ba565306ad Improved: removes a duplicated price for PEPPERS-G
PriceServices |I| There is more than one DEFAULT_PRICE with the currencyUomId
USD and productId PEPPERS-G, using the latest found with price: 1.000
2020-08-24 18:22:44 +02:00
Jacques Le Roux 809d2ce300 Improved: bootstrap-bundle*.js contains bootstrap*.js (OFBIZ-11969)
Non-bundle is redundant, with performance hit.

I also replaced in multiflex theme

Thanks: Alex Bodnaru
2020-08-22 11:08:59 +02:00
James Yong 429c9b4acd Improved: Move page-specific script links to html template (OFBIZ-11799)
Use importLibrary js function to load jstree and cookies js at ProductCategories.ftl
2020-08-22 15:53:53 +08:00
Suraj Khurana 1207d24062 Improved: Make data members of class as private and added accessor methods for the same, also corrected occurences of the same in plugins component.
(OFBIZ-11963)
Also made some related checkstyle code enhancements.
Thanks jacques for finalizing Javadoc pattern during this effort.
2020-08-22 13:22:19 +05:30
James Yong 2989420294 Fixed: Unable to add product to cart in ecommence (OFBIZ-11899)
Incorrect markup in ConfigProductDetail.ftl affected jsoup (when multi-block=true) to parse and output the file correctly. Let me know if not fixed.

Thanks: Jacques for reporting
2020-08-09 22:09:25 +08:00
Jacques Le Roux 882246204e Improved: Can't enter decimals when ordering on ecommerce (OFBIZ-11899)
I found the reason of this regression. It's due to
https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=a802ae0

This reverts Suraj's workaround and the change in ConfigProductDetail.ftl by
commit a802ae0. I'll ask James to fix the root of the issue in OFBIZ-11706.
2020-08-09 08:41:25 +02:00
Jacques Le Roux 5366f7d85e Improved: Can't enter decimals when ordering on ecommerce (OFBIZ-11899)
In stable demo, and R18 locally, you can order a half pizza, that's no longer
possible in trunk demo.

Moreover you can't use the Add button in trunk, And if you use the Config button
then it orders. There must be a mix between the 2 buttons, maybe the reason
why we can't no longer enter decimals in trunk...

Suraj: Added a patch with some refactoring of js code and used form attribute to
get quantity value for addform.
This might work with the provided patch but I think a better solution could be
through markup. Also, due to some time constraints, I was not able to dig deep
into how it is working in another branch.

It's a workaround that we can use to continue over OFBIZ-11916.
But I don't like that we have both add_amount and quantity fields out of the
addform form. Actually as I explained at https://markmail.org/message/lnz57yzj3uywcr2y
I don't even understand how this is possible since the FTL source sounds correct...

Thanks: Suraj for the temporary workaround
2020-08-08 16:59:15 +02:00
Akash Jain aa2bfde7cc Fixed: Product link on Order confirmation page is not responding (OFBIZ-11735)
Thanks, Rashi Dhagat for reporting.
2020-08-03 18:10:24 +05:30
Suraj Khurana 30f796146c Improved: Corrected some line is longer than 150 characters checkstyle issues. Also fixed some extra spaces and naming conventions related checkstyle issues.
(OFBIZ-11921)
2020-08-03 10:07:16 +05:30
Jacques Le Roux dc55cb4746 Improved: Update markup of Quick Checkout Page according Bootstrap v4.0.0 (OFBIZ-10136)
Fixes a typo
2020-07-25 09:57:39 +02:00
Aditya Sharma cfba1f3fe2 Fixed: ui for the product summary in promotion product list (OFBIZ-11906)
The product summary in the row is too slim, leaving 75% of the place unused.
Added CSS that forces to take 100% width
Thanks Alex Bodnaru for reporting and providing the patch
2020-07-24 16:06:33 +05:30
Suraj Khurana 51cb1d7958 Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-plugins into trunk 2020-07-21 12:29:01 +05:30