Commit Graph
13 Commits
Author SHA1 Message Date
Jacques Le Roux 8ca14ec910 Fixed: BigDecimal casting in Groovy (OFBIZ-11862)
Sometimes use wrong type castings for BigDecimal:

I have observed that for typecasting in groovy, we have used the wrong coding
pattern like

(BigDecimal) 0
It should be like
0 as BigDecimal

Note that this does not apply to decimal because in case of decimal, the default
type is always BigDecimal in Groovy.

Thanks: Pritam Kute for spotting the issue in OFBIZ-11843
2020-06-30 15:31:27 +02:00
d931dfb9c9 Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files (OFBIZ-11779) (#33)
* Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files(OFBIZ-11779)

* Improved: Removed extra bracket added accidentally. (OFBIZ-11779)

* Update bi/groovyScripts/DimensionServices.groovy

Co-authored-by: Nicolas Malin <nmalin@apache.org>

Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>
Co-authored-by: Nicolas Malin <nmalin@apache.org>
2020-06-28 01:24:52 +05:30
Jacques Le Roux 492dcb9208 Improved: fixes a typo due to OFBIZ-11030
Thanks: Pierre Smits for spotting it
2020-03-26 16:11:09 +01:00
Jacques Le Roux a8d3781cc6 Fixed: Convert DimensionServices.xml minilang to groovy
(OFBIZ-10948)

Now correctly creates the CurrencyDimension using currency.uomId
No need for delegator.setNextSeqId(), looking at (now removed)
DimensionServices.xml confused me.

Thanks: Pierre Smits for report
2020-03-21 19:36:39 +01:00
Pawan Verma 38112fb346 Fixed: prepareProductDimensionData does not load correct fields in ProductDimension
(OFBIZ-11465)

Thanks: Pierre Smits for your contribution.
2020-03-21 17:23:05 +05:30
Jacques Le Roux 350571deaa Fixed: Convert DimensionServices.xml minilang to groovy
(OFBIZ-10948)

There is a bug with loadCurrencyDimension in DimensionServices.groovy
It shows when running quickInitDataWarehouse.

The problem is this Minilang expression is missing in DimensionServices.groovy:
<sequenced-id sequence-name="CurrencyDimension" field="currencyDim.dimensionId"/>

Adding
  delegator.setNextSeqId(currencyDim)
is enough.
2020-03-17 08:49:05 +01:00
Michael Brohl b50d949376 Improved: Convert FactServices.xml minilang to groovy.
(OFBIZ-11030)

Thanks Pierre Smits for reporting and Sebastian Berg for providing the
patch.
2020-03-13 17:44:51 +01:00
Priya Sharma d5d0623e55 Update: The entity operator as the XML service used these instead of the current ones.
- Thanks Jacques for the catch. (OFBIZ-19048)
2020-03-09 20:45:11 +05:30
Priya Sharma fd902848e8 [Improved] : Converted the Dimension Service to groovy
- Deleted the old mini-lang service file
- Updated the service definitions with the new groovy methods
- Added a new file with the groovy implementation (with minor enhancement) of all the Dimension services
As the services deal with lists, there could be scenarios where the enterprise comprises of several thousand products, and so used the EntityListIterator instead of fetching the entire list.
2020-03-06 17:31:04 +05:30
Arun Patidar 8bb8f78872 Improved: Removed semicolon from all Groovy files of all components.
(OFBIZ-8652)

Thanks: Rohit Koushal, Jacques Le Roux and Rishi Solanki for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1767764 13f79535-47bb-0310-9956-ffa450edef68
2016-11-02 19:09:13 +00:00
Mridul Pathak 3dec32bd31 Improved: Removed unused imports from groovy files in BI component.
(OFBIZ-8474)

Thanks: Gopal Yadav for contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1765037 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 11:46:51 +00:00
Deepak Dixit 8f3141cd46 (OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752920 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 10:30:49 +00:00
Deepak Dixit d14bdf9ed2 (OFBIZ-7233) Relocate .groovy files in the specialpurpose/bi component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1747781 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 19:12:22 +00:00