Commit Graph
4195 Commits
Author SHA1 Message Date
Priya SharmaandPriya Sharma 01e2e16681 Improved: Move 'SecurityPermission' data to seed data files (OFBIZ-10575) (#38)
Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>
2020-08-11 16:01:46 +02:00
James Yong 2989420294 Fixed: Unable to add product to cart in ecommence (OFBIZ-11899)
Incorrect markup in ConfigProductDetail.ftl affected jsoup (when multi-block=true) to parse and output the file correctly. Let me know if not fixed.

Thanks: Jacques for reporting
2020-08-09 22:09:25 +08:00
Jacques Le Roux 882246204e Improved: Can't enter decimals when ordering on ecommerce (OFBIZ-11899)
I found the reason of this regression. It's due to
https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=a802ae0

This reverts Suraj's workaround and the change in ConfigProductDetail.ftl by
commit a802ae0. I'll ask James to fix the root of the issue in OFBIZ-11706.
2020-08-09 08:41:25 +02:00
Jacques Le Roux 5366f7d85e Improved: Can't enter decimals when ordering on ecommerce (OFBIZ-11899)
In stable demo, and R18 locally, you can order a half pizza, that's no longer
possible in trunk demo.

Moreover you can't use the Add button in trunk, And if you use the Config button
then it orders. There must be a mix between the 2 buttons, maybe the reason
why we can't no longer enter decimals in trunk...

Suraj: Added a patch with some refactoring of js code and used form attribute to
get quantity value for addform.
This might work with the provided patch but I think a better solution could be
through markup. Also, due to some time constraints, I was not able to dig deep
into how it is working in another branch.

It's a workaround that we can use to continue over OFBIZ-11916.
But I don't like that we have both add_amount and quantity fields out of the
addform form. Actually as I explained at https://markmail.org/message/lnz57yzj3uywcr2y
I don't even understand how this is possible since the FTL source sounds correct...

Thanks: Suraj for the temporary workaround
2020-08-08 16:59:15 +02:00
Priya Sharma 04b8809124 Improved: Removed unused imports from Java files for fixing checkstyle errors
(OFBIZ-11930)
Thanks: Priya Sharma
2020-08-07 18:55:50 +05:30
Priya Sharma fb7bdda1ef Improved: Remove unused imports from Java files (OFBIZ-11930) (#36)
Improved: Remove unused imports from Java files
(OFBIZ-11930)
Thanks: Priya Sharma
2020-08-06 19:49:45 +05:30
Akash Jain 7f462731de Improved: Status ID checkbox for FindTask and FindTimeSheet forms (OFBIZ-11936) 2020-08-04 22:57:24 +05:30
Akash Jain aa2bfde7cc Fixed: Product link on Order confirmation page is not responding (OFBIZ-11735)
Thanks, Rashi Dhagat for reporting.
2020-08-03 18:10:24 +05:30
Suraj Khurana b65d9c94df Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-plugins into trunk 2020-08-03 10:08:06 +05:30
Suraj Khurana 30f796146c Improved: Corrected some line is longer than 150 characters checkstyle issues. Also fixed some extra spaces and naming conventions related checkstyle issues.
(OFBIZ-11921)
2020-08-03 10:07:16 +05:30
Jacques Le Roux 68e603fb4b Fixed: getJs unknown in Webpos (OFBIZ-11932)
R17 is not affected
2020-08-01 13:08:53 +02:00
Pawan Verma b7ef54d494 Improved: Inconsistent String Comparisons(OFBIZ-9254)
There are some inconsistencies in the code for string comparison statusId.equals(PRUN_COMPLETED) whereas it should be written as PRUN_COMPLETED.equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.

Thanks: Devanshu for your contribution.
2020-07-30 17:02:52 +05:30
Suraj Khurana 743c627f40 Improved: Corrected all incorrect indentation level issues in plugins component, also fixed some case indentation checkstyle issues.
(OFBIZ-11922)
2020-07-26 21:07:45 +05:30
Suraj Khurana 4b88493e1b Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-plugins into trunk 2020-07-25 13:49:34 +05:30
Suraj Khurana 78801df453 Improved: Updated case indentation to 0 for all switch statements in plugins component. Also done formatting changes as per checkstyle best practices.
(OFBIZ-11904)
2020-07-25 13:48:25 +05:30
Jacques Le Roux dc55cb4746 Improved: Update markup of Quick Checkout Page according Bootstrap v4.0.0 (OFBIZ-10136)
Fixes a typo
2020-07-25 09:57:39 +02:00
Aditya Sharma cfba1f3fe2 Fixed: ui for the product summary in promotion product list (OFBIZ-11906)
The product summary in the row is too slim, leaving 75% of the place unused.
Added CSS that forces to take 100% width
Thanks Alex Bodnaru for reporting and providing the patch
2020-07-24 16:06:33 +05:30
holivier d349811a26 Documented: migrate help link to asciidoc user manual for Plugin
ProjectMgr (OFBIZ-11587)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, change Project help page to a
short page with a link to the new help

Remove docbook help files for PROJECTMGR
2020-07-22 19:26:24 +02:00
holivier 8d6c36b624 Documented: ofbiz-plugins / ProjectMgr, migration of docbook help files
to asciidoc, most of files have been directly included in
project-mgr.adoc. (OFBIZ-11587)
2020-07-22 19:21:29 +02:00
holivier cb502cae03 Documented: ofbiz-plugins / MyPortal, remove docbook migrated to
asciidoc (only a short introduction) (OFBIZ-11587)
2020-07-22 18:08:18 +02:00
holivier 2a7ea475d3 Documented: ofbiz-plugins / MyPortal, migration for the Help docbook
file to asciidoc (only a short introduction) (OFBIZ-11587)

add in _include directory, two portlet help coming from other components
(commonext and workeffort)
2020-07-22 18:08:18 +02:00
Jacques Le Roux 9c87fb85b1 Improved: Update build.gradle to the latest dependencies (OFBIZ-11903)
See
https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check
for libs not upgraded.
2020-07-21 10:42:14 +02:00
Suraj Khurana 51cb1d7958 Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-plugins into trunk 2020-07-21 12:29:01 +05:30
Suraj Khurana 22ccc6801f Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in plugins component.
(OFBIZ-11886)
2020-07-21 12:28:45 +05:30
Jacques Le Roux a0f7e77e77 Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)
Removes all error*.jsp reference, no longer used
2020-07-20 19:27:23 +02:00
holivier 1d41025097 Documented: ofbiz-plugins / msgGateway, remove docbook file without
migrate them to asciidoc (contain only a title)
(OFBIZ-11587)
2020-07-20 16:12:02 +02:00
holivier cb082af513 Documented: migrate help link to asciidoc user manual for Plugin
BIRT (OFBIZ-11587)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, change BIRT help page to a short
page with a link to the new help

Remove docbook help files for BIRT
2020-07-20 16:08:36 +02:00
holivier bf48bcb098 Documented: ofbiz-plugins / Birt, review existing adoc and migration for
Help docbook file to asciidoc (OFBIZ-11587)

* add license in each file, and remove trailing space
* better numberer list management
* add section Birt in Ofbiz user screen with help migrated file
2020-07-20 15:54:00 +02:00
holivier a321e5f49f Documented: migrate help link to asciidoc user manual for Plugin
EbayStore (OFBIZ-11587)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about
EbayStore and add a short page with a link to the new help

Remove docbook help files for EbayStore
2020-07-20 15:45:35 +02:00
holivier 0d8efd4a1b Documented: ofbiz-plugins / ebayStore, migration for Help docbook file
to asciidoc (OFBIZ-11587)

- ebay-store.adoc  include directly some content and call (with include)
other files
2020-07-20 15:00:15 +02:00
holivier b76ee41197 Documented: migrate help link to asciidoc developer manual for Plugins
dedicated for developer (OFBIZ-11587)

create file plugins-developer-manual, which will include all include
plugins for developer.

The file plugin-developer-manual is include in developer-manual
2020-07-20 12:52:14 +02:00
holivier 8f57d0c87f Documented: migrate help link to asciidoc user manual for Plugin Ebay
(OFBIZ-11587)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about
Ebay and add a short page with a link to the new help

Remove docbook help files for Ebay
2020-07-20 12:44:13 +02:00
holivier 7ecfaebc72 Documented: ofbiz-plugins / ebay, migration for Help docbook file to
asciidoc
(OFBIZ-11587)

- ebay.adoc call (with include) other files
2020-07-20 11:48:40 +02:00
Jacques Le Roux a905d459bd Improved: Rename a few map files (OFBIZ-11882)
Renames a few files to suppress warnings in the browser console.

Thanks: Alex Bodnaru
2020-07-19 16:04:18 +02:00
Jacques Le Roux 899d3061fe Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)
The ecommerce and webpos controller missed an errorpage reference.
All other controllers either use directly the common-controller or indirectly by
including controller/s that include the common-controller
2020-07-18 11:15:18 +02:00
Suraj Khurana 2144763bc0 Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in plugins component.
(OFBIZ-11887)
2020-07-18 12:26:04 +05:30
Jacques Le Roux df8b8213ff Improved: User Error.ftl everywhere it's not yet used (OFBIZ-11890)
Those are no longer needed, replaced by error.ftl
2020-07-16 17:14:42 +02:00
Jacques Le Roux a50442d121 Improved: User Error.ftl everywhere it's not yet used (OFBIZ-11890)
At https://markmail.org/message/n76cchtriexxmgm7 I asked

Why having the ftl handlers only in webtools controller? BTW it makes the XSD
documentation awkward because it speaks about the ftl handlers being in
handlers-controller.xml
Why not using error.ftl in common-controller.xml instead of error.jsp?
Same question for plugins.

And answered

I believe we could change all that and definitely get rid of error.jsp
(error.ftl is already in all supported releases branches)
2020-07-15 20:56:23 +02:00
holivier 647e10377b Documented: ofbiz-framework /framework, migration for
SingleSignOn-docbook files to asciidoc
(OFBIZ-11587)

- SingleSignOn with LDAP: move to plugin LDAP and include in
developer-manual in deployment section
2020-07-14 21:18:14 +02:00
Suraj Khurana e7ead3697f Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in plugins component.
(OFBIZ-11880)
Thanks Jacques for review.
2020-07-13 14:14:42 +05:30
Suraj Khurana b18669cddc Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for plugins component.
(OFBIZ-11874)
This fixes following checkstyle issues:
'{' is not preceded with whitespace.

'{' is not followed by whitespace.

'}' is not followed by whitespace.

'}' is not preceded with whitespace.

'typecast' is not followed by whitespace.

'try' is not followed by whitespace.

';' is preceded with whitespace.
2020-07-11 14:27:09 +05:30
Pawan Verma 845de6eb63 Fixed: Send me this every month link is not working in order items section(OFBIZ-10891)
Thanks, Ashish for the report, Vivek for lookup and Amit for the patch.
2020-07-11 10:30:54 +05:30
Suraj Khurana 6f264947c7 Improved: Corrected all checkstyle issues related to succeeding space for comma in plugins directory.
(OFBIZ-11805)
Thanks Jacques and Ritesh Kumar for review.
2020-07-09 12:02:54 +05:30
Suraj Khurana f8e17a5b00 Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in plugin component.
(OFBIZ-11805)
2020-07-07 14:59:53 +05:30
Suraj Khurana 40ddf41c1a Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-plugins into trunk 2020-07-06 15:28:28 +05:30
Suraj Khurana c24db772c9 Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors.
(OFBIZ-11805)
Thanks Jacques Le Roux and Ritesh Kumar for review.
2020-07-06 15:28:07 +05:30
Jacques Le Roux 2cbb7bd278 Improved: No need to do anything if there is no person
Possible bug found while checking 17.12.04
2020-07-04 12:14:49 +02:00
Jacques Le Roux c2925a43a4 Improved: Adds plugin for integration of 1st Data payment gateway (OFBIZ-11837)
Adds missing ASL2 license headers
2020-07-03 15:07:18 +02:00
Jacques Le Roux 8ca14ec910 Fixed: BigDecimal casting in Groovy (OFBIZ-11862)
Sometimes use wrong type castings for BigDecimal:

I have observed that for typecasting in groovy, we have used the wrong coding
pattern like

(BigDecimal) 0
It should be like
0 as BigDecimal

Note that this does not apply to decimal because in case of decimal, the default
type is always BigDecimal in Groovy.

Thanks: Pritam Kute for spotting the issue in OFBIZ-11843
2020-06-30 15:31:27 +02:00
Jacques Le Roux d5a2fe0696 Fixed: Adding new plugin for integration of First Data payment gateway with Apache OFBiz. (OFBIZ-11837)
Comments out FirstDataDemoData.xml loading because it makes fail
auto-accounting-transaction-tests-sales

Thanks: Pritam Kute for the lead on data error
2020-06-29 11:17:07 +02:00