Incorrect markup in ConfigProductDetail.ftl affected jsoup (when multi-block=true) to parse and output the file correctly. Let me know if not fixed.
Thanks: Jacques for reporting
In stable demo, and R18 locally, you can order a half pizza, that's no longer
possible in trunk demo.
Moreover you can't use the Add button in trunk, And if you use the Config button
then it orders. There must be a mix between the 2 buttons, maybe the reason
why we can't no longer enter decimals in trunk...
Suraj: Added a patch with some refactoring of js code and used form attribute to
get quantity value for addform.
This might work with the provided patch but I think a better solution could be
through markup. Also, due to some time constraints, I was not able to dig deep
into how it is working in another branch.
It's a workaround that we can use to continue over OFBIZ-11916.
But I don't like that we have both add_amount and quantity fields out of the
addform form. Actually as I explained at https://markmail.org/message/lnz57yzj3uywcr2y
I don't even understand how this is possible since the FTL source sounds correct...
Thanks: Suraj for the temporary workaround
There are some inconsistencies in the code for string comparison statusId.equals(PRUN_COMPLETED) whereas it should be written as PRUN_COMPLETED.equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.
Thanks: Devanshu for your contribution.
The product summary in the row is too slim, leaving 75% of the place unused.
Added CSS that forces to take 100% width
Thanks Alex Bodnaru for reporting and providing the patch
ProjectMgr (OFBIZ-11587)
All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files
In the global Help Docbook index tree, change Project help page to a
short page with a link to the new help
Remove docbook help files for PROJECTMGR
file to asciidoc (only a short introduction) (OFBIZ-11587)
add in _include directory, two portlet help coming from other components
(commonext and workeffort)
BIRT (OFBIZ-11587)
All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files
In the global Help Docbook index tree, change BIRT help page to a short
page with a link to the new help
Remove docbook help files for BIRT
Help docbook file to asciidoc (OFBIZ-11587)
* add license in each file, and remove trailing space
* better numberer list management
* add section Birt in Ofbiz user screen with help migrated file
EbayStore (OFBIZ-11587)
All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files
In the global Help Docbook index tree, remove all points about
EbayStore and add a short page with a link to the new help
Remove docbook help files for EbayStore
dedicated for developer (OFBIZ-11587)
create file plugins-developer-manual, which will include all include
plugins for developer.
The file plugin-developer-manual is include in developer-manual
(OFBIZ-11587)
All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files
In the global Help Docbook index tree, remove all points about
Ebay and add a short page with a link to the new help
Remove docbook help files for Ebay
The ecommerce and webpos controller missed an errorpage reference.
All other controllers either use directly the common-controller or indirectly by
including controller/s that include the common-controller
At https://markmail.org/message/n76cchtriexxmgm7 I asked
Why having the ftl handlers only in webtools controller? BTW it makes the XSD
documentation awkward because it speaks about the ftl handlers being in
handlers-controller.xml
Why not using error.ftl in common-controller.xml instead of error.jsp?
Same question for plugins.
And answered
I believe we could change all that and definitely get rid of error.jsp
(error.ftl is already in all supported releases branches)
SingleSignOn-docbook files to asciidoc
(OFBIZ-11587)
- SingleSignOn with LDAP: move to plugin LDAP and include in
developer-manual in deployment section
(OFBIZ-11874)
This fixes following checkstyle issues:
'{' is not preceded with whitespace.
'{' is not followed by whitespace.
'}' is not followed by whitespace.
'}' is not preceded with whitespace.
'typecast' is not followed by whitespace.
'try' is not followed by whitespace.
';' is preceded with whitespace.
Sometimes use wrong type castings for BigDecimal:
I have observed that for typecasting in groovy, we have used the wrong coding
pattern like
(BigDecimal) 0
It should be like
0 as BigDecimal
Note that this does not apply to decimal because in case of decimal, the default
type is always BigDecimal in Groovy.
Thanks: Pritam Kute for spotting the issue in OFBIZ-11843
Comments out FirstDataDemoData.xml loading because it makes fail
auto-accounting-transaction-tests-sales
Thanks: Pritam Kute for the lead on data error