Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the Request Roles screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
https://localhost:8443/ordermgr/control/requestroles?custRequestId=9000
Modified: CustRequestScreens.xml
- screen RequestRoles, restructured to work with permissions.
In general, a <object>TabBar menu is intended to give users access to overviews related to the <object>. And a <object>SubTabBar menu is intended to give users access to actions to be performed on the <object>, like status changes, adding new related records, etc.
The menu-item for editing a request is currently located in the RequestTabBar menu in OrderMenus.xml.
Given that this menu-item is intended for users with UPDATE permissions and to give those users access to a screen to edit the data, this menu-item must move to the RequestSubTabBar menu.
modified: OrderMenus.xml
- menu RequestTabBar, removed menu-item editRequest (moved to RequestSubTabBar), additional cleanup
- menu RequestSubTabBar, added menu-item editRequest, added permission condition, additional cleanup
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the config item screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://localhost:8443/catalog/control/EditProductConfigItem?configItemId=SC00000
modified:
- ConfigScreens.xml - restructured screen EditProductConfigItem to work with permissions
- ConfigForms.xml - added form ProductConfigItem for users with VIEW permission
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the store screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://localhost:8443/catalog/control/EditProductStore?productStoreId=9000
mdified:
StoreScreens.xml - restructured screen EditProductStore to work with permissions
StoreFirms - added form ProductStore for users with VIEW permissions
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the catalog screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://localhost:8443/catalog/control/EditProdCatalog?prodCatalogId=DemoCatalog
modified:
- CatalogScreens.xml
restructured screen EditProductCatalog vis-a-vis permissions
- ProdCatalogForms.xml
added form Catalog for users with VIEW permission
Currently, a user with only 'VIEW' permissions, as
demonstrated in trunk demo with userId = auditor,
accessing the Payment Group Payments screen, sees
editable fields and/or triggers (to requests)
reserved for users with 'CREATE' or 'UPDATE' permissions.
To see/test:
https://localhost:8443/accounting/control/EditPaymentGroupMember?paymentGroupId=9000
Modified: PaymentGroupScreens.xml
restructured screen ditPaymentGroupMember to work with permissions
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the category products screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://localhost:8443/catalog/control/EditCategoryProducts?productCategoryId=100
modified:
- CategoryScreens.xml
restructured EditCategoryProducts vis-a-vis permissions, additional cleanup
- CategoryForms.xml
added grid CategoryProducts for users with VIEW permissions
* Improved: Product Prices - VIEW permissions (OFBIZ-12489)
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the product prices screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://localhost:8443/catalog/control/EditProductPrices?productId=WG-9943
Modified:
- ProductScreens.xml - restructured for working with permissions
- ProductForms.xml - added grid ProductPrices for users with VIEW permissions
* Improved: Product Prices - VIEW permissions (OFBIZ-12489)
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the product prices screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://localhost:8443/catalog/control/EditProductPrices?productId=WG-9943
modified: ProductForms.xml
added display type to fields
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the agreement screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://localhost:8443/accounting/control/EditAgreement?agreementId=DS-1000-SALES
Modified:
- AgreementScreens.xml
restructured EditAgreement screen regarding permissions, additional cleanup
- AgreementForms.xml
added form Agreement for users with VIEW permission, additional cleanup, label harmonisation
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the billing account roles screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://localhost:8443/accounting/control/EditBillingAccountRoles?billingAccountId=9010
Modified:
BillingAccountScreens.xml, re EditBillingAccountRoles:
- added permission rules for CREATE/UPDATE
- restructured section and widget/fail-widget elements, additional cleanup
BillingAccountForms.xml
- added grid BillingAccountRoles (based on ListBillingAccountRoles)
- additional cleanup/label harmonisation
This replaces jquery-ui-timepicker-addon-1.6.3 by its equivalent from npm.
It should be noted that the 1.6.3 version is the EOL and
jquery-ui-timepicker-addon is no longer maintained.
Despite that according to
https://snyk.io/advisor/npm-package/jquery-ui-timepicker-addon
it's still a good choice, notably there are known no security issues.
I tried to use https://www.npmjs.com/package/jquery-datetimepicker instead
but crossed too much issues and let it go.
In general, a <object>TabBar menu is intended to give
users access to overviews related to the <object>.
And a <object>SubTabBar menu is intended to give
users access to actions to be performed on the <object>,
like status changes, adding new related records, etc.
The menu-item for editing a payment group is currently
located in the PaymentGroupTabBar menu in AccountingMenus.xml.
The menu item belongs in the PaymentGroupSubTabBar
Improved: AccountingMenus.xml
PaymentGroupTabBar: removed menu item to edit the payment group, additonal cleanup
PaymentGroupSubTabBar: Added menu iteem to edit the payment group, additional cleanup
Menu items to perform actions in PaymentGroupSubTabBar are visible to users with only VIEW permissions. As shows when logged in with userId = auditor.
Modified: AccountingMenus.xml
added permissions rules to menu-items of PaymentGroupSubTabBar
* Improved: Party - MainActionMenus (OFBIZ-12482)
Currently the create buttons for the main objects of the party component are located within the find and other widgets/templates of those objects.
In order to improve the usability of OFBiz (and thus the appeal of it for adopters and users) these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the component.
Modified:
PartyMenus.xml: added MainActionMenu
CommonScreens.xml: included MainActionMenu where appropriate
CommunicationEventScreens.xml: included MainActionMenu where appropriate
PartyClassificationScreens.xml: included MainActionMenu where appropriate
PartyInvitationScreens.xml: included MainActionMenu where appropriate
VisitScreens.xml: included MainActionMenu where appropriate
* Uses PartyCreateNewPerson instead of CommonNew & CommonPerson
Co-authored-by: Jacques Le Roux <jacques.le.roux@les7arts.com>
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.
Modified:
InventoryForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
FacilityScreens.xml: from form ref to grid ref , additional cleanup
According to the definition in widget-form.xsd the use of a combination of a
form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.
Modified:
SubscriptionScreens.xml: from form ref to grid ref , additional cleanup
SubscriptionForms.xml: from form definition with list ref to grid definition
with list ref, additional clean-up
jleroux: some modification after pushing previous commit from GH
In previous commit I noticed that Pierre used the CommonProduct label that I
committed for Pierre's "Adding som Dutch translations to common labels."
OFBIZ-6016
I did not notice then that there was already a more complete ProductProduct
label. I see no reason to create a new CommonProduct label. So I copied 2 lines
not present in ProductProduct from CommonProduct and removed the "nl" line that
is a duplicate of the "en" line.
With Michael we already said to Pierre that we don't like to review, before
pushing PR, not related changes mixed with what is announced by the title. It
complicates the review. I still remember being admonished by David E. Jones when
committing as a new committer doing the same. In the same David's spirit I see
no necessity to remove empty lines when it complicates the review...
Long story short, better make 2 different PR when such things is really
necessary...
I did not remove the <sub-hyperlink from communicationEventId lookup in
SubscriptionForms.xml. I checked there are 21 other cases like that in code.
Also better to remember to have lines not longer than 80 chars in commit comment.
All the rest is OK with me
* Improved: List and Grid (OFBIZ-11345)
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.
Modified:
SubscriptionScreens.xml: from form ref to grid ref , additional cleanup
SubscriptionForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
* Improved: List and Grid (OFBIZ-11345)
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.
Modified:
SubscriptionScreens.xml: from form ref to grid ref , additional cleanup
SubscriptionForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
Currently, when accessing screens related to production schemas and schema tasks (routing and routing tasks) in Manufacturing, the title of the shown object is below the menu items for that object (as shown in image attached).
To get to a more consistent user experience, this should be above the menu items for the object, like is done in many other screens in OFBiz.
modified: RoutingScreens.xml
CommonRoutingDecorator: moved title of object to above its menu, additional cleanup
CommonRoutingTaskDecorator: moved title of object to above its menu, additional cleanup
In French, and maybe other languages, there is not only one word for new.
There are nouveau (masculine), nouvelle (féminine) and nouvel (masculine followed
by a word starting with a vowel)
Here are few related changes with misc. labels, and use of these labels in
MainActionMenu of marketing order and catalog menus
In French, and maybe other languages, there is not only one word for new.
There are nouveau (masculine), nouvelle (féminine) and nouvel (masculine followed
by a word starting with a vowel)
Here are few related changes with existing AccountingUiLabels, HumanResUiLabel
changes and a new CommonUiLabels French labels improvements and use of
HumanResNew* labels in MainActionMenu of HumanresMenus.xml
Also alongside replaces tabs by spaces in HumanResUiLabel
In French, and maybe other languages, there is not only one word for new.
There are nouveau (masculine), nouvelle (féminine) and nouvel (masculine followed
by a word starting with a vowel)
This takes that into account by using rather
ManufacturingNewRouting and ManufacturingNewRoutingTask than
uiLabelMap.CommonNew and uiLabelMap.ManufacturingRoutingn same for
ManufacturingNewRoutingTask
I'll certainly do more when possible (all cases are not traduced)
Adding testIntegration in the GH Gradle process does not work.
For a reason I'll not dig in, it ALWAYS fails at:
Cannot find service [indexProductsFromContent] location class
(org.apache.ofbiz.content.search.SearchServices)
* Improved: Routing Screens - remove redundant action triggers (OFBIZ-12497)
With the inclusion of the MainActionMenu for the Manufacturing application, several screens in RoutingScreens.xml now have redundant and obsolete action triggers also available in the MainActionMenu.
These action triggers must be removed, as these don't adhere to common permission conventions or are redundant.
Modified: RoutingScreens.xml
- removed action triggers from various routing and routing task screens, as well as their surrounding style widget elements.
- additional clean-up
* Additional removal of trigger action
The majority of the invoice screens have grids encapsulated by a screenlet widget with a title. However some do not have this.
Modified: InvoiceScreens.xml
- screen InvoiceRoles - have grids in screenlet with title
- screen InvoiceTerms - have grids in screenlet with title
In general, a <object>TabBar menu is intended to give users access to overview related to the <object>. And a <object>SubTabBar menu is intended to give users to actions to be performed on the <object>, like status changes, adding new records, etc.
The menu-item for editing the invoice header (aptly translated as 'Header') is currently located in the InvoiceTabBar menu in AccountingMenus.xml.
Given that this menu-item is intended for users with UPDATE permissions and to give those users access to a screen to edit the data, this menu-item must move to the InvoiceSubTabBar menu
Modified: AccountingMenus.xml
- moved 'edit' menu-item for invoice from InvoiceTabBar menu to InvoiceSubTabBar menu. adjusted label.
Currently the create buttons for the main objects of the catalog components are located within the find and profile widgets/templates of those object.
In order to improve the usability of OFBiz (and thus the appeal of it for adopters and users) these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the component.
added: main action menu, having menu-items for
- new product process
- new store process
- new catalog process
- new category process
subject to catalog create permissions
added: decorator section for inclusion of main action menu where appropriate
Some cleanup
Screen EditProductStoreGroupAndAssoc does not connect with grid forms referenced.
Modified: StoreScreens.xml
moved from form references to grid references
removed screen duplicate
additional cleanup
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.
Modified:
ShipmentGatewayConfigScreens.xml: from form ref to grid ref , additional cleanup
ShipmentGatewayConfigForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
I just tried g npm_outdated undocumented Gradle task and got this result*:
> Task :npm_outdated
Package Current Wanted Latest Location
dompurify 2.3.3 2.3.4 2.3.4 ofbiz-framework
jquery 3.5.1 3.6.0 3.6.0 ofbiz-framework
jquery-migrate 3.3.1 3.3.2 3.3.2 ofbiz-framework
jquery-ui-dist 1.12.1 1.13.0 1.13.0 ofbiz-framework
This updates accordingly. I keep this task open as an umbrella tasks for similar
subtasks in future like we have OFBIZ-10213
Refactor various list forms into grids.
Refactor various list form references in screens.
Modified:
FacilityGroupScreens.xml: from form ref to grid ref , additional cleanup
FacilityGroupForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
According to the definition in widget-form.xsd the use of a combination
of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.
Modified:
FacilityScreens.xml: from form ref to grid ref , additional cleanup
FacilityForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
Thanks: Jacques for inspiration and guidance, Aditya Sharma for sharing
thoughts and visions and Ingo Richter for finding this gem.
- changed grid 'EditProductPriceRulesCondition' list-name to reflect
correct list
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the billing account screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://demo-trunk.ofbiz.apache.org/accounting/control/EditBillingAccount?billingAccountId=9010
Modified:
BillingAccountScreens.xml
- screen EditBillingAccount: restructured to work with view permissions
- screen CommonBillingAccountDecorator: added label visible to all billing account screens
- additional cleanup
BillingAccountForms.xml
- added form BillingAccount for users with VIEW permission
- additional cleanup
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.
Modified:
ShippingScreens.xml in product: from form ref to grid ref , additional cleanup
ShippingForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
Currently the create buttons for the main objects of the marketing application are located
within find and profile widgets/templates of those objects.
In order to improve the usability of this application, OFBiz,
and thus the appeal of it for adopters and users, these create buttons/links/etc.
should be in a main action menu visible at all times when a user is working within
the application of the component.
Modified:
MarketingMenus.xml - added MainActionMenu
To following screens - added ref to MainActionMenu, clean-up
CommonScreens.xml
ContactListScreens.xml
DataSourceScreens.xml
MarketingCampaignScreens.xml
MarketingReportScreens.xml
SegmentScreens.xml
TrackingCodeScreens.xml
Currently the create buttons for the main objects of the humanres plugin are located within find and profile widgets/templates of those objects.
In order to improve the usability of this plugin, OFBiz (and thus the appeal of it for adopters and users) these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the web appliclation of the component.
Modified:
HumanresMenus.xml - added MainActionMenu
To following screens - added ref to MainActionMenu, clean-up
CommonScreens.xml
EmplLeaveScreens.xml
EmployeeScreens.xml
EmploymentScreens.xml
PartyQualScreens.xml
PartyResumeScreens.xml
PartySkillsScreens.xml
PerfReviewScreens.xml